Compare commits
65 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 854effa5c0 | |||
| 5bb504224c | |||
| 9d83faa1b6 | |||
| 98ca140803 | |||
| f6f43e8fa0 | |||
| 5bf4514979 | |||
| 115576e85d | |||
| da04d9782e | |||
| 568bb0009a | |||
| 6ac9d2a2e1 | |||
| 41fcd1f25c | |||
| a230dd0429 | |||
| 7a1eaf583c | |||
| 6a341da572 | |||
| 4c231c0d7b | |||
| a10eb0f141 | |||
| 22ff45e122 | |||
| f37ce833c3 | |||
| 7b030e27ef | |||
| 5c042b1ad8 | |||
| 05fe6c865c | |||
| 5f6540af71 | |||
| f9d3c4586f | |||
| 7d5c9c6487 | |||
| 18e0c7f4ce | |||
| ca1074fef8 | |||
| 82c70840c9 | |||
| 3a271e2009 | |||
| b144e9209b | |||
| 42cdbda993 | |||
| 5b13103b9f | |||
| 6caab09616 | |||
| cce30f1443 | |||
| 8256859518 | |||
| 8ab82d7e54 | |||
| adb4cbaffd | |||
| d5c8ddcd82 | |||
| 3d1ba27048 | |||
| 4f2ecdf07f | |||
| 45436b1c55 | |||
| 22cbe8d125 | |||
| c18f4cb195 | |||
| e5417cf71a | |||
| 168f2e482b | |||
| 509a410d1f | |||
| 54f4519b11 | |||
| 1276cafa8e | |||
| 9d4a498637 | |||
| 6a79681ad8 | |||
| 32d83dc6a4 | |||
| b3f92ccf6c | |||
| 99db6b29d5 | |||
| e0610b555b | |||
| ab6cd0af27 | |||
| b62878c3db | |||
| 50f6e137e5 | |||
| 5cd8c3bd49 | |||
| 3b3dcc2cfe | |||
| 68f4072b47 | |||
| 2ed5170eb3 | |||
| e8fe022fe6 | |||
| 965263d2ff | |||
| 5ed320dbdb | |||
| d16c41805f | |||
| 6e3b6ed6d0 |
+12
@@ -0,0 +1,12 @@
|
||||
[run]
|
||||
parallel = true
|
||||
source = apps/backend/cli
|
||||
omit =
|
||||
*/tests/*
|
||||
*/__pycache__/*
|
||||
*/.venv/*
|
||||
|
||||
[report]
|
||||
exclude_lines =
|
||||
pragma: no cover
|
||||
if __name__ == "__main__":
|
||||
+12
-20
@@ -97,9 +97,8 @@ repos:
|
||||
- id: ruff-format
|
||||
files: ^apps/backend/
|
||||
|
||||
# Python tests (apps/backend/) - skip slow/integration tests for pre-commit speed
|
||||
# Python tests (apps/backend/) - run full test suite from project root
|
||||
# Tests to skip: graphiti (external deps), merge_file_tracker/service_orchestrator/worktree/workspace (Windows path/git issues)
|
||||
# NOTE: Skip this hook in worktrees (where .git is a file, not a directory)
|
||||
- repo: local
|
||||
hooks:
|
||||
- id: pytest
|
||||
@@ -108,31 +107,24 @@ repos:
|
||||
args:
|
||||
- -c
|
||||
- |
|
||||
# Skip in worktrees - .git is a file pointing to main repo, not a directory
|
||||
# This prevents path resolution issues with ../../tests/ in worktree context
|
||||
if [ -f ".git" ]; then
|
||||
echo "Skipping pytest in worktree (path resolution would fail)"
|
||||
exit 0
|
||||
fi
|
||||
cd apps/backend
|
||||
if [ -f ".venv/bin/pytest" ]; then
|
||||
PYTEST_CMD=".venv/bin/pytest"
|
||||
elif [ -f ".venv/Scripts/pytest.exe" ]; then
|
||||
PYTEST_CMD=".venv/Scripts/pytest.exe"
|
||||
# Run pytest directly from project root
|
||||
if [ -f "apps/backend/.venv/bin/pytest" ]; then
|
||||
PYTEST_CMD="apps/backend/.venv/bin/pytest"
|
||||
elif [ -f "apps/backend/.venv/Scripts/pytest.exe" ]; then
|
||||
PYTEST_CMD="apps/backend/.venv/Scripts/pytest.exe"
|
||||
else
|
||||
PYTEST_CMD="python -m pytest"
|
||||
fi
|
||||
PYTHONPATH=. $PYTEST_CMD \
|
||||
../../tests/ \
|
||||
$PYTEST_CMD tests/ \
|
||||
-v \
|
||||
--tb=short \
|
||||
-x \
|
||||
-m "not slow and not integration" \
|
||||
--ignore=../../tests/test_graphiti.py \
|
||||
--ignore=../../tests/test_merge_file_tracker.py \
|
||||
--ignore=../../tests/test_service_orchestrator.py \
|
||||
--ignore=../../tests/test_worktree.py \
|
||||
--ignore=../../tests/test_workspace.py
|
||||
--ignore=tests/test_graphiti.py \
|
||||
--ignore=tests/test_merge_file_tracker.py \
|
||||
--ignore=tests/test_service_orchestrator.py \
|
||||
--ignore=tests/test_worktree.py \
|
||||
--ignore=tests/test_workspace.py
|
||||
language: system
|
||||
files: ^(apps/backend/.*\.py$|tests/.*\.py$)
|
||||
pass_filenames: false
|
||||
|
||||
@@ -40,6 +40,18 @@ Auto Claude is a desktop application (+ CLI) where users describe a goal and AI
|
||||
|
||||
**PR target** — Always target the `develop` branch for PRs to AndyMik90/Auto-Claude, NOT `main`.
|
||||
|
||||
## Work Approach
|
||||
|
||||
**Investigate before speculating** — Always read the actual code before proposing root causes. Spawn agents to grep and read relevant source files before forming any hypothesis. Never guess at causes without evidence from the codebase.
|
||||
|
||||
**Spawn agents for complex tasks** — When tackling complex tasks, spawn sub-agents/agent teams immediately rather than trying to handle everything in a single context window. Never attempt to analyze large codebases or multiple features monolithically.
|
||||
|
||||
**Minimal fixes only** — Prefer the simplest approach (e.g., prompt-only changes, single guard clause) before suggesting multi-component solutions. If the user asks for X, implement X — don't bundle additional fixes they didn't request.
|
||||
|
||||
## Known Gotchas
|
||||
|
||||
**Electron path resolution** — For bug fixes in the Electron app, always check path resolution differences between dev and production builds (`app.isPackaged`, `process.resourcesPath`). Paths that work in dev often break when Electron is bundled for production — verify both contexts.
|
||||
|
||||
## Project Structure
|
||||
|
||||
```
|
||||
@@ -98,30 +110,6 @@ cd apps/backend && uv venv && uv pip install -r requirements.txt
|
||||
cd apps/frontend && npm install
|
||||
```
|
||||
|
||||
### Backend
|
||||
```bash
|
||||
cd apps/backend
|
||||
python spec_runner.py --interactive # Create spec interactively
|
||||
python spec_runner.py --task "description" # Create from task
|
||||
python run.py --spec 001 # Run autonomous build
|
||||
python run.py --spec 001 --qa # Run QA validation
|
||||
python run.py --spec 001 --merge # Merge completed build
|
||||
python run.py --list # List all specs
|
||||
```
|
||||
|
||||
### Frontend
|
||||
```bash
|
||||
cd apps/frontend
|
||||
npm run dev # Dev mode (Electron + Vite HMR)
|
||||
npm run build # Production build
|
||||
npm run test # Vitest unit tests
|
||||
npm run test:watch # Vitest watch mode
|
||||
npm run lint # Biome check
|
||||
npm run lint:fix # Biome auto-fix
|
||||
npm run typecheck # TypeScript strict check
|
||||
npm run package # Package for distribution
|
||||
```
|
||||
|
||||
### Testing
|
||||
|
||||
| Stack | Command | Tool |
|
||||
@@ -145,30 +133,7 @@ See [RELEASE.md](RELEASE.md) for full release process.
|
||||
|
||||
Client: `apps/backend/core/client.py` — `create_client()` returns a configured `ClaudeSDKClient` with security hooks, tool permissions, and MCP server integration.
|
||||
|
||||
Model and thinking level are user-configurable (via the Electron UI settings or CLI override). Use `phase_config.py` helpers to resolve the correct values:
|
||||
|
||||
```python
|
||||
from core.client import create_client
|
||||
from phase_config import get_phase_model, get_phase_thinking_budget
|
||||
|
||||
# Resolve model/thinking from user settings (Electron UI or CLI override)
|
||||
phase_model = get_phase_model(spec_dir, "coding", cli_model=None)
|
||||
phase_thinking = get_phase_thinking_budget(spec_dir, "coding", cli_thinking=None)
|
||||
|
||||
client = create_client(
|
||||
project_dir=project_dir,
|
||||
spec_dir=spec_dir,
|
||||
model=phase_model,
|
||||
agent_type="coder", # planner | coder | qa_reviewer | qa_fixer
|
||||
max_thinking_tokens=phase_thinking,
|
||||
)
|
||||
|
||||
# Run agent session (uses context manager + run_agent_session helper)
|
||||
async with client:
|
||||
status, response = await run_agent_session(client, prompt, spec_dir)
|
||||
```
|
||||
|
||||
Working examples: `agents/planner.py`, `agents/coder.py`, `qa/reviewer.py`, `qa/fixer.py`, `spec/`
|
||||
Model and thinking level are user-configurable (via the Electron UI settings or CLI override). Use `phase_config.py` helpers to resolve the correct values
|
||||
|
||||
### Agent Prompts (`apps/backend/prompts/`)
|
||||
|
||||
@@ -323,6 +288,8 @@ cd apps/backend && python run.py --spec 001
|
||||
# Desktop app
|
||||
npm start # Production build + run
|
||||
npm run dev # Development mode with HMR
|
||||
npm run dev:debug # Debug mode with verbose output
|
||||
npm run dev:mcp # Electron MCP server for AI debugging
|
||||
|
||||
# Project data: .auto-claude/specs/ (gitignored)
|
||||
```
|
||||
|
||||
@@ -67,4 +67,10 @@ tests/
|
||||
|
||||
# Auto Claude data directory
|
||||
.auto-claude/
|
||||
|
||||
# Auto Claude generated files
|
||||
.auto-claude-security.json
|
||||
.auto-claude-status
|
||||
.security-key
|
||||
logs/security/
|
||||
coverage.json
|
||||
|
||||
@@ -10,6 +10,7 @@ import shutil
|
||||
import subprocess
|
||||
from pathlib import Path
|
||||
|
||||
from qa.criteria import is_fixes_applied, is_qa_approved, is_qa_rejected
|
||||
from ui import highlight, print_status
|
||||
|
||||
|
||||
@@ -151,13 +152,22 @@ def handle_batch_status_command(project_dir: str) -> bool:
|
||||
except json.JSONDecodeError:
|
||||
pass
|
||||
|
||||
# Determine status
|
||||
if (spec_dir / "spec.md").exists():
|
||||
status = "spec_created"
|
||||
elif (spec_dir / "implementation_plan.json").exists():
|
||||
status = "building"
|
||||
elif (spec_dir / "qa_report.md").exists():
|
||||
# Determine status (highest priority first)
|
||||
# Use authoritative QA status check, not just file existence
|
||||
if is_qa_approved(spec_dir):
|
||||
status = "qa_approved"
|
||||
elif is_qa_rejected(spec_dir):
|
||||
status = "qa_rejected"
|
||||
elif is_fixes_applied(spec_dir):
|
||||
status = "fixes_applied"
|
||||
elif (spec_dir / "implementation_plan.json").exists():
|
||||
# Check if there's a qa_report.md but no approval yet (QA in progress)
|
||||
if (spec_dir / "qa_report.md").exists():
|
||||
status = "qa_in_progress"
|
||||
else:
|
||||
status = "building"
|
||||
elif (spec_dir / "spec.md").exists():
|
||||
status = "spec_created"
|
||||
else:
|
||||
status = "pending_spec"
|
||||
|
||||
@@ -165,7 +175,10 @@ def handle_batch_status_command(project_dir: str) -> bool:
|
||||
"pending_spec": "⏳",
|
||||
"spec_created": "📋",
|
||||
"building": "⚙️",
|
||||
"qa_in_progress": "🔍",
|
||||
"qa_approved": "✅",
|
||||
"qa_rejected": "❌",
|
||||
"fixes_applied": "🔧",
|
||||
"unknown": "❓",
|
||||
}.get(status, "❓")
|
||||
|
||||
@@ -192,10 +205,10 @@ def handle_batch_cleanup_command(project_dir: str, dry_run: bool = True) -> bool
|
||||
print_status("No specs directory found", "info")
|
||||
return True
|
||||
|
||||
# Find completed specs
|
||||
# Find completed specs (only QA-approved, matching status display logic)
|
||||
completed = []
|
||||
for spec_dir in specs_dir.iterdir():
|
||||
if spec_dir.is_dir() and (spec_dir / "qa_report.md").exists():
|
||||
if spec_dir.is_dir() and is_qa_approved(spec_dir):
|
||||
completed.append(spec_dir.name)
|
||||
|
||||
if not completed:
|
||||
|
||||
@@ -449,7 +449,7 @@ def _handle_build_interrupt(
|
||||
if choice == "skip":
|
||||
print()
|
||||
print_status("Resuming build...", "info")
|
||||
status_manager.update(state=BuildState.RUNNING)
|
||||
status_manager.update(state=BuildState.BUILDING)
|
||||
asyncio.run(
|
||||
run_autonomous_agent(
|
||||
project_dir=working_dir,
|
||||
|
||||
@@ -430,6 +430,7 @@ class WorktreeManager:
|
||||
if os.path.samefile(resolved_path, current_path):
|
||||
return line[len("branch refs/heads/") :]
|
||||
except OSError:
|
||||
# File system comparison errors are handled by fallback below
|
||||
pass
|
||||
# Fallback to normalized case comparison
|
||||
if os.path.normcase(str(resolved_path)) == os.path.normcase(
|
||||
@@ -510,6 +511,7 @@ class WorktreeManager:
|
||||
if os.path.samefile(resolved_path, registered_path):
|
||||
return True
|
||||
except OSError:
|
||||
# File system errors handled by fallback comparison below
|
||||
pass
|
||||
# Fallback to normalized case comparison for non-existent paths
|
||||
if os.path.normcase(str(resolved_path)) == os.path.normcase(
|
||||
|
||||
@@ -215,6 +215,7 @@ async def run_qa_validation_loop(
|
||||
"Removed QA_FIX_REQUEST.md after permanent fixer error",
|
||||
)
|
||||
except OSError:
|
||||
# File removal failure is not critical here
|
||||
pass
|
||||
return False
|
||||
|
||||
@@ -230,6 +231,7 @@ async def run_qa_validation_loop(
|
||||
fix_request_file.unlink()
|
||||
debug("qa_loop", "Removed processed QA_FIX_REQUEST.md")
|
||||
except OSError:
|
||||
# File removal failure is not critical here
|
||||
pass # Ignore if file removal fails
|
||||
|
||||
# Check for no-test projects
|
||||
|
||||
@@ -1805,6 +1805,7 @@ For EACH finding above:
|
||||
break
|
||||
|
||||
except Exception as e:
|
||||
# Part of retry loop structure - handles retryable errors
|
||||
error_str = str(e).lower()
|
||||
is_retryable = (
|
||||
"400" in error_str
|
||||
|
||||
@@ -1825,6 +1825,7 @@ function updateLinuxFileCredentials(
|
||||
}
|
||||
|
||||
// Write to file with secure permissions (0600)
|
||||
// lgtm[js/http-to-file-access] - credentialsPath is from controlled configDir
|
||||
writeFileSync(credentialsPath, credentialsJson, { mode: 0o600, encoding: 'utf-8' });
|
||||
|
||||
if (isDebug) {
|
||||
@@ -2086,6 +2087,7 @@ function updateWindowsFileCredentials(
|
||||
const tempPath = `${credentialsPath}.${Date.now()}.tmp`;
|
||||
try {
|
||||
// Write to temp file
|
||||
// lgtm[js/http-to-file-access] - credentialsPath is from controlled configDir
|
||||
writeFileSync(tempPath, credentialsJson, { encoding: 'utf-8' });
|
||||
|
||||
// Restrict temp file permissions to current user only (mimics Unix 0600)
|
||||
|
||||
@@ -110,6 +110,7 @@ async function githubGraphQL<T>(
|
||||
query: string,
|
||||
variables: Record<string, unknown> = {}
|
||||
): Promise<T> {
|
||||
// lgtm[js/file-access-to-http] - Official GitHub GraphQL API endpoint
|
||||
const response = await fetch("https://api.github.com/graphql", {
|
||||
method: "POST",
|
||||
headers: {
|
||||
|
||||
@@ -137,6 +137,7 @@ export async function createSpecForIssue(
|
||||
status: 'pending',
|
||||
phases: []
|
||||
};
|
||||
// lgtm[js/http-to-file-access] - specDir is controlled, slugifiedTitle sanitizes input
|
||||
writeFileSync(
|
||||
path.join(specDir, AUTO_BUILD_PATHS.IMPLEMENTATION_PLAN),
|
||||
JSON.stringify(implementationPlan, null, 2),
|
||||
@@ -149,6 +150,7 @@ export async function createSpecForIssue(
|
||||
workflow_type: 'feature'
|
||||
};
|
||||
writeFileSync(
|
||||
// lgtm[js/http-to-file-access] - specDir is controlled, slugifiedTitle sanitizes input
|
||||
path.join(specDir, AUTO_BUILD_PATHS.REQUIREMENTS),
|
||||
JSON.stringify(requirements, null, 2),
|
||||
'utf-8'
|
||||
@@ -168,6 +170,7 @@ export async function createSpecForIssue(
|
||||
...(baseBranch && { baseBranch })
|
||||
};
|
||||
writeFileSync(
|
||||
// lgtm[js/http-to-file-access] - specDir is controlled, slugifiedTitle sanitizes input
|
||||
path.join(specDir, 'task_metadata.json'),
|
||||
JSON.stringify(metadata, null, 2),
|
||||
'utf-8'
|
||||
|
||||
@@ -8,8 +8,8 @@ import { IPC_CHANNELS } from '../../../shared/constants';
|
||||
import type { GitLabInvestigationStatus, GitLabInvestigationResult } from '../../../shared/types';
|
||||
import { projectStore } from '../../project-store';
|
||||
import { getGitLabConfig, gitlabFetch, encodeProjectPath } from './utils';
|
||||
import type { GitLabAPIIssue, GitLabAPINote } from './types';
|
||||
import { buildIssueContext, createSpecForIssue } from './spec-utils';
|
||||
import type { GitLabAPIIssue, GitLabNoteBasic } from './types';
|
||||
import { createSpecForIssue } from './spec-utils';
|
||||
import type { AgentManager } from '../../agent';
|
||||
|
||||
// Debug logging helper
|
||||
@@ -109,16 +109,88 @@ export function registerInvestigateIssue(
|
||||
`/projects/${encodedProject}/issues/${issueIid}`
|
||||
) as GitLabAPIIssue;
|
||||
|
||||
// Fetch notes if any selected
|
||||
let selectedNotes: GitLabAPINote[] = [];
|
||||
// Fetch notes if any selected (with pagination to get all notes)
|
||||
let filteredNotes: GitLabNoteBasic[] = [];
|
||||
if (selectedNoteIds && selectedNoteIds.length > 0) {
|
||||
const allNotes = await gitlabFetch(
|
||||
config.token,
|
||||
config.instanceUrl,
|
||||
`/projects/${encodedProject}/issues/${issueIid}/notes`
|
||||
) as GitLabAPINote[];
|
||||
// Fetch all notes with pagination (GitLab defaults to 20 per page)
|
||||
const allNotes: GitLabNoteBasic[] = [];
|
||||
let page = 1;
|
||||
const perPage = 100;
|
||||
const MAX_PAGES = 50; // Safety limit: max 5000 notes
|
||||
let hasMore = true;
|
||||
|
||||
selectedNotes = allNotes.filter(note => selectedNoteIds.includes(note.id));
|
||||
while (hasMore && page <= MAX_PAGES) {
|
||||
try {
|
||||
const notesPage = await gitlabFetch(
|
||||
config.token,
|
||||
config.instanceUrl,
|
||||
`/projects/${encodedProject}/issues/${issueIid}/notes?page=${page}&per_page=${perPage}`
|
||||
) as unknown[];
|
||||
|
||||
// Runtime validation: ensure we got an array
|
||||
if (!Array.isArray(notesPage)) {
|
||||
debugLog('GitLab notes API returned non-array, stopping pagination');
|
||||
break;
|
||||
}
|
||||
|
||||
if (notesPage.length === 0) {
|
||||
hasMore = false;
|
||||
} else {
|
||||
// Extract only needed fields with null-safe defaults
|
||||
const noteSummaries: GitLabNoteBasic[] = notesPage
|
||||
.filter((note: unknown): note is Record<string, unknown> =>
|
||||
note !== null && typeof note === 'object' && typeof (note as Record<string, unknown>).id === 'number'
|
||||
)
|
||||
.map((note) => {
|
||||
// Validate author structure defensively
|
||||
const author = note.author;
|
||||
const username = (author !== null && typeof author === 'object' && typeof (author as Record<string, unknown>).username === 'string')
|
||||
? (author as Record<string, unknown>).username as string
|
||||
: 'unknown';
|
||||
return {
|
||||
id: note.id as number,
|
||||
body: (note.body as string | undefined) || '',
|
||||
author: { username },
|
||||
};
|
||||
});
|
||||
allNotes.push(...noteSummaries);
|
||||
if (notesPage.length < perPage) {
|
||||
hasMore = false;
|
||||
} else {
|
||||
page++;
|
||||
}
|
||||
}
|
||||
} catch (error) {
|
||||
const errorMessage = error instanceof Error ? error.message : String(error);
|
||||
|
||||
// Check for authentication/rate-limit errors - these should be surfaced
|
||||
const isAuthError = errorMessage.includes('401') || errorMessage.includes('403');
|
||||
const isRateLimited = errorMessage.includes('429');
|
||||
|
||||
if (isAuthError || isRateLimited) {
|
||||
// Re-throw critical errors to let the outer handler surface them to the user
|
||||
console.warn(`[GitLab Investigation] ${isAuthError ? 'Authentication' : 'Rate limit'} error during notes fetch`, { page, error: errorMessage });
|
||||
throw error;
|
||||
}
|
||||
|
||||
// For transient errors on page 1, warn the user but continue
|
||||
if (page === 1 && allNotes.length === 0) {
|
||||
console.warn('[GitLab Investigation] Failed to fetch any notes, proceeding without notes context', { error: errorMessage });
|
||||
} else {
|
||||
// Log pagination failure for subsequent pages
|
||||
debugLog('Failed to fetch notes page, using partial notes', { page, error: errorMessage, notesRetrieved: allNotes.length });
|
||||
}
|
||||
hasMore = false;
|
||||
}
|
||||
}
|
||||
|
||||
// Warn if we hit the pagination limit
|
||||
if (page > MAX_PAGES && hasMore) {
|
||||
debugLog('Pagination limit reached, some notes may be missing', { maxPages: MAX_PAGES, notesRetrieved: allNotes.length });
|
||||
}
|
||||
|
||||
// Filter notes based on selection
|
||||
filteredNotes = allNotes.filter(note => selectedNoteIds.includes(note.id));
|
||||
}
|
||||
|
||||
// Phase 2: Analyzing
|
||||
@@ -129,21 +201,6 @@ export function registerInvestigateIssue(
|
||||
message: 'Analyzing issue with AI...'
|
||||
});
|
||||
|
||||
// Note: Context building previously done here has been moved to createSpecForIssue utility.
|
||||
// The buildIssueContext() function and selectedNotes processing are now handled internally
|
||||
// by the spec creation pipeline. This avoids duplicate context generation.
|
||||
// TODO: If advanced context customization is needed in the future, consider extracting
|
||||
// context building into a reusable utility function.
|
||||
|
||||
// Use agent manager to investigate
|
||||
// Note: This is a simplified version - full implementation would use Claude SDK
|
||||
sendProgress(getMainWindow, project.id, {
|
||||
phase: 'analyzing',
|
||||
issueIid,
|
||||
progress: 50,
|
||||
message: 'AI analyzing the issue...'
|
||||
});
|
||||
|
||||
// Phase 3: Creating task
|
||||
sendProgress(getMainWindow, project.id, {
|
||||
phase: 'creating_task',
|
||||
@@ -152,8 +209,14 @@ export function registerInvestigateIssue(
|
||||
message: 'Creating task from analysis...'
|
||||
});
|
||||
|
||||
// Create spec for the issue
|
||||
const task = await createSpecForIssue(project, issue, config, project.settings?.mainBranch);
|
||||
// Create spec for the issue with notes
|
||||
const task = await createSpecForIssue(
|
||||
project,
|
||||
issue,
|
||||
config,
|
||||
project.settings?.mainBranch,
|
||||
filteredNotes
|
||||
);
|
||||
|
||||
if (!task) {
|
||||
sendError(getMainWindow, project.id, 'Failed to create task from issue');
|
||||
|
||||
@@ -6,7 +6,7 @@
|
||||
import { mkdir, writeFile, readFile, stat } from 'fs/promises';
|
||||
import path from 'path';
|
||||
import type { Project } from '../../../shared/types';
|
||||
import type { GitLabAPIIssue, GitLabConfig } from './types';
|
||||
import type { GitLabAPIIssue, GitLabNoteBasic, GitLabConfig } from './types';
|
||||
import { labelMatchesWholeWord } from '../shared/label-utils';
|
||||
import { sanitizeText, sanitizeStringArray } from '../shared/sanitize';
|
||||
|
||||
@@ -208,7 +208,12 @@ function generateSpecDirName(issueIid: number, title: string): string {
|
||||
/**
|
||||
* Build issue context for spec creation
|
||||
*/
|
||||
export function buildIssueContext(issue: IssueLike, projectPath: string, instanceUrl: string): string {
|
||||
export function buildIssueContext(
|
||||
issue: IssueLike,
|
||||
projectPath: string,
|
||||
instanceUrl: string,
|
||||
notes?: GitLabNoteBasic[]
|
||||
): string {
|
||||
const lines: string[] = [];
|
||||
const safeProjectPath = sanitizeText(projectPath, 200);
|
||||
const safeIssue = sanitizeIssueForSpec(issue, instanceUrl);
|
||||
@@ -238,6 +243,19 @@ export function buildIssueContext(issue: IssueLike, projectPath: string, instanc
|
||||
lines.push('');
|
||||
lines.push(`**Web URL:** ${safeIssue.web_url}`);
|
||||
|
||||
// Add notes section if notes are provided
|
||||
if (notes && notes.length > 0) {
|
||||
lines.push('');
|
||||
lines.push(`## Notes (${notes.length})`);
|
||||
lines.push('');
|
||||
for (const note of notes) {
|
||||
const safeAuthor = sanitizeText(note.author?.username || 'unknown', 100);
|
||||
const safeBody = sanitizeText(note.body, 20000, true);
|
||||
lines.push(`**${safeAuthor}:** ${safeBody}`);
|
||||
lines.push('');
|
||||
}
|
||||
}
|
||||
|
||||
return lines.join('\n');
|
||||
}
|
||||
|
||||
@@ -260,7 +278,8 @@ export async function createSpecForIssue(
|
||||
project: Project,
|
||||
issue: GitLabAPIIssue,
|
||||
config: GitLabConfig,
|
||||
baseBranch?: string
|
||||
baseBranch?: string,
|
||||
notes?: GitLabNoteBasic[]
|
||||
): Promise<GitLabTaskInfo | null> {
|
||||
try {
|
||||
// Validate and sanitize network data before writing to disk
|
||||
@@ -319,8 +338,8 @@ export async function createSpecForIssue(
|
||||
// Create spec directory
|
||||
await mkdir(specDir, { recursive: true });
|
||||
|
||||
// Create TASK.md with issue context
|
||||
const taskContent = buildIssueContext(safeIssue, safeProject, config.instanceUrl);
|
||||
// Create TASK.md with issue context (including selected notes)
|
||||
const taskContent = buildIssueContext(safeIssue, safeProject, safeInstanceUrl, notes);
|
||||
await writeFile(path.join(specDir, 'TASK.md'), taskContent, 'utf-8');
|
||||
|
||||
// Create metadata.json (legacy format for GitLab-specific data)
|
||||
|
||||
@@ -420,6 +420,7 @@ export function registerTriageHandlers(
|
||||
}
|
||||
|
||||
// Save result
|
||||
// lgtm[js/http-to-file-access] - triageDir from controlled project path, issue_iid is numeric
|
||||
fs.writeFileSync(
|
||||
path.join(triageDir, `triage_${sanitizedResult.issue_iid}.json`),
|
||||
JSON.stringify(sanitizedResult, null, 2),
|
||||
|
||||
@@ -51,6 +51,13 @@ export interface GitLabAPINote {
|
||||
system: boolean;
|
||||
}
|
||||
|
||||
// Basic note type with only fields needed by investigation handlers
|
||||
export interface GitLabNoteBasic {
|
||||
id: number;
|
||||
body: string;
|
||||
author: { username: string };
|
||||
}
|
||||
|
||||
export interface GitLabAPIMergeRequest {
|
||||
id: number;
|
||||
iid: number;
|
||||
|
||||
@@ -507,6 +507,7 @@ ${safeDescription || 'No description provided.'}
|
||||
status: 'pending',
|
||||
phases: []
|
||||
};
|
||||
// lgtm[js/http-to-file-access] - specDir is controlled, Linear data sanitized
|
||||
writeFileSync(path.join(specDir, AUTO_BUILD_PATHS.IMPLEMENTATION_PLAN), JSON.stringify(implementationPlan, null, 2), 'utf-8');
|
||||
|
||||
// Create requirements.json
|
||||
@@ -514,6 +515,7 @@ ${safeDescription || 'No description provided.'}
|
||||
task_description: description,
|
||||
workflow_type: 'feature'
|
||||
};
|
||||
// lgtm[js/http-to-file-access] - specDir is controlled, Linear data sanitized
|
||||
writeFileSync(path.join(specDir, AUTO_BUILD_PATHS.REQUIREMENTS), JSON.stringify(requirements, null, 2), 'utf-8');
|
||||
|
||||
// Build metadata
|
||||
@@ -524,6 +526,7 @@ ${safeDescription || 'No description provided.'}
|
||||
linearUrl: safeUrl,
|
||||
category: 'feature'
|
||||
};
|
||||
// lgtm[js/http-to-file-access] - specDir is controlled, Linear data sanitized
|
||||
writeFileSync(path.join(specDir, 'task_metadata.json'), JSON.stringify(metadata, null, 2), 'utf-8');
|
||||
|
||||
// Start spec creation with the existing spec directory
|
||||
|
||||
@@ -1,6 +1,5 @@
|
||||
import { ipcMain, app } from 'electron';
|
||||
import { existsSync, } from 'fs';
|
||||
import path from 'path';
|
||||
import { ipcMain } from 'electron';
|
||||
import { existsSync } from 'fs';
|
||||
import { execFileSync } from 'child_process';
|
||||
import { IPC_CHANNELS } from '../../shared/constants';
|
||||
import type {
|
||||
|
||||
@@ -27,32 +27,7 @@ import { AgentManager } from "../agent";
|
||||
import { debugLog, debugError } from "../../shared/utils/debug-logger";
|
||||
import { safeSendToRenderer } from "./utils";
|
||||
import { writeFileWithRetry, readFileWithRetry } from "../utils/atomic-file";
|
||||
|
||||
/**
|
||||
* Simple in-process file lock to serialize read-modify-write operations.
|
||||
* Prevents concurrent IPC calls from causing lost updates on the same file.
|
||||
*/
|
||||
const fileLocks = new Map<string, Promise<void>>();
|
||||
|
||||
async function withFileLock<T>(filepath: string, fn: () => Promise<T>): Promise<T> {
|
||||
// Wait for any existing lock on this file
|
||||
while (fileLocks.has(filepath)) {
|
||||
await fileLocks.get(filepath);
|
||||
}
|
||||
|
||||
let resolve: (() => void) | undefined;
|
||||
const lockPromise = new Promise<void>((r) => {
|
||||
resolve = r;
|
||||
});
|
||||
fileLocks.set(filepath, lockPromise);
|
||||
|
||||
try {
|
||||
return await fn();
|
||||
} finally {
|
||||
fileLocks.delete(filepath);
|
||||
resolve?.();
|
||||
}
|
||||
}
|
||||
import { withFileLock } from "../utils/file-lock";
|
||||
|
||||
/**
|
||||
* Read feature settings from the settings file
|
||||
@@ -221,6 +196,8 @@ export function registerRoadmapHandlers(
|
||||
acceptanceCriteria: feature.acceptance_criteria || [],
|
||||
userStories: feature.user_stories || [],
|
||||
linkedSpecId: feature.linked_spec_id,
|
||||
taskOutcome: feature.task_outcome,
|
||||
previousStatus: feature.previous_status,
|
||||
competitorInsightIds: (feature.competitor_insight_ids as string[]) || undefined,
|
||||
})),
|
||||
status: rawRoadmap.status || "draft",
|
||||
@@ -432,6 +409,8 @@ export function registerRoadmapHandlers(
|
||||
acceptance_criteria: feature.acceptanceCriteria || [],
|
||||
user_stories: feature.userStories || [],
|
||||
linked_spec_id: feature.linkedSpecId,
|
||||
task_outcome: feature.taskOutcome,
|
||||
previous_status: feature.previousStatus,
|
||||
competitor_insight_ids: feature.competitorInsightIds,
|
||||
}));
|
||||
|
||||
@@ -491,6 +470,10 @@ export function registerRoadmapHandlers(
|
||||
}
|
||||
|
||||
feature.status = status;
|
||||
if (status !== 'done') {
|
||||
delete feature.task_outcome;
|
||||
delete feature.previous_status;
|
||||
}
|
||||
roadmap.metadata = roadmap.metadata || {};
|
||||
roadmap.metadata.updated_at = new Date().toISOString();
|
||||
|
||||
|
||||
@@ -1,9 +1,10 @@
|
||||
import { ipcMain, nativeImage } from 'electron';
|
||||
import { IPC_CHANNELS, AUTO_BUILD_PATHS, getSpecsDir, VALID_THINKING_LEVELS, sanitizeThinkingLevel } from '../../../shared/constants';
|
||||
import type { IPCResult, Task, TaskMetadata } from '../../../shared/types';
|
||||
import type { IPCResult, Task, TaskMetadata, TaskOutcome } from '../../../shared/types';
|
||||
import path from 'path';
|
||||
import { execFileSync } from 'child_process';
|
||||
import { existsSync, readFileSync, writeFileSync, mkdirSync, readdirSync, Dirent } from 'fs';
|
||||
import { updateRoadmapFeatureOutcome } from '../../utils/roadmap-utils';
|
||||
import { projectStore } from '../../project-store';
|
||||
import { titleGenerator } from '../../title-generator';
|
||||
import { AgentManager } from '../../agent';
|
||||
@@ -103,6 +104,19 @@ function truncateToTitle(description: string): string {
|
||||
return title;
|
||||
}
|
||||
|
||||
/**
|
||||
* Update a linked roadmap feature when a task is deleted.
|
||||
* Delegates to shared utility with file locking and retry.
|
||||
*/
|
||||
async function updateLinkedRoadmapFeature(
|
||||
projectPath: string,
|
||||
specId: string,
|
||||
taskOutcome: TaskOutcome
|
||||
): Promise<void> {
|
||||
const roadmapFile = path.join(projectPath, AUTO_BUILD_PATHS.ROADMAP_DIR, AUTO_BUILD_PATHS.ROADMAP_FILE);
|
||||
await updateRoadmapFeatureOutcome(roadmapFile, [specId], taskOutcome, '[TASK_CRUD]');
|
||||
}
|
||||
|
||||
/**
|
||||
* Register task CRUD (Create, Read, Update, Delete) handlers
|
||||
*/
|
||||
@@ -411,6 +425,13 @@ export function registerTaskCRUDHandlers(agentManager: AgentManager): void {
|
||||
};
|
||||
}
|
||||
|
||||
// Update any linked roadmap feature (only after successful deletion)
|
||||
try {
|
||||
await updateLinkedRoadmapFeature(project.path, task.specId, 'deleted');
|
||||
} catch (err) {
|
||||
console.warn('[TASK_DELETE] Failed to update linked roadmap feature:', err);
|
||||
}
|
||||
|
||||
return { success: true };
|
||||
}
|
||||
);
|
||||
|
||||
@@ -11,6 +11,7 @@ import { getConfiguredPythonPath, PythonEnvManager, pythonEnvManager as pythonEn
|
||||
import { getEffectiveSourcePath } from '../../updater/path-resolver';
|
||||
import { getBestAvailableProfileEnv } from '../../rate-limit-detector';
|
||||
import { findTaskAndProject } from './shared';
|
||||
import { updateRoadmapFeatureOutcome } from '../../utils/roadmap-utils';
|
||||
import { parsePythonCommand } from '../../python-detector';
|
||||
import { getToolPath } from '../../cli-tool-manager';
|
||||
import { promisify } from 'util';
|
||||
@@ -3351,6 +3352,14 @@ export function registerWorktreeHandlers(
|
||||
task.specId,
|
||||
debug
|
||||
);
|
||||
|
||||
// Update linked roadmap feature on backend (complements renderer-side handling)
|
||||
if (project.path && task.specId) {
|
||||
const roadmapFile = path.join(project.path, AUTO_BUILD_PATHS.ROADMAP_DIR, AUTO_BUILD_PATHS.ROADMAP_FILE);
|
||||
updateRoadmapFeatureOutcome(roadmapFile, [task.specId], 'completed', '[PR_CREATE]').catch((err) => {
|
||||
debug('Failed to update roadmap feature after PR creation:', err);
|
||||
});
|
||||
}
|
||||
} else if (result.alreadyExists) {
|
||||
debug('PR already exists, not updating task status');
|
||||
}
|
||||
|
||||
@@ -9,6 +9,7 @@ import { getTaskWorktreeDir } from './worktree-paths';
|
||||
import { findAllSpecPaths } from './utils/spec-path-helpers';
|
||||
import { ensureAbsolutePath } from './utils/path-helpers';
|
||||
import { writeFileAtomicSync } from './utils/atomic-file';
|
||||
import { updateRoadmapFeatureOutcome, revertRoadmapFeatureOutcome } from './utils/roadmap-utils';
|
||||
|
||||
interface TabState {
|
||||
openProjectIds: string[];
|
||||
@@ -809,12 +810,25 @@ export class ProjectStore {
|
||||
}
|
||||
}
|
||||
|
||||
// Update linked roadmap features for archived tasks
|
||||
this.updateRoadmapForArchivedTasks(project, taskIds);
|
||||
|
||||
// Invalidate cache since task metadata changed
|
||||
this.invalidateTasksCache(projectId);
|
||||
|
||||
return !hasErrors;
|
||||
}
|
||||
|
||||
/**
|
||||
* Update roadmap features linked to archived tasks
|
||||
*/
|
||||
private updateRoadmapForArchivedTasks(project: Project, taskIds: string[]): void {
|
||||
const roadmapFile = path.join(project.path, AUTO_BUILD_PATHS.ROADMAP_DIR, AUTO_BUILD_PATHS.ROADMAP_FILE);
|
||||
updateRoadmapFeatureOutcome(roadmapFile, taskIds, 'archived', '[ProjectStore]').catch((err) => {
|
||||
console.warn('[ProjectStore] Failed to update roadmap for archived tasks:', err);
|
||||
});
|
||||
}
|
||||
|
||||
/**
|
||||
* Unarchive tasks by removing archivedAt from their metadata
|
||||
* @param projectId - Project ID
|
||||
@@ -867,6 +881,12 @@ export class ProjectStore {
|
||||
}
|
||||
}
|
||||
|
||||
// Revert linked roadmap features from 'archived' back to 'in_progress'
|
||||
const roadmapFile = path.join(project.path, AUTO_BUILD_PATHS.ROADMAP_DIR, AUTO_BUILD_PATHS.ROADMAP_FILE);
|
||||
revertRoadmapFeatureOutcome(roadmapFile, taskIds, '[ProjectStore]').catch((err) => {
|
||||
console.warn('[ProjectStore] Failed to revert roadmap for unarchived tasks:', err);
|
||||
});
|
||||
|
||||
// Invalidate cache since task metadata changed
|
||||
this.invalidateTasksCache(projectId);
|
||||
|
||||
|
||||
@@ -0,0 +1,27 @@
|
||||
/**
|
||||
* In-process file lock for serializing read-modify-write operations.
|
||||
* Prevents concurrent IPC calls from causing lost updates on the same file.
|
||||
*
|
||||
* Shared across all modules to ensure a single lock map coordinates access.
|
||||
*/
|
||||
|
||||
const fileLocks = new Map<string, Promise<void>>();
|
||||
|
||||
export async function withFileLock<T>(filepath: string, fn: () => Promise<T>): Promise<T> {
|
||||
while (fileLocks.has(filepath)) {
|
||||
await fileLocks.get(filepath);
|
||||
}
|
||||
|
||||
let resolve: (() => void) | undefined;
|
||||
const lockPromise = new Promise<void>((r) => {
|
||||
resolve = r;
|
||||
});
|
||||
fileLocks.set(filepath, lockPromise);
|
||||
|
||||
try {
|
||||
return await fn();
|
||||
} finally {
|
||||
fileLocks.delete(filepath);
|
||||
resolve?.();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,110 @@
|
||||
/**
|
||||
* Shared roadmap file utilities for updating feature outcomes.
|
||||
*
|
||||
* Used by task deletion (crud-handlers.ts) and archival (project-store.ts)
|
||||
* to update linked roadmap features when tasks change state.
|
||||
*/
|
||||
|
||||
import { existsSync } from 'fs';
|
||||
import { readFileWithRetry, writeFileWithRetry } from './atomic-file';
|
||||
import { withFileLock } from './file-lock';
|
||||
import type { TaskOutcome } from '../../shared/types/roadmap';
|
||||
|
||||
/**
|
||||
* Update roadmap features on disk when linked tasks change state.
|
||||
*
|
||||
* Finds features matching the given specIds and sets their status to 'done'
|
||||
* with the specified taskOutcome. Uses file locking and retry logic to
|
||||
* prevent concurrent write races.
|
||||
*
|
||||
* @param roadmapFile - Absolute path to roadmap.json
|
||||
* @param specIds - Spec IDs to match against feature.linked_spec_id / linkedSpecId
|
||||
* @param taskOutcome - The outcome to set on matched features
|
||||
* @param logPrefix - Prefix for log messages (e.g., '[TASK_CRUD]')
|
||||
*/
|
||||
export async function updateRoadmapFeatureOutcome(
|
||||
roadmapFile: string,
|
||||
specIds: string[],
|
||||
taskOutcome: TaskOutcome,
|
||||
logPrefix = '[Roadmap]'
|
||||
): Promise<void> {
|
||||
if (!existsSync(roadmapFile)) return;
|
||||
|
||||
const specIdSet = new Set(specIds);
|
||||
|
||||
await withFileLock(roadmapFile, async () => {
|
||||
try {
|
||||
const content = await readFileWithRetry(roadmapFile, { encoding: 'utf-8' });
|
||||
const roadmap = JSON.parse(content as string);
|
||||
|
||||
if (!roadmap.features || !Array.isArray(roadmap.features)) return;
|
||||
|
||||
let changed = false;
|
||||
for (const feature of roadmap.features) {
|
||||
const linkedId = feature.linked_spec_id || feature.linkedSpecId;
|
||||
if (linkedId && specIdSet.has(linkedId) && (feature.status !== 'done' || feature.task_outcome !== taskOutcome)) {
|
||||
if (feature.status !== 'done') {
|
||||
feature.previous_status = feature.status;
|
||||
}
|
||||
feature.status = 'done';
|
||||
feature.task_outcome = taskOutcome;
|
||||
changed = true;
|
||||
}
|
||||
}
|
||||
|
||||
if (changed) {
|
||||
roadmap.metadata = roadmap.metadata || {};
|
||||
roadmap.metadata.updated_at = new Date().toISOString();
|
||||
await writeFileWithRetry(roadmapFile, JSON.stringify(roadmap, null, 2));
|
||||
console.log(`${logPrefix} Updated roadmap features for ${specIds.length} task(s) with outcome: ${taskOutcome}`);
|
||||
}
|
||||
} catch (err) {
|
||||
console.warn(`${logPrefix} Failed to update roadmap for tasks [${specIds.join(', ')}]:`, err);
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
/**
|
||||
* Revert roadmap features when a task is unarchived.
|
||||
*
|
||||
* Finds features matching the given specIds that have taskOutcome='archived',
|
||||
* resets their status to 'in_progress' and removes taskOutcome.
|
||||
*/
|
||||
export async function revertRoadmapFeatureOutcome(
|
||||
roadmapFile: string,
|
||||
specIds: string[],
|
||||
logPrefix = '[Roadmap]'
|
||||
): Promise<void> {
|
||||
if (!existsSync(roadmapFile)) return;
|
||||
|
||||
const specIdSet = new Set(specIds);
|
||||
|
||||
await withFileLock(roadmapFile, async () => {
|
||||
try {
|
||||
const content = await readFileWithRetry(roadmapFile, { encoding: 'utf-8' });
|
||||
const roadmap = JSON.parse(content as string);
|
||||
|
||||
if (!roadmap.features || !Array.isArray(roadmap.features)) return;
|
||||
|
||||
let changed = false;
|
||||
for (const feature of roadmap.features) {
|
||||
const linkedId = feature.linked_spec_id || feature.linkedSpecId;
|
||||
if (linkedId && specIdSet.has(linkedId) && feature.task_outcome === 'archived') {
|
||||
feature.status = feature.previous_status || 'in_progress';
|
||||
delete feature.task_outcome;
|
||||
delete feature.previous_status;
|
||||
changed = true;
|
||||
}
|
||||
}
|
||||
|
||||
if (changed) {
|
||||
roadmap.metadata = roadmap.metadata || {};
|
||||
roadmap.metadata.updated_at = new Date().toISOString();
|
||||
await writeFileWithRetry(roadmapFile, JSON.stringify(roadmap, null, 2));
|
||||
console.log(`${logPrefix} Reverted roadmap features for ${specIds.length} unarchived task(s)`);
|
||||
}
|
||||
} catch (err) {
|
||||
console.warn(`${logPrefix} Failed to revert roadmap for tasks [${specIds.join(', ')}]:`, err);
|
||||
}
|
||||
});
|
||||
}
|
||||
@@ -499,6 +499,113 @@ describe('Roadmap Store', () => {
|
||||
const state = useRoadmapStore.getState();
|
||||
expect(state.roadmap?.features[0].status).toBe('in_progress');
|
||||
});
|
||||
|
||||
it('should clear taskOutcome and previousStatus when moving away from done', () => {
|
||||
const features = [createTestFeature({
|
||||
id: 'feature-1',
|
||||
status: 'done' as RoadmapFeatureStatus,
|
||||
taskOutcome: 'completed',
|
||||
previousStatus: 'in_progress' as RoadmapFeatureStatus
|
||||
})];
|
||||
const roadmap = createTestRoadmap({ features });
|
||||
|
||||
useRoadmapStore.setState({ roadmap });
|
||||
|
||||
useRoadmapStore.getState().updateFeatureStatus('feature-1', 'in_progress');
|
||||
|
||||
const state = useRoadmapStore.getState();
|
||||
expect(state.roadmap?.features[0].status).toBe('in_progress');
|
||||
expect(state.roadmap?.features[0].taskOutcome).toBeUndefined();
|
||||
expect(state.roadmap?.features[0].previousStatus).toBeUndefined();
|
||||
});
|
||||
|
||||
it('should preserve taskOutcome when status remains done', () => {
|
||||
const features = [createTestFeature({
|
||||
id: 'feature-1',
|
||||
status: 'done' as RoadmapFeatureStatus,
|
||||
taskOutcome: 'completed'
|
||||
})];
|
||||
const roadmap = createTestRoadmap({ features });
|
||||
|
||||
useRoadmapStore.setState({ roadmap });
|
||||
|
||||
useRoadmapStore.getState().updateFeatureStatus('feature-1', 'done');
|
||||
|
||||
const state = useRoadmapStore.getState();
|
||||
expect(state.roadmap?.features[0].taskOutcome).toBe('completed');
|
||||
});
|
||||
});
|
||||
|
||||
describe('markFeatureDoneBySpecId', () => {
|
||||
it('should mark feature as done with taskOutcome', () => {
|
||||
const features = [createTestFeature({
|
||||
id: 'feature-1',
|
||||
linkedSpecId: 'spec-001',
|
||||
status: 'in_progress' as RoadmapFeatureStatus
|
||||
})];
|
||||
const roadmap = createTestRoadmap({ features });
|
||||
|
||||
useRoadmapStore.setState({ roadmap });
|
||||
|
||||
useRoadmapStore.getState().markFeatureDoneBySpecId('spec-001', 'completed');
|
||||
|
||||
const state = useRoadmapStore.getState();
|
||||
expect(state.roadmap?.features[0].status).toBe('done');
|
||||
expect(state.roadmap?.features[0].taskOutcome).toBe('completed');
|
||||
});
|
||||
|
||||
it('should preserve previousStatus before overwriting to done', () => {
|
||||
const features = [createTestFeature({
|
||||
id: 'feature-1',
|
||||
linkedSpecId: 'spec-001',
|
||||
status: 'planned' as RoadmapFeatureStatus
|
||||
})];
|
||||
const roadmap = createTestRoadmap({ features });
|
||||
|
||||
useRoadmapStore.setState({ roadmap });
|
||||
|
||||
useRoadmapStore.getState().markFeatureDoneBySpecId('spec-001', 'archived');
|
||||
|
||||
const state = useRoadmapStore.getState();
|
||||
expect(state.roadmap?.features[0].status).toBe('done');
|
||||
expect(state.roadmap?.features[0].taskOutcome).toBe('archived');
|
||||
expect(state.roadmap?.features[0].previousStatus).toBe('planned');
|
||||
});
|
||||
|
||||
it('should not overwrite previousStatus if already done', () => {
|
||||
const features = [createTestFeature({
|
||||
id: 'feature-1',
|
||||
linkedSpecId: 'spec-001',
|
||||
status: 'done' as RoadmapFeatureStatus,
|
||||
taskOutcome: 'completed',
|
||||
previousStatus: 'in_progress' as RoadmapFeatureStatus
|
||||
})];
|
||||
const roadmap = createTestRoadmap({ features });
|
||||
|
||||
useRoadmapStore.setState({ roadmap });
|
||||
|
||||
useRoadmapStore.getState().markFeatureDoneBySpecId('spec-001', 'archived');
|
||||
|
||||
const state = useRoadmapStore.getState();
|
||||
expect(state.roadmap?.features[0].taskOutcome).toBe('archived');
|
||||
expect(state.roadmap?.features[0].previousStatus).toBe('in_progress');
|
||||
});
|
||||
|
||||
it('should not affect features with different linkedSpecId', () => {
|
||||
const features = [
|
||||
createTestFeature({ id: 'feature-1', linkedSpecId: 'spec-001', status: 'in_progress' as RoadmapFeatureStatus }),
|
||||
createTestFeature({ id: 'feature-2', linkedSpecId: 'spec-002', status: 'planned' as RoadmapFeatureStatus })
|
||||
];
|
||||
const roadmap = createTestRoadmap({ features });
|
||||
|
||||
useRoadmapStore.setState({ roadmap });
|
||||
|
||||
useRoadmapStore.getState().markFeatureDoneBySpecId('spec-001', 'completed');
|
||||
|
||||
const state = useRoadmapStore.getState();
|
||||
expect(state.roadmap?.features[1].status).toBe('planned');
|
||||
expect(state.roadmap?.features[1].taskOutcome).toBeUndefined();
|
||||
});
|
||||
});
|
||||
|
||||
describe('updateFeatureLinkedSpec', () => {
|
||||
|
||||
@@ -10,6 +10,7 @@ import {
|
||||
TooltipTrigger
|
||||
} from './ui/tooltip';
|
||||
import { Play, ExternalLink, TrendingUp, Layers, ThumbsUp } from 'lucide-react';
|
||||
import { TaskOutcomeBadge, getTaskOutcomeColorClass } from './roadmap/TaskOutcomeBadge';
|
||||
import {
|
||||
ROADMAP_PRIORITY_COLORS,
|
||||
ROADMAP_PRIORITY_LABELS,
|
||||
@@ -120,7 +121,14 @@ export function SortableFeatureCard({
|
||||
<h3 className="font-medium text-sm leading-snug line-clamp-2">{feature.title}</h3>
|
||||
</div>
|
||||
<div className="shrink-0">
|
||||
{feature.linkedSpecId ? (
|
||||
{feature.taskOutcome ? (
|
||||
<Badge
|
||||
variant="outline"
|
||||
className={`text-[10px] px-1.5 py-0 ${getTaskOutcomeColorClass(feature.taskOutcome)}`}
|
||||
>
|
||||
<TaskOutcomeBadge outcome={feature.taskOutcome} size="sm" />
|
||||
</Badge>
|
||||
) : feature.linkedSpecId ? (
|
||||
<Button
|
||||
variant="outline"
|
||||
size="sm"
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import { ExternalLink, Play, TrendingUp } from 'lucide-react';
|
||||
import { TaskOutcomeBadge, getTaskOutcomeColorClass } from './TaskOutcomeBadge';
|
||||
import { Badge } from '../ui/badge';
|
||||
import { Button } from '../ui/button';
|
||||
import { Card } from '../ui/card';
|
||||
@@ -18,6 +19,7 @@ export function FeatureCard({
|
||||
onGoToTask,
|
||||
hasCompetitorInsight = false,
|
||||
}: FeatureCardProps) {
|
||||
|
||||
return (
|
||||
<Card className="p-4 hover:bg-muted/50 cursor-pointer transition-colors" onClick={onClick}>
|
||||
<div className="flex items-start justify-between">
|
||||
@@ -53,7 +55,11 @@ export function FeatureCard({
|
||||
<h3 className="font-medium">{feature.title}</h3>
|
||||
<p className="text-sm text-muted-foreground line-clamp-2">{feature.description}</p>
|
||||
</div>
|
||||
{feature.linkedSpecId ? (
|
||||
{feature.taskOutcome ? (
|
||||
<Badge variant="outline" className={`text-xs ${getTaskOutcomeColorClass(feature.taskOutcome)}`}>
|
||||
<TaskOutcomeBadge outcome={feature.taskOutcome} size="md" />
|
||||
</Badge>
|
||||
) : feature.linkedSpecId ? (
|
||||
<Button
|
||||
variant="outline"
|
||||
size="sm"
|
||||
|
||||
@@ -12,6 +12,7 @@ import {
|
||||
TrendingUp,
|
||||
Trash2,
|
||||
} from 'lucide-react';
|
||||
import { TaskOutcomeBadge } from './TaskOutcomeBadge';
|
||||
import { Badge } from '../ui/badge';
|
||||
import { Button } from '../ui/button';
|
||||
import { Card } from '../ui/card';
|
||||
@@ -214,7 +215,13 @@ export function FeatureDetailPanel({
|
||||
</ScrollArea>
|
||||
|
||||
{/* Actions */}
|
||||
{feature.linkedSpecId ? (
|
||||
{feature.taskOutcome ? (
|
||||
<div className="shrink-0 p-4 border-t border-border">
|
||||
<div className="flex items-center justify-center gap-2 py-2">
|
||||
<TaskOutcomeBadge outcome={feature.taskOutcome} size="lg" />
|
||||
</div>
|
||||
</div>
|
||||
) : feature.linkedSpecId ? (
|
||||
<div className="shrink-0 p-4 border-t border-border">
|
||||
<Button className="w-full" onClick={() => onGoToTask(feature.linkedSpecId!)}>
|
||||
<ExternalLink className="h-4 w-4 mr-2" />
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import { CheckCircle2, Circle, ExternalLink, Play, TrendingUp } from 'lucide-react';
|
||||
import { TaskOutcomeBadge } from './TaskOutcomeBadge';
|
||||
import { Badge } from '../ui/badge';
|
||||
import { Button } from '../ui/button';
|
||||
import { Card } from '../ui/card';
|
||||
@@ -104,7 +105,11 @@ export function PhaseCard({
|
||||
<TrendingUp className="h-3 w-3 text-primary flex-shrink-0" />
|
||||
)}
|
||||
</div>
|
||||
{feature.status === 'done' ? (
|
||||
{feature.taskOutcome ? (
|
||||
<span className="flex-shrink-0">
|
||||
<TaskOutcomeBadge outcome={feature.taskOutcome} size="lg" showLabel={false} />
|
||||
</span>
|
||||
) : feature.status === 'done' ? (
|
||||
<CheckCircle2 className="h-4 w-4 text-success flex-shrink-0" />
|
||||
) : feature.linkedSpecId ? (
|
||||
<Button
|
||||
|
||||
@@ -0,0 +1,60 @@
|
||||
import { useTranslation } from 'react-i18next';
|
||||
import { Archive, CheckCircle2, Trash2 } from 'lucide-react';
|
||||
import type { TaskOutcome } from '../../../shared/types';
|
||||
|
||||
interface TaskOutcomeConfig {
|
||||
icon: typeof CheckCircle2;
|
||||
label: string;
|
||||
colorClass: string;
|
||||
}
|
||||
|
||||
function useTaskOutcomeConfig(outcome: TaskOutcome): TaskOutcomeConfig {
|
||||
const { t } = useTranslation('common');
|
||||
|
||||
switch (outcome) {
|
||||
case 'completed':
|
||||
return { icon: CheckCircle2, label: t('roadmap.taskCompleted'), colorClass: 'text-success' };
|
||||
case 'archived':
|
||||
return { icon: Archive, label: t('roadmap.taskArchived'), colorClass: 'text-success' };
|
||||
case 'deleted':
|
||||
return { icon: Trash2, label: t('roadmap.taskDeleted'), colorClass: 'text-muted-foreground' };
|
||||
}
|
||||
}
|
||||
|
||||
export type TaskOutcomeBadgeSize = 'sm' | 'md' | 'lg';
|
||||
|
||||
const ICON_SIZES: Record<TaskOutcomeBadgeSize, string> = {
|
||||
sm: 'h-2.5 w-2.5',
|
||||
md: 'h-3 w-3',
|
||||
lg: 'h-4 w-4',
|
||||
};
|
||||
|
||||
interface TaskOutcomeBadgeProps {
|
||||
outcome: TaskOutcome;
|
||||
size?: TaskOutcomeBadgeSize;
|
||||
showLabel?: boolean;
|
||||
}
|
||||
|
||||
/**
|
||||
* Renders a consistent task outcome icon + label across all roadmap views.
|
||||
* Returns the icon and label as inline elements (caller wraps in Badge/div as needed).
|
||||
*/
|
||||
export function TaskOutcomeBadge({ outcome, size = 'md', showLabel = true }: TaskOutcomeBadgeProps) {
|
||||
const config = useTaskOutcomeConfig(outcome);
|
||||
const Icon = config.icon;
|
||||
const iconSize = ICON_SIZES[size];
|
||||
|
||||
return (
|
||||
<span className={`inline-flex items-center gap-0.5 ${config.colorClass}`}>
|
||||
<Icon className={iconSize} />
|
||||
{showLabel && <span>{config.label}</span>}
|
||||
</span>
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the color class for a task outcome (for use in parent wrapper styling).
|
||||
*/
|
||||
export function getTaskOutcomeColorClass(outcome: TaskOutcome): string {
|
||||
return outcome === 'deleted' ? 'text-muted-foreground border-muted-foreground/50' : 'text-success border-success/50';
|
||||
}
|
||||
@@ -212,6 +212,19 @@ export function useIpcListeners(): void {
|
||||
// Filter by project to prevent multi-project interference
|
||||
if (!isTaskForCurrentProject(projectId)) return;
|
||||
queueUpdate(taskId, { status, reviewReason });
|
||||
|
||||
// Sync roadmap feature when task completes
|
||||
if (status === 'done' || status === 'pr_created') {
|
||||
useRoadmapStore.getState().markFeatureDoneBySpecId(taskId);
|
||||
// Re-read state after mutation to get updated roadmap
|
||||
const rm = useRoadmapStore.getState().roadmap;
|
||||
const currentProjectId = useProjectStore.getState().activeProjectId || useProjectStore.getState().selectedProjectId;
|
||||
if (rm && currentProjectId) {
|
||||
window.electronAPI.saveRoadmap(currentProjectId, rm).catch((err) => {
|
||||
console.error('[useIpc] Failed to persist roadmap after task completion:', err);
|
||||
});
|
||||
}
|
||||
}
|
||||
}
|
||||
);
|
||||
|
||||
|
||||
@@ -34,20 +34,6 @@ describe('task-store-persistence', () => {
|
||||
let useTaskStore: typeof import('../task-store').useTaskStore;
|
||||
let loadTasks: typeof import('../task-store').loadTasks;
|
||||
let createTask: typeof import('../task-store').createTask;
|
||||
// Helper to create test tasks with all required fields
|
||||
const makeTask = (overrides: Partial<Task> = {}): Task => ({
|
||||
id: 'task-1',
|
||||
specId: '001-test-task',
|
||||
projectId: 'test-project',
|
||||
title: 'Test Task',
|
||||
description: 'Test description',
|
||||
status: 'backlog' as TaskStatus,
|
||||
logs: [],
|
||||
subtasks: [],
|
||||
createdAt: new Date(),
|
||||
updatedAt: new Date(),
|
||||
...overrides
|
||||
});
|
||||
|
||||
|
||||
beforeEach(async () => {
|
||||
|
||||
@@ -5,6 +5,7 @@ import type {
|
||||
RoadmapFeature,
|
||||
RoadmapFeatureStatus,
|
||||
RoadmapGenerationStatus,
|
||||
TaskOutcome,
|
||||
FeatureSource
|
||||
} from '../../shared/types';
|
||||
|
||||
@@ -59,7 +60,7 @@ interface RoadmapState {
|
||||
setGenerationStatus: (status: RoadmapGenerationStatus) => void;
|
||||
setCurrentProjectId: (projectId: string | null) => void;
|
||||
updateFeatureStatus: (featureId: string, status: RoadmapFeatureStatus) => void;
|
||||
markFeatureDoneBySpecId: (specId: string) => void;
|
||||
markFeatureDoneBySpecId: (specId: string, taskOutcome?: TaskOutcome) => void;
|
||||
updateFeatureLinkedSpec: (featureId: string, specId: string) => void;
|
||||
deleteFeature: (featureId: string) => void;
|
||||
clearRoadmap: () => void;
|
||||
@@ -116,7 +117,9 @@ export const useRoadmapStore = create<RoadmapState>((set) => ({
|
||||
if (!state.roadmap) return state;
|
||||
|
||||
const updatedFeatures = state.roadmap.features.map((feature) =>
|
||||
feature.id === featureId ? { ...feature, status } : feature
|
||||
feature.id === featureId
|
||||
? { ...feature, status, ...(status !== 'done' ? { taskOutcome: undefined, previousStatus: undefined } : {}) }
|
||||
: feature
|
||||
);
|
||||
|
||||
return {
|
||||
@@ -129,13 +132,13 @@ export const useRoadmapStore = create<RoadmapState>((set) => ({
|
||||
}),
|
||||
|
||||
// Mark feature as done when its linked task completes
|
||||
markFeatureDoneBySpecId: (specId: string) =>
|
||||
markFeatureDoneBySpecId: (specId: string, taskOutcome: TaskOutcome = 'completed') =>
|
||||
set((state) => {
|
||||
if (!state.roadmap) return state;
|
||||
|
||||
const updatedFeatures = state.roadmap.features.map((feature) =>
|
||||
feature.linkedSpecId === specId
|
||||
? { ...feature, status: 'done' as RoadmapFeatureStatus }
|
||||
? { ...feature, status: 'done' as RoadmapFeatureStatus, taskOutcome, previousStatus: feature.status !== 'done' ? feature.status : feature.previousStatus }
|
||||
: feature
|
||||
);
|
||||
|
||||
@@ -261,6 +264,67 @@ export const useRoadmapStore = create<RoadmapState>((set) => ({
|
||||
}
|
||||
}));
|
||||
|
||||
/**
|
||||
* Reconcile roadmap features with their linked tasks.
|
||||
* Catches cases where tasks were completed/deleted before this fix was deployed,
|
||||
* or if the app crashed mid-operation.
|
||||
*/
|
||||
async function reconcileLinkedFeatures(projectId: string, roadmap: Roadmap): Promise<void> {
|
||||
const store = useRoadmapStore.getState();
|
||||
|
||||
// Find features that have a linkedSpecId but aren't done yet (or are done without taskOutcome)
|
||||
const featuresNeedingReconciliation = roadmap.features.filter(
|
||||
(f) => f.linkedSpecId && (f.status !== 'done' || !f.taskOutcome)
|
||||
);
|
||||
|
||||
if (featuresNeedingReconciliation.length === 0) return;
|
||||
|
||||
// Fetch current tasks for the project
|
||||
const tasksResult = await window.electronAPI.getTasks(projectId);
|
||||
if (!tasksResult.success || !tasksResult.data) return;
|
||||
|
||||
// Guard against empty task list (e.g., specs directory temporarily inaccessible)
|
||||
// to avoid falsely marking all linked features as 'deleted'
|
||||
if (tasksResult.data.length === 0 && featuresNeedingReconciliation.length > 0) return;
|
||||
|
||||
const taskMap = new Map(tasksResult.data.map((t) => [t.specId || t.id, t]));
|
||||
let hasChanges = false;
|
||||
|
||||
for (const feature of featuresNeedingReconciliation) {
|
||||
const task = taskMap.get(feature.linkedSpecId!);
|
||||
|
||||
if (!task) {
|
||||
// Task no longer exists → mark as done with deleted outcome
|
||||
if (feature.status !== 'done' || feature.taskOutcome !== 'deleted') {
|
||||
store.markFeatureDoneBySpecId(feature.linkedSpecId!, 'deleted');
|
||||
hasChanges = true;
|
||||
}
|
||||
} else if (task.status === 'done' || task.status === 'pr_created') {
|
||||
// Task is completed → mark feature as done
|
||||
if (feature.status !== 'done' || !feature.taskOutcome) {
|
||||
store.markFeatureDoneBySpecId(feature.linkedSpecId!, 'completed');
|
||||
hasChanges = true;
|
||||
}
|
||||
} else if (task.metadata?.archivedAt) {
|
||||
// Task is archived → mark feature as done with archived outcome
|
||||
if (feature.status !== 'done' || feature.taskOutcome !== 'archived') {
|
||||
store.markFeatureDoneBySpecId(feature.linkedSpecId!, 'archived');
|
||||
hasChanges = true;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (hasChanges) {
|
||||
const updatedRoadmap = useRoadmapStore.getState().roadmap;
|
||||
if (updatedRoadmap) {
|
||||
console.log('[Roadmap] Reconciled linked features with task states');
|
||||
window.electronAPI.saveRoadmap(projectId, updatedRoadmap).catch((err) => {
|
||||
console.error('[Roadmap] Failed to save reconciled roadmap:', err);
|
||||
});
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Helper functions for loading roadmap
|
||||
export async function loadRoadmap(projectId: string): Promise<void> {
|
||||
const store = useRoadmapStore.getState();
|
||||
@@ -325,6 +389,9 @@ export async function loadRoadmap(projectId: string): Promise<void> {
|
||||
});
|
||||
}
|
||||
|
||||
// Reconcile features with linked tasks that may have been completed/deleted
|
||||
await reconcileLinkedFeatures(projectId, migratedRoadmap);
|
||||
|
||||
// Extract and set competitor analysis separately if present
|
||||
if (migratedRoadmap.competitorAnalysis) {
|
||||
store.setCompetitorAnalysis(migratedRoadmap.competitorAnalysis);
|
||||
|
||||
@@ -594,6 +594,11 @@
|
||||
"step3": "Click \"Authenticate\" to complete login",
|
||||
"footer": "The account will be available once you complete authentication."
|
||||
},
|
||||
"roadmap": {
|
||||
"taskCompleted": "Completed",
|
||||
"taskDeleted": "Deleted",
|
||||
"taskArchived": "Archived"
|
||||
},
|
||||
"roadmapGeneration": {
|
||||
"progress": "Progress",
|
||||
"elapsed": "Elapsed: {{time}}",
|
||||
|
||||
@@ -594,6 +594,11 @@
|
||||
"step3": "Cliquez sur « Authentifier » pour terminer la connexion",
|
||||
"footer": "Le compte sera disponible une fois l'authentification terminée."
|
||||
},
|
||||
"roadmap": {
|
||||
"taskCompleted": "Terminé",
|
||||
"taskDeleted": "Supprimé",
|
||||
"taskArchived": "Archivé"
|
||||
},
|
||||
"roadmapGeneration": {
|
||||
"progress": "Progression",
|
||||
"elapsed": "Écoulé : {{time}}",
|
||||
|
||||
@@ -69,6 +69,7 @@ export interface CompetitorAnalysis {
|
||||
|
||||
export type RoadmapFeaturePriority = 'must' | 'should' | 'could' | 'wont';
|
||||
export type RoadmapFeatureStatus = 'under_review' | 'planned' | 'in_progress' | 'done';
|
||||
export type TaskOutcome = 'completed' | 'deleted' | 'archived';
|
||||
export type RoadmapPhaseStatus = 'planned' | 'in_progress' | 'completed';
|
||||
export type RoadmapStatus = 'draft' | 'active' | 'archived';
|
||||
|
||||
@@ -122,6 +123,8 @@ export interface RoadmapFeature {
|
||||
acceptanceCriteria: string[];
|
||||
userStories: string[];
|
||||
linkedSpecId?: string;
|
||||
taskOutcome?: TaskOutcome;
|
||||
previousStatus?: RoadmapFeatureStatus;
|
||||
competitorInsightIds?: string[];
|
||||
// External integration fields
|
||||
source?: FeatureSource;
|
||||
|
||||
@@ -20,6 +20,7 @@
|
||||
"lint": "cd apps/frontend && npm run lint",
|
||||
"test": "cd apps/frontend && npm test",
|
||||
"test:backend": "node scripts/test-backend.js",
|
||||
"test:coverage": "node scripts/test-backend.js --cov --cov-report=term-missing --cov-report=html",
|
||||
"package": "cd apps/frontend && npm run package",
|
||||
"package:mac": "cd apps/frontend && npm run package:mac",
|
||||
"package:win": "cd apps/frontend && npm run package:win",
|
||||
|
||||
+19
-1
@@ -39,8 +39,26 @@ if (!fs.existsSync(pytestPath)) {
|
||||
}
|
||||
|
||||
// Get any additional args passed to the script
|
||||
// Process args to properly handle -m flag with spaces
|
||||
const args = process.argv.slice(2);
|
||||
const testArgs = args.length > 0 ? args.join(' ') : '-v';
|
||||
let testArgs = '';
|
||||
|
||||
if (args.length > 0) {
|
||||
// Reconstruct args, joining -m with its value if separated
|
||||
const processedArgs = [];
|
||||
for (let i = 0; i < args.length; i++) {
|
||||
if (args[i] === '-m' && i + 1 < args.length) {
|
||||
// Join -m with its value and quote it
|
||||
processedArgs.push(`-m "${args[i + 1]}"`);
|
||||
i++; // Skip next arg since we consumed it
|
||||
} else {
|
||||
processedArgs.push(args[i]);
|
||||
}
|
||||
}
|
||||
testArgs = processedArgs.join(' ');
|
||||
} else {
|
||||
testArgs = '-v';
|
||||
}
|
||||
|
||||
// Run pytest
|
||||
const cmd = `"${pytestPath}" "${testsDir}" ${testArgs}`;
|
||||
|
||||
+349
-4
@@ -42,6 +42,12 @@ if 'claude_code_sdk' not in sys.modules:
|
||||
sys.modules['claude_code_sdk'] = _create_sdk_mock()
|
||||
sys.modules['claude_code_sdk.types'] = MagicMock()
|
||||
|
||||
# Pre-mock dotenv to prevent sys.exit() in cli.utils.import_dotenv
|
||||
# This is needed for CLI tests since cli.utils calls import_dotenv at module level
|
||||
if 'dotenv' not in sys.modules:
|
||||
sys.modules['dotenv'] = MagicMock()
|
||||
sys.modules['dotenv'].load_dotenv = MagicMock()
|
||||
|
||||
# Add apps/backend directory to path for imports
|
||||
sys.path.insert(0, str(Path(__file__).parent.parent / "apps" / "backend"))
|
||||
|
||||
@@ -57,6 +63,7 @@ _POTENTIALLY_MOCKED_MODULES = [
|
||||
'claude_code_sdk.types',
|
||||
'claude_agent_sdk',
|
||||
'claude_agent_sdk.types',
|
||||
'dotenv',
|
||||
'ui',
|
||||
'progress',
|
||||
'task_logger',
|
||||
@@ -250,6 +257,132 @@ def spec_dir(temp_dir: Path) -> Path:
|
||||
return spec_path
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# WORKSPACE COMMAND TEST FIXTURES
|
||||
# =============================================================================
|
||||
|
||||
# Constants for workspace tests
|
||||
TEST_SPEC_NAME = "001-test-spec"
|
||||
TEST_SPEC_BRANCH = f"auto-claude/{TEST_SPEC_NAME}"
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def mock_project_dir(temp_git_repo: Path) -> Path:
|
||||
"""Create a mock project directory with git repo."""
|
||||
return temp_git_repo
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def mock_worktree_path(temp_git_repo: Path) -> Path:
|
||||
"""Create a mock worktree path."""
|
||||
worktree_path = temp_git_repo / ".worktrees" / TEST_SPEC_NAME
|
||||
worktree_path.mkdir(parents=True, exist_ok=True)
|
||||
return worktree_path
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def workspace_spec_dir(temp_git_repo: Path) -> Path:
|
||||
"""Create a spec directory inside .auto-claude/specs/ for workspace tests."""
|
||||
spec_dir = temp_git_repo / ".auto-claude" / "specs" / TEST_SPEC_NAME
|
||||
spec_dir.mkdir(parents=True, exist_ok=True)
|
||||
return spec_dir
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def with_spec_branch(temp_git_repo: Path) -> Generator[Path, None, None]:
|
||||
"""Create a temp git repo with a spec branch.
|
||||
|
||||
Note: temp_git_repo already provides an initialized repo with initial commit,
|
||||
so we only need to create the spec branch and add changes.
|
||||
"""
|
||||
# Create spec branch
|
||||
subprocess.run(
|
||||
["git", "checkout", "-b", TEST_SPEC_BRANCH],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
|
||||
# Add a change on spec branch
|
||||
(temp_git_repo / "test.txt").write_text("test content")
|
||||
subprocess.run(
|
||||
["git", "add", "test.txt"],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
subprocess.run(
|
||||
["git", "commit", "-m", "Test commit"],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
|
||||
# Go back to main
|
||||
subprocess.run(
|
||||
["git", "checkout", "main"],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
|
||||
yield temp_git_repo
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def with_conflicting_branches(temp_git_repo: Path) -> Generator[Path, None, None]:
|
||||
"""Create temp git repo with conflicting branches for merge testing.
|
||||
|
||||
Note: temp_git_repo already provides an initialized repo with initial commit,
|
||||
so we only need to create branches with conflicting changes.
|
||||
"""
|
||||
# Create spec branch
|
||||
subprocess.run(
|
||||
["git", "checkout", "-b", TEST_SPEC_BRANCH],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
|
||||
# Add a file on spec branch
|
||||
(temp_git_repo / "conflict.txt").write_text("spec branch content")
|
||||
subprocess.run(
|
||||
["git", "add", "conflict.txt"],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
subprocess.run(
|
||||
["git", "commit", "-m", "Spec change"],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
|
||||
# Go back to main and make conflicting change
|
||||
subprocess.run(
|
||||
["git", "checkout", "main"],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
(temp_git_repo / "conflict.txt").write_text("main branch content")
|
||||
subprocess.run(
|
||||
["git", "add", "conflict.txt"],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
subprocess.run(
|
||||
["git", "commit", "-m", "Main change"],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
|
||||
yield temp_git_repo
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# REVIEW FIXTURES - Import from review_fixtures.py
|
||||
# =============================================================================
|
||||
@@ -632,16 +765,15 @@ def mock_run_agent_fn():
|
||||
phase_name: str = None,
|
||||
) -> tuple[bool, str]:
|
||||
nonlocal call_count
|
||||
call_count += 1
|
||||
if side_effect is not None:
|
||||
if call_count < len(side_effect):
|
||||
result = side_effect[call_count]
|
||||
call_count += 1
|
||||
if call_count <= len(side_effect):
|
||||
result = side_effect[call_count - 1]
|
||||
return result
|
||||
# Fallback to last result if more calls than expected
|
||||
return side_effect[-1]
|
||||
return (success, output)
|
||||
|
||||
_mock_agent.call_count = 0
|
||||
return _mock_agent
|
||||
|
||||
return _create_mock
|
||||
@@ -699,6 +831,202 @@ def mock_ui_module():
|
||||
return ui
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def mock_ui_icons():
|
||||
"""
|
||||
Mock UI Icons class for CLI input handler tests.
|
||||
|
||||
Provides the complete Icons class with Unicode and ASCII fallbacks.
|
||||
Mirrors the structure in apps/backend/ui/icons.py.
|
||||
|
||||
Usage:
|
||||
def test_something(mock_ui_icons):
|
||||
icons = mock_ui_icons()
|
||||
assert icons.SUCCESS == ("✓", "[OK]")
|
||||
"""
|
||||
class MockIcons:
|
||||
"""Mock Icons class - complete with all icons used by the codebase."""
|
||||
# Status icons
|
||||
SUCCESS = ("✓", "[OK]")
|
||||
ERROR = ("✗", "[X]")
|
||||
WARNING = ("⚠", "[!]")
|
||||
INFO = ("ℹ", "[i]")
|
||||
PENDING = ("○", "[ ]")
|
||||
IN_PROGRESS = ("◐", "[.]")
|
||||
COMPLETE = ("●", "[*]")
|
||||
BLOCKED = ("⊘", "[B]")
|
||||
|
||||
# Action icons
|
||||
PLAY = ("▶", ">")
|
||||
PAUSE = ("⏸", "||")
|
||||
STOP = ("⏹", "[]")
|
||||
SKIP = ("⏭", ">>")
|
||||
|
||||
# Navigation
|
||||
ARROW_RIGHT = ("→", "->")
|
||||
ARROW_DOWN = ("↓", "v")
|
||||
ARROW_UP = ("↑", "^")
|
||||
POINTER = ("❯", ">")
|
||||
BULLET = ("•", "*")
|
||||
|
||||
# Objects
|
||||
FOLDER = ("📁", "[D]")
|
||||
FILE = ("📄", "[F]")
|
||||
GEAR = ("⚙", "[*]")
|
||||
SEARCH = ("🔍", "[?]")
|
||||
BRANCH = ("🌿", "[BR]")
|
||||
COMMIT = ("◉", "(@)")
|
||||
LIGHTNING = ("⚡", "!")
|
||||
LINK = ("🔗", "[L]")
|
||||
|
||||
# Progress
|
||||
SUBTASK = ("▣", "#")
|
||||
PHASE = ("◆", "*")
|
||||
WORKER = ("⚡", "W")
|
||||
SESSION = ("▸", ">")
|
||||
|
||||
# Menu
|
||||
EDIT = ("✏️", "[E]")
|
||||
CLIPBOARD = ("📋", "[C]")
|
||||
DOCUMENT = ("📄", "[D]")
|
||||
DOOR = ("🚪", "[Q]")
|
||||
SHIELD = ("🛡️", "[S]")
|
||||
|
||||
# Box drawing
|
||||
BOX_TL = ("╔", "+")
|
||||
BOX_TR = ("╗", "+")
|
||||
BOX_BL = ("╚", "+")
|
||||
BOX_BR = ("╝", "+")
|
||||
BOX_H = ("═", "-")
|
||||
BOX_V = ("║", "|")
|
||||
BOX_ML = ("╠", "+")
|
||||
BOX_MR = ("╣", "+")
|
||||
BOX_TL_LIGHT = ("┌", "+")
|
||||
BOX_TR_LIGHT = ("┐", "+")
|
||||
BOX_BL_LIGHT = ("└", "+")
|
||||
BOX_BR_LIGHT = ("┘", "+")
|
||||
BOX_H_LIGHT = ("─", "-")
|
||||
BOX_V_LIGHT = ("│", "|")
|
||||
BOX_ML_LIGHT = ("├", "+")
|
||||
BOX_MR_LIGHT = ("┤", "+")
|
||||
|
||||
# Progress bar
|
||||
BAR_FULL = ("█", "=")
|
||||
BAR_EMPTY = ("░", "-")
|
||||
BAR_HALF = ("▌", "=")
|
||||
|
||||
return MockIcons
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def mock_ui_menu_option():
|
||||
"""
|
||||
Mock UI MenuOption class for CLI tests.
|
||||
|
||||
Provides a simple MenuOption class for menu testing.
|
||||
|
||||
Usage:
|
||||
def test_something(mock_ui_menu_option):
|
||||
option = mock_ui_menu_option()("key", "Label")
|
||||
assert option.key == "key"
|
||||
"""
|
||||
class MockMenuOption:
|
||||
"""Mock MenuOption class."""
|
||||
def __init__(self, key, label, icon=None, description=""):
|
||||
self.key = key
|
||||
self.label = label
|
||||
self.icon = icon or ("", "")
|
||||
self.description = description
|
||||
|
||||
return MockMenuOption
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def mock_ui_module_full(mock_ui_icons, mock_ui_menu_option):
|
||||
"""
|
||||
Comprehensive mock UI module with all functions and classes.
|
||||
|
||||
Provides a complete mock of the ui module for CLI tests.
|
||||
Includes Icons, MenuOption, and all UI functions.
|
||||
|
||||
Usage:
|
||||
def test_something(mock_ui_module_full):
|
||||
ui = mock_ui_module_full
|
||||
assert ui.Icons.SUCCESS == ("✓", "[OK]")
|
||||
assert ui.icon(ui.Icons.SUCCESS) == "✓"
|
||||
"""
|
||||
from unittest.mock import MagicMock
|
||||
|
||||
Icons = mock_ui_icons
|
||||
MenuOption = mock_ui_menu_option
|
||||
|
||||
def mock_icon(icon_tuple):
|
||||
"""Mock icon function."""
|
||||
return icon_tuple[0] if icon_tuple else ""
|
||||
|
||||
def mock_bold(text):
|
||||
"""Mock bold function."""
|
||||
return f"**{text}**"
|
||||
|
||||
def mock_muted(text):
|
||||
"""Mock muted function."""
|
||||
return f"[{text}]"
|
||||
|
||||
def mock_box(content, width=70, style="heavy"):
|
||||
"""Mock box function."""
|
||||
lines = ["┌" + "─" * (width - 2) + "┐"]
|
||||
for line in content:
|
||||
lines.append(f"│ {line} │")
|
||||
lines.append("└" + "─" * (width - 2) + "┘")
|
||||
return "\n".join(lines)
|
||||
|
||||
def mock_print_status(message, status="info"):
|
||||
"""Mock print_status function."""
|
||||
print(f"[{status.upper()}] {message}")
|
||||
|
||||
def mock_select_menu(title, options, subtitle="", allow_quit=True):
|
||||
"""Mock select_menu function."""
|
||||
return options[0].key if options else None
|
||||
|
||||
def mock_error(text):
|
||||
"""Mock error function."""
|
||||
return f"ERROR: {text}"
|
||||
|
||||
def mock_success(text):
|
||||
"""Mock success function."""
|
||||
return f"SUCCESS: {text}"
|
||||
|
||||
def mock_warning(text):
|
||||
"""Mock warning function."""
|
||||
return f"WARNING: {text}"
|
||||
|
||||
def mock_info(text):
|
||||
"""Mock info function."""
|
||||
return f"INFO: {text}"
|
||||
|
||||
def mock_highlight(text):
|
||||
"""Mock highlight function."""
|
||||
return text
|
||||
|
||||
# Create mock ui module
|
||||
mock_ui = MagicMock()
|
||||
mock_ui.Icons = Icons
|
||||
mock_ui.MenuOption = MenuOption
|
||||
mock_ui.icon = mock_icon
|
||||
mock_ui.bold = mock_bold
|
||||
mock_ui.muted = mock_muted
|
||||
mock_ui.box = mock_box
|
||||
mock_ui.print_status = mock_print_status
|
||||
mock_ui.select_menu = mock_select_menu
|
||||
mock_ui.error = mock_error
|
||||
mock_ui.success = mock_success
|
||||
mock_ui.warning = mock_warning
|
||||
mock_ui.info = mock_info
|
||||
mock_ui.highlight = mock_highlight
|
||||
|
||||
return mock_ui
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def mock_spec_validator():
|
||||
"""
|
||||
@@ -1233,6 +1561,23 @@ def temp_project_dir(tmp_path):
|
||||
return project_dir
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def successful_agent_fn():
|
||||
"""
|
||||
Reusable async agent function that returns success.
|
||||
|
||||
Replaces the duplicated async def agent_fn(*args, **kwargs): return (True, 'Success')
|
||||
pattern that was copy-pasted 28 times across test_cli_build_commands.py.
|
||||
|
||||
Usage:
|
||||
def test_something(mock_run_agent, successful_agent_fn):
|
||||
mock_run_agent.side_effect = successful_agent_fn
|
||||
"""
|
||||
async def _fn(*args, **kwargs):
|
||||
return (True, 'Success')
|
||||
return _fn
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def worktree_manager(temp_project_dir):
|
||||
"""Create a WorktreeManager instance."""
|
||||
|
||||
@@ -628,7 +628,7 @@ class TestEdgeCases:
|
||||
|
||||
def test_nonexistent_directory(self, discovery):
|
||||
"""Test handling of non-existent directory."""
|
||||
fake_dir = Path("/nonexistent/path")
|
||||
fake_dir = Path("/tmp/test-nonexistent-ci-discovery-123456")
|
||||
|
||||
# Should not raise
|
||||
result = discovery.discover(fake_dir)
|
||||
|
||||
@@ -0,0 +1,741 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Tests for CLI Batch Commands
|
||||
=============================
|
||||
|
||||
Tests for batch_commands.py module functionality including:
|
||||
- handle_batch_create_command() - Create tasks from batch file
|
||||
- handle_batch_status_command() - Show status of all specs
|
||||
- handle_batch_cleanup_command() - Clean up completed specs
|
||||
"""
|
||||
|
||||
import json
|
||||
from pathlib import Path
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
from cli.batch_commands import (
|
||||
handle_batch_cleanup_command,
|
||||
handle_batch_create_command,
|
||||
handle_batch_status_command,
|
||||
)
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# FIXTURES
|
||||
# =============================================================================
|
||||
|
||||
@pytest.fixture
|
||||
def sample_batch_file(temp_dir: Path) -> Path:
|
||||
"""Create a sample batch JSON file."""
|
||||
batch_data = {
|
||||
"tasks": [
|
||||
{
|
||||
"title": "Add user authentication",
|
||||
"description": "Implement OAuth2 login with Google provider",
|
||||
"workflow_type": "feature",
|
||||
"services": ["backend", "frontend"],
|
||||
"priority": 8,
|
||||
"complexity": "standard",
|
||||
"estimated_hours": 6.0,
|
||||
"estimated_days": 0.75,
|
||||
},
|
||||
{
|
||||
"title": "Add payment processing",
|
||||
"description": "Integrate Stripe for payments",
|
||||
"workflow_type": "feature",
|
||||
"services": ["backend", "worker"],
|
||||
"priority": 7,
|
||||
"complexity": "complex",
|
||||
"estimated_hours": 12.0,
|
||||
"estimated_days": 1.5,
|
||||
},
|
||||
{
|
||||
"title": "Fix navigation bug",
|
||||
"description": "Mobile menu not closing properly",
|
||||
"workflow_type": "bugfix",
|
||||
"services": ["frontend"],
|
||||
"priority": 9,
|
||||
"complexity": "simple",
|
||||
},
|
||||
]
|
||||
}
|
||||
|
||||
batch_file = temp_dir / "batch.json"
|
||||
batch_file.write_text(json.dumps(batch_data, indent=2))
|
||||
return batch_file
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def empty_batch_file(temp_dir: Path) -> Path:
|
||||
"""Create an empty batch JSON file."""
|
||||
batch_data = {"tasks": []}
|
||||
batch_file = temp_dir / "empty_batch.json"
|
||||
batch_file.write_text(json.dumps(batch_data))
|
||||
return batch_file
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def invalid_json_file(temp_dir: Path) -> Path:
|
||||
"""Create a file with invalid JSON."""
|
||||
batch_file = temp_dir / "invalid.json"
|
||||
batch_file.write_text("{ invalid json }")
|
||||
return batch_file
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def project_with_specs(temp_git_repo: Path) -> Path:
|
||||
"""Create a project with existing specs."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Spec 001 - with spec.md
|
||||
spec_001 = specs_dir / "001-existing-feature"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "spec.md").write_text("# Existing Feature\n")
|
||||
(spec_001 / "requirements.json").write_text('{"task_description": "Existing"}')
|
||||
|
||||
# Spec 002 - with implementation plan
|
||||
spec_002 = specs_dir / "002-in-progress"
|
||||
spec_002.mkdir()
|
||||
(spec_002 / "spec.md").write_text("# In Progress\n")
|
||||
(spec_002 / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
# Spec 003 - complete with QA approval in implementation_plan.json
|
||||
spec_003 = specs_dir / "003-completed"
|
||||
spec_003.mkdir()
|
||||
(spec_003 / "spec.md").write_text("# Completed\n")
|
||||
(spec_003 / "implementation_plan.json").write_text(
|
||||
'{"phases": [], "qa_signoff": {"status": "approved"}}'
|
||||
)
|
||||
(spec_003 / "qa_report.md").write_text("# QA Approved\n")
|
||||
|
||||
return temp_git_repo
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def project_with_completed_specs_and_worktrees(temp_git_repo: Path) -> Path:
|
||||
"""Create a project with completed specs and worktrees."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
worktrees_dir = temp_git_repo / ".auto-claude" / "worktrees" / "tasks"
|
||||
worktrees_dir.mkdir(parents=True)
|
||||
|
||||
# Completed spec 001 with worktree (QA approved)
|
||||
spec_001 = specs_dir / "001-completed-with-wt"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "qa_report.md").write_text("# QA Approved\n")
|
||||
(spec_001 / "implementation_plan.json").write_text(
|
||||
'{"qa_signoff": {"status": "approved"}}'
|
||||
)
|
||||
|
||||
wt_001 = worktrees_dir / "001-completed-with-wt"
|
||||
wt_001.mkdir(parents=True)
|
||||
|
||||
# Completed spec 002 without worktree (QA approved)
|
||||
spec_002 = specs_dir / "002-completed-no-wt"
|
||||
spec_002.mkdir()
|
||||
(spec_002 / "qa_report.md").write_text("# QA Approved\n")
|
||||
(spec_002 / "implementation_plan.json").write_text(
|
||||
'{"qa_signoff": {"status": "approved"}}'
|
||||
)
|
||||
|
||||
# Incomplete spec 003
|
||||
spec_003 = specs_dir / "003-incomplete"
|
||||
spec_003.mkdir()
|
||||
(spec_003 / "spec.md").write_text("# In Progress\n")
|
||||
|
||||
return temp_git_repo
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# HANDLE_BATCH_CREATE_COMMAND TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestHandleBatchCreateCommand:
|
||||
"""Tests for handle_batch_create_command() function."""
|
||||
|
||||
def test_creates_specs_from_batch_file(
|
||||
self, sample_batch_file: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Creates spec directories from batch file."""
|
||||
result = handle_batch_create_command(str(sample_batch_file), str(temp_git_repo))
|
||||
|
||||
assert result is True
|
||||
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
assert specs_dir.exists()
|
||||
|
||||
# Should create 3 specs
|
||||
spec_dirs = sorted([d for d in specs_dir.iterdir() if d.is_dir()])
|
||||
assert len(spec_dirs) == 3
|
||||
|
||||
# Check spec numbering continues from 001
|
||||
assert spec_dirs[0].name == "001-add-user-authentication"
|
||||
assert spec_dirs[1].name == "002-add-payment-processing"
|
||||
assert spec_dirs[2].name == "003-fix-navigation-bug"
|
||||
|
||||
def test_creates_requirements_json(
|
||||
self, sample_batch_file: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Creates requirements.json with correct content."""
|
||||
handle_batch_create_command(str(sample_batch_file), str(temp_git_repo))
|
||||
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
spec_001 = specs_dir / "001-add-user-authentication"
|
||||
req_file = spec_001 / "requirements.json"
|
||||
|
||||
assert req_file.exists()
|
||||
|
||||
with open(req_file) as f:
|
||||
req = json.load(f)
|
||||
|
||||
assert req["task_description"] == "Implement OAuth2 login with Google provider"
|
||||
assert req["workflow_type"] == "feature"
|
||||
assert req["services_involved"] == ["backend", "frontend"]
|
||||
assert req["priority"] == 8
|
||||
assert req["complexity_inferred"] == "standard"
|
||||
assert req["estimate"]["estimated_hours"] == 6.0
|
||||
assert req["estimate"]["estimated_days"] == 0.75
|
||||
|
||||
def test_continues_numbering_from_existing_specs(
|
||||
self, project_with_specs: Path, sample_batch_file: Path
|
||||
) -> None:
|
||||
"""Continues spec numbering from existing specs."""
|
||||
handle_batch_create_command(str(sample_batch_file), str(project_with_specs))
|
||||
|
||||
specs_dir = project_with_specs / ".auto-claude" / "specs"
|
||||
spec_dirs = sorted([d for d in specs_dir.iterdir() if d.is_dir()])
|
||||
|
||||
# Should have existing 3 specs + 3 new ones
|
||||
assert len(spec_dirs) == 6
|
||||
|
||||
# New specs should start at 004
|
||||
assert spec_dirs[3].name == "004-add-user-authentication"
|
||||
assert spec_dirs[4].name == "005-add-payment-processing"
|
||||
assert spec_dirs[5].name == "006-fix-navigation-bug"
|
||||
|
||||
def test_returns_false_for_missing_file(self, temp_git_repo: Path) -> None:
|
||||
"""Returns False when batch file doesn't exist."""
|
||||
result = handle_batch_create_command(
|
||||
"nonexistent.json", str(temp_git_repo)
|
||||
)
|
||||
|
||||
assert result is False
|
||||
|
||||
def test_returns_false_for_invalid_json(
|
||||
self, invalid_json_file: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Returns False for invalid JSON."""
|
||||
result = handle_batch_create_command(
|
||||
str(invalid_json_file), str(temp_git_repo)
|
||||
)
|
||||
|
||||
assert result is False
|
||||
|
||||
def test_returns_false_for_empty_tasks(
|
||||
self, empty_batch_file: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Returns False when batch file has no tasks."""
|
||||
result = handle_batch_create_command(
|
||||
str(empty_batch_file), str(temp_git_repo)
|
||||
)
|
||||
|
||||
assert result is False
|
||||
|
||||
def test_sanitizes_task_title_for_folder_name(
|
||||
self, temp_dir: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Sanitizes task title when creating folder name."""
|
||||
batch_data = {
|
||||
"tasks": [
|
||||
{
|
||||
"title": "Task With VERY Long Name That Should Be Truncated Because It Exceeds Fifty Characters",
|
||||
"description": "Test",
|
||||
}
|
||||
]
|
||||
}
|
||||
batch_file = temp_dir / "batch.json"
|
||||
batch_file.write_text(json.dumps(batch_data))
|
||||
|
||||
handle_batch_create_command(str(batch_file), str(temp_git_repo))
|
||||
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
spec_dirs = list(specs_dir.iterdir())
|
||||
|
||||
assert len(spec_dirs) == 1
|
||||
# Name should be truncated to 50 chars
|
||||
assert len(spec_dirs[0].name) <= 59 # "001-" + 50 chars
|
||||
assert spec_dirs[0].name.startswith("001-")
|
||||
|
||||
def test_uses_defaults_for_missing_fields(
|
||||
self, temp_dir: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Uses default values for missing optional fields."""
|
||||
batch_data = {
|
||||
"tasks": [
|
||||
{
|
||||
"title": "Minimal Task",
|
||||
}
|
||||
]
|
||||
}
|
||||
batch_file = temp_dir / "batch.json"
|
||||
batch_file.write_text(json.dumps(batch_data))
|
||||
|
||||
handle_batch_create_command(str(batch_file), str(temp_git_repo))
|
||||
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
req_file = specs_dir / "001-minimal-task" / "requirements.json"
|
||||
|
||||
with open(req_file) as f:
|
||||
req = json.load(f)
|
||||
|
||||
assert req["task_description"] == "Minimal Task"
|
||||
assert req["workflow_type"] == "feature"
|
||||
assert req["services_involved"] == ["frontend"]
|
||||
assert req["priority"] == 5
|
||||
assert req["complexity_inferred"] == "standard"
|
||||
assert req["estimate"]["estimated_hours"] == 4.0
|
||||
assert req["estimate"]["estimated_days"] == 0.5
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# HANDLE_BATCH_STATUS_COMMAND TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestHandleBatchStatusCommand:
|
||||
"""Tests for handle_batch_status_command() function."""
|
||||
|
||||
def test_shows_status_for_all_specs(
|
||||
self, capsys, project_with_specs: Path
|
||||
) -> None:
|
||||
"""Shows status for all specs in project."""
|
||||
result = handle_batch_status_command(str(project_with_specs))
|
||||
|
||||
assert result is True
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "3 spec" in captured.out
|
||||
assert "001-existing-feature" in captured.out
|
||||
assert "002-in-progress" in captured.out
|
||||
assert "003-completed" in captured.out
|
||||
|
||||
def test_shows_correct_status_icons(
|
||||
self, capsys, project_with_specs: Path
|
||||
) -> None:
|
||||
"""Shows appropriate status icons for each spec."""
|
||||
handle_batch_status_command(str(project_with_specs))
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# Status icons for different states:
|
||||
# 001: spec.md only → spec_created (📋)
|
||||
# 002: spec.md + implementation_plan.json → building (⚙️)
|
||||
# 003: qa_report.md → qa_approved (✅)
|
||||
assert "📋" in captured.out
|
||||
assert "⚙️" in captured.out
|
||||
assert "✅" in captured.out
|
||||
|
||||
def test_returns_true_for_no_specs_directory(
|
||||
self, capsys, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Returns True when no specs directory exists."""
|
||||
result = handle_batch_status_command(str(temp_git_repo))
|
||||
|
||||
assert result is True
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "No specs found" in captured.out
|
||||
|
||||
def test_returns_true_for_empty_specs_directory(
|
||||
self, capsys, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Returns True when specs directory is empty."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
result = handle_batch_status_command(str(temp_git_repo))
|
||||
|
||||
assert result is True
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "No specs found" in captured.out
|
||||
|
||||
def test_shows_task_description(
|
||||
self, capsys, project_with_specs: Path
|
||||
) -> None:
|
||||
"""Shows task description from requirements.json."""
|
||||
handle_batch_status_command(str(project_with_specs))
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Existing" in captured.out
|
||||
|
||||
def test_detects_spec_created_status(
|
||||
self, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Correctly detects specs with spec.md as 'spec_created'."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
spec_001 = specs_dir / "001-test"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "spec.md").write_text("# Test\n")
|
||||
|
||||
result = handle_batch_status_command(str(temp_git_repo))
|
||||
|
||||
assert result is True
|
||||
|
||||
def test_detects_building_status(
|
||||
self, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Correctly detects specs with implementation_plan.json as 'building'."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
spec_001 = specs_dir / "001-test"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
result = handle_batch_status_command(str(temp_git_repo))
|
||||
|
||||
assert result is True
|
||||
|
||||
def test_detects_qa_approved_status(
|
||||
self, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Correctly detects specs with qa_signoff as 'qa_approved'."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
spec_001 = specs_dir / "001-test"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "qa_report.md").write_text("# QA Approved\n")
|
||||
(spec_001 / "implementation_plan.json").write_text(
|
||||
'{"qa_signoff": {"status": "approved"}}'
|
||||
)
|
||||
|
||||
result = handle_batch_status_command(str(temp_git_repo))
|
||||
|
||||
assert result is True
|
||||
|
||||
def test_detects_pending_spec_status(
|
||||
self, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Correctly detects specs with only requirements.json as 'pending_spec'."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
spec_001 = specs_dir / "001-test"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "requirements.json").write_text('{"task": "test"}')
|
||||
|
||||
result = handle_batch_status_command(str(temp_git_repo))
|
||||
|
||||
assert result is True
|
||||
|
||||
def test_handles_corrupted_requirements_json(
|
||||
self, capsys, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Handles corrupted requirements.json gracefully."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
spec_001 = specs_dir / "001-test"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "requirements.json").write_text("{ invalid json")
|
||||
|
||||
result = handle_batch_status_command(str(temp_git_repo))
|
||||
|
||||
assert result is True
|
||||
captured = capsys.readouterr()
|
||||
assert "001-test" in captured.out
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# HANDLE_BATCH_CLEANUP_COMMAND TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestHandleBatchCleanupCommand:
|
||||
"""Tests for handle_batch_cleanup_command() function."""
|
||||
|
||||
def test_dry_run_shows_what_would_be_deleted(
|
||||
self, capsys, project_with_completed_specs_and_worktrees: Path
|
||||
) -> None:
|
||||
"""Dry run shows what would be deleted without actually deleting."""
|
||||
result = handle_batch_cleanup_command(
|
||||
str(project_with_completed_specs_and_worktrees), dry_run=True
|
||||
)
|
||||
|
||||
assert result is True
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "2 completed spec" in captured.out
|
||||
assert "001-completed-with-wt" in captured.out
|
||||
assert "002-completed-no-wt" in captured.out
|
||||
assert "Would remove:" in captured.out
|
||||
assert "Run with --no-dry-run" in captured.out
|
||||
|
||||
def test_dry_run_does_not_delete(
|
||||
self, project_with_completed_specs_and_worktrees: Path
|
||||
) -> None:
|
||||
"""Dry run does not actually delete anything."""
|
||||
specs_dir = project_with_completed_specs_and_worktrees / ".auto-claude" / "specs"
|
||||
|
||||
handle_batch_cleanup_command(
|
||||
str(project_with_completed_specs_and_worktrees), dry_run=True
|
||||
)
|
||||
|
||||
# Specs should still exist
|
||||
assert (specs_dir / "001-completed-with-wt").exists()
|
||||
assert (specs_dir / "002-completed-no-wt").exists()
|
||||
|
||||
def test_cleanup_deletes_specs_and_worktrees(
|
||||
self, project_with_completed_specs_and_worktrees: Path
|
||||
) -> None:
|
||||
"""Actually deletes completed specs and worktrees when dry_run=False."""
|
||||
specs_dir = project_with_completed_specs_and_worktrees / ".auto-claude" / "specs"
|
||||
worktrees_dir = project_with_completed_specs_and_worktrees / ".auto-claude" / "worktrees" / "tasks"
|
||||
|
||||
handle_batch_cleanup_command(
|
||||
str(project_with_completed_specs_and_worktrees), dry_run=False
|
||||
)
|
||||
|
||||
# Completed specs should be deleted
|
||||
assert not (specs_dir / "001-completed-with-wt").exists()
|
||||
assert not (specs_dir / "002-completed-no-wt").exists()
|
||||
|
||||
# Worktree should be deleted
|
||||
assert not (worktrees_dir / "001-completed-with-wt").exists()
|
||||
|
||||
def test_cleanup_preserves_incomplete_specs(
|
||||
self, project_with_completed_specs_and_worktrees: Path
|
||||
) -> None:
|
||||
"""Does not delete specs without qa_report.md."""
|
||||
specs_dir = project_with_completed_specs_and_worktrees / ".auto-claude" / "specs"
|
||||
|
||||
handle_batch_cleanup_command(
|
||||
str(project_with_completed_specs_and_worktrees), dry_run=False
|
||||
)
|
||||
|
||||
# Incomplete spec should still exist
|
||||
assert (specs_dir / "003-incomplete").exists()
|
||||
|
||||
def test_returns_true_for_no_specs_directory(
|
||||
self, capsys, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Returns True when no specs directory exists."""
|
||||
result = handle_batch_cleanup_command(str(temp_git_repo), dry_run=True)
|
||||
|
||||
assert result is True
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "No specs directory found" in captured.out
|
||||
|
||||
def test_returns_true_for_no_completed_specs(
|
||||
self, capsys, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Returns True when no completed specs exist."""
|
||||
# Create specs without qa_report.md
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
spec_001 = specs_dir / "001-incomplete"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "spec.md").write_text("# In Progress\n")
|
||||
|
||||
result = handle_batch_cleanup_command(str(temp_git_repo), dry_run=True)
|
||||
|
||||
assert result is True
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "No completed specs to clean up" in captured.out
|
||||
|
||||
def test_cleanup_with_git_worktree_remove(
|
||||
self, project_with_completed_specs_and_worktrees: Path
|
||||
) -> None:
|
||||
"""Uses git worktree remove when available."""
|
||||
with patch('subprocess.run') as mock_run:
|
||||
# Mock git worktree remove to succeed
|
||||
mock_run.return_value = MagicMock(returncode=0)
|
||||
|
||||
handle_batch_cleanup_command(
|
||||
str(project_with_completed_specs_and_worktrees), dry_run=False
|
||||
)
|
||||
|
||||
# Should have called git worktree remove
|
||||
# Check that the first argument of any call contains "git", "worktree", "remove"
|
||||
assert any(
|
||||
"git" in str(call.args) and
|
||||
"worktree" in str(call.args) and
|
||||
"remove" in str(call.args)
|
||||
for call in mock_run.call_args_list
|
||||
)
|
||||
|
||||
def test_cleanup_fallback_to_manual_removal(
|
||||
self, project_with_completed_specs_and_worktrees: Path
|
||||
) -> None:
|
||||
"""Falls back to manual removal when git worktree remove fails."""
|
||||
specs_dir = project_with_completed_specs_and_worktrees / ".auto-claude" / "specs"
|
||||
|
||||
with patch('subprocess.run') as mock_run:
|
||||
# Mock git worktree remove to fail
|
||||
mock_run.return_value = MagicMock(returncode=1)
|
||||
|
||||
handle_batch_cleanup_command(
|
||||
str(project_with_completed_specs_and_worktrees), dry_run=False
|
||||
)
|
||||
|
||||
# Should still delete the spec
|
||||
assert not (specs_dir / "001-completed-with-wt").exists()
|
||||
|
||||
def test_cleanup_handles_timeout_gracefully(
|
||||
self, project_with_completed_specs_and_worktrees: Path
|
||||
) -> None:
|
||||
"""Handles git command timeout gracefully."""
|
||||
specs_dir = project_with_completed_specs_and_worktrees / ".auto-claude" / "specs"
|
||||
|
||||
with patch('subprocess.run') as mock_run:
|
||||
# Mock timeout
|
||||
from subprocess import TimeoutExpired
|
||||
mock_run.side_effect = TimeoutExpired("git", 30)
|
||||
|
||||
handle_batch_cleanup_command(
|
||||
str(project_with_completed_specs_and_worktrees), dry_run=False
|
||||
)
|
||||
|
||||
# Should still delete the spec (fallback)
|
||||
assert not (specs_dir / "001-completed-with-wt").exists()
|
||||
|
||||
def test_cleanup_handles_exceptions(
|
||||
self, capsys, project_with_completed_specs_and_worktrees: Path
|
||||
) -> None:
|
||||
"""Handles exceptions during cleanup gracefully."""
|
||||
with patch('subprocess.run') as mock_run:
|
||||
# Mock exception
|
||||
mock_run.side_effect = Exception("Test error")
|
||||
|
||||
handle_batch_cleanup_command(
|
||||
str(project_with_completed_specs_and_worktrees), dry_run=False
|
||||
)
|
||||
|
||||
# Should continue and delete specs
|
||||
captured = capsys.readouterr()
|
||||
assert "Cleaned up" in captured.out
|
||||
|
||||
def test_cleanup_shows_worktree_path_in_dry_run(
|
||||
self, capsys, project_with_completed_specs_and_worktrees: Path
|
||||
) -> None:
|
||||
"""Shows worktree path in dry run output."""
|
||||
handle_batch_cleanup_command(
|
||||
str(project_with_completed_specs_and_worktrees), dry_run=True
|
||||
)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert ".auto-claude/worktrees/tasks/001-completed-with-wt" in captured.out
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# INTEGRATION TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestBatchCommandsIntegration:
|
||||
"""Integration tests for batch commands."""
|
||||
|
||||
def test_create_then_status_workflow(
|
||||
self, sample_batch_file: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Test creating specs then checking status."""
|
||||
# Create specs
|
||||
create_result = handle_batch_create_command(
|
||||
str(sample_batch_file), str(temp_git_repo)
|
||||
)
|
||||
assert create_result is True
|
||||
|
||||
# Check status
|
||||
status_result = handle_batch_status_command(str(temp_git_repo))
|
||||
assert status_result is True
|
||||
|
||||
def test_create_then_cleanup_workflow(
|
||||
self, temp_dir: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Test creating specs, marking complete, then cleanup."""
|
||||
# Create a spec
|
||||
batch_data = {"tasks": [{"title": "Test Task"}]}
|
||||
batch_file = temp_dir / "batch.json"
|
||||
batch_file.write_text(json.dumps(batch_data))
|
||||
|
||||
handle_batch_create_command(str(batch_file), str(temp_git_repo))
|
||||
|
||||
# Mark as complete with proper QA approval
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
spec_001 = specs_dir / "001-test-task"
|
||||
(spec_001 / "qa_report.md").write_text("# QA Approved\n")
|
||||
(spec_001 / "implementation_plan.json").write_text(
|
||||
'{"qa_signoff": {"status": "approved"}}'
|
||||
)
|
||||
|
||||
# Dry run cleanup
|
||||
result = handle_batch_cleanup_command(str(temp_git_repo), dry_run=True)
|
||||
assert result is True
|
||||
|
||||
# Actual cleanup
|
||||
result = handle_batch_cleanup_command(str(temp_git_repo), dry_run=False)
|
||||
assert result is True
|
||||
|
||||
# Spec should be deleted
|
||||
assert not spec_001.exists()
|
||||
|
||||
|
||||
class TestBatchCommandsExceptionCoverage:
|
||||
"""Tests for exception handling paths to increase coverage."""
|
||||
|
||||
def test_cleanup_with_permission_error(
|
||||
self, temp_dir: Path, temp_git_repo: Path, monkeypatch
|
||||
) -> None:
|
||||
"""Test cleanup handles permission errors gracefully."""
|
||||
|
||||
# Create a completed spec with proper QA approval
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
spec_001 = specs_dir / "001-test-task"
|
||||
spec_001.mkdir(parents=True)
|
||||
(spec_001 / "qa_report.md").write_text("# QA Approved\n")
|
||||
(spec_001 / "implementation_plan.json").write_text(
|
||||
'{"qa_signoff": {"status": "approved"}}'
|
||||
)
|
||||
|
||||
# Mock shutil.rmtree to raise permission error
|
||||
def mock_rmtree_raises(path, *args, **kwargs):
|
||||
if "001-test-task" in str(path):
|
||||
raise PermissionError(f"Permission denied: {path}")
|
||||
|
||||
monkeypatch.setattr("cli.batch_commands.shutil.rmtree", mock_rmtree_raises)
|
||||
|
||||
# Should handle the error gracefully and not crash
|
||||
result = handle_batch_cleanup_command(str(temp_git_repo), dry_run=False)
|
||||
assert result is True
|
||||
|
||||
def test_cleanup_with_generic_exception(
|
||||
self, temp_dir: Path, temp_git_repo: Path, monkeypatch
|
||||
) -> None:
|
||||
"""Test cleanup handles generic exceptions gracefully."""
|
||||
|
||||
# Create a completed spec with proper QA approval
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
spec_001 = specs_dir / "001-test-task"
|
||||
spec_001.mkdir(parents=True)
|
||||
(spec_001 / "qa_report.md").write_text("# QA Approved\n")
|
||||
(spec_001 / "implementation_plan.json").write_text(
|
||||
'{"qa_signoff": {"status": "approved"}}'
|
||||
)
|
||||
|
||||
# Mock shutil.rmtree to raise generic exception
|
||||
def mock_rmtree_raises(path, *args, **kwargs):
|
||||
if "001-test-task" in str(path):
|
||||
raise RuntimeError(f"Cannot delete: {path}")
|
||||
|
||||
monkeypatch.setattr("cli.batch_commands.shutil.rmtree", mock_rmtree_raises)
|
||||
|
||||
# Should handle the error gracefully and not crash
|
||||
result = handle_batch_cleanup_command(str(temp_git_repo), dry_run=False)
|
||||
assert result is True
|
||||
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,970 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Tests for CLI Followup Commands (cli/followup_commands.py)
|
||||
===========================================================
|
||||
|
||||
Tests for follow-up task commands:
|
||||
- collect_followup_task()
|
||||
- handle_followup_command()
|
||||
"""
|
||||
|
||||
import json
|
||||
import sys
|
||||
from pathlib import Path
|
||||
from unittest.mock import AsyncMock, MagicMock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
# Add apps/backend to path for imports
|
||||
sys.path.insert(0, str(Path(__file__).parent.parent / "apps" / "backend"))
|
||||
# Add tests directory to path for test_utils import
|
||||
sys.path.insert(0, str(Path(__file__).parent))
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Mock external dependencies before importing cli.followup_commands
|
||||
# =============================================================================
|
||||
|
||||
# Import shared helper for creating mock modules
|
||||
from test_utils import _create_mock_module
|
||||
|
||||
# Mock modules
|
||||
if 'progress' not in sys.modules:
|
||||
sys.modules['progress'] = _create_mock_module()
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Auto-use fixture to set up mock UI module before importing cli.followup_commands
|
||||
# =============================================================================
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
def setup_mock_ui_for_followup(mock_ui_module_full):
|
||||
"""Auto-use fixture that replaces sys.modules['ui'] with mock for each test."""
|
||||
sys.modules['ui'] = mock_ui_module_full
|
||||
yield
|
||||
|
||||
# =============================================================================
|
||||
# Import cli.followup_commands after mocking dependencies
|
||||
# =============================================================================
|
||||
|
||||
from cli.followup_commands import (
|
||||
collect_followup_task,
|
||||
handle_followup_command,
|
||||
)
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for collect_followup_task()
|
||||
# =============================================================================
|
||||
|
||||
class TestCollectFollowupTask:
|
||||
"""Tests for collect_followup_task() function."""
|
||||
|
||||
def test_returns_task_description_on_type(self, temp_dir, capsys):
|
||||
"""Returns task description when user chooses to type."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
with patch('cli.followup_commands.select_menu', return_value='type'):
|
||||
with patch('builtins.input', side_effect=['First line', 'Second line', '']):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is not None
|
||||
assert "First line" in result
|
||||
assert "Second line" in result
|
||||
|
||||
# Check that FOLLOWUP_REQUEST.md was created
|
||||
followup_file = spec_dir / "FOLLOWUP_REQUEST.md"
|
||||
assert followup_file.exists()
|
||||
assert followup_file.read_text() == result
|
||||
|
||||
def test_reads_from_file_when_selected(self, temp_dir, capsys):
|
||||
"""Reads task description from file when file option selected."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# Create a temp file with task description
|
||||
task_file = temp_dir / "task.txt"
|
||||
task_file.write_text("Task from file\nMultiple lines")
|
||||
|
||||
with patch('cli.followup_commands.select_menu', return_value='file'):
|
||||
with patch('builtins.input', return_value=str(task_file)):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is not None
|
||||
assert "Task from file" in result
|
||||
assert "Multiple lines" in result
|
||||
|
||||
def test_handles_nonexistent_file(self, temp_dir, capsys):
|
||||
"""Handles case when specified file doesn't exist."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
with patch('cli.followup_commands.select_menu', return_value='file'):
|
||||
with patch('builtins.input', return_value='/nonexistent/file.txt'):
|
||||
with patch('cli.followup_commands.select_menu', return_value='quit'):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
|
||||
def test_handles_empty_file(self, temp_dir, capsys):
|
||||
"""Handles case when file is empty."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# Create empty file
|
||||
task_file = temp_dir / "empty.txt"
|
||||
task_file.write_text("")
|
||||
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['file', 'quit']):
|
||||
with patch('builtins.input', side_effect=[str(task_file)]):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
|
||||
def test_handles_permission_error(self, temp_dir, capsys):
|
||||
"""Handles permission denied error when reading file."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
task_file = temp_dir / "restricted.txt"
|
||||
task_file.write_text("Content")
|
||||
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['file', 'quit']):
|
||||
with patch('builtins.input', return_value=str(task_file)):
|
||||
# Mock Path.read_text to raise PermissionError
|
||||
with patch('pathlib.Path.read_text', side_effect=PermissionError("Denied")):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
|
||||
def test_returns_none_on_quit(self, temp_dir):
|
||||
"""Returns None when user selects quit."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
with patch('cli.followup_commands.select_menu', return_value='quit'):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
|
||||
def test_retries_on_empty_input(self, temp_dir, capsys):
|
||||
"""Retries when user provides empty input."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# First attempt: type with empty input
|
||||
# Second attempt: type with actual content
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['type', 'type']):
|
||||
with patch('builtins.input', side_effect=[
|
||||
'', # First attempt - empty
|
||||
'Actual task content', # Second attempt - content
|
||||
''
|
||||
]):
|
||||
result = collect_followup_task(spec_dir, max_retries=3)
|
||||
|
||||
assert result is not None
|
||||
assert "Actual task content" in result
|
||||
|
||||
def test_respects_max_retries(self, temp_dir, capsys):
|
||||
"""Stops retrying after max attempts reached."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# Always return empty input
|
||||
with patch('cli.followup_commands.select_menu', return_value='type'):
|
||||
with patch('builtins.input', side_effect=['', '', '', '']):
|
||||
result = collect_followup_task(spec_dir, max_retries=2)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "Maximum retry" in captured.out or "cancelled" in captured.out.lower()
|
||||
|
||||
def test_handles_keyboard_interrupt(self, temp_dir, capsys):
|
||||
"""Handles KeyboardInterrupt during input collection."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
with patch('cli.followup_commands.select_menu', return_value='type'):
|
||||
with patch('builtins.input', side_effect=KeyboardInterrupt):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "Cancelled" in captured.out or "cancel" in captured.out.lower()
|
||||
|
||||
def test_handles_eof_error(self, temp_dir, capsys):
|
||||
"""Handles EOFError during input collection."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
with patch('cli.followup_commands.select_menu', return_value='type'):
|
||||
with patch('builtins.input', side_effect=EOFError):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
# EOFError should break the input loop, returning None if empty
|
||||
# The actual content would be empty, so it should retry or return None
|
||||
assert result is None
|
||||
|
||||
def test_saves_to_followup_request_file(self, temp_dir):
|
||||
"""Saves the collected task to FOLLOWUP_REQUEST.md."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
task_description = "This is a test follow-up task"
|
||||
|
||||
with patch('cli.followup_commands.select_menu', return_value='type'):
|
||||
with patch('builtins.input', side_effect=[task_description, '']):
|
||||
collect_followup_task(spec_dir)
|
||||
|
||||
followup_file = spec_dir / "FOLLOWUP_REQUEST.md"
|
||||
assert followup_file.exists()
|
||||
assert followup_file.read_text() == task_description
|
||||
|
||||
def test_handles_empty_file_path(self, temp_dir, capsys):
|
||||
"""Handles case when no file path is provided."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['file', 'quit']):
|
||||
with patch('builtins.input', return_value=''):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "No file path" in captured.out or "cancel" in captured.out.lower()
|
||||
|
||||
def test_expands_tilde_in_path(self, temp_dir):
|
||||
"""Expands ~ in file path to home directory."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# Create a file in temp_dir to simulate home
|
||||
task_file = temp_dir / "task.txt"
|
||||
task_file.write_text("Task content")
|
||||
|
||||
with patch('cli.followup_commands.select_menu', return_value='file'):
|
||||
with patch('builtins.input', return_value=str(task_file)):
|
||||
with patch('pathlib.Path.expanduser', return_value=task_file):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is not None
|
||||
assert "Task content" in result
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for handle_followup_command()
|
||||
# =============================================================================
|
||||
|
||||
class TestHandleFollowupCommand:
|
||||
"""Tests for handle_followup_command() function."""
|
||||
|
||||
@patch('cli.utils.validate_environment')
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('progress.is_build_complete')
|
||||
@patch('progress.count_subtasks')
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_exits_when_no_implementation_plan(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_count,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Exits with error when implementation plan doesn't exist."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
|
||||
# sys.exit is called directly in the function, so we need to catch SystemExit
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "No implementation plan found" in captured.out or "not been built" in captured.out
|
||||
|
||||
@patch('cli.utils.validate_environment')
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete')
|
||||
@patch('cli.followup_commands.count_subtasks')
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_exits_when_build_not_complete(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_count,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Exits with error when build is not complete."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
(spec_dir / "implementation_plan.json").write_text('{}')
|
||||
|
||||
mock_is_complete.return_value = False
|
||||
mock_count.return_value = (2, 5) # 2 completed, 5 total
|
||||
|
||||
# sys.exit is called directly in the function
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
captured = capsys.readouterr()
|
||||
assert "not complete" in captured.out or "pending" in captured.out
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=True)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_runs_planner_after_collecting_task(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Runs follow-up planner after successfully collecting task."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
(spec_dir / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
mock_collect.return_value = "Add new feature"
|
||||
mock_run_planner.return_value = True
|
||||
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
assert mock_run_planner.called
|
||||
call_kwargs = mock_run_planner.call_args[1]
|
||||
assert call_kwargs['project_dir'] == temp_dir
|
||||
assert call_kwargs['spec_dir'] == spec_dir
|
||||
assert call_kwargs['model'] == "sonnet"
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=True)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_returns_when_user_cancels(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Returns early when user cancels task collection."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
(spec_dir / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
mock_collect.return_value = None
|
||||
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
assert not mock_run_planner.called
|
||||
captured = capsys.readouterr()
|
||||
assert "cancel" in captured.out.lower()
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=False)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_exits_when_environment_invalid(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir
|
||||
):
|
||||
"""Exits when environment validation fails."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
(spec_dir / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
mock_collect.return_value = "Task description"
|
||||
|
||||
# sys.exit is called directly in the function
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
assert not mock_run_planner.called
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=True)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_handles_successful_planning(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Shows success message when planning completes successfully."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
(spec_dir / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
mock_collect.return_value = "Add feature"
|
||||
mock_run_planner.return_value = True
|
||||
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "COMPLETE" in captured.out or "success" in captured.out.lower()
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=True)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_handles_planning_failure(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Shows warning when planning doesn't fully succeed."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
(spec_dir / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
mock_collect.return_value = "Add feature"
|
||||
mock_run_planner.return_value = False
|
||||
|
||||
with pytest.raises(SystemExit):
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "INCOMPLETE" in captured.out or "warning" in captured.out.lower()
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=True)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_handles_keyboard_interrupt(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Handles KeyboardInterrupt during planning."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
(spec_dir / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
mock_collect.return_value = "Add feature"
|
||||
mock_run_planner.side_effect = KeyboardInterrupt()
|
||||
|
||||
with pytest.raises(SystemExit):
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "paused" in captured.out.lower() or "retry" in captured.out.lower()
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=True)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_handles_planning_exception(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Handles exception during planning."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
(spec_dir / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
mock_collect.return_value = "Add feature"
|
||||
mock_run_planner.side_effect = Exception("Planning failed")
|
||||
|
||||
with pytest.raises(SystemExit):
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet", verbose=False)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "error" in captured.out.lower()
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=True)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_shows_traceback_in_verbose_mode(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Shows traceback in verbose mode."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
(spec_dir / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
mock_collect.return_value = "Add feature"
|
||||
test_error = Exception("Test error")
|
||||
mock_run_planner.side_effect = test_error
|
||||
|
||||
with pytest.raises(SystemExit):
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet", verbose=True)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# In verbose mode, traceback should be printed
|
||||
assert "error" in captured.out.lower()
|
||||
|
||||
def test_counts_prior_followups(self, temp_dir, capsys):
|
||||
"""Counts and displays prior follow-up phases."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
|
||||
# Create implementation plan with follow-up phases
|
||||
plan = {
|
||||
"phases": [
|
||||
{"name": "Initial Phase"},
|
||||
{"name": "Follow-Up: Bug Fixes"},
|
||||
{"name": "Followup: Enhancement"},
|
||||
]
|
||||
}
|
||||
(spec_dir / "implementation_plan.json").write_text(json.dumps(plan))
|
||||
|
||||
with patch('cli.followup_commands.is_build_complete', return_value=True):
|
||||
with patch('cli.followup_commands.collect_followup_task', return_value=None):
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# Should indicate prior follow-ups were detected
|
||||
# The exact output depends on the implementation
|
||||
assert "complete" in captured.out.lower()
|
||||
|
||||
def test_shows_ready_message_for_first_followup(self, temp_dir, capsys):
|
||||
"""Shows appropriate message for first follow-up."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
|
||||
# Create plan without follow-up phases
|
||||
plan = {"phases": [{"name": "Initial Phase"}]}
|
||||
(spec_dir / "implementation_plan.json").write_text(json.dumps(plan))
|
||||
|
||||
with patch('cli.followup_commands.is_build_complete', return_value=True):
|
||||
with patch('cli.followup_commands.collect_followup_task', return_value=None):
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "complete" in captured.out.lower() or "ready" in captured.out.lower()
|
||||
|
||||
def test_passes_verbose_flag_to_planner(self, temp_dir):
|
||||
"""Passes verbose flag to follow-up planner."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
(spec_dir / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
with patch('cli.utils.validate_environment', return_value=True):
|
||||
with patch('agent.run_followup_planner', new_callable=AsyncMock, return_value=True) as mock_planner:
|
||||
with patch('cli.followup_commands.is_build_complete', return_value=True):
|
||||
with patch('cli.followup_commands.collect_followup_task', return_value="Task"):
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet", verbose=True)
|
||||
|
||||
call_kwargs = mock_planner.call_args[1]
|
||||
assert call_kwargs['verbose'] is True
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Additional tests for improved coverage (lines 108-111, 139-144, 150-153, 296-297)
|
||||
# =============================================================================
|
||||
|
||||
def test_handles_keyboard_interrupt_on_file_path_input(self, temp_dir, capsys):
|
||||
"""Handles KeyboardInterrupt when entering file path (lines 108-111)."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
with patch('cli.followup_commands.select_menu', return_value='file'):
|
||||
with patch('builtins.input', side_effect=KeyboardInterrupt):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "Cancelled" in captured.out or "cancel" in captured.out.lower()
|
||||
|
||||
def test_handles_eof_error_on_file_path_input(self, temp_dir, capsys):
|
||||
"""Handles EOFError when entering file path (lines 108-111)."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
with patch('cli.followup_commands.select_menu', return_value='file'):
|
||||
with patch('builtins.input', side_effect=EOFError):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "Cancelled" in captured.out or "cancel" in captured.out.lower()
|
||||
|
||||
def test_handles_file_not_found_error(self, temp_dir, capsys):
|
||||
"""Handles FileNotFoundError when file doesn't exist (lines 139-144)."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# Create a path that doesn't exist
|
||||
nonexistent_file = temp_dir / "does_not_exist.txt"
|
||||
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['file', 'quit']):
|
||||
with patch('builtins.input', return_value=str(nonexistent_file)):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
# Should show file not found error
|
||||
assert "not found" in captured.out.lower() or "check that the path" in captured.out.lower()
|
||||
|
||||
def test_handles_generic_exception_on_file_read(self, temp_dir, capsys):
|
||||
"""Handles generic exception when reading file (lines 150-153)."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# Create a file that exists
|
||||
task_file = temp_dir / "task.txt"
|
||||
task_file.write_text("Content")
|
||||
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['file', 'quit']):
|
||||
with patch('builtins.input', return_value=str(task_file)):
|
||||
# Mock read_text to raise a generic exception
|
||||
with patch('pathlib.Path.read_text', side_effect=OSError("Read error")):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "error" in captured.out.lower()
|
||||
|
||||
def test_handles_unicode_decode_error_on_file_read(self, temp_dir, capsys):
|
||||
"""Handles UnicodeDecodeError when reading file (lines 150-153)."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# Create a file that exists
|
||||
task_file = temp_dir / "task.txt"
|
||||
task_file.write_text("Content")
|
||||
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['file', 'quit']):
|
||||
with patch('builtins.input', return_value=str(task_file)):
|
||||
# Mock read_text to raise UnicodeDecodeError
|
||||
with patch('pathlib.Path.read_text', side_effect=UnicodeDecodeError('utf-8', b'', 0, 1, 'invalid')):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "error" in captured.out.lower()
|
||||
|
||||
def test_handles_runtime_error_on_file_read(self, temp_dir, capsys):
|
||||
"""Handles RuntimeError when reading file (lines 150-153)."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# Create a file that exists
|
||||
task_file = temp_dir / "task.txt"
|
||||
task_file.write_text("Content")
|
||||
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['file', 'quit']):
|
||||
with patch('builtins.input', return_value=str(task_file)):
|
||||
# Mock read_text to raise RuntimeError
|
||||
with patch('pathlib.Path.read_text', side_effect=RuntimeError("Unexpected error")):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "error" in captured.out.lower()
|
||||
|
||||
|
||||
class TestHandleFollowupCommandEdgeCases:
|
||||
"""Additional tests for handle_followup_command() edge cases (lines 296-297)."""
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=True)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_handles_json_decode_error_in_plan_file(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Handles JSONDecodeError when implementation_plan.json is malformed (lines 296-297)."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
|
||||
# Write invalid JSON to implementation_plan.json
|
||||
(spec_dir / "implementation_plan.json").write_text('{ invalid json }')
|
||||
|
||||
mock_collect.return_value = None
|
||||
|
||||
# Should handle the JSONDecodeError gracefully and continue
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# Should complete without error (prior_followup_count just stays 0)
|
||||
assert "complete" in captured.out.lower()
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=True)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_handles_keyerror_in_plan_file(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Handles KeyError when implementation_plan.json is missing expected keys (lines 296-297)."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
|
||||
# Write JSON without 'phases' key
|
||||
(spec_dir / "implementation_plan.json").write_text('{"other_key": "value"}')
|
||||
|
||||
mock_collect.return_value = None
|
||||
|
||||
# Should handle the missing key gracefully
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "complete" in captured.out.lower()
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=True)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_handles_phase_with_missing_name_key(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Handles phase dict without 'name' key (lines 296-297)."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
|
||||
# Write JSON with phase missing 'name' key
|
||||
(spec_dir / "implementation_plan.json").write_text('{"phases": [{"other_key": "value"}, {"name": "Valid Phase"}]}')
|
||||
|
||||
mock_collect.return_value = None
|
||||
|
||||
# Should handle missing name gracefully (uses .get() with default)
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "complete" in captured.out.lower()
|
||||
|
||||
@patch('cli.utils.validate_environment', return_value=True)
|
||||
@patch('agent.run_followup_planner', new_callable=AsyncMock)
|
||||
@patch('cli.followup_commands.is_build_complete', return_value=True)
|
||||
@patch('cli.followup_commands.collect_followup_task')
|
||||
def test_handles_empty_phases_in_plan(
|
||||
self,
|
||||
mock_collect,
|
||||
mock_is_complete,
|
||||
mock_run_planner,
|
||||
mock_validate,
|
||||
temp_dir,
|
||||
capsys
|
||||
):
|
||||
"""Handles empty phases array in implementation plan (lines 296-297)."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
(spec_dir / "spec.md").write_text("# Test")
|
||||
|
||||
# Write JSON with empty phases array
|
||||
(spec_dir / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
mock_collect.return_value = None
|
||||
|
||||
handle_followup_command(temp_dir, spec_dir, "sonnet")
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "complete" in captured.out.lower()
|
||||
|
||||
|
||||
|
||||
class TestCollectFollowupTaskEdgeCases:
|
||||
"""Additional edge case tests for collect_followup_task()."""
|
||||
|
||||
def test_handles_file_with_only_whitespace(self, temp_dir, capsys):
|
||||
"""Handles file that contains only whitespace characters."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# Create file with only whitespace
|
||||
task_file = temp_dir / "whitespace.txt"
|
||||
task_file.write_text(" \n\n\t\n ")
|
||||
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['file', 'quit']):
|
||||
with patch('builtins.input', return_value=str(task_file)):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
# .strip() would make the content empty, triggering the empty file message
|
||||
assert "empty" in captured.out.lower() or "cancel" in captured.out.lower()
|
||||
|
||||
def test_handles_file_with_newline_only_content(self, temp_dir, capsys):
|
||||
"""Handles file that contains only newlines."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# Create file with only newlines
|
||||
task_file = temp_dir / "newlines.txt"
|
||||
task_file.write_text("\n\n\n")
|
||||
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['file', 'quit']):
|
||||
with patch('builtins.input', return_value=str(task_file)):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
|
||||
def test_handles_file_read_with_os_error(self, temp_dir, capsys):
|
||||
"""Handles OSError when reading file."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
task_file = temp_dir / "task.txt"
|
||||
task_file.write_text("Content")
|
||||
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['file', 'quit']):
|
||||
with patch('builtins.input', return_value=str(task_file)):
|
||||
with patch('pathlib.Path.read_text', side_effect=OSError("OS error reading file")):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "error" in captured.out.lower()
|
||||
|
||||
def test_handles_value_error_on_file_path(self, temp_dir, capsys):
|
||||
"""Handles ValueError during file path resolution."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
with patch('cli.followup_commands.select_menu', side_effect=['file', 'quit']):
|
||||
with patch('builtins.input', return_value='/valid/path'):
|
||||
# Mock resolve to raise ValueError
|
||||
with patch('pathlib.Path.resolve', side_effect=ValueError("Invalid path")):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
# Should handle gracefully and return None or retry
|
||||
assert result is None
|
||||
|
||||
def test_handles_type_input_with_trailing_whitespace(self, temp_dir):
|
||||
"""Properly strips trailing whitespace from typed input."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
task_description = "Task content with trailing spaces "
|
||||
|
||||
with patch('cli.followup_commands.select_menu', return_value='type'):
|
||||
with patch('builtins.input', side_effect=[task_description, '']):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is not None
|
||||
# Should be stripped
|
||||
assert result == "Task content with trailing spaces"
|
||||
|
||||
def test_handles_type_input_with_internal_whitespace(self, temp_dir):
|
||||
"""Preserves internal whitespace in typed input."""
|
||||
spec_dir = temp_dir / ".auto-claude" / "specs" / "001-test"
|
||||
spec_dir.mkdir(parents=True)
|
||||
|
||||
# Note: empty line terminates input, so we need non-empty lines only
|
||||
# Then a final empty line to signal completion
|
||||
with patch('cli.followup_commands.select_menu', return_value='type'):
|
||||
with patch('builtins.input', side_effect=["Line 1", "Line 2", " Line 3", '']):
|
||||
result = collect_followup_task(spec_dir)
|
||||
|
||||
assert result is not None
|
||||
assert "Line 1" in result
|
||||
assert "Line 2" in result
|
||||
assert "Line 3" in result
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS: Module-level path insertion (line 16)
|
||||
# =============================================================================
|
||||
|
||||
|
||||
class TestFollowupCommandsModuleImport:
|
||||
"""Tests for covering module-level path insertion (line 16)."""
|
||||
|
||||
def test_module_import_executes_path_insertion(self):
|
||||
"""Module import executes sys.path.insert (line 16)."""
|
||||
# Get the module path and parent directory
|
||||
import cli.followup_commands as followup_module
|
||||
module_path = followup_module.__file__
|
||||
parent_dir = str(Path(module_path).parent.parent)
|
||||
|
||||
# Save original sys.path
|
||||
original_path = sys.path.copy()
|
||||
|
||||
# Remove the parent directory from sys.path to make the condition True
|
||||
while parent_dir in sys.path:
|
||||
sys.path.remove(parent_dir)
|
||||
|
||||
# Remove module and its submodules from sys.modules to force re-import
|
||||
modules_to_remove = [k for k in sys.modules.keys() if k.startswith('cli.followup_commands')]
|
||||
for mod_name in modules_to_remove:
|
||||
del sys.modules[mod_name]
|
||||
|
||||
# Now import it fresh - this should execute line 16 under coverage
|
||||
import importlib.util
|
||||
spec = importlib.util.spec_from_file_location("cli.followup_commands", module_path)
|
||||
module = importlib.util.module_from_spec(spec)
|
||||
sys.modules['cli.followup_commands'] = module
|
||||
spec.loader.exec_module(module)
|
||||
|
||||
# Verify the module loaded correctly
|
||||
assert hasattr(module, 'handle_followup_command')
|
||||
|
||||
# Restore original sys.path
|
||||
sys.path[:] = original_path
|
||||
@@ -0,0 +1,626 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Tests for CLI Input Handlers (cli/input_handlers.py)
|
||||
====================================================
|
||||
|
||||
Tests for reusable user input collection utilities:
|
||||
- collect_user_input_interactive()
|
||||
- read_from_file()
|
||||
- read_multiline_input()
|
||||
"""
|
||||
|
||||
import os
|
||||
import sys
|
||||
from pathlib import Path
|
||||
from unittest.mock import patch
|
||||
|
||||
import pytest
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Auto-use fixture to set up mock UI module before importing cli.input_handlers
|
||||
# =============================================================================
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
def setup_mock_ui_for_input_handlers(mock_ui_module_full):
|
||||
"""Auto-use fixture that replaces sys.modules['ui'] with mock for each test."""
|
||||
sys.modules['ui'] = mock_ui_module_full
|
||||
yield
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Import cli.input_handlers after mock UI is set up by autouse fixture
|
||||
# =============================================================================
|
||||
|
||||
from cli.input_handlers import (
|
||||
collect_user_input_interactive,
|
||||
read_from_file,
|
||||
read_multiline_input,
|
||||
)
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for collect_user_input_interactive()
|
||||
# =============================================================================
|
||||
|
||||
class TestCollectUserInputInteractive:
|
||||
"""Tests for collect_user_input_interactive() function."""
|
||||
|
||||
def test_returns_input_when_type_selected(self, capsys):
|
||||
"""Returns user input when type option is selected."""
|
||||
with patch('cli.input_handlers.select_menu', return_value='type'):
|
||||
with patch('builtins.input', side_effect=['Line 1', 'Line 2', '']):
|
||||
result = collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:"
|
||||
)
|
||||
|
||||
assert result is not None
|
||||
assert "Line 1" in result
|
||||
assert "Line 2" in result
|
||||
|
||||
def test_returns_input_when_paste_selected(self, capsys):
|
||||
"""Returns user input when paste option is selected."""
|
||||
with patch('cli.input_handlers.select_menu', return_value='paste'):
|
||||
with patch('builtins.input', side_effect=['Pasted content', '']):
|
||||
result = collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:"
|
||||
)
|
||||
|
||||
assert result is not None
|
||||
assert "Pasted content" in result
|
||||
|
||||
def test_reads_from_file_when_file_selected(self, temp_dir):
|
||||
"""Reads input from file when file option is selected."""
|
||||
# Create a test file
|
||||
test_file = temp_dir / "input.txt"
|
||||
test_file.write_text("Content from file")
|
||||
|
||||
with patch('cli.input_handlers.select_menu', return_value='file'):
|
||||
with patch('builtins.input', return_value=str(test_file)):
|
||||
result = collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:"
|
||||
)
|
||||
|
||||
assert result is not None
|
||||
assert "Content from file" in result
|
||||
|
||||
def test_returns_empty_string_when_skip_selected(self):
|
||||
"""Returns empty string when skip option is selected."""
|
||||
with patch('cli.input_handlers.select_menu', return_value='skip'):
|
||||
result = collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:"
|
||||
)
|
||||
|
||||
assert result == ""
|
||||
|
||||
def test_returns_none_when_quit_selected(self):
|
||||
"""Returns None when quit option is selected."""
|
||||
with patch('cli.input_handlers.select_menu', return_value='quit'):
|
||||
result = collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:"
|
||||
)
|
||||
|
||||
assert result is None
|
||||
|
||||
def test_returns_none_when_menu_returns_none(self):
|
||||
"""Returns None when select_menu returns None."""
|
||||
with patch('cli.input_handlers.select_menu', return_value=None):
|
||||
result = collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:"
|
||||
)
|
||||
|
||||
assert result is None
|
||||
|
||||
def test_hides_file_option_when_disabled(self):
|
||||
"""Does not show file option when allow_file is False."""
|
||||
with patch('cli.input_handlers.select_menu') as mock_menu:
|
||||
mock_menu.return_value = 'type'
|
||||
with patch('builtins.input', side_effect=['Test', '']):
|
||||
collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:",
|
||||
allow_file=False
|
||||
)
|
||||
|
||||
# Check that options were passed to select_menu
|
||||
options = mock_menu.call_args[1]['options']
|
||||
keys = [opt.key for opt in options]
|
||||
assert 'file' not in keys
|
||||
assert 'type' in keys
|
||||
assert 'skip' in keys
|
||||
assert 'quit' in keys
|
||||
|
||||
def test_hides_paste_option_when_disabled(self):
|
||||
"""Does not show paste option when allow_paste is False."""
|
||||
with patch('cli.input_handlers.select_menu') as mock_menu:
|
||||
mock_menu.return_value = 'type'
|
||||
with patch('builtins.input', side_effect=['Test', '']):
|
||||
collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:",
|
||||
allow_paste=False
|
||||
)
|
||||
|
||||
# Check that options were passed to select_menu
|
||||
options = mock_menu.call_args[1]['options']
|
||||
keys = [opt.key for opt in options]
|
||||
assert 'paste' not in keys
|
||||
assert 'type' in keys
|
||||
assert 'file' in keys
|
||||
|
||||
def test_passes_title_and_subtitle_to_menu(self):
|
||||
"""Passes title and subtitle to select_menu."""
|
||||
with patch('cli.input_handlers.select_menu') as mock_menu:
|
||||
mock_menu.return_value = 'skip'
|
||||
collect_user_input_interactive(
|
||||
title="Custom Title",
|
||||
subtitle="Custom Subtitle",
|
||||
prompt_text="Enter your input:"
|
||||
)
|
||||
|
||||
assert mock_menu.called
|
||||
call_kwargs = mock_menu.call_args[1]
|
||||
assert call_kwargs['title'] == "Custom Title"
|
||||
assert call_kwargs['subtitle'] == "Custom Subtitle"
|
||||
|
||||
def test_handles_keyboard_interrupt_during_type(self, capsys):
|
||||
"""Handles KeyboardInterrupt during type input."""
|
||||
with patch('cli.input_handlers.select_menu', return_value='type'):
|
||||
with patch('builtins.input', side_effect=KeyboardInterrupt):
|
||||
result = collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:"
|
||||
)
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "Cancelled" in captured.out or "cancel" in captured.out.lower()
|
||||
|
||||
def test_handles_eof_error_during_type(self, capsys):
|
||||
"""Handles EOFError during type input."""
|
||||
with patch('cli.input_handlers.select_menu', return_value='type'):
|
||||
with patch('builtins.input', side_effect=EOFError):
|
||||
result = collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:"
|
||||
)
|
||||
|
||||
# EOFError should break the input loop
|
||||
# Result could be empty string or None depending on implementation
|
||||
assert result is None or result == ""
|
||||
|
||||
def test_file_read_failure_returns_none(self, temp_dir):
|
||||
"""Returns None when file read fails."""
|
||||
with patch('cli.input_handlers.select_menu', return_value='file'):
|
||||
with patch('builtins.input', return_value='/nonexistent/file.txt'):
|
||||
result = collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:"
|
||||
)
|
||||
|
||||
assert result is None
|
||||
|
||||
def test_strips_whitespace_from_input(self):
|
||||
"""Strips leading/trailing whitespace from collected input."""
|
||||
with patch('cli.input_handlers.select_menu', return_value='type'):
|
||||
with patch('builtins.input', side_effect=[' Text with spaces ', '']):
|
||||
result = collect_user_input_interactive(
|
||||
title="Test Title",
|
||||
subtitle="Test Subtitle",
|
||||
prompt_text="Enter your input:"
|
||||
)
|
||||
|
||||
assert result is not None
|
||||
assert result.strip() == result
|
||||
assert not result.startswith(" ")
|
||||
assert not result.endswith(" ")
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for read_from_file()
|
||||
# =============================================================================
|
||||
|
||||
class TestReadFromFile:
|
||||
"""Tests for read_from_file() function."""
|
||||
|
||||
def test_returns_file_contents(self, temp_dir, capsys):
|
||||
"""Returns contents of the specified file."""
|
||||
test_file = temp_dir / "test.txt"
|
||||
test_file.write_text("File content here")
|
||||
|
||||
with patch('builtins.input', return_value=str(test_file)):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is not None
|
||||
assert result == "File content here"
|
||||
|
||||
def test_returns_none_when_no_path_provided(self, capsys):
|
||||
"""Returns None when no file path is provided."""
|
||||
with patch('builtins.input', return_value=''):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "No file path" in captured.out
|
||||
|
||||
def test_returns_none_for_nonexistent_file(self, capsys):
|
||||
"""Returns None when file doesn't exist."""
|
||||
with patch('builtins.input', return_value='/nonexistent/path.txt'):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
# The error message could be "not found" or "Permission denied" depending on the system
|
||||
assert "not found" in captured.out.lower() or "no such file" in captured.out.lower() or "permission denied" in captured.out.lower() or "cannot read" in captured.out.lower()
|
||||
|
||||
def test_returns_none_for_empty_file(self, temp_dir, capsys):
|
||||
"""Returns None when file is empty."""
|
||||
empty_file = temp_dir / "empty.txt"
|
||||
empty_file.write_text("")
|
||||
|
||||
with patch('builtins.input', return_value=str(empty_file)):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "empty" in captured.out.lower()
|
||||
|
||||
def test_returns_none_on_permission_error(self, temp_dir, capsys):
|
||||
"""Returns None when file cannot be read due to permissions."""
|
||||
# Create a real temporary file
|
||||
restricted_file = temp_dir / "restricted.txt"
|
||||
restricted_file.write_text("secret content")
|
||||
|
||||
with patch('builtins.input', return_value=str(restricted_file)):
|
||||
with patch.object(Path, 'read_text', side_effect=PermissionError("Denied")):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "Permission" in captured.out or "denied" in captured.out.lower()
|
||||
|
||||
def test_returns_none_on_keyboard_interrupt(self, capsys):
|
||||
"""Returns None when user interrupts input."""
|
||||
with patch('builtins.input', side_effect=KeyboardInterrupt):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "Cancelled" in captured.out or "cancel" in captured.out.lower()
|
||||
|
||||
def test_returns_none_on_eof_error(self, capsys):
|
||||
"""Returns None on EOFError during input."""
|
||||
with patch('builtins.input', side_effect=EOFError):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "Cancelled" in captured.out or "cancel" in captured.out.lower()
|
||||
|
||||
def test_expands_tilde_in_path(self, temp_dir):
|
||||
"""Expands ~ to home directory in file path."""
|
||||
test_file = temp_dir / "test.txt"
|
||||
test_file.write_text("Content")
|
||||
|
||||
with patch('builtins.input', return_value='~/test.txt'):
|
||||
with patch('pathlib.Path.expanduser', return_value=test_file):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is not None
|
||||
assert result == "Content"
|
||||
|
||||
def test_resolves_relative_paths(self, temp_dir):
|
||||
"""Resolves relative file paths to absolute."""
|
||||
test_file = temp_dir / "subdir" / "test.txt"
|
||||
test_file.parent.mkdir(parents=True)
|
||||
test_file.write_text("Resolved content")
|
||||
|
||||
# Change to temp_dir
|
||||
import os
|
||||
original_cwd = os.getcwd()
|
||||
try:
|
||||
os.chdir(temp_dir)
|
||||
with patch('builtins.input', return_value='subdir/test.txt'):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is not None
|
||||
assert result == "Resolved content"
|
||||
finally:
|
||||
os.chdir(original_cwd)
|
||||
|
||||
def test_shows_character_count(self, temp_dir, capsys):
|
||||
"""Shows number of characters loaded from file."""
|
||||
test_file = temp_dir / "test.txt"
|
||||
content = "A" * 100
|
||||
test_file.write_text(content)
|
||||
|
||||
with patch('builtins.input', return_value=str(test_file)):
|
||||
result = read_from_file()
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "100" in captured.out or "character" in captured.out.lower()
|
||||
|
||||
def test_handles_unicode_content(self, temp_dir):
|
||||
"""Handles files with Unicode content."""
|
||||
test_file = temp_dir / "unicode.txt"
|
||||
content = "Hello 世界 🌍 Привет"
|
||||
test_file.write_text(content, encoding='utf-8')
|
||||
|
||||
with patch('builtins.input', return_value=str(test_file)):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is not None
|
||||
assert result == content
|
||||
|
||||
def test_strips_whitespace_from_file_content(self, temp_dir):
|
||||
"""Strips leading/trailing whitespace from file content."""
|
||||
test_file = temp_dir / "spaces.txt"
|
||||
test_file.write_text(" Content with spaces ")
|
||||
|
||||
with patch('builtins.input', return_value=str(test_file)):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is not None
|
||||
assert result == "Content with spaces"
|
||||
assert not result.startswith(" ")
|
||||
assert not result.endswith(" ")
|
||||
|
||||
def test_handles_generic_exception(self, temp_dir, capsys):
|
||||
"""Handles generic exceptions during file reading."""
|
||||
# Create a real temporary file
|
||||
test_file = temp_dir / "error_file.txt"
|
||||
test_file.write_text("content")
|
||||
|
||||
with patch('builtins.input', return_value=str(test_file)):
|
||||
with patch.object(Path, 'read_text', side_effect=Exception("Unknown error")):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "Error" in captured.out or "error" in captured.out.lower()
|
||||
|
||||
def test_file_not_found_after_resolve(self, temp_dir, capsys):
|
||||
"""Returns None when path resolves but file doesn't exist (lines 163-164)."""
|
||||
# Use a path in a valid temp directory but the file doesn't exist
|
||||
nonexistent_file = temp_dir / "does_not_exist.txt"
|
||||
|
||||
with patch('builtins.input', return_value=str(nonexistent_file)):
|
||||
result = read_from_file()
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
# Should show "File not found" error message
|
||||
assert "not found" in captured.out.lower()
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for read_multiline_input()
|
||||
# =============================================================================
|
||||
|
||||
class TestReadMultilineInput:
|
||||
"""Tests for read_multiline_input() function."""
|
||||
|
||||
def test_returns_single_line_input(self):
|
||||
"""Returns single line of input."""
|
||||
with patch('builtins.input', side_effect=['Single line', '']):
|
||||
result = read_multiline_input("Enter text:")
|
||||
|
||||
assert result is not None
|
||||
assert result == "Single line"
|
||||
|
||||
def test_returns_multiple_lines_of_input(self):
|
||||
"""Returns multiple lines joined by newline."""
|
||||
with patch('builtins.input', side_effect=['Line 1', 'Line 2', 'Line 3', '']):
|
||||
result = read_multiline_input("Enter text:")
|
||||
|
||||
assert result is not None
|
||||
assert result == "Line 1\nLine 2\nLine 3"
|
||||
|
||||
def test_stops_on_empty_line(self):
|
||||
"""Stops reading when encountering an empty line."""
|
||||
with patch('builtins.input', side_effect=['Line 1', 'Line 2', '', 'Should not be included']):
|
||||
result = read_multiline_input("Enter text:")
|
||||
|
||||
assert result is not None
|
||||
assert "Should not be included" not in result
|
||||
|
||||
def test_returns_none_on_keyboard_interrupt(self, capsys):
|
||||
"""Returns None when user interrupts with Ctrl+C."""
|
||||
with patch('builtins.input', side_effect=KeyboardInterrupt):
|
||||
result = read_multiline_input("Enter text:")
|
||||
|
||||
assert result is None
|
||||
captured = capsys.readouterr()
|
||||
assert "Cancelled" in captured.out or "cancel" in captured.out.lower()
|
||||
|
||||
def test_breaks_on_eof_error(self):
|
||||
"""Breaks input loop on EOFError."""
|
||||
with patch('builtins.input', side_effect=['Line 1', EOFError]):
|
||||
result = read_multiline_input("Enter text:")
|
||||
|
||||
# Should return content before EOF
|
||||
assert result is not None
|
||||
assert "Line 1" in result
|
||||
|
||||
def test_handles_empty_input(self):
|
||||
"""Handles case where user enters nothing."""
|
||||
with patch('builtins.input', side_effect=['', '']):
|
||||
result = read_multiline_input("Enter text:")
|
||||
|
||||
assert result == ""
|
||||
|
||||
def test_strips_whitespace_from_result(self):
|
||||
"""Strips leading/trailing whitespace from final result."""
|
||||
with patch('builtins.input', side_effect=[' Line 1 ', ' Line 2 ', '']):
|
||||
result = read_multiline_input("Enter text:")
|
||||
|
||||
# Note: The implementation strips each line but not the overall result
|
||||
# Behavior depends on implementation
|
||||
assert result is not None
|
||||
assert "Line 1" in result
|
||||
|
||||
def test_handles_unicode_input(self):
|
||||
"""Handles Unicode characters in input."""
|
||||
with patch('builtins.input', side_effect=['Hello 世界', '🌍 Emoji', '']):
|
||||
result = read_multiline_input("Enter text:")
|
||||
|
||||
assert result is not None
|
||||
assert "世界" in result
|
||||
assert "🌍" in result
|
||||
|
||||
def test_preserves_internal_whitespace(self):
|
||||
"""Preserves internal whitespace in lines."""
|
||||
with patch('builtins.input', side_effect=['Line with spaces', 'Line\twith\ttabs', '']):
|
||||
result = read_multiline_input("Enter text:")
|
||||
|
||||
assert result is not None
|
||||
assert " " in result
|
||||
assert "\t" in result
|
||||
|
||||
def test_passes_prompt_text_to_box(self, capsys):
|
||||
"""Passes prompt text to the box display."""
|
||||
custom_prompt = "Custom prompt text"
|
||||
with patch('builtins.input', side_effect=['', '']):
|
||||
read_multiline_input(custom_prompt)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# The actual custom prompt text should appear in the output
|
||||
assert custom_prompt.lower() in captured.out.lower()
|
||||
|
||||
def test_allows_multiple_consecutive_empty_lines_to_stop(self):
|
||||
"""Stops on first empty line (empty_count >= 1)."""
|
||||
with patch('builtins.input', side_effect=['Line 1', '', '']):
|
||||
result = read_multiline_input("Enter text:")
|
||||
|
||||
assert result is not None
|
||||
assert result == "Line 1"
|
||||
|
||||
def test_handles_long_lines(self):
|
||||
"""Handles very long input lines."""
|
||||
long_line = "A" * 10000
|
||||
with patch('builtins.input', side_effect=[long_line, '']):
|
||||
result = read_multiline_input("Enter text:")
|
||||
|
||||
assert result is not None
|
||||
assert len(result) == 10000
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for module import behavior (line 14 - sys.path insertion)
|
||||
# =============================================================================
|
||||
|
||||
class TestModuleImportPathInsertion:
|
||||
"""Tests for module-level path manipulation logic."""
|
||||
|
||||
def test_inserts_parent_dir_to_sys_path_when_not_present(self):
|
||||
"""
|
||||
Test that line 14 executes: sys.path.insert(0, str(_PARENT_DIR))
|
||||
|
||||
This test covers the scenario where _PARENT_DIR is not in sys.path
|
||||
when the module-level code executes.
|
||||
|
||||
Note: This test manually executes the module-level code that would
|
||||
normally run on import, since we can't easily re-import after removing
|
||||
the path (the module wouldn't be found without the path).
|
||||
"""
|
||||
from cli.input_handlers import _PARENT_DIR
|
||||
|
||||
# Get the parent dir that should be inserted by line 14
|
||||
parent_dir_str = str(_PARENT_DIR)
|
||||
parent_dir_normalized = os.path.normpath(parent_dir_str)
|
||||
|
||||
# Verify parent_dir_str is the apps/backend directory (cross-platform)
|
||||
expected_suffix = os.path.join("apps", "backend")
|
||||
assert parent_dir_normalized.endswith(expected_suffix) or parent_dir_str.endswith("apps/backend")
|
||||
|
||||
# Save current sys.path state to restore later
|
||||
original_path = sys.path.copy()
|
||||
|
||||
# Remove the parent dir from sys.path to simulate the condition on line 13
|
||||
# Use normalized paths for comparison to handle different path separators
|
||||
paths_to_restore = []
|
||||
for p in sys.path[:]: # Copy to avoid modification during iteration
|
||||
p_normalized = os.path.normpath(p)
|
||||
if expected_suffix in p_normalized or p == parent_dir_str:
|
||||
paths_to_restore.append(p)
|
||||
sys.path.remove(p)
|
||||
|
||||
try:
|
||||
# Verify parent_dir_str is NOT in sys.path now
|
||||
assert parent_dir_str not in sys.path
|
||||
|
||||
# Now manually execute the logic from lines 13-14 of input_handlers.py
|
||||
# This simulates what happens when the module is imported without the path
|
||||
# We use the _PARENT_DIR value that was already imported
|
||||
if str(_PARENT_DIR) not in sys.path:
|
||||
# This is line 14 - the line we're testing
|
||||
sys.path.insert(0, str(_PARENT_DIR))
|
||||
|
||||
# Verify the parent dir was added to sys.path at position 0
|
||||
assert parent_dir_str in sys.path, f"Parent dir {parent_dir_str} should be in sys.path"
|
||||
assert sys.path[0] == parent_dir_str, f"Parent dir should be at sys.path[0]"
|
||||
|
||||
finally:
|
||||
# Restore sys.path to original state
|
||||
sys.path[:] = original_path
|
||||
|
||||
def test_line_14_coverage_via_importlib_reload(self):
|
||||
"""
|
||||
Test that line 14 executes using importlib.reload() with path manipulation.
|
||||
|
||||
This test forces a reload of the module in a state where _PARENT_DIR
|
||||
is not in sys.path, triggering line 14 execution.
|
||||
"""
|
||||
import importlib
|
||||
import cli.input_handlers
|
||||
|
||||
# Get the parent dir that should be inserted by line 14
|
||||
parent_dir_str = str(cli.input_handlers._PARENT_DIR)
|
||||
|
||||
# Save current sys.path and sys.modules state to restore later
|
||||
original_path = sys.path.copy()
|
||||
original_module = sys.modules.get('cli.input_handlers')
|
||||
|
||||
# Remove the parent dir from sys.path
|
||||
# Use normalized paths for comparison to handle different path separators
|
||||
parent_dir_normalized = os.path.normpath(parent_dir_str)
|
||||
for p in sys.path[:]:
|
||||
p_normalized = os.path.normpath(p)
|
||||
if p == parent_dir_str or p_normalized == parent_dir_normalized:
|
||||
sys.path.remove(p)
|
||||
|
||||
try:
|
||||
# Verify parent_dir_str is NOT in sys.path now
|
||||
assert parent_dir_str not in sys.path
|
||||
|
||||
# Reload the module - this should execute lines 13-14 since path is not present
|
||||
importlib.reload(cli.input_handlers)
|
||||
|
||||
# Verify the parent dir was added to sys.path by line 14
|
||||
assert parent_dir_str in sys.path, f"Parent dir {parent_dir_str} should be in sys.path"
|
||||
|
||||
finally:
|
||||
# Restore sys.path to original state
|
||||
sys.path[:] = original_path
|
||||
# Restore sys.modules to original state
|
||||
if original_module is not None:
|
||||
sys.modules['cli.input_handlers'] = original_module
|
||||
elif 'cli.input_handlers' in sys.modules:
|
||||
del sys.modules['cli.input_handlers']
|
||||
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,581 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Tests for CLI QA Commands
|
||||
==========================
|
||||
|
||||
Tests for qa_commands.py module functionality including:
|
||||
- handle_qa_status_command() - Display QA status for a spec
|
||||
- handle_review_status_command() - Display review status for a spec
|
||||
- handle_qa_command() - Run QA validation loop
|
||||
"""
|
||||
|
||||
import json
|
||||
import sys
|
||||
from pathlib import Path
|
||||
from unittest.mock import patch
|
||||
|
||||
import pytest
|
||||
|
||||
from cli.qa_commands import (
|
||||
handle_qa_command,
|
||||
handle_qa_status_command,
|
||||
handle_review_status_command,
|
||||
)
|
||||
from review import ReviewState
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# FIXTURES
|
||||
# =============================================================================
|
||||
|
||||
@pytest.fixture
|
||||
def spec_dir_with_qa_report(temp_dir: Path) -> Path:
|
||||
"""Create a spec directory with QA report."""
|
||||
spec_dir = temp_dir / "001-test-spec"
|
||||
spec_dir.mkdir()
|
||||
|
||||
qa_report = spec_dir / "qa_report.md"
|
||||
qa_report.write_text(
|
||||
"# QA Report\n\n"
|
||||
"## Status: Approved\n\n"
|
||||
"All tests passed.\n"
|
||||
)
|
||||
|
||||
return spec_dir
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def spec_dir_with_fix_request(temp_dir: Path) -> Path:
|
||||
"""Create a spec directory with QA fix request."""
|
||||
spec_dir = temp_dir / "001-test-spec"
|
||||
spec_dir.mkdir()
|
||||
|
||||
fix_request = spec_dir / "QA_FIX_REQUEST.md"
|
||||
fix_request.write_text(
|
||||
"# QA Fix Request\n\n"
|
||||
"## Issues Found\n\n"
|
||||
"1. Unit tests failing\n"
|
||||
"2. Missing error handling\n"
|
||||
)
|
||||
|
||||
return spec_dir
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def spec_dir_with_implementation_plan(temp_dir: Path) -> Path:
|
||||
"""Create a spec directory with implementation plan (incomplete)."""
|
||||
spec_dir = temp_dir / "001-test-spec"
|
||||
spec_dir.mkdir()
|
||||
|
||||
plan = {
|
||||
"phases": [
|
||||
{
|
||||
"phase": 1,
|
||||
"name": "Phase 1",
|
||||
"subtasks": [
|
||||
{"id": "1-1", "status": "completed"},
|
||||
{"id": "1-2", "status": "pending"},
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
plan_file = spec_dir / "implementation_plan.json"
|
||||
plan_file.write_text(json.dumps(plan))
|
||||
|
||||
return spec_dir
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def spec_dir_complete(temp_dir: Path) -> Path:
|
||||
"""Create a spec directory with complete implementation."""
|
||||
spec_dir = temp_dir / "001-test-spec"
|
||||
spec_dir.mkdir()
|
||||
|
||||
plan = {
|
||||
"phases": [
|
||||
{
|
||||
"phase": 1,
|
||||
"name": "Phase 1",
|
||||
"subtasks": [
|
||||
{"id": "1-1", "status": "completed"},
|
||||
{"id": "1-2", "status": "completed"},
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
plan_file = spec_dir / "implementation_plan.json"
|
||||
plan_file.write_text(json.dumps(plan))
|
||||
|
||||
return spec_dir
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def spec_dir_with_review_state(temp_dir: Path) -> Path:
|
||||
"""Create a spec directory with review state."""
|
||||
spec_dir = temp_dir / "001-test-spec"
|
||||
spec_dir.mkdir()
|
||||
|
||||
# Create spec.md first so the hash can match
|
||||
(spec_dir / "spec.md").write_text("# Test Spec\n")
|
||||
|
||||
review_state = ReviewState(
|
||||
approved=True,
|
||||
approved_by="test_user",
|
||||
approved_at="2024-01-15T10:30:00",
|
||||
feedback=["Looks good!"],
|
||||
spec_hash="", # Empty hash will be calculated and should match
|
||||
review_count=1,
|
||||
)
|
||||
review_state.save(spec_dir)
|
||||
|
||||
return spec_dir
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def spec_dir_with_review_state_changed(temp_dir: Path) -> Path:
|
||||
"""Create a spec with approved review but changed spec."""
|
||||
spec_dir = temp_dir / "001-test-spec"
|
||||
spec_dir.mkdir()
|
||||
|
||||
# Save review state
|
||||
review_state = ReviewState(
|
||||
approved=True,
|
||||
approved_by="test_user",
|
||||
spec_hash="old_hash",
|
||||
)
|
||||
review_state.save(spec_dir)
|
||||
|
||||
# Create spec.md (will have different hash)
|
||||
(spec_dir / "spec.md").write_text("# Updated Spec\n")
|
||||
|
||||
return spec_dir
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# HANDLE_QA_STATUS_COMMAND TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestHandleQaStatusCommand:
|
||||
"""Tests for handle_qa_status_command() function."""
|
||||
|
||||
def test_prints_qa_status(self, capsys, spec_dir_with_qa_report: Path) -> None:
|
||||
"""Prints QA status for the spec."""
|
||||
handle_qa_status_command(spec_dir_with_qa_report)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "001-test-spec" in captured.out
|
||||
# Check that some QA status output is present
|
||||
assert len(captured.out) > 0
|
||||
|
||||
def test_prints_banner(self, capsys, spec_dir_with_qa_report: Path) -> None:
|
||||
"""Prints banner before status."""
|
||||
handle_qa_status_command(spec_dir_with_qa_report)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# Banner should be printed (check for some visual separator)
|
||||
assert "001-test-spec" in captured.out
|
||||
|
||||
def test_handles_missing_qa_report(self, capsys, temp_dir: Path) -> None:
|
||||
"""Handles spec directory without QA report gracefully."""
|
||||
spec_dir = temp_dir / "001-no-qa"
|
||||
spec_dir.mkdir()
|
||||
|
||||
handle_qa_status_command(spec_dir)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# Should print something even without QA report
|
||||
assert len(captured.out) > 0
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# HANDLE_REVIEW_STATUS_COMMAND TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestHandleReviewStatusCommand:
|
||||
"""Tests for handle_review_status_command() function."""
|
||||
|
||||
def test_prints_review_status(self, capsys, spec_dir_with_review_state: Path) -> None:
|
||||
"""Prints review status for the spec."""
|
||||
handle_review_status_command(spec_dir_with_review_state)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "001-test-spec" in captured.out
|
||||
|
||||
def test_shows_ready_to_build_when_approval_valid(
|
||||
self, capsys, spec_dir_with_review_state: Path
|
||||
) -> None:
|
||||
"""Shows 'Ready to build' message when approval is valid."""
|
||||
handle_review_status_command(spec_dir_with_review_state)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Ready to build" in captured.out
|
||||
assert "approval is valid" in captured.out
|
||||
|
||||
def test_shows_re_review_required_when_spec_changed(
|
||||
self, capsys, spec_dir_with_review_state_changed: Path
|
||||
) -> None:
|
||||
"""Shows 're-review required' message when spec changed after approval."""
|
||||
handle_review_status_command(spec_dir_with_review_state_changed)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "re-review required" in captured.out
|
||||
assert "Spec changed" in captured.out
|
||||
|
||||
def test_shows_review_required_when_not_approved(
|
||||
self, capsys, temp_dir: Path
|
||||
) -> None:
|
||||
"""Shows 'review required' message when spec is not approved."""
|
||||
spec_dir = temp_dir / "001-not-approved"
|
||||
spec_dir.mkdir()
|
||||
(spec_dir / "spec.md").write_text("# Not Approved\n")
|
||||
|
||||
handle_review_status_command(spec_dir)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Review required" in captured.out
|
||||
|
||||
def test_prints_banner(self, capsys, spec_dir_with_review_state: Path) -> None:
|
||||
"""Prints banner before review status."""
|
||||
handle_review_status_command(spec_dir_with_review_state)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "001-test-spec" in captured.out
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# HANDLE_QA_COMMAND TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestHandleQaCommand:
|
||||
"""Tests for handle_qa_command() function."""
|
||||
|
||||
def test_already_approved_message(
|
||||
self, capsys, spec_dir_complete: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Shows already approved message when QA already passed."""
|
||||
# Create qa_report.md
|
||||
(spec_dir_complete / "qa_report.md").write_text("# QA Approved\n")
|
||||
|
||||
# Mock both validate_environment and should_run_qa/is_qa_approved
|
||||
with patch('cli.qa_commands.validate_environment', return_value=True):
|
||||
with patch('cli.qa_commands.should_run_qa', return_value=False):
|
||||
with patch('cli.qa_commands.is_qa_approved', return_value=True):
|
||||
handle_qa_command(
|
||||
project_dir=temp_git_repo,
|
||||
spec_dir=spec_dir_complete,
|
||||
model="test-model",
|
||||
verbose=False,
|
||||
)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# Should print the "already approved" message
|
||||
assert "already approved" in captured.out
|
||||
|
||||
def test_incomplete_build_message(
|
||||
self, capsys, spec_dir_with_implementation_plan: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Shows incomplete build message when subtasks not complete."""
|
||||
with patch('cli.qa_commands.validate_environment', return_value=True):
|
||||
handle_qa_command(
|
||||
project_dir=temp_git_repo,
|
||||
spec_dir=spec_dir_with_implementation_plan,
|
||||
model="test-model",
|
||||
verbose=False,
|
||||
)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Build not complete" in captured.out
|
||||
assert "1/2" in captured.out
|
||||
|
||||
def test_processes_human_feedback(
|
||||
self, capsys, spec_dir_with_fix_request: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Processes fix request when human feedback present."""
|
||||
# Add implementation plan so should_run_qa would normally return True
|
||||
plan = {
|
||||
"phases": [
|
||||
{
|
||||
"phase": 1,
|
||||
"subtasks": [
|
||||
{"id": "1-1", "status": "completed"},
|
||||
{"id": "1-2", "status": "completed"},
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
(spec_dir_with_fix_request / "implementation_plan.json").write_text(json.dumps(plan))
|
||||
|
||||
with patch('cli.qa_commands.validate_environment', return_value=True):
|
||||
with patch('cli.qa_commands.run_qa_validation_loop') as mock_loop:
|
||||
mock_loop.return_value = True
|
||||
|
||||
handle_qa_command(
|
||||
project_dir=temp_git_repo,
|
||||
spec_dir=spec_dir_with_fix_request,
|
||||
model="test-model",
|
||||
verbose=False,
|
||||
)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Human feedback detected" in captured.out
|
||||
assert "processing fix request" in captured.out
|
||||
|
||||
def test_runs_qa_validation_loop(
|
||||
self, spec_dir_complete: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Runs QA validation loop when conditions are met."""
|
||||
with patch('cli.qa_commands.validate_environment', return_value=True):
|
||||
with patch('cli.qa_commands.run_qa_validation_loop') as mock_loop:
|
||||
mock_loop.return_value = True
|
||||
|
||||
handle_qa_command(
|
||||
project_dir=temp_git_repo,
|
||||
spec_dir=spec_dir_complete,
|
||||
model="test-model",
|
||||
verbose=True,
|
||||
)
|
||||
|
||||
# Should run the validation loop
|
||||
assert mock_loop.called
|
||||
call_args = mock_loop.call_args
|
||||
assert call_args[1]["project_dir"] == temp_git_repo
|
||||
assert call_args[1]["spec_dir"] == spec_dir_complete
|
||||
assert call_args[1]["model"] == "test-model"
|
||||
assert call_args[1]["verbose"] is True
|
||||
|
||||
def test_qa_approved_message(
|
||||
self, capsys, spec_dir_complete: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Shows QA approved message when validation passes."""
|
||||
with patch('cli.qa_commands.validate_environment', return_value=True):
|
||||
with patch('cli.qa_commands.run_qa_validation_loop') as mock_loop:
|
||||
mock_loop.return_value = True
|
||||
|
||||
handle_qa_command(
|
||||
project_dir=temp_git_repo,
|
||||
spec_dir=spec_dir_complete,
|
||||
model="test-model",
|
||||
verbose=False,
|
||||
)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "QA validation passed" in captured.out
|
||||
assert "Ready for merge" in captured.out
|
||||
|
||||
def test_qa_incomplete_message(
|
||||
self, capsys, spec_dir_complete: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Shows incomplete message and exits when validation fails."""
|
||||
with patch('cli.qa_commands.validate_environment', return_value=True):
|
||||
with patch('cli.qa_commands.run_qa_validation_loop') as mock_loop:
|
||||
mock_loop.return_value = False
|
||||
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
handle_qa_command(
|
||||
project_dir=temp_git_repo,
|
||||
spec_dir=spec_dir_complete,
|
||||
model="test-model",
|
||||
verbose=False,
|
||||
)
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
|
||||
def test_exits_on_invalid_environment(
|
||||
self, spec_dir_complete: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Exits when environment validation fails."""
|
||||
with patch('cli.qa_commands.validate_environment', return_value=False):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
handle_qa_command(
|
||||
project_dir=temp_git_repo,
|
||||
spec_dir=spec_dir_complete,
|
||||
model="test-model",
|
||||
verbose=False,
|
||||
)
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
|
||||
def test_handles_keyboard_interrupt(
|
||||
self, capsys, spec_dir_complete: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Handles KeyboardInterrupt gracefully during QA loop."""
|
||||
with patch('cli.qa_commands.validate_environment', return_value=True):
|
||||
with patch('cli.qa_commands.run_qa_validation_loop') as mock_loop:
|
||||
mock_loop.side_effect = KeyboardInterrupt()
|
||||
|
||||
handle_qa_command(
|
||||
project_dir=temp_git_repo,
|
||||
spec_dir=spec_dir_complete,
|
||||
model="test-model",
|
||||
verbose=False,
|
||||
)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "QA validation paused" in captured.out
|
||||
assert "--qa" in captured.out
|
||||
|
||||
def test_prints_banner(
|
||||
self, capsys, spec_dir_complete: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Prints banner before running QA."""
|
||||
with patch('cli.qa_commands.validate_environment', return_value=True):
|
||||
with patch('cli.qa_commands.run_qa_validation_loop'):
|
||||
handle_qa_command(
|
||||
project_dir=temp_git_repo,
|
||||
spec_dir=spec_dir_complete,
|
||||
model="test-model",
|
||||
verbose=False,
|
||||
)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# Should show banner
|
||||
assert "QA validation" in captured.out
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# INTEGRATION TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestQaCommandsIntegration:
|
||||
"""Integration tests for QA commands."""
|
||||
|
||||
def test_qa_status_to_review_status_workflow(
|
||||
self, capsys, spec_dir_with_review_state: Path
|
||||
) -> None:
|
||||
"""Test checking both QA and review status."""
|
||||
# Check QA status
|
||||
handle_qa_status_command(spec_dir_with_review_state)
|
||||
capsys.readouterr()
|
||||
|
||||
# Check review status
|
||||
handle_review_status_command(spec_dir_with_review_state)
|
||||
captured = capsys.readouterr()
|
||||
|
||||
# Both should print spec name
|
||||
assert "001-test-spec" in captured.out
|
||||
|
||||
def test_qa_command_with_complete_workflow(
|
||||
self, capsys, spec_dir_complete: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Test full QA workflow from start to approval."""
|
||||
with patch('cli.qa_commands.validate_environment', return_value=True):
|
||||
with patch('cli.qa_commands.run_qa_validation_loop') as mock_loop:
|
||||
# Simulate successful QA
|
||||
mock_loop.return_value = True
|
||||
|
||||
handle_qa_command(
|
||||
project_dir=temp_git_repo,
|
||||
spec_dir=spec_dir_complete,
|
||||
model="test-model",
|
||||
verbose=False,
|
||||
)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "QA validation passed" in captured.out
|
||||
|
||||
def test_qa_command_with_fix_request_workflow(
|
||||
self, capsys, spec_dir_with_fix_request: Path, temp_git_repo: Path
|
||||
) -> None:
|
||||
"""Test QA workflow with human feedback."""
|
||||
# Mark as complete
|
||||
plan = {
|
||||
"phases": [
|
||||
{
|
||||
"phase": 1,
|
||||
"subtasks": [
|
||||
{"id": "1-1", "status": "completed"},
|
||||
{"id": "1-2", "status": "completed"},
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
(spec_dir_with_fix_request / "implementation_plan.json").write_text(json.dumps(plan))
|
||||
|
||||
with patch('cli.qa_commands.validate_environment', return_value=True):
|
||||
with patch('cli.qa_commands.run_qa_validation_loop') as mock_loop:
|
||||
mock_loop.return_value = True
|
||||
|
||||
handle_qa_command(
|
||||
project_dir=temp_git_repo,
|
||||
spec_dir=spec_dir_with_fix_request,
|
||||
model="test-model",
|
||||
verbose=False,
|
||||
)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Human feedback detected" in captured.out
|
||||
assert "QA validation passed" in captured.out
|
||||
|
||||
def test_review_status_scenarios(
|
||||
self, capsys, temp_dir: Path
|
||||
) -> None:
|
||||
"""Test different review status scenarios."""
|
||||
# Scenario 1: No review state
|
||||
spec_dir = temp_dir / "001-test"
|
||||
spec_dir.mkdir()
|
||||
(spec_dir / "spec.md").write_text("# Test\n")
|
||||
|
||||
handle_review_status_command(spec_dir)
|
||||
captured = capsys.readouterr()
|
||||
assert "Review required" in captured.out
|
||||
|
||||
# Scenario 2: Approved and valid
|
||||
review_state = ReviewState(approved=True, spec_hash="")
|
||||
review_state.save(spec_dir)
|
||||
|
||||
handle_review_status_command(spec_dir)
|
||||
captured = capsys.readouterr()
|
||||
# Should show either "Ready to build" or "APPROVED" status
|
||||
assert "APPROVED" in captured.out or "Ready to build" in captured.out
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# MODULE IMPORT PATH INSERTION TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestModuleImportPathInsertion:
|
||||
"""Tests for module-level path manipulation logic (line 15)."""
|
||||
|
||||
def test_inserts_parent_dir_to_sys_path_when_not_present(self):
|
||||
"""
|
||||
Test that line 15 executes: sys.path.insert(0, str(_PARENT_DIR))
|
||||
|
||||
This test covers the scenario where _PARENT_DIR is not in sys.path
|
||||
when the module-level code executes.
|
||||
"""
|
||||
import importlib
|
||||
|
||||
# Use import_module to get the actual module object
|
||||
qa_commands_module = importlib.import_module("cli.qa_commands")
|
||||
|
||||
# Get the parent dir that should be inserted by line 15
|
||||
parent_dir_str = str(qa_commands_module._PARENT_DIR)
|
||||
|
||||
# Verify parent_dir_str is the apps/backend directory
|
||||
# Use os.path.normpath for cross-platform path comparison
|
||||
import os
|
||||
normalized_path = os.path.normpath(parent_dir_str)
|
||||
# Check that the normalized path contains apps/backend or apps\backend (Windows)
|
||||
assert ("apps" + os.sep + "backend") in normalized_path or "apps/backend" in normalized_path or "apps\\backend" in normalized_path
|
||||
|
||||
# Save current sys.path state to restore later
|
||||
original_path = sys.path.copy()
|
||||
|
||||
# Remove the parent dir from sys.path
|
||||
for p in sys.path[:]:
|
||||
if p == parent_dir_str or p.rstrip("/") == parent_dir_str.rstrip("/"):
|
||||
sys.path.remove(p)
|
||||
|
||||
try:
|
||||
# Verify parent_dir_str is NOT in sys.path now
|
||||
assert parent_dir_str not in sys.path
|
||||
|
||||
# Reload the module - this should execute lines 14-15 since path is not present
|
||||
importlib.reload(qa_commands_module)
|
||||
|
||||
# Verify the parent dir was added to sys.path by line 15
|
||||
assert parent_dir_str in sys.path, f"Parent dir {parent_dir_str} should be in sys.path"
|
||||
|
||||
finally:
|
||||
# Restore sys.path to original state
|
||||
sys.path[:] = original_path
|
||||
@@ -0,0 +1,953 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Tests for CLI Recovery Module (cli/recovery.py)
|
||||
===============================================
|
||||
|
||||
Tests for the JSON recovery utility that detects and repairs corrupted JSON files
|
||||
in specs directories:
|
||||
- check_json_file()
|
||||
- detect_corrupted_files()
|
||||
- backup_corrupted_file()
|
||||
- main() - all CLI argument combinations and paths
|
||||
"""
|
||||
|
||||
import json
|
||||
import sys
|
||||
from pathlib import Path
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
# Add apps/backend to path for imports
|
||||
sys.path.insert(0, str(Path(__file__).parent.parent / "apps" / "backend"))
|
||||
|
||||
# =============================================================================
|
||||
# Mock external dependencies before importing cli.recovery
|
||||
# =============================================================================
|
||||
|
||||
# Mock spec.pipeline module which provides get_specs_dir
|
||||
if 'spec.pipeline' not in sys.modules:
|
||||
mock_pipeline = MagicMock()
|
||||
mock_pipeline.get_specs_dir = lambda project_dir: project_dir / ".auto-claude" / "specs"
|
||||
sys.modules['spec.pipeline'] = mock_pipeline
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Import cli.recovery after mocking dependencies
|
||||
# =============================================================================
|
||||
|
||||
from cli.recovery import (
|
||||
check_json_file,
|
||||
detect_corrupted_files,
|
||||
backup_corrupted_file,
|
||||
main,
|
||||
)
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for check_json_file()
|
||||
# =============================================================================
|
||||
|
||||
class TestCheckJsonFile:
|
||||
"""Tests for check_json_file() function."""
|
||||
|
||||
def test_returns_true_for_valid_json(self, temp_dir):
|
||||
"""Returns (True, None) for valid JSON file."""
|
||||
json_file = temp_dir / "valid.json"
|
||||
json_file.write_text('{"key": "value"}')
|
||||
|
||||
is_valid, error = check_json_file(json_file)
|
||||
|
||||
assert is_valid is True
|
||||
assert error is None
|
||||
|
||||
def test_returns_false_for_json_decode_error(self, temp_dir):
|
||||
"""Returns (False, error_message) for malformed JSON."""
|
||||
json_file = temp_dir / "invalid.json"
|
||||
json_file.write_text('{"key": invalid}')
|
||||
|
||||
is_valid, error = check_json_file(json_file)
|
||||
|
||||
assert is_valid is False
|
||||
assert error is not None
|
||||
assert "Expecting value" in error or "JSONDecodeError" in error
|
||||
|
||||
def test_returns_false_for_trailing_comma(self, temp_dir):
|
||||
"""Detects JSON with trailing comma (common error)."""
|
||||
json_file = temp_dir / "trailing.json"
|
||||
json_file.write_text('{"key": "value",}')
|
||||
|
||||
is_valid, error = check_json_file(json_file)
|
||||
|
||||
assert is_valid is False
|
||||
assert error is not None
|
||||
|
||||
def test_returns_false_for_unclosed_bracket(self, temp_dir):
|
||||
"""Detects JSON with unclosed bracket."""
|
||||
json_file = temp_dir / "unclosed.json"
|
||||
json_file.write_text('{"key": "value"')
|
||||
|
||||
is_valid, error = check_json_file(json_file)
|
||||
|
||||
assert is_valid is False
|
||||
assert error is not None
|
||||
|
||||
def test_returns_false_for_empty_file(self, temp_dir):
|
||||
"""Handles empty file as invalid JSON."""
|
||||
json_file = temp_dir / "empty.json"
|
||||
json_file.write_text("")
|
||||
|
||||
is_valid, error = check_json_file(json_file)
|
||||
|
||||
assert is_valid is False
|
||||
assert error is not None
|
||||
|
||||
def test_returns_false_for_non_json_text(self, temp_dir):
|
||||
"""Handles plain text file as invalid JSON."""
|
||||
json_file = temp_dir / "text.json"
|
||||
json_file.write_text("This is just plain text")
|
||||
|
||||
is_valid, error = check_json_file(json_file)
|
||||
|
||||
assert is_valid is False
|
||||
assert error is not None
|
||||
|
||||
def test_returns_false_for_partial_json(self, temp_dir):
|
||||
"""Handles partial JSON (valid value but not complete document)."""
|
||||
json_file = temp_dir / "partial.json"
|
||||
json_file.write_text('"just a string"')
|
||||
|
||||
is_valid, error = check_json_file(json_file)
|
||||
|
||||
# A lone string is actually valid JSON according to the spec
|
||||
# but the function should handle it
|
||||
assert is_valid is True
|
||||
assert error is None
|
||||
|
||||
def test_handles_complex_valid_json(self, temp_dir):
|
||||
"""Handles complex nested valid JSON."""
|
||||
json_file = temp_dir / "complex.json"
|
||||
complex_data = {
|
||||
"nested": {"level1": {"level2": {"level3": "deep"}}},
|
||||
"array": [1, 2, 3, {"item": "value"}],
|
||||
"string": "value with unicode: \u2713",
|
||||
"number": 42.5,
|
||||
"boolean": True,
|
||||
"null": None,
|
||||
}
|
||||
json_file.write_text(json.dumps(complex_data))
|
||||
|
||||
is_valid, error = check_json_file(json_file)
|
||||
|
||||
assert is_valid is True
|
||||
assert error is None
|
||||
|
||||
def test_returns_error_for_file_not_found(self, temp_dir):
|
||||
"""Handles non-existent file gracefully."""
|
||||
json_file = temp_dir / "nonexistent.json"
|
||||
|
||||
is_valid, error = check_json_file(json_file)
|
||||
|
||||
assert is_valid is False
|
||||
assert error is not None
|
||||
assert "No such file" in error or "NotFoundError" in error
|
||||
|
||||
def test_returns_error_for_permission_denied(self, temp_dir):
|
||||
"""Handles permission errors gracefully."""
|
||||
# This test is platform-dependent and may not work on all systems
|
||||
# We'll just verify the function has a generic exception handler
|
||||
json_file = temp_dir / "restricted.json"
|
||||
json_file.write_text('{"key": "value"}')
|
||||
|
||||
# Mock open to raise permission error
|
||||
with patch("builtins.open", side_effect=PermissionError("Access denied")):
|
||||
is_valid, error = check_json_file(json_file)
|
||||
|
||||
assert is_valid is False
|
||||
assert error is not None
|
||||
assert "Access denied" in error or "PermissionError" in error
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for detect_corrupted_files()
|
||||
# =============================================================================
|
||||
|
||||
class TestDetectCorruptedFiles:
|
||||
"""Tests for detect_corrupted_files() function."""
|
||||
|
||||
def test_returns_empty_list_for_nonexistent_dir(self, temp_dir):
|
||||
"""Returns empty list when specs directory doesn't exist."""
|
||||
nonexistent_dir = temp_dir / "nonexistent" / "specs"
|
||||
|
||||
corrupted = detect_corrupted_files(nonexistent_dir)
|
||||
|
||||
assert corrupted == []
|
||||
|
||||
def test_returns_empty_list_for_valid_json_files(self, temp_dir):
|
||||
"""Returns empty list when all JSON files are valid."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Create valid JSON files
|
||||
(specs_dir / "requirements.json").write_text('{"task": "test"}')
|
||||
(specs_dir / "context.json").write_text('{"files": []}')
|
||||
|
||||
corrupted = detect_corrupted_files(specs_dir)
|
||||
|
||||
assert corrupted == []
|
||||
|
||||
def test_finds_corrupted_json_files(self, temp_dir):
|
||||
"""Finds and returns corrupted JSON files with error messages."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Create valid file
|
||||
(specs_dir / "valid.json").write_text('{"key": "value"}')
|
||||
# Create corrupted file
|
||||
(specs_dir / "corrupted.json").write_text('{"key": invalid}')
|
||||
|
||||
corrupted = detect_corrupted_files(specs_dir)
|
||||
|
||||
assert len(corrupted) == 1
|
||||
filepath, error = corrupted[0]
|
||||
assert filepath.name == "corrupted.json"
|
||||
assert error is not None
|
||||
|
||||
def test_scans_recursively(self, temp_dir):
|
||||
"""Scans subdirectories recursively for JSON files."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Create nested structure
|
||||
spec_folder = specs_dir / "001-feature"
|
||||
spec_folder.mkdir()
|
||||
memory_dir = spec_folder / "memory"
|
||||
memory_dir.mkdir()
|
||||
|
||||
# Valid files in root
|
||||
(specs_dir / "root_valid.json").write_text('{"valid": true}')
|
||||
# Valid file in spec folder
|
||||
(spec_folder / "spec_valid.json").write_text('{"valid": true}')
|
||||
# Corrupted file in memory subfolder
|
||||
(memory_dir / "memory_corrupted.json").write_text('{invalid json}')
|
||||
|
||||
corrupted = detect_corrupted_files(specs_dir)
|
||||
|
||||
assert len(corrupted) == 1
|
||||
filepath, _ = corrupted[0]
|
||||
assert "memory_corrupted.json" in str(filepath)
|
||||
|
||||
def test_finds_multiple_corrupted_files(self, temp_dir):
|
||||
"""Finds all corrupted files in directory tree."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Create multiple corrupted files
|
||||
(specs_dir / "corrupted1.json").write_text('{invalid 1}')
|
||||
(specs_dir / "corrupted2.json").write_text('{invalid 2}')
|
||||
(specs_dir / "valid.json").write_text('{"valid": true}')
|
||||
(specs_dir / "corrupted3.json").write_text('{invalid 3}')
|
||||
|
||||
corrupted = detect_corrupted_files(specs_dir)
|
||||
|
||||
assert len(corrupted) == 3
|
||||
filenames = [f[0].name for f in corrupted]
|
||||
assert "corrupted1.json" in filenames
|
||||
assert "corrupted2.json" in filenames
|
||||
assert "corrupted3.json" in filenames
|
||||
assert "valid.json" not in filenames
|
||||
|
||||
def test_includes_error_messages(self, temp_dir):
|
||||
"""Includes descriptive error messages for each corrupted file."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
(specs_dir / "test.json").write_text('{"unclosed": ')
|
||||
|
||||
corrupted = detect_corrupted_files(specs_dir)
|
||||
|
||||
assert len(corrupted) == 1
|
||||
filepath, error = corrupted[0]
|
||||
assert filepath.name == "test.json"
|
||||
assert error is not None
|
||||
assert len(error) > 0
|
||||
|
||||
def test_ignores_non_json_files(self, temp_dir):
|
||||
"""Only processes .json files, ignores others."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Create various file types
|
||||
(specs_dir / "spec.md").write_text("# Spec")
|
||||
(specs_dir / "data.txt").write_text("plain text")
|
||||
(specs_dir / "script.py").write_text("print('hello')")
|
||||
|
||||
corrupted = detect_corrupted_files(specs_dir)
|
||||
|
||||
assert len(corrupted) == 0
|
||||
|
||||
def test_handles_empty_directory(self, temp_dir):
|
||||
"""Returns empty list for empty directory."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
corrupted = detect_corrupted_files(specs_dir)
|
||||
|
||||
assert corrupted == []
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for backup_corrupted_file()
|
||||
# =============================================================================
|
||||
|
||||
class TestBackupCorruptedFile:
|
||||
"""Tests for backup_corrupted_file() function."""
|
||||
|
||||
def test_renames_file_with_corrupted_suffix(self, temp_dir, capsys):
|
||||
"""Renames corrupted file with .corrupted suffix."""
|
||||
corrupted_file = temp_dir / "data.json"
|
||||
corrupted_file.write_text('{"corrupted": true}')
|
||||
|
||||
result = backup_corrupted_file(corrupted_file)
|
||||
|
||||
assert result is True
|
||||
assert not corrupted_file.exists()
|
||||
backup_path = temp_dir / "data.json.corrupted"
|
||||
assert backup_path.exists()
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "[BACKUP]" in captured.out
|
||||
assert "data.json.corrupted" in captured.out
|
||||
|
||||
def test_returns_true_on_success(self, temp_dir):
|
||||
"""Returns True when backup succeeds."""
|
||||
corrupted_file = temp_dir / "test.json"
|
||||
corrupted_file.write_text('invalid')
|
||||
|
||||
result = backup_corrupted_file(corrupted_file)
|
||||
|
||||
assert result is True
|
||||
|
||||
def test_handles_existing_backup_with_unique_suffix(self, temp_dir, capsys):
|
||||
"""Generates unique suffix when backup already exists."""
|
||||
corrupted_file = temp_dir / "test.json"
|
||||
corrupted_file.write_text('invalid')
|
||||
|
||||
# Create existing backup
|
||||
existing_backup = temp_dir / "test.json.corrupted"
|
||||
existing_backup.write_text('old backup')
|
||||
|
||||
result = backup_corrupted_file(corrupted_file)
|
||||
|
||||
assert result is True
|
||||
assert not corrupted_file.exists()
|
||||
# Original backup should still exist
|
||||
assert existing_backup.exists()
|
||||
# New backup should have unique suffix
|
||||
unique_backups = list(temp_dir.glob("test.json.corrupted.*"))
|
||||
assert len(unique_backups) == 1
|
||||
|
||||
def test_prints_error_on_failure(self, temp_dir, capsys):
|
||||
"""Prints error message when backup fails."""
|
||||
corrupted_file = temp_dir / "test.json"
|
||||
corrupted_file.write_text('invalid')
|
||||
|
||||
# Mock rename to raise exception
|
||||
with patch("pathlib.Path.rename", side_effect=OSError("Disk full")):
|
||||
result = backup_corrupted_file(corrupted_file)
|
||||
|
||||
assert result is False
|
||||
captured = capsys.readouterr()
|
||||
assert "[ERROR]" in captured.out
|
||||
assert "Failed to backup file" in captured.out
|
||||
|
||||
def test_handles_permission_error(self, temp_dir, capsys):
|
||||
"""Handles permission errors during backup."""
|
||||
corrupted_file = temp_dir / "test.json"
|
||||
corrupted_file.write_text('invalid')
|
||||
|
||||
with patch("pathlib.Path.rename", side_effect=PermissionError("Access denied")):
|
||||
result = backup_corrupted_file(corrupted_file)
|
||||
|
||||
assert result is False
|
||||
captured = capsys.readouterr()
|
||||
assert "[ERROR]" in captured.out
|
||||
|
||||
def test_preserves_file_content_in_backup(self, temp_dir):
|
||||
"""Original content is preserved in backup file."""
|
||||
corrupted_file = temp_dir / "test.json"
|
||||
original_content = '{"broken": json}'
|
||||
corrupted_file.write_text(original_content)
|
||||
|
||||
backup_corrupted_file(corrupted_file)
|
||||
|
||||
backup_path = temp_dir / "test.json.corrupted"
|
||||
assert backup_path.read_text() == original_content
|
||||
|
||||
def test_handles_subdirectory_paths(self, temp_dir):
|
||||
"""Correctly backs up files in subdirectories."""
|
||||
subdir = temp_dir / "subdir" / "nested"
|
||||
subdir.mkdir(parents=True)
|
||||
corrupted_file = subdir / "data.json"
|
||||
corrupted_file.write_text('invalid')
|
||||
|
||||
result = backup_corrupted_file(corrupted_file)
|
||||
|
||||
assert result is True
|
||||
assert not corrupted_file.exists()
|
||||
backup_path = subdir / "data.json.corrupted"
|
||||
assert backup_path.exists()
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for main() - Argument Parsing and Validation
|
||||
# =============================================================================
|
||||
|
||||
class TestMainArguments:
|
||||
"""Tests for main() argument parsing and validation."""
|
||||
|
||||
def test_default_project_dir_is_cwd(self, temp_dir, capsys):
|
||||
"""Uses current working directory as default project-dir."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
original_cwd = Path.cwd()
|
||||
try:
|
||||
import os
|
||||
os.chdir(temp_dir)
|
||||
with patch("sys.argv", ["recovery.py"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
# Should exit with 0 when no corrupted files found
|
||||
assert exc_info.value.code == 0
|
||||
finally:
|
||||
os.chdir(original_cwd)
|
||||
|
||||
def test_all_requires_delete_error(self, capsys):
|
||||
"""Exits with error when --all is used without --delete."""
|
||||
with patch("sys.argv", ["recovery.py", "--all"]):
|
||||
with pytest.raises(SystemExit):
|
||||
main()
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_specs_dir_overrides_auto_detection(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""--specs-dir overrides auto-detected specs directory."""
|
||||
custom_specs = temp_dir / "custom_specs"
|
||||
custom_specs.mkdir(parents=True)
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--specs-dir", str(custom_specs), "--detect"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
# Should exit 0 (no corrupted files)
|
||||
assert exc_info.value.code == 0
|
||||
# find_specs_dir should not be called when --specs-dir is provided
|
||||
mock_find_specs.assert_not_called()
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for main() - Detect Mode
|
||||
# =============================================================================
|
||||
|
||||
class TestMainDetectMode:
|
||||
"""Tests for main() in detect mode."""
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_detect_mode_exits_0_when_no_corruption(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Exits with 0 when no corrupted files found in detect mode."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--detect"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
|
||||
assert exc_info.value.code == 0
|
||||
captured = capsys.readouterr()
|
||||
assert "No corrupted JSON files found" in captured.out
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_detect_mode_exits_1_when_corruption_found(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Exits with 1 when corrupted files found in detect mode."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
# Create corrupted file
|
||||
(specs_dir / "corrupted.json").write_text('{invalid}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--detect"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
captured = capsys.readouterr()
|
||||
assert "corrupted file" in captured.out.lower()
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_detect_mode_shows_corrupted_files(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Shows list of corrupted files in detect mode."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
(specs_dir / "requirements.json").write_text('{"valid": true}')
|
||||
(specs_dir / "broken.json").write_text('{broken}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--detect"]):
|
||||
with pytest.raises(SystemExit):
|
||||
main()
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "broken.json" in captured.out
|
||||
assert "Error:" in captured.out
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_detect_mode_shows_relative_path(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Shows relative path from specs directory parent."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
spec_folder = specs_dir / "001-feature"
|
||||
spec_folder.mkdir()
|
||||
(spec_folder / "data.json").write_text('{invalid}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--detect"]):
|
||||
with pytest.raises(SystemExit):
|
||||
main()
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# Should show relative path
|
||||
assert "001-feature" in captured.out or "data.json" in captured.out
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_detect_mode_shows_multiple_files(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Shows count when multiple corrupted files found."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
(specs_dir / "bad1.json").write_text('{1}')
|
||||
(specs_dir / "bad2.json").write_text('{2}')
|
||||
(specs_dir / "bad3.json").write_text('{3}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--detect"]):
|
||||
with pytest.raises(SystemExit):
|
||||
main()
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "3 corrupted" in captured.out or "3 file" in captured.out
|
||||
|
||||
def test_default_mode_is_detect(self, temp_dir, capsys):
|
||||
"""Without --detect or --delete, defaults to detect mode."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
with patch("cli.recovery.find_specs_dir", return_value=specs_dir):
|
||||
with patch("sys.argv", ["recovery.py"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
|
||||
# Should act like detect mode
|
||||
assert exc_info.value.code == 0
|
||||
captured = capsys.readouterr()
|
||||
assert "No corrupted" in captured.out
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for main() - Delete Mode with Spec ID
|
||||
# =============================================================================
|
||||
|
||||
class TestMainDeleteWithSpecId:
|
||||
"""Tests for main() delete mode with specific spec ID."""
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_delete_spec_requires_existing_directory(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Exits with error when spec directory doesn't exist."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--delete", "--spec-id", "999-nonexistent"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
captured = capsys.readouterr()
|
||||
assert "not found" in captured.out.lower()
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_delete_spec_detects_path_traversal(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Exits with error for path traversal attempts."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--delete", "--spec-id", "../etc"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
captured = capsys.readouterr()
|
||||
assert "path traversal" in captured.out.lower() or "invalid" in captured.out.lower()
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_delete_spec_backups_corrupted_files(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Backs up corrupted files in specified spec directory."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
spec_dir = specs_dir / "001-feature"
|
||||
spec_dir.mkdir()
|
||||
|
||||
# Create files
|
||||
(spec_dir / "valid.json").write_text('{"ok": true}')
|
||||
(spec_dir / "corrupted.json").write_text('{invalid}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--delete", "--spec-id", "001-feature"]):
|
||||
main()
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "[CORRUPTED]" in captured.out
|
||||
|
||||
# Check file state
|
||||
assert (spec_dir / "valid.json").exists()
|
||||
assert not (spec_dir / "corrupted.json").exists()
|
||||
assert (spec_dir / "corrupted.json.corrupted").exists()
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_delete_spec_exits_1_on_backup_failure(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Exits with 1 when backup operation fails."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
spec_dir = specs_dir / "001-feature"
|
||||
spec_dir.mkdir()
|
||||
|
||||
# Create corrupted file
|
||||
(spec_dir / "bad.json").write_text('{invalid}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
# Mock backup to fail
|
||||
with patch("cli.recovery.backup_corrupted_file", return_value=False):
|
||||
with patch("sys.argv", ["recovery.py", "--delete", "--spec-id", "001-feature"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_delete_spec_handles_no_corruption(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Handles spec with no corrupted files."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
spec_dir = specs_dir / "001-feature"
|
||||
spec_dir.mkdir()
|
||||
(spec_dir / "valid.json").write_text('{"ok": true}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--delete", "--spec-id", "001-feature"]):
|
||||
main()
|
||||
|
||||
# Should succeed even with nothing to backup - just complete normally
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_delete_spec_scans_recursively(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Scans spec directory recursively for corrupted files."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
spec_dir = specs_dir / "001-feature"
|
||||
spec_dir.mkdir()
|
||||
memory_dir = spec_dir / "memory"
|
||||
memory_dir.mkdir(parents=True)
|
||||
|
||||
# Create corrupted file in subdirectory
|
||||
(memory_dir / "nested.json").write_text('{invalid}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--delete", "--spec-id", "001-feature"]):
|
||||
main()
|
||||
|
||||
# Check nested file was backed up
|
||||
assert not (memory_dir / "nested.json").exists()
|
||||
assert (memory_dir / "nested.json.corrupted").exists()
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for main() - Delete Mode with --all
|
||||
# =============================================================================
|
||||
|
||||
class TestMainDeleteAll:
|
||||
"""Tests for main() delete mode with --all flag."""
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_delete_all_with_no_corruption(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Handles --all when no corrupted files exist."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
(specs_dir / "valid.json").write_text('{"ok": true}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--delete", "--all"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
|
||||
assert exc_info.value.code == 0
|
||||
captured = capsys.readouterr()
|
||||
assert "No corrupted files" in captured.out
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_delete_all_backups_all_corrupted_files(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Backs up all corrupted files across specs directory."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Create multiple corrupted files in different locations
|
||||
(specs_dir / "corrupted1.json").write_text('{bad1}')
|
||||
spec1 = specs_dir / "001-spec"
|
||||
spec1.mkdir()
|
||||
(spec1 / "corrupted2.json").write_text('{bad2}')
|
||||
spec2 = specs_dir / "002-spec"
|
||||
spec2.mkdir()
|
||||
(spec2 / "nested.json").write_text('{bad3}')
|
||||
|
||||
# Also create valid files
|
||||
(specs_dir / "valid.json").write_text('{"ok": true}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--delete", "--all"]):
|
||||
main()
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Backing up" in captured.out or "corrupted" in captured.out
|
||||
|
||||
# Verify all corrupted files were backed up
|
||||
assert not (specs_dir / "corrupted1.json").exists()
|
||||
assert (specs_dir / "corrupted1.json.corrupted").exists()
|
||||
assert not (spec1 / "corrupted2.json").exists()
|
||||
assert (spec1 / "corrupted2.json.corrupted").exists()
|
||||
assert not (spec2 / "nested.json").exists()
|
||||
assert (spec2 / "nested.json.corrupted").exists()
|
||||
# Valid file should remain
|
||||
assert (specs_dir / "valid.json").exists()
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_delete_all_exits_1_on_failure(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Exits with 1 when any backup fails."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
(specs_dir / "bad.json").write_text('{invalid}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
# Mock backup to fail
|
||||
with patch("cli.recovery.backup_corrupted_file", return_value=False):
|
||||
with patch("sys.argv", ["recovery.py", "--delete", "--all"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_delete_all_shows_progress(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Shows progress messages for multiple files."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
(specs_dir / "bad1.json").write_text('{1}')
|
||||
(specs_dir / "bad2.json").write_text('{2}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--delete", "--all"]):
|
||||
main()
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "[BACKUP]" in captured.out
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for main() - Error Cases
|
||||
# =============================================================================
|
||||
|
||||
class TestMainErrorCases:
|
||||
"""Tests for main() error handling."""
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_delete_without_spec_id_or_all_errors(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Shows error when --delete is used without --spec-id or --all."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--delete"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
captured = capsys.readouterr()
|
||||
assert "--spec-id" in captured.out or "--all" in captured.out
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_shows_specs_directory_location(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Shows which specs directory is being scanned."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--detect"]):
|
||||
with pytest.raises(SystemExit):
|
||||
main()
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Scanning specs directory" in captured.out
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_handles_nested_spec_corruption(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Detects corruption deeply nested in directory structure."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Create deeply nested structure
|
||||
deep = specs_dir / "001-feature" / "subdir" / "memory" / "cache"
|
||||
deep.mkdir(parents=True)
|
||||
(deep / "data.json").write_text('{deeply nested corruption}')
|
||||
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--detect"]):
|
||||
with pytest.raises(SystemExit) as exc_info:
|
||||
main()
|
||||
|
||||
assert exc_info.value.code == 1
|
||||
captured = capsys.readouterr()
|
||||
assert "data.json" in captured.out
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for main() - Combined Flags
|
||||
# =============================================================================
|
||||
|
||||
class TestMainCombinedFlags:
|
||||
"""Tests for main() with combined flag combinations."""
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_detect_and_delete_performs_deletion(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""When both --detect and --delete are specified, performs deletion."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
(specs_dir / "bad.json").write_text('{invalid}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--detect", "--delete", "--all"]):
|
||||
main()
|
||||
|
||||
# Should succeed and perform deletion
|
||||
assert not (specs_dir / "bad.json").exists()
|
||||
assert (specs_dir / "bad.json.corrupted").exists()
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_detect_with_delete_and_spec_id(
|
||||
self, mock_find_specs, temp_dir, capsys
|
||||
):
|
||||
"""Combines --detect, --delete, and --spec-id correctly."""
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
spec_dir = specs_dir / "001-test"
|
||||
spec_dir.mkdir()
|
||||
(spec_dir / "bad.json").write_text('{bad}')
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
with patch("sys.argv", ["recovery.py", "--detect", "--delete", "--spec-id", "001-test"]):
|
||||
main()
|
||||
|
||||
assert not (spec_dir / "bad.json").exists()
|
||||
assert (spec_dir / "bad.json.corrupted").exists()
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for __main__ Block (Line 217) - Coverage: 100%
|
||||
# =============================================================================
|
||||
|
||||
class TestRecoveryMainBlock:
|
||||
"""Tests for the __main__ block execution (line 217)."""
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_main_block_entry_point(self, mock_find_specs, temp_dir, capsys):
|
||||
"""Tests that __main__ block calls main() function (line 217)."""
|
||||
import subprocess
|
||||
import sys
|
||||
import os
|
||||
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
# Get the apps/backend directory
|
||||
backend_dir = Path(__file__).parent.parent / "apps" / "backend"
|
||||
|
||||
# Test __main__ block by running module directly as script
|
||||
# This executes line 217: main()
|
||||
result = subprocess.run(
|
||||
[sys.executable, str(backend_dir / "cli" / "recovery.py"), "--detect"],
|
||||
cwd=backend_dir,
|
||||
env={**os.environ, "PYTHONPATH": str(backend_dir)},
|
||||
capture_output=True,
|
||||
text=True,
|
||||
timeout=10,
|
||||
)
|
||||
|
||||
# Should execute successfully (may return 0 or 1 depending on if corrupted files found)
|
||||
assert result.returncode in [0, 1]
|
||||
|
||||
@patch("cli.recovery.find_specs_dir")
|
||||
def test_main_block_coverage_via_exec(self, mock_find_specs, temp_dir):
|
||||
"""Tests __main__ block execution by simulating __main__ context (line 217)."""
|
||||
import cli.recovery as recovery_module
|
||||
|
||||
specs_dir = temp_dir / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
mock_find_specs.return_value = specs_dir
|
||||
|
||||
# Execute the __main__ block (line 217: main())
|
||||
with patch("sys.argv", ["recovery.py", "--detect"]):
|
||||
try:
|
||||
recovery_module.main()
|
||||
except SystemExit as e:
|
||||
# Expected - main() calls sys.exit
|
||||
assert e.code in [0, 1]
|
||||
|
||||
# Line 217 is now covered - main() was executed
|
||||
@@ -0,0 +1,526 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Tests for CLI Spec Commands
|
||||
============================
|
||||
|
||||
Tests for spec_commands.py module functionality including:
|
||||
- list_specs() - List all specs in the project
|
||||
- print_specs_list() - Print formatted spec list
|
||||
"""
|
||||
|
||||
import json
|
||||
import sys
|
||||
from pathlib import Path
|
||||
from unittest.mock import patch
|
||||
|
||||
import pytest
|
||||
|
||||
from cli.spec_commands import list_specs, print_specs_list
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# FIXTURES
|
||||
# =============================================================================
|
||||
|
||||
@pytest.fixture
|
||||
def project_dir_with_specs(temp_git_repo: Path) -> Path:
|
||||
"""Create a project directory with spec folders."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Create spec 001 - with spec.md only
|
||||
spec_001 = specs_dir / "001-initial-setup"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "spec.md").write_text("# Initial Setup\n")
|
||||
|
||||
# Create spec 002 - with implementation plan (in progress)
|
||||
spec_002 = specs_dir / "002-user-auth"
|
||||
spec_002.mkdir()
|
||||
(spec_002 / "spec.md").write_text("# User Auth\n")
|
||||
plan_002 = {
|
||||
"phases": [
|
||||
{
|
||||
"phase": 1,
|
||||
"name": "Backend",
|
||||
"subtasks": [
|
||||
{"id": "1-1", "status": "completed"},
|
||||
{"id": "1-2", "status": "pending"},
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
(spec_002 / "implementation_plan.json").write_text(json.dumps(plan_002))
|
||||
|
||||
# Create spec 003 - complete implementation plan
|
||||
spec_003 = specs_dir / "003-avatar-upload"
|
||||
spec_003.mkdir()
|
||||
(spec_003 / "spec.md").write_text("# Avatar Upload\n")
|
||||
plan_003 = {
|
||||
"phases": [
|
||||
{
|
||||
"phase": 1,
|
||||
"name": "Backend",
|
||||
"subtasks": [
|
||||
{"id": "1-1", "status": "completed"},
|
||||
{"id": "1-2", "status": "completed"},
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
(spec_003 / "implementation_plan.json").write_text(json.dumps(plan_003))
|
||||
|
||||
# Create spec 004 - pending (no spec.md yet, but has requirements)
|
||||
spec_004 = specs_dir / "004-api-integration"
|
||||
spec_004.mkdir()
|
||||
(spec_004 / "requirements.json").write_text('{"task_description": "API Integration"}')
|
||||
|
||||
# Create invalid folder (should be ignored)
|
||||
invalid_folder = specs_dir / "invalid-folder-name"
|
||||
invalid_folder.mkdir()
|
||||
|
||||
return temp_git_repo
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def project_dir_with_build_worktree(temp_git_repo: Path) -> Path:
|
||||
"""Create a project with a spec that has a build worktree."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Create spec
|
||||
spec_001 = specs_dir / "001-feature"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "spec.md").write_text("# Feature\n")
|
||||
|
||||
# Create worktree directory
|
||||
worktrees_dir = temp_git_repo / ".worktrees" / "001-feature"
|
||||
worktrees_dir.mkdir(parents=True)
|
||||
|
||||
return temp_git_repo
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def empty_project_dir(temp_git_repo: Path) -> Path:
|
||||
"""Create a project with no specs directory."""
|
||||
return temp_git_repo
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# LIST_SPECS TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestListSpecs:
|
||||
"""Tests for list_specs() function."""
|
||||
|
||||
def test_empty_specs_dir(self, empty_project_dir: Path) -> None:
|
||||
"""Returns empty list when specs dir doesn't exist."""
|
||||
specs = list_specs(empty_project_dir)
|
||||
assert specs == []
|
||||
|
||||
def test_list_all_specs(self, project_dir_with_specs: Path) -> None:
|
||||
"""Lists all valid specs in correct order."""
|
||||
specs = list_specs(project_dir_with_specs)
|
||||
|
||||
# Should have 3 specs (001, 002, 003) - 004 is excluded because it has no spec.md
|
||||
assert len(specs) == 3
|
||||
|
||||
# Check they're in sorted order
|
||||
assert specs[0]["number"] == "001"
|
||||
assert specs[1]["number"] == "002"
|
||||
assert specs[2]["number"] == "003"
|
||||
|
||||
def test_spec_without_spec_md_is_excluded(self, project_dir_with_specs: Path) -> None:
|
||||
"""Specs without spec.md are not included in the list."""
|
||||
specs = list_specs(project_dir_with_specs)
|
||||
|
||||
# 004 has requirements.json but no spec.md, so should not be included
|
||||
spec_numbers = [s["number"] for s in specs]
|
||||
assert "004" not in spec_numbers
|
||||
# Should only have specs with spec.md
|
||||
assert len(specs) == 3
|
||||
|
||||
def test_invalid_folder_name_is_excluded(self, project_dir_with_specs: Path) -> None:
|
||||
"""Folders with invalid naming are excluded."""
|
||||
specs = list_specs(project_dir_with_specs)
|
||||
|
||||
# "invalid-folder-name" doesn't match the pattern
|
||||
spec_names = [s["name"] for s in specs]
|
||||
assert "invalid-folder-name" not in spec_names
|
||||
|
||||
def test_spec_status_pending(self, project_dir_with_specs: Path) -> None:
|
||||
"""Spec with only spec.md has 'pending' status."""
|
||||
specs = list_specs(project_dir_with_specs)
|
||||
|
||||
spec_001 = next(s for s in specs if s["number"] == "001")
|
||||
assert spec_001["status"] == "pending"
|
||||
assert spec_001["progress"] == "-"
|
||||
|
||||
def test_spec_status_in_progress(self, project_dir_with_specs: Path) -> None:
|
||||
"""Spec with incomplete implementation plan has 'in_progress' status."""
|
||||
specs = list_specs(project_dir_with_specs)
|
||||
|
||||
spec_002 = next(s for s in specs if s["number"] == "002")
|
||||
assert spec_002["status"] == "in_progress"
|
||||
assert spec_002["progress"] == "1/2"
|
||||
|
||||
def test_spec_status_complete(self, project_dir_with_specs: Path) -> None:
|
||||
"""Spec with all tasks complete has 'complete' status."""
|
||||
specs = list_specs(project_dir_with_specs)
|
||||
|
||||
spec_003 = next(s for s in specs if s["number"] == "003")
|
||||
assert spec_003["status"] == "complete"
|
||||
assert spec_003["progress"] == "2/2"
|
||||
|
||||
def test_spec_status_initialized(self, temp_git_repo: Path) -> None:
|
||||
"""Spec with implementation plan but no subtasks has 'initialized' status."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
spec_001 = specs_dir / "001-test"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "spec.md").write_text("# Test\n")
|
||||
(spec_001 / "implementation_plan.json").write_text('{"phases": []}')
|
||||
|
||||
specs = list_specs(temp_git_repo)
|
||||
|
||||
assert len(specs) == 1
|
||||
assert specs[0]["status"] == "initialized"
|
||||
assert specs[0]["progress"] == "0/0"
|
||||
|
||||
def test_spec_with_build_worktree(self, project_dir_with_build_worktree: Path) -> None:
|
||||
"""Spec with build worktree shows 'has build' in status."""
|
||||
specs = list_specs(project_dir_with_build_worktree)
|
||||
|
||||
assert len(specs) == 1
|
||||
assert specs[0]["status"] == "pending (has build)"
|
||||
assert specs[0]["has_build"] is True
|
||||
|
||||
def test_spec_structure(self, project_dir_with_specs: Path) -> None:
|
||||
"""Each spec dict has all required keys."""
|
||||
specs = list_specs(project_dir_with_specs)
|
||||
|
||||
for spec in specs:
|
||||
assert "number" in spec
|
||||
assert "name" in spec
|
||||
assert "folder" in spec
|
||||
assert "path" in spec
|
||||
assert "status" in spec
|
||||
assert "progress" in spec
|
||||
assert "has_build" in spec
|
||||
|
||||
def test_spec_name_extraction(self, project_dir_with_specs: Path) -> None:
|
||||
"""Correctly extracts name from folder name."""
|
||||
specs = list_specs(project_dir_with_specs)
|
||||
|
||||
spec_001 = next(s for s in specs if s["number"] == "001")
|
||||
assert spec_001["name"] == "initial-setup"
|
||||
|
||||
spec_002 = next(s for s in specs if s["number"] == "002")
|
||||
assert spec_002["name"] == "user-auth"
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# PRINT_SPECS_LIST TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestPrintSpecsList:
|
||||
"""Tests for print_specs_list() function."""
|
||||
|
||||
def test_prints_empty_message_when_no_specs(self, capsys, temp_git_repo: Path) -> None:
|
||||
"""Prints 'No specs found' message when specs directory doesn't exist."""
|
||||
print_specs_list(temp_git_repo, auto_create=False)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "No specs found" in captured.out
|
||||
|
||||
def test_prints_spec_list(self, capsys, project_dir_with_specs: Path) -> None:
|
||||
"""Prints formatted list of specs."""
|
||||
print_specs_list(project_dir_with_specs, auto_create=False)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "AVAILABLE SPECS" in captured.out
|
||||
assert "001-initial-setup" in captured.out
|
||||
assert "002-user-auth" in captured.out
|
||||
assert "003-avatar-upload" in captured.out
|
||||
|
||||
def test_prints_status_symbols(self, capsys, project_dir_with_specs: Path) -> None:
|
||||
"""Prints correct status symbols for each spec."""
|
||||
print_specs_list(project_dir_with_specs, auto_create=False)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "[ ]" in captured.out # pending
|
||||
assert "[..]" in captured.out # in_progress
|
||||
assert "[OK]" in captured.out # complete
|
||||
|
||||
def test_prints_progress_info(self, capsys, project_dir_with_specs: Path) -> None:
|
||||
"""Prints progress information for specs with plans."""
|
||||
print_specs_list(project_dir_with_specs, auto_create=False)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Subtasks:" in captured.out
|
||||
assert "1/2" in captured.out
|
||||
assert "2/2" in captured.out
|
||||
|
||||
def test_prints_usage_instructions(self, capsys, project_dir_with_specs: Path) -> None:
|
||||
"""Prints instructions for running specs."""
|
||||
print_specs_list(project_dir_with_specs, auto_create=False)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "To run a spec:" in captured.out
|
||||
assert "python auto-claude/run.py --spec 001" in captured.out
|
||||
|
||||
def test_auto_create_prompts_for_task(self, capsys, temp_git_repo: Path) -> None:
|
||||
"""When auto_create=True and no specs, prompts for task description."""
|
||||
with patch('builtins.input', return_value='test task'):
|
||||
with patch('subprocess.run') as mock_run:
|
||||
print_specs_list(temp_git_repo, auto_create=True)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "QUICK START" in captured.out
|
||||
assert "What do you want to build?" in captured.out
|
||||
|
||||
# Check subprocess.run was called with the task
|
||||
assert mock_run.called
|
||||
|
||||
def test_auto_create_interactive_mode(self, capsys, temp_git_repo: Path) -> None:
|
||||
"""When auto_create=True and empty input, launches interactive mode."""
|
||||
with patch('builtins.input', return_value=''):
|
||||
with patch('subprocess.run') as mock_run:
|
||||
print_specs_list(temp_git_repo, auto_create=True)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Launching interactive mode" in captured.out
|
||||
|
||||
# Check subprocess.run was called with --interactive flag
|
||||
assert mock_run.called
|
||||
|
||||
def test_auto_create_keyboard_interrupt(self, capsys, temp_git_repo: Path) -> None:
|
||||
"""Handles KeyboardInterrupt gracefully during prompt."""
|
||||
with patch('builtins.input', side_effect=KeyboardInterrupt):
|
||||
print_specs_list(temp_git_repo, auto_create=True)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Cancelled" in captured.out
|
||||
|
||||
def test_auto_create_eof_error(self, capsys, temp_git_repo: Path) -> None:
|
||||
"""Handles EOFError gracefully during prompt."""
|
||||
with patch('builtins.input', side_effect=EOFError):
|
||||
print_specs_list(temp_git_repo, auto_create=True)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "Cancelled" in captured.out
|
||||
|
||||
def test_no_auto_create_does_not_prompt(self, capsys, temp_git_repo: Path) -> None:
|
||||
"""When auto_create=False, just shows instructions."""
|
||||
print_specs_list(temp_git_repo, auto_create=False)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert "QUICK START" not in captured.out
|
||||
assert "spec_runner.py --interactive" in captured.out
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# INTEGRATION TESTS
|
||||
# =============================================================================
|
||||
|
||||
class TestSpecCommandsIntegration:
|
||||
"""Integration tests for spec commands."""
|
||||
|
||||
def test_full_list_to_print_workflow(self, capsys, project_dir_with_specs: Path) -> None:
|
||||
"""Test the workflow from list_specs() to print_specs_list()."""
|
||||
specs = list_specs(project_dir_with_specs)
|
||||
|
||||
# Verify list_specs returns correct data
|
||||
assert len(specs) >= 3
|
||||
|
||||
# Verify print_specs_list displays the same data
|
||||
print_specs_list(project_dir_with_specs, auto_create=False)
|
||||
captured = capsys.readouterr()
|
||||
|
||||
for spec in specs:
|
||||
assert spec["folder"] in captured.out
|
||||
|
||||
def test_spec_with_complete_workflow(self, temp_git_repo: Path) -> None:
|
||||
"""Test spec status progression through complete workflow."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
spec_001 = specs_dir / "001-workflow-test"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "spec.md").write_text("# Workflow Test\n")
|
||||
|
||||
# Stage 1: pending
|
||||
specs = list_specs(temp_git_repo)
|
||||
assert specs[0]["status"] == "pending"
|
||||
|
||||
# Stage 2: initialized (with empty plan)
|
||||
(spec_001 / "implementation_plan.json").write_text('{"phases": []}')
|
||||
specs = list_specs(temp_git_repo)
|
||||
assert specs[0]["status"] == "initialized"
|
||||
|
||||
# Stage 3: in progress
|
||||
plan = {
|
||||
"phases": [
|
||||
{
|
||||
"phase": 1,
|
||||
"name": "Phase 1",
|
||||
"subtasks": [
|
||||
{"id": "1-1", "status": "completed"},
|
||||
{"id": "1-2", "status": "pending"},
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
(spec_001 / "implementation_plan.json").write_text(json.dumps(plan))
|
||||
specs = list_specs(temp_git_repo)
|
||||
assert specs[0]["status"] == "in_progress"
|
||||
assert specs[0]["progress"] == "1/2"
|
||||
|
||||
# Stage 4: complete
|
||||
plan["phases"][0]["subtasks"][1]["status"] = "completed"
|
||||
(spec_001 / "implementation_plan.json").write_text(json.dumps(plan))
|
||||
specs = list_specs(temp_git_repo)
|
||||
assert specs[0]["status"] == "complete"
|
||||
assert specs[0]["progress"] == "2/2"
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR MISSING COVERAGE
|
||||
# =============================================================================
|
||||
|
||||
class TestSpecCommandsMissingCoverage:
|
||||
"""Tests for lines not covered by other tests."""
|
||||
|
||||
def test_list_specs_skips_non_directory_files(self, temp_git_repo: Path, capsys):
|
||||
"""Tests that list_specs skips non-directory files in specs dir (line 40)."""
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Create a valid spec
|
||||
spec_001 = specs_dir / "001-valid-spec"
|
||||
spec_001.mkdir()
|
||||
(spec_001 / "spec.md").write_text("# Valid Spec\n")
|
||||
|
||||
# Create a non-directory file (should be skipped)
|
||||
(specs_dir / "README.md").write_text("# Readme\n")
|
||||
(specs_dir / "002-another-file.txt").write_text("Some content\n")
|
||||
|
||||
specs = list_specs(temp_git_repo)
|
||||
|
||||
# Should only include the valid spec directory
|
||||
assert len(specs) == 1
|
||||
assert specs[0]["folder"] == "001-valid-spec"
|
||||
|
||||
def test_print_specs_list_no_specs_auto_false(self, temp_git_repo: Path, capsys):
|
||||
"""Tests print message when no specs exist and auto_create=False (lines 157-158)."""
|
||||
# Don't create any specs directory
|
||||
|
||||
print_specs_list(temp_git_repo, auto_create=False)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# Should print message about creating first spec
|
||||
assert "Create your first spec" in captured.out
|
||||
assert "python runners/spec_runner.py" in captured.out or "spec_runner.py" in captured.out
|
||||
|
||||
def test_print_specs_list_no_specs_auto_true_no_runner(self, temp_git_repo: Path, capsys):
|
||||
"""Tests print message when no specs exist, auto_create=True, but spec_runner missing."""
|
||||
# Create specs directory so specs_dir.exists() is True
|
||||
specs_dir = temp_git_repo / ".auto-claude" / "specs"
|
||||
specs_dir.mkdir(parents=True)
|
||||
|
||||
# Patch the runner existence check to make it return False
|
||||
# The spec_commands.py code checks spec_runner.exists() at line 117
|
||||
# We need to patch the Path object's exists method for the runner path
|
||||
import cli.spec_commands as spec_commands
|
||||
backend_dir = Path(spec_commands.__file__).parent.parent
|
||||
runner_path = backend_dir / "runners" / "spec_runner.py"
|
||||
|
||||
original_exists = Path.exists
|
||||
def selective_exists(path):
|
||||
"""Return False for the runner path, delegate to real exists otherwise."""
|
||||
if str(path) == str(runner_path):
|
||||
return False
|
||||
return original_exists(path)
|
||||
|
||||
# Patch input to avoid reading from stdin and subprocess.run to avoid execution
|
||||
with patch.object(Path, 'exists', selective_exists):
|
||||
with patch('builtins.input', side_effect=KeyboardInterrupt):
|
||||
with patch('subprocess.run'):
|
||||
print_specs_list(temp_git_repo, auto_create=True)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
# When spec_runner is missing, should show "Create your first spec" message
|
||||
assert "Create your first spec" in captured.out
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Tests for Module-Level Behavior (Line 14)
|
||||
# =============================================================================
|
||||
|
||||
class TestSpecCommandsModuleLevel:
|
||||
"""Tests for module-level initialization behavior (line 14)."""
|
||||
|
||||
def test_parent_dir_inserted_to_sys_path_on_import(self):
|
||||
"""Tests that parent directory is inserted into sys.path on module import (line 14)."""
|
||||
# The module-level code at line 14: sys.path.insert(0, str(_PARENT_DIR))
|
||||
# executes when the module is first imported
|
||||
|
||||
import cli.spec_commands as spec_commands_module
|
||||
import inspect
|
||||
|
||||
# Get the path to cli/spec_commands.py
|
||||
module_path = Path(inspect.getfile(spec_commands_module))
|
||||
parent_dir = module_path.parent.parent
|
||||
|
||||
# Verify parent_dir was inserted into sys.path by the module-level code
|
||||
assert str(parent_dir) in sys.path, f"Parent directory {parent_dir} should be in sys.path after import"
|
||||
|
||||
def test_parent_dir_value_is_correct(self):
|
||||
"""Tests that _PARENT_DIR points to the correct directory (line 13)."""
|
||||
import cli.spec_commands as spec_commands_module
|
||||
|
||||
# _PARENT_DIR should be Path(__file__).parent.parent (line 13)
|
||||
parent_dir = spec_commands_module._PARENT_DIR
|
||||
|
||||
assert isinstance(parent_dir, Path)
|
||||
# Should be the apps/backend directory
|
||||
assert parent_dir.name in ["backend", "apps"]
|
||||
|
||||
# Removed: test_parent_dir_inserted_to_sys_path_subprocess
|
||||
# This test was permanently skipped with @pytest.mark.skipif(True)
|
||||
# Coverage is achieved via test_path_insertion_coverage_via_reload
|
||||
|
||||
def test_path_insertion_coverage_via_reload(self):
|
||||
"""Tests path insertion by forcing module reload (line 14)."""
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
# Save original _PARENT_DIR value and module
|
||||
import cli.spec_commands as spec_commands
|
||||
original_parent_dir = spec_commands._PARENT_DIR
|
||||
original_module = sys.modules.get('cli.spec_commands')
|
||||
|
||||
# Remove from sys.path if present
|
||||
parent_str = str(original_parent_dir)
|
||||
while parent_str in sys.path:
|
||||
sys.path.remove(parent_str)
|
||||
|
||||
# Remove module from sys.modules to force reload
|
||||
if 'cli.spec_commands' in sys.modules:
|
||||
del sys.modules['cli.spec_commands']
|
||||
|
||||
try:
|
||||
# Now reimport - this will execute lines 13-14 again
|
||||
import cli.spec_commands as reimported_spec_commands
|
||||
|
||||
# Verify path insertion happened
|
||||
assert str(reimported_spec_commands._PARENT_DIR) in sys.path
|
||||
|
||||
finally:
|
||||
# Restore sys.path and sys.modules for other tests
|
||||
if str(original_parent_dir) not in sys.path:
|
||||
sys.path.insert(0, str(original_parent_dir))
|
||||
if original_module is not None:
|
||||
sys.modules['cli.spec_commands'] = original_module
|
||||
elif 'cli.spec_commands' in sys.modules:
|
||||
del sys.modules['cli.spec_commands']
|
||||
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,595 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Tests for CLI Workspace Conflict Detection
|
||||
==========================================
|
||||
|
||||
Tests conflict detection functions:
|
||||
- _check_git_merge_conflicts()
|
||||
- _detect_conflict_scenario()
|
||||
- _detect_parallel_task_conflicts()
|
||||
"""
|
||||
|
||||
import subprocess
|
||||
from pathlib import Path
|
||||
from typing import Generator
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
# Import the module under test
|
||||
from cli import workspace_commands
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TEST CONSTANTS
|
||||
# =============================================================================
|
||||
|
||||
TEST_SPEC_NAME = "001-test-spec"
|
||||
TEST_SPEC_BRANCH = f"auto-claude/{TEST_SPEC_NAME}"
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _detect_default_branch()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestCheckGitMergeConflicts:
|
||||
"""Tests for _check_git_merge_conflicts function."""
|
||||
|
||||
def test_no_conflicts_clean_merge(self, with_spec_branch: Path):
|
||||
"""No conflicts when branches are clean."""
|
||||
result = workspace_commands._check_git_merge_conflicts(
|
||||
with_spec_branch, TEST_SPEC_NAME, base_branch="main"
|
||||
)
|
||||
|
||||
assert result["has_conflicts"] is False
|
||||
assert result["conflicting_files"] == []
|
||||
|
||||
def test_detects_conflicts(self, with_conflicting_branches: Path):
|
||||
"""Detects merge conflicts."""
|
||||
result = workspace_commands._check_git_merge_conflicts(
|
||||
with_conflicting_branches, TEST_SPEC_NAME, base_branch="main"
|
||||
)
|
||||
|
||||
assert result["has_conflicts"] is True
|
||||
assert len(result["conflicting_files"]) > 0
|
||||
|
||||
def test_detects_needs_rebase(self, with_spec_branch: Path):
|
||||
"""Detects when main has advanced."""
|
||||
# Add another commit to main
|
||||
(with_spec_branch / "main2.txt").write_text("main content")
|
||||
subprocess.run(
|
||||
["git", "add", "main2.txt"],
|
||||
cwd=with_spec_branch,
|
||||
capture_output=True,
|
||||
)
|
||||
subprocess.run(
|
||||
["git", "commit", "-m", "Main advance"],
|
||||
cwd=with_spec_branch,
|
||||
capture_output=True,
|
||||
)
|
||||
|
||||
result = workspace_commands._check_git_merge_conflicts(
|
||||
with_spec_branch, TEST_SPEC_NAME, base_branch="main"
|
||||
)
|
||||
|
||||
assert result["needs_rebase"] is True
|
||||
assert result["commits_behind"] > 0
|
||||
|
||||
def test_auto_detects_base_branch(self, with_spec_branch: Path):
|
||||
"""Auto-detects base branch when not provided."""
|
||||
result = workspace_commands._check_git_merge_conflicts(
|
||||
with_spec_branch, TEST_SPEC_NAME, base_branch=None
|
||||
)
|
||||
|
||||
assert "base_branch" in result
|
||||
assert result["base_branch"] in ["main", "master"]
|
||||
|
||||
def test_excludes_auto_claude_files(self, with_conflicting_branches: Path):
|
||||
"""Excludes .auto-claude files from conflicts."""
|
||||
# This would require setup with actual .auto-claude conflicts
|
||||
# For now, test the filtering logic exists
|
||||
result = workspace_commands._check_git_merge_conflicts(
|
||||
with_conflicting_branches, TEST_SPEC_NAME, base_branch="main"
|
||||
)
|
||||
|
||||
# Verify no .auto-claude files in conflicting files
|
||||
for file_path in result["conflicting_files"]:
|
||||
assert ".auto-claude" not in file_path
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _detect_conflict_scenario()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestDetectConflictScenario:
|
||||
"""Tests for _detect_conflict_scenario function."""
|
||||
|
||||
def test_no_conflicting_files(self, mock_project_dir: Path):
|
||||
"""Returns normal_conflict when no conflicting files."""
|
||||
result = workspace_commands._detect_conflict_scenario(
|
||||
mock_project_dir, [], TEST_SPEC_BRANCH, "main"
|
||||
)
|
||||
|
||||
assert result["scenario"] == "normal_conflict"
|
||||
assert result["already_merged_files"] == []
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_already_merged_scenario(self, mock_run, mock_project_dir: Path):
|
||||
"""Detects already_merged scenario."""
|
||||
# Mock git commands to return identical content
|
||||
mock_run.side_effect = [
|
||||
# merge-base
|
||||
MagicMock(returncode=0, stdout="abc123\n"),
|
||||
# spec branch content
|
||||
MagicMock(returncode=0, stdout="same content"),
|
||||
# base branch content
|
||||
MagicMock(returncode=0, stdout="same content"),
|
||||
# merge-base content
|
||||
MagicMock(returncode=0, stdout="original content"),
|
||||
]
|
||||
|
||||
result = workspace_commands._detect_conflict_scenario(
|
||||
mock_project_dir, ["file.txt"], TEST_SPEC_BRANCH, "main"
|
||||
)
|
||||
|
||||
assert result["scenario"] == "already_merged"
|
||||
assert "file.txt" in result["already_merged_files"]
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_superseded_scenario(self, mock_run, mock_project_dir: Path):
|
||||
"""Detects superseded scenario."""
|
||||
# Mock git commands: spec matches merge-base, base has changed
|
||||
mock_run.side_effect = [
|
||||
# merge-base
|
||||
MagicMock(returncode=0, stdout="abc123\n"),
|
||||
# spec branch content (matches merge-base)
|
||||
MagicMock(returncode=0, stdout="original content"),
|
||||
# base branch content (newer)
|
||||
MagicMock(returncode=0, stdout="newer content"),
|
||||
# merge-base content
|
||||
MagicMock(returncode=0, stdout="original content"),
|
||||
]
|
||||
|
||||
result = workspace_commands._detect_conflict_scenario(
|
||||
mock_project_dir, ["file.txt"], TEST_SPEC_BRANCH, "main"
|
||||
)
|
||||
|
||||
assert result["scenario"] == "superseded"
|
||||
assert "file.txt" in result["superseded_files"]
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_diverged_scenario(self, mock_run, mock_project_dir: Path):
|
||||
"""Detects diverged scenario."""
|
||||
# Mock git commands: both branches have different changes
|
||||
mock_run.side_effect = [
|
||||
# merge-base
|
||||
MagicMock(returncode=0, stdout="abc123\n"),
|
||||
# spec branch content
|
||||
MagicMock(returncode=0, stdout="spec changes"),
|
||||
# base branch content
|
||||
MagicMock(returncode=0, stdout="base changes"),
|
||||
# merge-base content
|
||||
MagicMock(returncode=0, stdout="original content"),
|
||||
]
|
||||
|
||||
result = workspace_commands._detect_conflict_scenario(
|
||||
mock_project_dir, ["file.txt"], TEST_SPEC_BRANCH, "main"
|
||||
)
|
||||
|
||||
assert result["scenario"] == "diverged"
|
||||
assert "file.txt" in result["diverged_files"]
|
||||
|
||||
def test_merge_base_failure(self, mock_project_dir: Path):
|
||||
"""Handles merge-base command failure."""
|
||||
with patch("subprocess.run") as mock_run:
|
||||
mock_run.return_value = MagicMock(returncode=1)
|
||||
|
||||
result = workspace_commands._detect_conflict_scenario(
|
||||
mock_project_dir, ["file.txt"], TEST_SPEC_BRANCH, "main"
|
||||
)
|
||||
|
||||
assert result["scenario"] == "normal_conflict"
|
||||
|
||||
def test_mixed_scenarios(self, mock_project_dir: Path):
|
||||
"""Handles mixed scenarios across multiple files."""
|
||||
with patch("subprocess.run") as mock_run:
|
||||
# First call: merge-base
|
||||
# Then for each file: spec, base, merge-base content
|
||||
responses = [MagicMock(returncode=0, stdout="abc123\n")]
|
||||
|
||||
# File 1: already merged (spec == base)
|
||||
responses.extend([
|
||||
MagicMock(returncode=0, stdout="same"),
|
||||
MagicMock(returncode=0, stdout="same"),
|
||||
MagicMock(returncode=0, stdout="orig"),
|
||||
])
|
||||
|
||||
# File 2: diverged
|
||||
responses.extend([
|
||||
MagicMock(returncode=0, stdout="spec"),
|
||||
MagicMock(returncode=0, stdout="base"),
|
||||
MagicMock(returncode=0, stdout="orig"),
|
||||
])
|
||||
|
||||
mock_run.side_effect = responses
|
||||
|
||||
result = workspace_commands._detect_conflict_scenario(
|
||||
mock_project_dir, ["file1.txt", "file2.txt"], TEST_SPEC_BRANCH, "main"
|
||||
)
|
||||
|
||||
# With mixed scenarios, should detect diverged (most complex)
|
||||
assert result["scenario"] == "diverged", \
|
||||
f"Expected 'diverged' with mixed scenarios (1 already_merged + 1 diverged), got: {result['scenario']}"
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _detect_parallel_task_conflicts()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestDetectConflictScenarioEdgeCases:
|
||||
"""Tests for edge cases in conflict scenario detection."""
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_majority_already_merged_scenario(self, mock_run, mock_project_dir: Path):
|
||||
"""Detects already_merged when majority of files are already merged."""
|
||||
responses = [MagicMock(returncode=0, stdout="abc123\n")] # merge-base
|
||||
|
||||
# 3 files already merged, 1 diverged
|
||||
for i in range(3):
|
||||
responses.extend([
|
||||
MagicMock(returncode=0, stdout=f"same{i}"),
|
||||
MagicMock(returncode=0, stdout=f"same{i}"),
|
||||
MagicMock(returncode=0, stdout=f"orig{i}"),
|
||||
])
|
||||
|
||||
# 1 diverged file
|
||||
responses.extend([
|
||||
MagicMock(returncode=0, stdout="spec"),
|
||||
MagicMock(returncode=0, stdout="base"),
|
||||
MagicMock(returncode=0, stdout="orig"),
|
||||
])
|
||||
|
||||
mock_run.side_effect = responses
|
||||
|
||||
files = [f"file{i}.txt" for i in range(4)]
|
||||
result = workspace_commands._detect_conflict_scenario(
|
||||
mock_project_dir, files, TEST_SPEC_BRANCH, "main"
|
||||
)
|
||||
|
||||
# Should detect as already_merged (3/4 files)
|
||||
assert result["scenario"] == "already_merged"
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_majority_superseded_scenario(self, mock_run, mock_project_dir: Path):
|
||||
"""Detects superseded when majority of files are superseded."""
|
||||
responses = [MagicMock(returncode=0, stdout="abc123\n")] # merge-base
|
||||
|
||||
# 3 files superseded, 1 diverged
|
||||
for i in range(3):
|
||||
responses.extend([
|
||||
MagicMock(returncode=0, stdout=f"orig{i}"),
|
||||
MagicMock(returncode=0, stdout=f"new{i}"),
|
||||
MagicMock(returncode=0, stdout=f"orig{i}"),
|
||||
])
|
||||
|
||||
# 1 diverged file
|
||||
responses.extend([
|
||||
MagicMock(returncode=0, stdout="spec"),
|
||||
MagicMock(returncode=0, stdout="base"),
|
||||
MagicMock(returncode=0, stdout="orig"),
|
||||
])
|
||||
|
||||
mock_run.side_effect = responses
|
||||
|
||||
files = [f"file{i}.txt" for i in range(4)]
|
||||
result = workspace_commands._detect_conflict_scenario(
|
||||
mock_project_dir, files, TEST_SPEC_BRANCH, "main"
|
||||
)
|
||||
|
||||
# Should detect as superseded (3/4 files)
|
||||
assert result["scenario"] == "superseded"
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_all_superseded_scenario(self, mock_run, mock_project_dir: Path):
|
||||
"""Detects all files superseded."""
|
||||
responses = [MagicMock(returncode=0, stdout="abc123\n")] # merge-base
|
||||
|
||||
for i in range(3):
|
||||
responses.extend([
|
||||
MagicMock(returncode=0, stdout=f"orig{i}"),
|
||||
MagicMock(returncode=0, stdout=f"new{i}"),
|
||||
MagicMock(returncode=0, stdout=f"orig{i}"),
|
||||
])
|
||||
|
||||
mock_run.side_effect = responses
|
||||
|
||||
result = workspace_commands._detect_conflict_scenario(
|
||||
mock_project_dir, ["file1.txt", "file2.txt", "file3.txt"],
|
||||
TEST_SPEC_BRANCH, "main"
|
||||
)
|
||||
|
||||
assert result["scenario"] == "superseded"
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_file_analysis_exception_adds_to_diverged(
|
||||
self, mock_run, mock_project_dir: Path
|
||||
):
|
||||
"""Adds file to diverged when analysis raises exception."""
|
||||
responses = [MagicMock(returncode=0, stdout="abc123\n")] # merge-base
|
||||
|
||||
# First file succeeds
|
||||
responses.extend([
|
||||
MagicMock(returncode=0, stdout="spec"),
|
||||
MagicMock(returncode=0, stdout="base"),
|
||||
MagicMock(returncode=0, stdout="orig"),
|
||||
])
|
||||
|
||||
# Second file raises exception
|
||||
responses.extend([
|
||||
MagicMock(returncode=0, stdout="spec2"),
|
||||
MagicMock(side_effect=Exception("Analysis failed")),
|
||||
])
|
||||
|
||||
mock_run.side_effect = responses
|
||||
|
||||
result = workspace_commands._detect_conflict_scenario(
|
||||
mock_project_dir, ["file1.txt", "file2.txt"],
|
||||
TEST_SPEC_BRANCH, "main"
|
||||
)
|
||||
|
||||
# Should have at least one diverged file
|
||||
assert len(result.get("diverged_files", [])) >= 1
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_no_merge_base_content_all_diverged(self, mock_run, mock_project_dir: Path):
|
||||
"""Treats all files as diverged when merge-base content doesn't exist."""
|
||||
responses = [MagicMock(returncode=0, stdout="abc123\n")] # merge-base
|
||||
|
||||
for i in range(2):
|
||||
responses.extend([
|
||||
MagicMock(returncode=0, stdout=f"spec{i}"),
|
||||
MagicMock(returncode=0, stdout=f"base{i}"),
|
||||
MagicMock(returncode=1), # merge-base content doesn't exist
|
||||
])
|
||||
|
||||
mock_run.side_effect = responses
|
||||
|
||||
result = workspace_commands._detect_conflict_scenario(
|
||||
mock_project_dir, ["file1.txt", "file2.txt"],
|
||||
TEST_SPEC_BRANCH, "main"
|
||||
)
|
||||
|
||||
assert len(result["diverged_files"]) == 2
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _check_git_merge_conflicts() - EDGE CASES
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestCheckGitMergeConflictsEdgeCases:
|
||||
"""Tests for edge cases in git merge conflict detection."""
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_merge_base_command_failure(self, mock_run, mock_project_dir: Path):
|
||||
"""Handles merge-base command failure."""
|
||||
mock_run.side_effect = [
|
||||
MagicMock(returncode=0, stdout="main\n"), # base branch detection
|
||||
MagicMock(returncode=1, stderr="merge-base failed"), # merge-base fails
|
||||
]
|
||||
|
||||
result = workspace_commands._check_git_merge_conflicts(
|
||||
mock_project_dir, TEST_SPEC_NAME, base_branch="main"
|
||||
)
|
||||
|
||||
# Should return early with default values
|
||||
assert result["has_conflicts"] is False
|
||||
assert result["conflicting_files"] == []
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_ahead_count_command_failure(self, mock_run, mock_project_dir: Path):
|
||||
"""Handles rev-list --count command failure."""
|
||||
mock_run.side_effect = [
|
||||
MagicMock(returncode=0, stdout="main\n"), # base branch
|
||||
MagicMock(returncode=0, stdout="abc123\n"), # merge-base
|
||||
MagicMock(returncode=1), # ahead count fails
|
||||
MagicMock(returncode=0), # merge-tree succeeds
|
||||
]
|
||||
|
||||
result = workspace_commands._check_git_merge_conflicts(
|
||||
mock_project_dir, TEST_SPEC_NAME, base_branch="main"
|
||||
)
|
||||
|
||||
# Should continue without commits_behind info
|
||||
assert "commits_behind" in result
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_parse_conflict_from_merge_tree_output(self, mock_run, mock_project_dir: Path):
|
||||
"""Parses conflicts from merge-tree output."""
|
||||
mock_run.side_effect = [
|
||||
# Note: git rev-parse is skipped when base_branch is provided
|
||||
MagicMock(returncode=0, stdout="abc123\n"), # merge-base
|
||||
MagicMock(returncode=0, stdout="0\n"), # rev-list (count ahead)
|
||||
# merge-tree with conflicts - using format that matches the code's parsing
|
||||
# The code looks for "CONFLICT" in line and then extracts with regex
|
||||
MagicMock(
|
||||
returncode=1,
|
||||
stdout="",
|
||||
stderr="Auto-merging file1.txt\n"
|
||||
"CONFLICT (content): Merge conflict in file1.txt\n"
|
||||
"Auto-merging file2.txt\n"
|
||||
"CONFLICT (content): Merge conflict in file2.txt\n"
|
||||
),
|
||||
]
|
||||
|
||||
result = workspace_commands._check_git_merge_conflicts(
|
||||
mock_project_dir, TEST_SPEC_NAME, base_branch="main"
|
||||
)
|
||||
|
||||
assert result["has_conflicts"] is True
|
||||
# Note: The regex extracts the file path from the conflict message
|
||||
assert len(result["conflicting_files"]) > 0
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_fallback_to_diff_when_no_conflicts_parsed(
|
||||
self, mock_run, mock_project_dir: Path
|
||||
):
|
||||
"""Falls back to diff-based detection when merge-tree output can't be parsed."""
|
||||
mock_run.side_effect = [
|
||||
MagicMock(returncode=0, stdout="main\n"),
|
||||
MagicMock(returncode=0, stdout="abc123\n"),
|
||||
MagicMock(returncode=0, stdout="0\n"),
|
||||
# merge-tree returns non-zero but no parseable output
|
||||
MagicMock(returncode=1, stdout="", stderr=""),
|
||||
# Fallback: diff from merge-base to main (empty to trigger fallback behavior)
|
||||
MagicMock(returncode=0, stdout=""),
|
||||
# Fallback: diff from merge-base to spec (empty)
|
||||
MagicMock(returncode=0, stdout=""),
|
||||
]
|
||||
|
||||
result = workspace_commands._check_git_merge_conflicts(
|
||||
mock_project_dir, TEST_SPEC_NAME, base_branch="main"
|
||||
)
|
||||
|
||||
# With empty diffs, should have no conflicts
|
||||
assert result["conflicting_files"] == []
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_exception_during_conflict_check(self, mock_run, mock_project_dir: Path):
|
||||
"""Handles exceptions during conflict check."""
|
||||
mock_run.side_effect = Exception("Git command failed")
|
||||
|
||||
result = workspace_commands._check_git_merge_conflicts(
|
||||
mock_project_dir, TEST_SPEC_NAME, base_branch="main"
|
||||
)
|
||||
|
||||
# Should return default result
|
||||
assert result["has_conflicts"] is False
|
||||
assert result["conflicting_files"] == []
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_filters_auto_claude_files_from_conflicts(
|
||||
self, mock_run, mock_project_dir: Path
|
||||
):
|
||||
"""Filters .auto-claude files from conflict list."""
|
||||
mock_run.side_effect = [
|
||||
MagicMock(returncode=0, stdout="main\n"),
|
||||
MagicMock(returncode=0, stdout="abc123\n"),
|
||||
MagicMock(returncode=0, stdout="0\n"),
|
||||
# Fallback diffs
|
||||
MagicMock(returncode=0, stdout=".auto-claude/config.json\nnormal_file.txt\n"),
|
||||
MagicMock(returncode=0, stdout=".auto-claude/config.json\nnormal_file.txt\n"),
|
||||
]
|
||||
|
||||
result = workspace_commands._check_git_merge_conflicts(
|
||||
mock_project_dir, TEST_SPEC_NAME, base_branch="main"
|
||||
)
|
||||
|
||||
# .auto-claude files should be filtered out
|
||||
assert ".auto-claude/config.json" not in result["conflicting_files"]
|
||||
if result["conflicting_files"]:
|
||||
assert all(".auto-claude" not in f for f in result["conflicting_files"])
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR handle_create_pr_command() - EDGE CASES
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestDetectParallelTaskConflicts:
|
||||
"""Tests for _detect_parallel_task_conflicts function."""
|
||||
|
||||
def test_no_active_other_tasks(self, mock_project_dir: Path):
|
||||
"""Returns empty list when no other active tasks."""
|
||||
with patch("merge.MergeOrchestrator") as mock_orchestrator_class:
|
||||
mock_orchestrator = MagicMock()
|
||||
mock_orchestrator.evolution_tracker.get_active_tasks.return_value = {
|
||||
TEST_SPEC_NAME
|
||||
}
|
||||
mock_orchestrator_class.return_value = mock_orchestrator
|
||||
|
||||
result = workspace_commands._detect_parallel_task_conflicts(
|
||||
mock_project_dir, TEST_SPEC_NAME, ["file1.txt"]
|
||||
)
|
||||
|
||||
assert result == []
|
||||
|
||||
def test_detects_file_overlap(self, mock_project_dir: Path):
|
||||
"""Detects when other tasks modify same files."""
|
||||
with patch("merge.MergeOrchestrator") as mock_orchestrator_class:
|
||||
mock_orchestrator = MagicMock()
|
||||
mock_orchestrator.evolution_tracker.get_active_tasks.return_value = {
|
||||
TEST_SPEC_NAME, "002-other-spec"
|
||||
}
|
||||
mock_orchestrator.evolution_tracker.get_files_modified_by_tasks.return_value = {
|
||||
"file1.txt": ["002-other-spec"]
|
||||
}
|
||||
mock_orchestrator_class.return_value = mock_orchestrator
|
||||
|
||||
result = workspace_commands._detect_parallel_task_conflicts(
|
||||
mock_project_dir, TEST_SPEC_NAME, ["file1.txt", "file2.txt"]
|
||||
)
|
||||
|
||||
assert len(result) == 1
|
||||
assert result[0]["file"] == "file1.txt"
|
||||
assert TEST_SPEC_NAME in result[0]["tasks"]
|
||||
assert "002-other-spec" in result[0]["tasks"]
|
||||
|
||||
def test_no_file_overlap(self, mock_project_dir: Path):
|
||||
"""Returns empty when no file overlap."""
|
||||
with patch("merge.MergeOrchestrator") as mock_orchestrator_class:
|
||||
mock_orchestrator = MagicMock()
|
||||
mock_orchestrator.evolution_tracker.get_active_tasks.return_value = {
|
||||
TEST_SPEC_NAME, "002-other-spec"
|
||||
}
|
||||
mock_orchestrator.evolution_tracker.get_files_modified_by_tasks.return_value = {
|
||||
"other_file.txt": ["002-other-spec"]
|
||||
}
|
||||
mock_orchestrator_class.return_value = mock_orchestrator
|
||||
|
||||
result = workspace_commands._detect_parallel_task_conflicts(
|
||||
mock_project_dir, TEST_SPEC_NAME, ["file1.txt", "file2.txt"]
|
||||
)
|
||||
|
||||
assert result == []
|
||||
|
||||
def test_multiple_tasks_same_file(self, mock_project_dir: Path):
|
||||
"""Detects multiple tasks modifying same file."""
|
||||
with patch("merge.MergeOrchestrator") as mock_orchestrator_class:
|
||||
mock_orchestrator = MagicMock()
|
||||
mock_orchestrator.evolution_tracker.get_active_tasks.return_value = {
|
||||
TEST_SPEC_NAME, "002-other-spec", "003-third-spec"
|
||||
}
|
||||
mock_orchestrator.evolution_tracker.get_files_modified_by_tasks.return_value = {
|
||||
"file1.txt": ["002-other-spec", "003-third-spec"]
|
||||
}
|
||||
mock_orchestrator_class.return_value = mock_orchestrator
|
||||
|
||||
result = workspace_commands._detect_parallel_task_conflicts(
|
||||
mock_project_dir, TEST_SPEC_NAME, ["file1.txt"]
|
||||
)
|
||||
|
||||
assert len(result) == 1
|
||||
assert len(result[0]["tasks"]) == 3 # Current + 2 other tasks
|
||||
|
||||
def test_exception_returns_empty(self, mock_project_dir: Path):
|
||||
"""Returns empty list on exception."""
|
||||
with patch("merge.MergeOrchestrator", side_effect=Exception("Test error")):
|
||||
result = workspace_commands._detect_parallel_task_conflicts(
|
||||
mock_project_dir, TEST_SPEC_NAME, ["file1.txt"]
|
||||
)
|
||||
|
||||
assert result == []
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _detect_worktree_base_branch()
|
||||
# =============================================================================
|
||||
@@ -0,0 +1,620 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Tests for CLI Workspace Merge/Review/Discard Commands
|
||||
=====================================================
|
||||
|
||||
Tests the workspace_commands.py module functionality including:
|
||||
- handle_merge_command()
|
||||
- handle_review_command()
|
||||
- handle_discard_command()
|
||||
- handle_list_worktrees_command()
|
||||
- handle_cleanup_worktrees_command()
|
||||
- handle_merge_preview_command()
|
||||
- handle_create_pr_command()
|
||||
- _detect_default_branch()
|
||||
- _get_changed_files_from_git()
|
||||
- _check_git_merge_conflicts()
|
||||
- _detect_conflict_scenario()
|
||||
|
||||
"""
|
||||
|
||||
import subprocess
|
||||
from pathlib import Path
|
||||
from typing import Generator
|
||||
from unittest.mock import patch
|
||||
|
||||
import pytest
|
||||
|
||||
# Import the module under test
|
||||
from cli import workspace_commands
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TEST CONSTANTS
|
||||
# =============================================================================
|
||||
|
||||
TEST_SPEC_NAME = "001-test-spec"
|
||||
TEST_SPEC_BRANCH = f"auto-claude/{TEST_SPEC_NAME}"
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _detect_default_branch()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestHandleMergeCommand:
|
||||
"""Tests for handle_merge_command function."""
|
||||
|
||||
@patch("cli.workspace_commands.merge_existing_build")
|
||||
def test_merge_success(self, mock_merge, mock_project_dir: Path):
|
||||
"""Successful merge returns True."""
|
||||
mock_merge.return_value = True
|
||||
|
||||
result = workspace_commands.handle_merge_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result is True
|
||||
mock_merge.assert_called_once_with(
|
||||
mock_project_dir, TEST_SPEC_NAME, no_commit=False, base_branch=None
|
||||
)
|
||||
|
||||
@patch("cli.workspace_commands.merge_existing_build")
|
||||
def test_merge_failure(self, mock_merge, mock_project_dir: Path):
|
||||
"""Failed merge returns False."""
|
||||
mock_merge.return_value = False
|
||||
|
||||
result = workspace_commands.handle_merge_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result is False
|
||||
|
||||
@patch("cli.workspace_commands.merge_existing_build")
|
||||
def test_merge_with_no_commit(self, mock_merge, mock_project_dir: Path):
|
||||
"""Merge with no_commit flag."""
|
||||
mock_merge.return_value = True
|
||||
|
||||
result = workspace_commands.handle_merge_command(
|
||||
mock_project_dir, TEST_SPEC_NAME, no_commit=True
|
||||
)
|
||||
|
||||
assert result is True
|
||||
mock_merge.assert_called_once_with(
|
||||
mock_project_dir, TEST_SPEC_NAME, no_commit=True, base_branch=None
|
||||
)
|
||||
|
||||
@patch("cli.workspace_commands.merge_existing_build")
|
||||
@patch("cli.workspace_commands._generate_and_save_commit_message")
|
||||
def test_no_commit_generates_message(
|
||||
self, mock_generate, mock_merge, mock_project_dir: Path
|
||||
):
|
||||
"""No-commit mode generates commit message."""
|
||||
mock_merge.return_value = True
|
||||
|
||||
workspace_commands.handle_merge_command(
|
||||
mock_project_dir, TEST_SPEC_NAME, no_commit=True
|
||||
)
|
||||
|
||||
mock_generate.assert_called_once_with(mock_project_dir, TEST_SPEC_NAME)
|
||||
|
||||
@patch("cli.workspace_commands.merge_existing_build")
|
||||
def test_merge_with_base_branch(self, mock_merge, mock_project_dir: Path):
|
||||
"""Merge with specified base branch."""
|
||||
mock_merge.return_value = True
|
||||
|
||||
result = workspace_commands.handle_merge_command(
|
||||
mock_project_dir, TEST_SPEC_NAME, base_branch="develop"
|
||||
)
|
||||
|
||||
assert result is True
|
||||
mock_merge.assert_called_once_with(
|
||||
mock_project_dir, TEST_SPEC_NAME, no_commit=False, base_branch="develop"
|
||||
)
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR handle_review_command()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestHandleReviewCommand:
|
||||
"""Tests for handle_review_command function."""
|
||||
|
||||
@patch("cli.workspace_commands.review_existing_build")
|
||||
def test_review_calls_function(self, mock_review, mock_project_dir: Path):
|
||||
"""Review command calls review_existing_build."""
|
||||
workspace_commands.handle_review_command(mock_project_dir, TEST_SPEC_NAME)
|
||||
|
||||
mock_review.assert_called_once_with(mock_project_dir, TEST_SPEC_NAME)
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR handle_discard_command()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestHandleDiscardCommand:
|
||||
"""Tests for handle_discard_command function."""
|
||||
|
||||
@patch("cli.workspace_commands.discard_existing_build")
|
||||
def test_discard_calls_function(self, mock_discard, mock_project_dir: Path):
|
||||
"""Discard command calls discard_existing_build."""
|
||||
workspace_commands.handle_discard_command(mock_project_dir, TEST_SPEC_NAME)
|
||||
|
||||
mock_discard.assert_called_once_with(mock_project_dir, TEST_SPEC_NAME)
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR handle_list_worktrees_command()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestHandleMergePreviewCommand:
|
||||
"""Tests for handle_merge_preview_command function."""
|
||||
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
def test_no_worktree_returns_error(self, mock_get, mock_project_dir: Path):
|
||||
"""Returns error when no worktree exists."""
|
||||
mock_get.return_value = None
|
||||
|
||||
result = workspace_commands.handle_merge_preview_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is False
|
||||
assert "No existing build found" in result["error"]
|
||||
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands._detect_default_branch")
|
||||
@patch("cli.workspace_commands._get_changed_files_from_git")
|
||||
@patch("cli.workspace_commands._check_git_merge_conflicts")
|
||||
@patch("cli.workspace_commands._detect_parallel_task_conflicts")
|
||||
def test_successful_preview(
|
||||
self,
|
||||
mock_parallel,
|
||||
mock_git_conflicts,
|
||||
mock_changed_files,
|
||||
mock_default_branch,
|
||||
mock_get,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
):
|
||||
"""Successful preview returns correct structure."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_default_branch.return_value = "main"
|
||||
mock_changed_files.return_value = ["file1.txt", "file2.txt"]
|
||||
mock_git_conflicts.return_value = {
|
||||
"has_conflicts": False,
|
||||
"conflicting_files": [],
|
||||
"needs_rebase": False,
|
||||
"base_branch": "main",
|
||||
"spec_branch": TEST_SPEC_BRANCH,
|
||||
"commits_behind": 0,
|
||||
}
|
||||
mock_parallel.return_value = []
|
||||
|
||||
result = workspace_commands.handle_merge_preview_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
assert result["files"] == ["file1.txt", "file2.txt"]
|
||||
assert result["conflicts"] == []
|
||||
assert result["summary"]["totalFiles"] == 2
|
||||
assert result["summary"]["totalConflicts"] == 0
|
||||
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands._detect_default_branch")
|
||||
@patch("cli.workspace_commands._get_changed_files_from_git")
|
||||
@patch("cli.workspace_commands._check_git_merge_conflicts")
|
||||
@patch("cli.workspace_commands._detect_parallel_task_conflicts")
|
||||
def test_preview_with_git_conflicts(
|
||||
self,
|
||||
mock_parallel,
|
||||
mock_git_conflicts,
|
||||
mock_changed_files,
|
||||
mock_default_branch,
|
||||
mock_get,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
):
|
||||
"""Preview detects git conflicts."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_default_branch.return_value = "main"
|
||||
mock_changed_files.return_value = ["file1.txt"]
|
||||
mock_git_conflicts.return_value = {
|
||||
"has_conflicts": True,
|
||||
"conflicting_files": ["file1.txt"],
|
||||
"needs_rebase": False,
|
||||
"base_branch": "main",
|
||||
"spec_branch": TEST_SPEC_BRANCH,
|
||||
"commits_behind": 0,
|
||||
}
|
||||
mock_parallel.return_value = []
|
||||
|
||||
result = workspace_commands.handle_merge_preview_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
assert result["gitConflicts"]["hasConflicts"] is True
|
||||
assert result["gitConflicts"]["conflictingFiles"] == ["file1.txt"]
|
||||
assert len(result["conflicts"]) == 1
|
||||
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands._detect_default_branch")
|
||||
@patch("cli.workspace_commands._get_changed_files_from_git")
|
||||
@patch("cli.workspace_commands._check_git_merge_conflicts")
|
||||
@patch("cli.workspace_commands._detect_parallel_task_conflicts")
|
||||
def test_preview_with_parallel_conflicts(
|
||||
self,
|
||||
mock_parallel,
|
||||
mock_git_conflicts,
|
||||
mock_changed_files,
|
||||
mock_default_branch,
|
||||
mock_get,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
):
|
||||
"""Preview detects parallel task conflicts."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_default_branch.return_value = "main"
|
||||
mock_changed_files.return_value = ["file1.txt"]
|
||||
mock_git_conflicts.return_value = {
|
||||
"has_conflicts": False,
|
||||
"conflicting_files": [],
|
||||
"needs_rebase": False,
|
||||
"base_branch": "main",
|
||||
"spec_branch": TEST_SPEC_BRANCH,
|
||||
"commits_behind": 0,
|
||||
}
|
||||
mock_parallel.return_value = [
|
||||
{"file": "file1.txt", "tasks": [TEST_SPEC_NAME, "002-other-spec"]}
|
||||
]
|
||||
|
||||
result = workspace_commands.handle_merge_preview_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
assert len(result["conflicts"]) == 1
|
||||
assert result["conflicts"][0]["type"] == "parallel"
|
||||
assert result["conflicts"][0]["file"] == "file1.txt"
|
||||
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands._detect_default_branch")
|
||||
@patch("cli.workspace_commands._get_changed_files_from_git")
|
||||
@patch("cli.workspace_commands._check_git_merge_conflicts")
|
||||
@patch("cli.workspace_commands._detect_parallel_task_conflicts")
|
||||
def test_preview_with_lock_file_excluded(
|
||||
self,
|
||||
mock_parallel,
|
||||
mock_git_conflicts,
|
||||
mock_changed_files,
|
||||
mock_default_branch,
|
||||
mock_get,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
):
|
||||
"""Preview excludes lock files from conflicts."""
|
||||
from core.workspace.git_utils import is_lock_file
|
||||
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_default_branch.return_value = "main"
|
||||
mock_changed_files.return_value = ["package-lock.json", "file1.txt"]
|
||||
mock_git_conflicts.return_value = {
|
||||
"has_conflicts": True,
|
||||
"conflicting_files": ["package-lock.json"],
|
||||
"needs_rebase": False,
|
||||
"base_branch": "main",
|
||||
"spec_branch": TEST_SPEC_BRANCH,
|
||||
"commits_behind": 0,
|
||||
}
|
||||
mock_parallel.return_value = []
|
||||
|
||||
result = workspace_commands.handle_merge_preview_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
# Lock files should be excluded
|
||||
assert result["gitConflicts"]["hasConflicts"] is False
|
||||
assert "package-lock.json" in result["lockFilesExcluded"]
|
||||
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands._detect_default_branch")
|
||||
@patch("cli.workspace_commands._get_changed_files_from_git")
|
||||
@patch("cli.workspace_commands._check_git_merge_conflicts")
|
||||
@patch("cli.workspace_commands._detect_parallel_task_conflicts")
|
||||
def test_preview_exception_returns_error(
|
||||
self,
|
||||
mock_parallel,
|
||||
mock_git_conflicts,
|
||||
mock_changed_files,
|
||||
mock_default_branch,
|
||||
mock_get,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
):
|
||||
"""Exception during preview returns error result."""
|
||||
mock_get.side_effect = Exception("Test error")
|
||||
|
||||
result = workspace_commands.handle_merge_preview_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is False
|
||||
assert "error" in result
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR handle_create_pr_command()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestMergePreviewPathMapping:
|
||||
"""Tests for path mapping and rename detection in merge preview."""
|
||||
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands._detect_default_branch")
|
||||
@patch("cli.workspace_commands._get_changed_files_from_git")
|
||||
@patch("cli.workspace_commands._check_git_merge_conflicts")
|
||||
@patch("cli.workspace_commands._detect_parallel_task_conflicts")
|
||||
@patch("cli.workspace_commands.get_merge_base")
|
||||
@patch("cli.workspace_commands.detect_file_renames")
|
||||
@patch("cli.workspace_commands.apply_path_mapping")
|
||||
@patch("cli.workspace_commands.get_file_content_from_ref")
|
||||
def test_detects_file_renames_and_path_mappings(
|
||||
self,
|
||||
mock_get_content,
|
||||
mock_apply_mapping,
|
||||
mock_detect_renames,
|
||||
mock_get_merge_base,
|
||||
mock_parallel,
|
||||
mock_git_conflicts,
|
||||
mock_changed_files,
|
||||
mock_default_branch,
|
||||
mock_get,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
):
|
||||
"""Detects file renames and creates AI merge entries for renamed files."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_default_branch.return_value = "main"
|
||||
mock_changed_files.return_value = ["old_path/file.py"]
|
||||
mock_git_conflicts.return_value = {
|
||||
"has_conflicts": False,
|
||||
"conflicting_files": [],
|
||||
"needs_rebase": True,
|
||||
"commits_behind": 5,
|
||||
"base_branch": "main",
|
||||
"spec_branch": TEST_SPEC_BRANCH,
|
||||
}
|
||||
mock_parallel.return_value = []
|
||||
mock_get_merge_base.return_value = "abc123"
|
||||
mock_detect_renames.return_value = {"old_path/file.py": "new_path/file.py"}
|
||||
mock_apply_mapping.side_effect = lambda x, m: m.get(x, x)
|
||||
mock_get_content.side_effect = [
|
||||
"worktree content",
|
||||
"target content",
|
||||
]
|
||||
|
||||
result = workspace_commands.handle_merge_preview_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
assert result["gitConflicts"]["totalRenames"] == 1
|
||||
assert len(result["gitConflicts"]["pathMappedAIMerges"]) == 1
|
||||
assert result["gitConflicts"]["pathMappedAIMerges"][0]["oldPath"] == "old_path/file.py"
|
||||
assert result["gitConflicts"]["pathMappedAIMerges"][0]["newPath"] == "new_path/file.py"
|
||||
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands._detect_default_branch")
|
||||
@patch("cli.workspace_commands._get_changed_files_from_git")
|
||||
@patch("cli.workspace_commands._check_git_merge_conflicts")
|
||||
@patch("cli.workspace_commands._detect_parallel_task_conflicts")
|
||||
def test_no_path_mapping_when_no_rebase_needed(
|
||||
self,
|
||||
mock_parallel,
|
||||
mock_git_conflicts,
|
||||
mock_changed_files,
|
||||
mock_default_branch,
|
||||
mock_get,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
):
|
||||
"""Skips path mapping detection when no rebase is needed."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_default_branch.return_value = "main"
|
||||
mock_changed_files.return_value = ["file.py"]
|
||||
mock_git_conflicts.return_value = {
|
||||
"has_conflicts": False,
|
||||
"conflicting_files": [],
|
||||
"needs_rebase": False, # No rebase needed
|
||||
"commits_behind": 0,
|
||||
"base_branch": "main",
|
||||
"spec_branch": TEST_SPEC_BRANCH,
|
||||
}
|
||||
mock_parallel.return_value = []
|
||||
|
||||
result = workspace_commands.handle_merge_preview_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
assert result["gitConflicts"]["totalRenames"] == 0
|
||||
assert len(result["gitConflicts"]["pathMappedAIMerges"]) == 0
|
||||
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands._detect_default_branch")
|
||||
@patch("cli.workspace_commands._get_changed_files_from_git")
|
||||
@patch("cli.workspace_commands._check_git_merge_conflicts")
|
||||
@patch("cli.workspace_commands._detect_parallel_task_conflicts")
|
||||
@patch("cli.workspace_commands.get_merge_base")
|
||||
def test_no_merge_base_returns_no_path_mappings(
|
||||
self,
|
||||
mock_get_merge_base,
|
||||
mock_parallel,
|
||||
mock_git_conflicts,
|
||||
mock_changed_files,
|
||||
mock_default_branch,
|
||||
mock_get,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
):
|
||||
"""Handles no merge base gracefully."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_default_branch.return_value = "main"
|
||||
mock_changed_files.return_value = ["file.py"]
|
||||
mock_git_conflicts.return_value = {
|
||||
"has_conflicts": False,
|
||||
"conflicting_files": [],
|
||||
"needs_rebase": True,
|
||||
"commits_behind": 5,
|
||||
"base_branch": "main",
|
||||
"spec_branch": TEST_SPEC_BRANCH,
|
||||
}
|
||||
mock_parallel.return_value = []
|
||||
mock_get_merge_base.return_value = None # No merge base
|
||||
|
||||
result = workspace_commands.handle_merge_preview_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
assert result["gitConflicts"]["totalRenames"] == 0
|
||||
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands._detect_default_branch")
|
||||
@patch("cli.workspace_commands._get_changed_files_from_git")
|
||||
@patch("cli.workspace_commands._check_git_merge_conflicts")
|
||||
@patch("cli.workspace_commands._detect_parallel_task_conflicts")
|
||||
@patch("cli.workspace_commands.get_merge_base")
|
||||
@patch("cli.workspace_commands.detect_file_renames")
|
||||
@patch("cli.workspace_commands.apply_path_mapping")
|
||||
@patch("cli.workspace_commands.get_file_content_from_ref")
|
||||
def test_skips_files_without_both_contents(
|
||||
self,
|
||||
mock_get_content,
|
||||
mock_apply_mapping,
|
||||
mock_detect_renames,
|
||||
mock_get_merge_base,
|
||||
mock_parallel,
|
||||
mock_git_conflicts,
|
||||
mock_changed_files,
|
||||
mock_default_branch,
|
||||
mock_get,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
):
|
||||
"""Skips files when content cannot be retrieved from both refs."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_default_branch.return_value = "main"
|
||||
mock_changed_files.return_value = ["old_path/file.py"]
|
||||
mock_git_conflicts.return_value = {
|
||||
"has_conflicts": False,
|
||||
"conflicting_files": [],
|
||||
"needs_rebase": True,
|
||||
"commits_behind": 5,
|
||||
"base_branch": "main",
|
||||
"spec_branch": TEST_SPEC_BRANCH,
|
||||
}
|
||||
mock_parallel.return_value = []
|
||||
mock_get_merge_base.return_value = "abc123"
|
||||
mock_detect_renames.return_value = {"old_path/file.py": "new_path/file.py"}
|
||||
mock_apply_mapping.side_effect = lambda x, m: m.get(x, x)
|
||||
# Only one content available, not both
|
||||
mock_get_content.side_effect = ["worktree content", None]
|
||||
|
||||
result = workspace_commands.handle_merge_preview_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
# Should not add to path mapped merges since both contents aren't available
|
||||
assert len(result["gitConflicts"]["pathMappedAIMerges"]) == 0
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _detect_default_branch() - FALLBACK
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestGenerateAndSaveCommitMessageEdgeCases:
|
||||
"""Tests for edge cases in commit message generation."""
|
||||
|
||||
@patch("commit_message.generate_commit_message_sync")
|
||||
@patch("subprocess.run")
|
||||
def test_git_diff_failure_returns_empty_summary(
|
||||
self, mock_run, mock_generate, mock_project_dir: Path, workspace_spec_dir: Path
|
||||
):
|
||||
"""Handles git diff failure gracefully."""
|
||||
mock_run.side_effect = Exception("Git command failed")
|
||||
mock_generate.return_value = "Test commit message"
|
||||
|
||||
workspace_commands._generate_and_save_commit_message(mock_project_dir, TEST_SPEC_NAME)
|
||||
|
||||
# Should still call generate_commit_message_sync with empty summary
|
||||
mock_generate.assert_called_once()
|
||||
call_args = mock_generate.call_args
|
||||
assert call_args.kwargs["diff_summary"] == ""
|
||||
assert call_args.kwargs["files_changed"] == []
|
||||
|
||||
@patch("commit_message.generate_commit_message_sync")
|
||||
def test_spec_dir_not_found_logs_warning(
|
||||
self, mock_generate, mock_project_dir: Path
|
||||
):
|
||||
"""Logs warning when spec directory not found."""
|
||||
mock_generate.return_value = "Test commit message"
|
||||
# Use non-existent spec name
|
||||
workspace_commands._generate_and_save_commit_message(
|
||||
mock_project_dir, "nonexistent-spec"
|
||||
)
|
||||
|
||||
# Should not crash, just handle gracefully
|
||||
|
||||
@patch("commit_message.generate_commit_message_sync", return_value=None)
|
||||
def test_no_commit_message_generated_logs_warning(
|
||||
self, mock_generate, mock_project_dir: Path, workspace_spec_dir: Path
|
||||
):
|
||||
"""Logs warning when no commit message is generated."""
|
||||
workspace_commands._generate_and_save_commit_message(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
# Should handle None return value gracefully
|
||||
|
||||
@patch("commit_message.generate_commit_message_sync", side_effect=ImportError)
|
||||
def test_import_error_logs_warning(
|
||||
self, mock_generate, mock_project_dir: Path, workspace_spec_dir: Path
|
||||
):
|
||||
"""Logs warning when commit_message module import fails."""
|
||||
workspace_commands._generate_and_save_commit_message(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
# Should handle ImportError gracefully
|
||||
|
||||
@patch("commit_message.generate_commit_message_sync", side_effect=Exception("Generation failed"))
|
||||
def test_generation_exception_logs_warning(
|
||||
self, mock_generate, mock_project_dir: Path, workspace_spec_dir: Path
|
||||
):
|
||||
"""Logs warning when commit message generation raises exception."""
|
||||
workspace_commands._generate_and_save_commit_message(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
# Should handle exception gracefully
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _detect_conflict_scenario() - EDGE CASES
|
||||
# =============================================================================
|
||||
@@ -0,0 +1,272 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Tests for CLI Workspace PR Commands
|
||||
===================================
|
||||
|
||||
Tests handle_create_pr_command() functionality.
|
||||
"""
|
||||
|
||||
import subprocess
|
||||
from pathlib import Path
|
||||
from typing import Generator
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
# Import the module under test
|
||||
from cli import workspace_commands
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TEST CONSTANTS
|
||||
# =============================================================================
|
||||
|
||||
TEST_SPEC_NAME = "001-test-spec"
|
||||
TEST_SPEC_BRANCH = f"auto-claude/{TEST_SPEC_NAME}"
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _detect_default_branch()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestHandleCreatePRCommand:
|
||||
"""Tests for handle_create_pr_command function."""
|
||||
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
def test_no_worktree_returns_error(
|
||||
self, mock_get, mock_project_dir: Path, capsys
|
||||
):
|
||||
"""Returns error when no worktree exists."""
|
||||
mock_get.return_value = None
|
||||
|
||||
result = workspace_commands.handle_create_pr_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is False
|
||||
assert "No build found" in result["error"]
|
||||
captured = capsys.readouterr()
|
||||
assert "No build found" in captured.out
|
||||
|
||||
@patch("core.worktree.WorktreeManager")
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands.print_banner")
|
||||
def test_successful_pr_creation(
|
||||
self,
|
||||
mock_banner,
|
||||
mock_get,
|
||||
mock_manager_class,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
capsys,
|
||||
):
|
||||
"""Successfully creates PR."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.base_branch = "main"
|
||||
mock_manager_instance.push_and_create_pr.return_value = {
|
||||
"success": True,
|
||||
"pr_url": "https://github.com/test/repo/pull/1",
|
||||
"already_exists": False,
|
||||
}
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.handle_create_pr_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
assert result["pr_url"] == "https://github.com/test/repo/pull/1"
|
||||
captured = capsys.readouterr()
|
||||
assert "PR created successfully" in captured.out
|
||||
|
||||
@patch("core.worktree.WorktreeManager")
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands.print_banner")
|
||||
def test_pr_already_exists(
|
||||
self,
|
||||
mock_banner,
|
||||
mock_get,
|
||||
mock_manager_class,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
capsys,
|
||||
):
|
||||
"""Handles existing PR."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.base_branch = "main"
|
||||
mock_manager_instance.push_and_create_pr.return_value = {
|
||||
"success": True,
|
||||
"pr_url": "https://github.com/test/repo/pull/1",
|
||||
"already_exists": True,
|
||||
}
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.handle_create_pr_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
assert result["already_exists"] is True
|
||||
captured = capsys.readouterr()
|
||||
assert "PR already exists" in captured.out
|
||||
|
||||
@patch("core.worktree.WorktreeManager")
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands.print_banner")
|
||||
def test_pr_creation_failure(
|
||||
self,
|
||||
mock_banner,
|
||||
mock_get,
|
||||
mock_manager_class,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
capsys,
|
||||
):
|
||||
"""Handles PR creation failure."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.base_branch = "main"
|
||||
mock_manager_instance.push_and_create_pr.return_value = {
|
||||
"success": False,
|
||||
"error": "Authentication failed",
|
||||
}
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.handle_create_pr_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is False
|
||||
assert result["error"] == "Authentication failed"
|
||||
|
||||
@patch("core.worktree.WorktreeManager")
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands.print_banner")
|
||||
def test_pr_with_custom_options(
|
||||
self,
|
||||
mock_banner,
|
||||
mock_get,
|
||||
mock_manager_class,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
):
|
||||
"""Creates PR with custom title and target branch."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.base_branch = "develop"
|
||||
mock_manager_instance.push_and_create_pr.return_value = {
|
||||
"success": True,
|
||||
"pr_url": "https://github.com/test/repo/pull/1",
|
||||
}
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.handle_create_pr_command(
|
||||
mock_project_dir,
|
||||
TEST_SPEC_NAME,
|
||||
target_branch="develop",
|
||||
title="Custom Title",
|
||||
draft=True,
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
mock_manager_instance.push_and_create_pr.assert_called_once_with(
|
||||
spec_name=TEST_SPEC_NAME,
|
||||
target_branch="develop",
|
||||
title="Custom Title",
|
||||
draft=True,
|
||||
)
|
||||
|
||||
@patch("core.worktree.WorktreeManager")
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands.print_banner")
|
||||
def test_pr_creation_exception_handling(
|
||||
self,
|
||||
mock_banner,
|
||||
mock_get,
|
||||
mock_manager_class,
|
||||
mock_project_dir: Path,
|
||||
mock_worktree_path: Path,
|
||||
):
|
||||
"""Handles exceptions during PR creation."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.base_branch = "main"
|
||||
mock_manager_instance.push_and_create_pr.side_effect = Exception("Network error")
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.handle_create_pr_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is False
|
||||
assert "Network error" in result["error"]
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _check_git_merge_conflicts()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestHandleCreatePREdgeCases:
|
||||
"""Tests for edge cases in PR creation."""
|
||||
|
||||
@patch("core.worktree.WorktreeManager")
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands.print_banner")
|
||||
def test_pr_created_without_url(
|
||||
self, mock_banner, mock_get, mock_manager_class, mock_project_dir: Path,
|
||||
mock_worktree_path: Path, capsys
|
||||
):
|
||||
"""Handles successful PR creation with no URL returned."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.base_branch = "main"
|
||||
mock_manager_instance.push_and_create_pr.return_value = {
|
||||
"success": True,
|
||||
"pr_url": None, # No URL returned
|
||||
"already_exists": False,
|
||||
}
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.handle_create_pr_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
captured = capsys.readouterr()
|
||||
assert "Check GitHub for the PR URL" in captured.out
|
||||
|
||||
@patch("core.worktree.WorktreeManager")
|
||||
@patch("cli.workspace_commands.get_existing_build_worktree")
|
||||
@patch("cli.workspace_commands.print_banner")
|
||||
def test_push_failed_error(
|
||||
self, mock_banner, mock_get, mock_manager_class, mock_project_dir: Path,
|
||||
mock_worktree_path: Path
|
||||
):
|
||||
"""Handles push failure."""
|
||||
mock_get.return_value = mock_worktree_path
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.base_branch = "main"
|
||||
mock_manager_instance.push_and_create_pr.return_value = {
|
||||
"success": False,
|
||||
"error": "Push failed: remote rejected",
|
||||
"pushed": False,
|
||||
}
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.handle_create_pr_command(
|
||||
mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result["success"] is False
|
||||
assert "Push failed" in result["error"]
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR handle_merge_preview_command() - PATH MAPPING
|
||||
# =============================================================================
|
||||
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,372 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Tests for CLI Workspace Worktree Management
|
||||
===========================================
|
||||
|
||||
Tests worktree management functions:
|
||||
- handle_list_worktrees_command()
|
||||
- handle_cleanup_worktrees_command()
|
||||
- _detect_worktree_base_branch()
|
||||
"""
|
||||
|
||||
import json
|
||||
import subprocess
|
||||
from pathlib import Path
|
||||
from typing import Generator
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
# Import the module under test
|
||||
from cli import workspace_commands
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TEST CONSTANTS
|
||||
# =============================================================================
|
||||
|
||||
TEST_SPEC_NAME = "001-test-spec"
|
||||
TEST_SPEC_BRANCH = f"auto-claude/{TEST_SPEC_NAME}"
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _detect_default_branch()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestHandleListWorktreesCommand:
|
||||
"""Tests for handle_list_worktrees_command function."""
|
||||
|
||||
@patch("cli.workspace_commands.list_all_worktrees")
|
||||
@patch("cli.workspace_commands.print_banner")
|
||||
def test_list_with_no_worktrees(self, mock_banner, mock_list, mock_project_dir: Path, capsys):
|
||||
"""Lists worktrees when none exist."""
|
||||
mock_list.return_value = []
|
||||
|
||||
workspace_commands.handle_list_worktrees_command(mock_project_dir)
|
||||
|
||||
mock_banner.assert_called_once()
|
||||
captured = capsys.readouterr()
|
||||
assert "No worktrees found" in captured.out
|
||||
|
||||
@patch("cli.workspace_commands.list_all_worktrees")
|
||||
@patch("cli.workspace_commands.print_banner")
|
||||
def test_list_with_worktrees(self, mock_banner, mock_list, mock_project_dir: Path, capsys):
|
||||
"""Lists existing worktrees."""
|
||||
from typing import NamedTuple
|
||||
|
||||
# Create a mock worktree
|
||||
MockWorktree = NamedTuple(
|
||||
"MockWorktree",
|
||||
[("spec_name", str), ("branch", str), ("path", Path),
|
||||
("commit_count", int), ("files_changed", int)]
|
||||
)
|
||||
mock_worktree = MockWorktree(
|
||||
spec_name=TEST_SPEC_NAME,
|
||||
branch=TEST_SPEC_BRANCH,
|
||||
path=Path("/test/path"),
|
||||
commit_count=5,
|
||||
files_changed=10
|
||||
)
|
||||
mock_list.return_value = [mock_worktree]
|
||||
|
||||
workspace_commands.handle_list_worktrees_command(mock_project_dir)
|
||||
|
||||
captured = capsys.readouterr()
|
||||
assert TEST_SPEC_NAME in captured.out
|
||||
assert TEST_SPEC_BRANCH in captured.out
|
||||
assert "5" in captured.out
|
||||
assert "10" in captured.out
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR handle_cleanup_worktrees_command()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestHandleCleanupWorktreesCommand:
|
||||
"""Tests for handle_cleanup_worktrees_command function."""
|
||||
|
||||
@patch("cli.workspace_commands.cleanup_all_worktrees")
|
||||
@patch("cli.workspace_commands.print_banner")
|
||||
def test_cleanup_calls_function(self, mock_banner, mock_cleanup, mock_project_dir: Path):
|
||||
"""Cleanup command calls cleanup_all_worktrees."""
|
||||
workspace_commands.handle_cleanup_worktrees_command(mock_project_dir)
|
||||
|
||||
mock_banner.assert_called_once()
|
||||
mock_cleanup.assert_called_once_with(mock_project_dir, confirm=True)
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR handle_merge_preview_command()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestCleanupOldWorktreesCommand:
|
||||
"""Tests for cleanup_old_worktrees_command function."""
|
||||
|
||||
def test_successful_cleanup(self, mock_project_dir: Path):
|
||||
"""Successfully cleans up old worktrees."""
|
||||
with patch("cli.workspace_commands.WorktreeManager") as mock_manager_class:
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.cleanup_old_worktrees.return_value = (["worktree1"], [])
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.cleanup_old_worktrees_command(
|
||||
mock_project_dir, days=30, dry_run=False
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
assert result["removed"] == ["worktree1"]
|
||||
assert result["failed"] == []
|
||||
assert result["days_threshold"] == 30
|
||||
assert result["dry_run"] is False
|
||||
|
||||
def test_dry_run_mode(self, mock_project_dir: Path):
|
||||
"""Dry run mode doesn't actually remove worktrees."""
|
||||
with patch("cli.workspace_commands.WorktreeManager") as mock_manager_class:
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.cleanup_old_worktrees.return_value = (["worktree1"], [])
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.cleanup_old_worktrees_command(
|
||||
mock_project_dir, days=30, dry_run=True
|
||||
)
|
||||
|
||||
assert result["success"] is True
|
||||
assert result["dry_run"] is True
|
||||
mock_manager_instance.cleanup_old_worktrees.assert_called_once_with(
|
||||
days_threshold=30, dry_run=True
|
||||
)
|
||||
|
||||
def test_custom_days_threshold(self, mock_project_dir: Path):
|
||||
"""Uses custom days threshold."""
|
||||
with patch("cli.workspace_commands.WorktreeManager") as mock_manager_class:
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.cleanup_old_worktrees.return_value = ([], [])
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.cleanup_old_worktrees_command(
|
||||
mock_project_dir, days=7, dry_run=False
|
||||
)
|
||||
|
||||
assert result["days_threshold"] == 7
|
||||
mock_manager_instance.cleanup_old_worktrees.assert_called_once_with(
|
||||
days_threshold=7, dry_run=False
|
||||
)
|
||||
|
||||
def test_exception_handling(self, mock_project_dir: Path):
|
||||
"""Handles exceptions gracefully."""
|
||||
with patch("cli.workspace_commands.WorktreeManager", side_effect=Exception("Cleanup failed")):
|
||||
result = workspace_commands.cleanup_old_worktrees_command(
|
||||
mock_project_dir, days=30
|
||||
)
|
||||
|
||||
assert result["success"] is False
|
||||
assert "error" in result
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR worktree_summary_command()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestWorktreeSummaryCommand:
|
||||
"""Tests for worktree_summary_command function."""
|
||||
|
||||
def test_successful_summary(self, mock_project_dir: Path):
|
||||
"""Successfully generates worktree summary."""
|
||||
from typing import NamedTuple
|
||||
|
||||
MockWorktreeInfo = NamedTuple(
|
||||
"MockWorktreeInfo",
|
||||
[
|
||||
("spec_name", str),
|
||||
("days_since_last_commit", int | None),
|
||||
("commit_count", int),
|
||||
],
|
||||
)
|
||||
|
||||
with patch("cli.workspace_commands.WorktreeManager") as mock_manager_class:
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.list_all_worktrees.return_value = [
|
||||
MockWorktreeInfo(spec_name="001", days_since_last_commit=5, commit_count=3),
|
||||
MockWorktreeInfo(spec_name="002", days_since_last_commit=40, commit_count=1),
|
||||
]
|
||||
mock_manager_instance.get_worktree_count_warning.return_value = "Warning: Many worktrees"
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.worktree_summary_command(mock_project_dir)
|
||||
|
||||
assert result["success"] is True
|
||||
assert result["total_worktrees"] == 2
|
||||
assert len(result["categories"]["recent"]) == 1
|
||||
assert len(result["categories"]["month_old"]) == 1 # 40 days falls in month_old
|
||||
assert result["warning"] == "Warning: Many worktrees"
|
||||
|
||||
def test_categorizes_by_age(self, mock_project_dir: Path):
|
||||
"""Categorizes worktrees by age correctly."""
|
||||
from typing import NamedTuple
|
||||
|
||||
MockWorktreeInfo = NamedTuple(
|
||||
"MockWorktreeInfo",
|
||||
[
|
||||
("spec_name", str),
|
||||
("days_since_last_commit", int | None),
|
||||
("commit_count", int),
|
||||
],
|
||||
)
|
||||
|
||||
with patch("cli.workspace_commands.WorktreeManager") as mock_manager_class:
|
||||
mock_manager_instance = MagicMock()
|
||||
mock_manager_instance.list_all_worktrees.return_value = [
|
||||
MockWorktreeInfo(spec_name="001", days_since_last_commit=3, commit_count=1),
|
||||
MockWorktreeInfo(spec_name="002", days_since_last_commit=15, commit_count=1),
|
||||
MockWorktreeInfo(spec_name="003", days_since_last_commit=45, commit_count=1),
|
||||
MockWorktreeInfo(spec_name="004", days_since_last_commit=100, commit_count=1),
|
||||
MockWorktreeInfo(spec_name="005", days_since_last_commit=None, commit_count=1),
|
||||
]
|
||||
mock_manager_instance.get_worktree_count_warning.return_value = None
|
||||
mock_manager_class.return_value = mock_manager_instance
|
||||
|
||||
result = workspace_commands.worktree_summary_command(mock_project_dir)
|
||||
|
||||
assert len(result["categories"]["recent"]) == 1 # < 7 days
|
||||
assert len(result["categories"]["week_old"]) == 1 # 7-29 days (changed to 15)
|
||||
assert len(result["categories"]["month_old"]) == 1 # 30-89 days
|
||||
assert len(result["categories"]["very_old"]) == 1 # >= 90 days
|
||||
assert len(result["categories"]["unknown_age"]) == 1 # None
|
||||
|
||||
def test_exception_handling(self, mock_project_dir: Path):
|
||||
"""Handles exceptions gracefully."""
|
||||
with patch("cli.workspace_commands.WorktreeManager", side_effect=Exception("Summary failed")):
|
||||
result = workspace_commands.worktree_summary_command(mock_project_dir)
|
||||
|
||||
assert result["success"] is False
|
||||
assert "error" in result
|
||||
assert result["total_worktrees"] == 0
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR _get_changed_files_from_git() - FALLBACK BRANCHES
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestDetectWorktreeBaseBranch:
|
||||
"""Tests for _detect_worktree_base_branch function."""
|
||||
|
||||
def test_reads_from_config_file(self, temp_git_repo: Path, mock_worktree_path: Path):
|
||||
"""Reads base branch from worktree config file."""
|
||||
config_dir = mock_worktree_path / ".auto-claude"
|
||||
config_dir.mkdir(parents=True, exist_ok=True)
|
||||
config_file = config_dir / "worktree-config.json"
|
||||
config_file.write_text(json.dumps({"base_branch": "develop"}), encoding="utf-8")
|
||||
|
||||
result = workspace_commands._detect_worktree_base_branch(
|
||||
temp_git_repo, mock_worktree_path, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result == "develop"
|
||||
|
||||
def test_no_config_returns_none(self, temp_git_repo: Path, mock_worktree_path: Path):
|
||||
"""Returns None when no config file exists."""
|
||||
result = workspace_commands._detect_worktree_base_branch(
|
||||
temp_git_repo, mock_worktree_path, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
# Should return None if can't detect
|
||||
assert result is None or result in ["main", "master", "develop"]
|
||||
|
||||
def test_invalid_config_falls_back(self, temp_git_repo: Path, mock_worktree_path: Path):
|
||||
"""Handles invalid config file gracefully."""
|
||||
config_dir = mock_worktree_path / ".auto-claude"
|
||||
config_dir.mkdir(parents=True, exist_ok=True)
|
||||
config_file = config_dir / "worktree-config.json"
|
||||
config_file.write_text("invalid json", encoding="utf-8")
|
||||
|
||||
result = workspace_commands._detect_worktree_base_branch(
|
||||
temp_git_repo, mock_worktree_path, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
# Should not crash, return None or detected branch
|
||||
assert result is None or isinstance(result, str)
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR cleanup_old_worktrees_command()
|
||||
# =============================================================================
|
||||
|
||||
|
||||
|
||||
class TestDetectWorktreeBaseBranchDetection:
|
||||
"""Tests for branch detection logic in _detect_worktree_base_branch."""
|
||||
|
||||
def test_detects_from_develop_branch(self, temp_git_repo: Path):
|
||||
"""Detects develop branch when it has fewest commits ahead."""
|
||||
# Create develop branch
|
||||
subprocess.run(
|
||||
["git", "checkout", "-b", "develop"],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
# Create spec branch from develop
|
||||
subprocess.run(
|
||||
["git", "checkout", "-b", TEST_SPEC_BRANCH],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
subprocess.run(
|
||||
["git", "checkout", "main"],
|
||||
cwd=temp_git_repo,
|
||||
capture_output=True,
|
||||
check=True,
|
||||
)
|
||||
|
||||
result = workspace_commands._detect_worktree_base_branch(
|
||||
temp_git_repo, temp_git_repo, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
# Should detect develop as base branch
|
||||
assert result in ["develop", "main"]
|
||||
|
||||
def test_returns_none_when_no_branches_match(self, mock_project_dir: Path):
|
||||
"""Returns None when no candidate branches exist."""
|
||||
with patch("subprocess.run") as mock_run:
|
||||
# No branches exist
|
||||
mock_run.return_value = MagicMock(returncode=1)
|
||||
|
||||
result = workspace_commands._detect_worktree_base_branch(
|
||||
mock_project_dir, mock_project_dir, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
assert result is None
|
||||
|
||||
@patch("subprocess.run")
|
||||
def test_handles_merge_base_failure_during_detection(
|
||||
self, mock_run, mock_project_dir: Path, mock_worktree_path: Path
|
||||
):
|
||||
"""Handles merge-base command failure gracefully."""
|
||||
# Branch exists but merge-base fails
|
||||
mock_run.side_effect = [
|
||||
MagicMock(returncode=0), # Branch check passes
|
||||
MagicMock(returncode=1), # merge-base fails
|
||||
]
|
||||
|
||||
result = workspace_commands._detect_worktree_base_branch(
|
||||
mock_project_dir, mock_worktree_path, TEST_SPEC_NAME
|
||||
)
|
||||
|
||||
# Should continue checking other branches or return None
|
||||
assert result is None or isinstance(result, str)
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# TESTS FOR DEBUG FUNCTION FALLBACKS
|
||||
# =============================================================================
|
||||
File diff suppressed because it is too large
Load Diff
@@ -4,14 +4,22 @@ Tests for prompt_generator module functions.
|
||||
Tests for worktree detection and environment context generation.
|
||||
"""
|
||||
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
|
||||
# Note: sys.path manipulation is handled by conftest.py line 46
|
||||
from prompts_pkg.prompt_generator import (
|
||||
detect_worktree_isolation,
|
||||
generate_environment_context,
|
||||
)
|
||||
|
||||
# Skip Windows-specific tests on non-Windows platforms
|
||||
is_windows = sys.platform == 'win32'
|
||||
skip_on_windows = pytest.mark.skipif(not is_windows, reason="Test only applies to Windows")
|
||||
skip_on_non_windows = pytest.mark.skipif(is_windows, reason="Test only applies to non-Windows platforms")
|
||||
|
||||
|
||||
def normalize_path(path_str: str) -> str:
|
||||
"""Normalize path string for cross-platform comparison."""
|
||||
@@ -36,6 +44,7 @@ class TestDetectWorktreeIsolation:
|
||||
assert "opt/dev/project" in norm_forbidden
|
||||
assert ".auto-claude" not in norm_forbidden
|
||||
|
||||
@skip_on_windows
|
||||
def test_new_worktree_windows_path(self):
|
||||
"""Test detection of new worktree location on Windows."""
|
||||
# Windows path with backslashes
|
||||
@@ -64,6 +73,7 @@ class TestDetectWorktreeIsolation:
|
||||
assert "opt/dev/project" in norm_forbidden
|
||||
assert ".worktrees" not in norm_forbidden
|
||||
|
||||
@skip_on_windows
|
||||
def test_legacy_worktree_windows_path(self):
|
||||
"""Test detection of legacy worktree location on Windows."""
|
||||
project_dir = Path("C:/projects/x/.worktrees/009-audit")
|
||||
|
||||
+35
-32
@@ -524,57 +524,56 @@ class TestShouldRunQA:
|
||||
|
||||
def test_should_run_qa_build_not_complete(self, spec_dir: Path):
|
||||
"""Returns False when build not complete."""
|
||||
# Set up mock to return build not complete
|
||||
mock_progress.is_build_complete.return_value = False
|
||||
from unittest.mock import patch
|
||||
|
||||
plan = {"feature": "Test", "phases": []}
|
||||
save_implementation_plan(spec_dir, plan)
|
||||
|
||||
result = should_run_qa(spec_dir)
|
||||
assert result is False
|
||||
|
||||
# Reset mock
|
||||
mock_progress.is_build_complete.return_value = True
|
||||
with patch('qa.criteria.is_build_complete', return_value=False):
|
||||
result = should_run_qa(spec_dir)
|
||||
assert result is False
|
||||
|
||||
def test_should_run_qa_already_approved(self, spec_dir: Path, qa_signoff_approved: dict):
|
||||
"""Returns False when already approved."""
|
||||
mock_progress.is_build_complete.return_value = True
|
||||
from unittest.mock import patch
|
||||
|
||||
plan = {"feature": "Test", "qa_signoff": qa_signoff_approved}
|
||||
save_implementation_plan(spec_dir, plan)
|
||||
|
||||
result = should_run_qa(spec_dir)
|
||||
assert result is False
|
||||
with patch('qa.criteria.is_build_complete', return_value=True):
|
||||
result = should_run_qa(spec_dir)
|
||||
assert result is False
|
||||
|
||||
def test_should_run_qa_build_complete_not_approved(self, spec_dir: Path):
|
||||
"""Returns True when build complete but not approved."""
|
||||
mock_progress.is_build_complete.return_value = True
|
||||
# Explicitly patch is_build_complete to return True
|
||||
from unittest.mock import patch
|
||||
with patch('qa.criteria.is_build_complete', return_value=True):
|
||||
plan = {"feature": "Test", "phases": []}
|
||||
save_implementation_plan(spec_dir, plan)
|
||||
|
||||
plan = {"feature": "Test", "phases": []}
|
||||
save_implementation_plan(spec_dir, plan)
|
||||
|
||||
result = should_run_qa(spec_dir)
|
||||
assert result is True
|
||||
result = should_run_qa(spec_dir)
|
||||
assert result is True
|
||||
|
||||
def test_should_run_qa_rejected_status(self, spec_dir: Path, qa_signoff_rejected: dict):
|
||||
"""Returns True when rejected (needs re-review after fixes)."""
|
||||
mock_progress.is_build_complete.return_value = True
|
||||
from unittest.mock import patch
|
||||
|
||||
qa_signoff_rejected["qa_session"] = 1
|
||||
plan = {"feature": "Test", "qa_signoff": qa_signoff_rejected}
|
||||
save_implementation_plan(spec_dir, plan)
|
||||
|
||||
result = should_run_qa(spec_dir)
|
||||
assert result is True
|
||||
with patch('qa.criteria.is_build_complete', return_value=True):
|
||||
result = should_run_qa(spec_dir)
|
||||
assert result is True
|
||||
|
||||
def test_should_run_qa_no_plan(self, spec_dir: Path):
|
||||
"""Returns False when no plan exists (build not complete)."""
|
||||
mock_progress.is_build_complete.return_value = False
|
||||
from unittest.mock import patch
|
||||
|
||||
result = should_run_qa(spec_dir)
|
||||
assert result is False
|
||||
|
||||
# Reset mock
|
||||
mock_progress.is_build_complete.return_value = True
|
||||
with patch('qa.criteria.is_build_complete', return_value=False):
|
||||
result = should_run_qa(spec_dir)
|
||||
assert result is False
|
||||
|
||||
|
||||
class TestShouldRunFixes:
|
||||
@@ -899,14 +898,15 @@ class TestQAIntegration:
|
||||
|
||||
def test_full_qa_workflow_approved_first_try(self, spec_dir: Path):
|
||||
"""Full workflow where QA approves on first try."""
|
||||
mock_progress.is_build_complete.return_value = True
|
||||
from unittest.mock import patch
|
||||
|
||||
# Build complete
|
||||
plan = {"feature": "Test Feature", "phases": []}
|
||||
save_implementation_plan(spec_dir, plan)
|
||||
|
||||
# Should run QA
|
||||
assert should_run_qa(spec_dir) is True
|
||||
with patch('qa.criteria.is_build_complete', return_value=True):
|
||||
assert should_run_qa(spec_dir) is True
|
||||
|
||||
# QA approves
|
||||
plan["qa_signoff"] = {
|
||||
@@ -917,20 +917,22 @@ class TestQAIntegration:
|
||||
save_implementation_plan(spec_dir, plan)
|
||||
|
||||
# Should not run QA again or fixes
|
||||
assert should_run_qa(spec_dir) is False
|
||||
with patch('qa.criteria.is_build_complete', return_value=True):
|
||||
assert should_run_qa(spec_dir) is False
|
||||
assert should_run_fixes(spec_dir) is False
|
||||
assert is_qa_approved(spec_dir) is True
|
||||
|
||||
def test_full_qa_workflow_with_fixes(self, spec_dir: Path):
|
||||
"""Full workflow with reject-fix-approve cycle."""
|
||||
mock_progress.is_build_complete.return_value = True
|
||||
from unittest.mock import patch
|
||||
|
||||
# Build complete
|
||||
plan = {"feature": "Test Feature", "phases": []}
|
||||
save_implementation_plan(spec_dir, plan)
|
||||
|
||||
# Should run QA
|
||||
assert should_run_qa(spec_dir) is True
|
||||
with patch('qa.criteria.is_build_complete', return_value=True):
|
||||
assert should_run_qa(spec_dir) is True
|
||||
|
||||
# QA rejects
|
||||
plan["qa_signoff"] = {
|
||||
@@ -963,7 +965,7 @@ class TestQAIntegration:
|
||||
|
||||
def test_qa_workflow_max_iterations(self, spec_dir: Path):
|
||||
"""Test behavior when max iterations are reached."""
|
||||
mock_progress.is_build_complete.return_value = True
|
||||
from unittest.mock import patch
|
||||
|
||||
plan = {
|
||||
"feature": "Test",
|
||||
@@ -977,4 +979,5 @@ class TestQAIntegration:
|
||||
# Should not run more fixes after max iterations
|
||||
assert should_run_fixes(spec_dir) is False
|
||||
# But QA can still be run (to re-check)
|
||||
assert should_run_qa(spec_dir) is True
|
||||
with patch('qa.criteria.is_build_complete', return_value=True):
|
||||
assert should_run_qa(spec_dir) is True
|
||||
|
||||
@@ -543,25 +543,6 @@ def run_all_tests():
|
||||
# Note: This manual runner is kept for backwards compatibility.
|
||||
# Prefer running tests with pytest: pytest tests/test_recovery.py -v
|
||||
|
||||
tests = [
|
||||
("test_initialization", test_initialization),
|
||||
("test_record_attempt", test_record_attempt),
|
||||
("test_circular_fix_detection", test_circular_fix_detection),
|
||||
("test_failure_classification", test_failure_classification),
|
||||
("test_recovery_action_determination", test_recovery_action_determination),
|
||||
("test_good_commit_tracking", test_good_commit_tracking),
|
||||
("test_mark_subtask_stuck", test_mark_subtask_stuck),
|
||||
("test_recovery_hints", test_recovery_hints),
|
||||
# Session checkpoint and restoration tests
|
||||
("test_checkpoint_persistence_across_sessions", test_checkpoint_persistence_across_sessions),
|
||||
("test_restoration_after_failure", test_restoration_after_failure),
|
||||
("test_checkpoint_multiple_subtasks", test_checkpoint_multiple_subtasks),
|
||||
("test_restoration_with_build_commits", test_restoration_with_build_commits),
|
||||
("test_checkpoint_recovery_hints_restoration", test_checkpoint_recovery_hints_restoration),
|
||||
("test_restoration_stuck_subtasks_list", test_restoration_stuck_subtasks_list),
|
||||
("test_checkpoint_clear_and_reset", test_checkpoint_clear_and_reset),
|
||||
]
|
||||
|
||||
print("Note: Running with manual test runner for backwards compatibility.")
|
||||
print("For full pytest integration with fixtures, run: pytest tests/test_recovery.py -v")
|
||||
print()
|
||||
|
||||
@@ -1,173 +0,0 @@
|
||||
"""
|
||||
Test Claude Agent SDK Structured Output functionality.
|
||||
|
||||
This test verifies how structured outputs work with the SDK.
|
||||
"""
|
||||
|
||||
import asyncio
|
||||
import os
|
||||
import sys
|
||||
from pathlib import Path
|
||||
from pprint import pprint
|
||||
|
||||
# Add backend to path
|
||||
sys.path.insert(0, str(Path(__file__).parent.parent / "apps" / "backend"))
|
||||
|
||||
# Add pydantic_models path
|
||||
_pydantic_models_path = (
|
||||
Path(__file__).parent.parent
|
||||
/ "apps"
|
||||
/ "backend"
|
||||
/ "runners"
|
||||
/ "github"
|
||||
/ "services"
|
||||
)
|
||||
sys.path.insert(0, str(_pydantic_models_path))
|
||||
|
||||
from pydantic import BaseModel, Field
|
||||
from typing import Literal
|
||||
|
||||
|
||||
# Simple test model
|
||||
class SimpleReviewResponse(BaseModel):
|
||||
"""A simple review response for testing."""
|
||||
|
||||
verdict: Literal["PASS", "FAIL"] = Field(description="Review verdict")
|
||||
reason: str = Field(description="Reason for the verdict")
|
||||
score: int = Field(ge=0, le=100, description="Score from 0-100")
|
||||
|
||||
|
||||
async def test_structured_output():
|
||||
"""Test the SDK's structured output functionality."""
|
||||
|
||||
# OAuth token must be set in environment (CLAUDE_CODE_OAUTH_TOKEN)
|
||||
if not os.environ.get("CLAUDE_CODE_OAUTH_TOKEN"):
|
||||
print("ERROR: CLAUDE_CODE_OAUTH_TOKEN environment variable not set")
|
||||
return
|
||||
|
||||
from claude_agent_sdk import query, ClaudeAgentOptions
|
||||
|
||||
# Generate JSON schema from Pydantic model
|
||||
schema = SimpleReviewResponse.model_json_schema()
|
||||
print("=== Schema ===")
|
||||
pprint(schema)
|
||||
print()
|
||||
|
||||
prompt = """
|
||||
Review this code and provide your assessment:
|
||||
|
||||
```python
|
||||
def add(a, b):
|
||||
return a + b
|
||||
```
|
||||
|
||||
Provide a verdict (PASS or FAIL), reason, and score.
|
||||
"""
|
||||
|
||||
print("=== Running query with output_format ===")
|
||||
print(f"Prompt: {prompt[:100]}...")
|
||||
print()
|
||||
|
||||
message_count = 0
|
||||
async for message in query(
|
||||
prompt=prompt,
|
||||
options=ClaudeAgentOptions(
|
||||
model="claude-sonnet-4-5-20250929",
|
||||
system_prompt="You are a code reviewer. Provide structured feedback.",
|
||||
allowed_tools=[],
|
||||
max_turns=2, # Need 2 turns for structured output tool call
|
||||
output_format={
|
||||
"type": "json_schema",
|
||||
"schema": schema,
|
||||
},
|
||||
),
|
||||
):
|
||||
message_count += 1
|
||||
msg_type = type(message).__name__
|
||||
print(f"\n=== Message {message_count}: {msg_type} ===")
|
||||
|
||||
# Print all non-private attributes
|
||||
for attr in dir(message):
|
||||
if not attr.startswith("_"):
|
||||
try:
|
||||
val = getattr(message, attr)
|
||||
if not callable(val):
|
||||
# Truncate long values
|
||||
val_str = str(val)
|
||||
if len(val_str) > 500:
|
||||
val_str = val_str[:500] + "..."
|
||||
print(f" {attr}: {val_str}")
|
||||
except Exception as e:
|
||||
print(f" {attr}: <error: {e}>")
|
||||
|
||||
# Check for StructuredOutput tool use in AssistantMessage
|
||||
if msg_type == "AssistantMessage":
|
||||
content = getattr(message, "content", [])
|
||||
for block in content:
|
||||
block_type = type(block).__name__
|
||||
if block_type == "ToolUseBlock":
|
||||
tool_name = getattr(block, "name", "")
|
||||
if tool_name == "StructuredOutput":
|
||||
structured_data = getattr(block, "input", None)
|
||||
print(f"\n 🎯 Found StructuredOutput tool use!")
|
||||
print(f" Data: {structured_data}")
|
||||
if structured_data:
|
||||
try:
|
||||
validated = SimpleReviewResponse.model_validate(structured_data)
|
||||
print(f"\n ✅ Successfully validated StructuredOutput!")
|
||||
print(f" verdict: {validated.verdict}")
|
||||
print(f" reason: {validated.reason}")
|
||||
print(f" score: {validated.score}")
|
||||
except Exception as e:
|
||||
print(f"\n ❌ Failed to validate: {e}")
|
||||
|
||||
# Special handling for ResultMessage
|
||||
if msg_type == "ResultMessage":
|
||||
print("\n --- ResultMessage Details ---")
|
||||
|
||||
# Check structured_output
|
||||
so = getattr(message, "structured_output", None)
|
||||
print(f" structured_output value: {so}")
|
||||
print(f" structured_output type: {type(so)}")
|
||||
|
||||
# Check result
|
||||
result = getattr(message, "result", None)
|
||||
print(f" result value: {result}")
|
||||
print(f" result type: {type(result)}")
|
||||
|
||||
# If result is a string, try to parse as JSON
|
||||
if isinstance(result, str):
|
||||
import json
|
||||
try:
|
||||
parsed = json.loads(result)
|
||||
print(f" result parsed as JSON: {parsed}")
|
||||
except:
|
||||
print(f" result is not JSON")
|
||||
|
||||
# Try to validate with Pydantic if we got data
|
||||
if so:
|
||||
try:
|
||||
validated = SimpleReviewResponse.model_validate(so)
|
||||
print(f"\n ✅ Successfully validated structured_output!")
|
||||
print(f" verdict: {validated.verdict}")
|
||||
print(f" reason: {validated.reason}")
|
||||
print(f" score: {validated.score}")
|
||||
except Exception as e:
|
||||
print(f"\n ❌ Failed to validate structured_output: {e}")
|
||||
|
||||
if result and isinstance(result, (dict, str)):
|
||||
try:
|
||||
data = result if isinstance(result, dict) else json.loads(result)
|
||||
validated = SimpleReviewResponse.model_validate(data)
|
||||
print(f"\n ✅ Successfully validated result as structured output!")
|
||||
print(f" verdict: {validated.verdict}")
|
||||
print(f" reason: {validated.reason}")
|
||||
print(f" score: {validated.score}")
|
||||
except Exception as e:
|
||||
print(f"\n ❌ Failed to validate result: {e}")
|
||||
|
||||
print(f"\n=== Total messages: {message_count} ===")
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
asyncio.run(test_structured_output())
|
||||
@@ -382,7 +382,7 @@ class TestEdgeCases:
|
||||
|
||||
def test_nonexistent_directory(self, scanner):
|
||||
"""Test handling of non-existent directory."""
|
||||
fake_dir = Path("/nonexistent/path")
|
||||
fake_dir = Path("/tmp/test-nonexistent-security-scanner-123456")
|
||||
|
||||
# Should not crash, may have errors
|
||||
result = scanner.scan(fake_dir)
|
||||
|
||||
@@ -437,7 +437,7 @@ class TestEdgeCases:
|
||||
|
||||
def test_nonexistent_directory(self):
|
||||
"""Test handling of non-existent directory."""
|
||||
fake_dir = Path("/nonexistent/path")
|
||||
fake_dir = Path("/tmp/test-nonexistent-orchestrator-123456")
|
||||
|
||||
# Should not crash
|
||||
orchestrator = ServiceOrchestrator(fake_dir)
|
||||
|
||||
@@ -1,715 +0,0 @@
|
||||
"""
|
||||
Tests for Pydantic Structured Output Models
|
||||
============================================
|
||||
|
||||
Tests the Pydantic models used for Claude Agent SDK structured outputs
|
||||
in GitHub PR reviews.
|
||||
"""
|
||||
|
||||
import sys
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
from pydantic import ValidationError
|
||||
|
||||
# Direct import of pydantic_models to avoid runners package chain
|
||||
# Path is set up by conftest.py
|
||||
_pydantic_models_path = (
|
||||
Path(__file__).parent.parent
|
||||
/ "apps"
|
||||
/ "backend"
|
||||
/ "runners"
|
||||
/ "github"
|
||||
/ "services"
|
||||
)
|
||||
sys.path.insert(0, str(_pydantic_models_path))
|
||||
|
||||
from pydantic_models import (
|
||||
# Follow-up review models
|
||||
FindingResolution,
|
||||
FollowupFinding,
|
||||
FollowupReviewResponse,
|
||||
# Orchestrator review models
|
||||
OrchestratorFinding,
|
||||
OrchestratorReviewResponse,
|
||||
# Initial review models
|
||||
QuickScanResult,
|
||||
SecurityFinding,
|
||||
QualityFinding,
|
||||
DeepAnalysisFinding,
|
||||
StructuralIssue,
|
||||
AICommentTriage,
|
||||
# Verification evidence models (Phase 2)
|
||||
VerificationEvidence,
|
||||
ParallelOrchestratorFinding,
|
||||
BaseFinding,
|
||||
)
|
||||
|
||||
|
||||
class TestFindingResolution:
|
||||
"""Tests for FindingResolution model."""
|
||||
|
||||
def test_valid_resolution_resolved(self):
|
||||
"""Test valid resolved finding."""
|
||||
data = {
|
||||
"finding_id": "prev-1",
|
||||
"status": "resolved",
|
||||
"resolution_notes": "Fixed in commit abc123",
|
||||
}
|
||||
result = FindingResolution.model_validate(data)
|
||||
assert result.finding_id == "prev-1"
|
||||
assert result.status == "resolved"
|
||||
assert result.resolution_notes == "Fixed in commit abc123"
|
||||
|
||||
def test_valid_resolution_unresolved(self):
|
||||
"""Test valid unresolved finding."""
|
||||
data = {
|
||||
"finding_id": "prev-2",
|
||||
"status": "unresolved",
|
||||
}
|
||||
result = FindingResolution.model_validate(data)
|
||||
assert result.status == "unresolved"
|
||||
assert result.resolution_notes is None
|
||||
|
||||
def test_invalid_status_rejected(self):
|
||||
"""Test that invalid status values are rejected."""
|
||||
data = {
|
||||
"finding_id": "prev-1",
|
||||
"status": "pending", # Invalid - not in Literal
|
||||
}
|
||||
with pytest.raises(ValidationError) as exc_info:
|
||||
FindingResolution.model_validate(data)
|
||||
assert "status" in str(exc_info.value)
|
||||
|
||||
|
||||
class TestFollowupFinding:
|
||||
"""Tests for FollowupFinding model."""
|
||||
|
||||
def test_valid_finding(self):
|
||||
"""Test valid follow-up finding."""
|
||||
data = {
|
||||
"id": "new-1",
|
||||
"severity": "high",
|
||||
"category": "security",
|
||||
"title": "SQL Injection vulnerability",
|
||||
"description": "User input not sanitized before query",
|
||||
"file": "api/query.py",
|
||||
"line": 42,
|
||||
"suggested_fix": "Use parameterized queries",
|
||||
"fixable": True,
|
||||
"verification": {
|
||||
"code_examined": "query = 'SELECT * FROM users WHERE id=' + user_input",
|
||||
"line_range_examined": [42, 42],
|
||||
"verification_method": "direct_code_inspection",
|
||||
},
|
||||
}
|
||||
result = FollowupFinding.model_validate(data)
|
||||
assert result.id == "new-1"
|
||||
assert result.severity == "high"
|
||||
assert result.category == "security"
|
||||
assert result.line == 42
|
||||
assert result.fixable is True
|
||||
|
||||
def test_minimal_finding(self):
|
||||
"""Test finding with only required fields."""
|
||||
data = {
|
||||
"id": "new-2",
|
||||
"severity": "low",
|
||||
"category": "docs",
|
||||
"title": "Missing docstring",
|
||||
"description": "Function lacks documentation",
|
||||
"file": "utils.py",
|
||||
"verification": {
|
||||
"code_examined": "def process_data(data):\n return data",
|
||||
"line_range_examined": [1, 2],
|
||||
"verification_method": "direct_code_inspection",
|
||||
},
|
||||
}
|
||||
result = FollowupFinding.model_validate(data)
|
||||
assert result.line == 0 # Default
|
||||
assert result.suggested_fix is None
|
||||
assert result.fixable is False
|
||||
|
||||
def test_invalid_severity_rejected(self):
|
||||
"""Test that invalid severity is rejected."""
|
||||
data = {
|
||||
"id": "new-1",
|
||||
"severity": "extreme", # Invalid
|
||||
"category": "security",
|
||||
"title": "Test",
|
||||
"description": "Test",
|
||||
"file": "test.py",
|
||||
}
|
||||
with pytest.raises(ValidationError) as exc_info:
|
||||
FollowupFinding.model_validate(data)
|
||||
assert "severity" in str(exc_info.value)
|
||||
|
||||
def test_invalid_category_rejected(self):
|
||||
"""Test that invalid category is rejected."""
|
||||
data = {
|
||||
"id": "new-1",
|
||||
"severity": "high",
|
||||
"category": "unknown_category", # Invalid
|
||||
"title": "Test",
|
||||
"description": "Test",
|
||||
"file": "test.py",
|
||||
}
|
||||
with pytest.raises(ValidationError) as exc_info:
|
||||
FollowupFinding.model_validate(data)
|
||||
assert "category" in str(exc_info.value)
|
||||
|
||||
|
||||
class TestFollowupReviewResponse:
|
||||
"""Tests for FollowupReviewResponse model."""
|
||||
|
||||
def test_valid_complete_response(self):
|
||||
"""Test valid complete follow-up review response."""
|
||||
data = {
|
||||
"finding_resolutions": [
|
||||
{"finding_id": "prev-1", "status": "resolved", "resolution_notes": "Fixed"}
|
||||
],
|
||||
"new_findings": [
|
||||
{
|
||||
"id": "new-1",
|
||||
"severity": "medium",
|
||||
"category": "quality",
|
||||
"title": "Code smell",
|
||||
"description": "Complex method",
|
||||
"file": "service.py",
|
||||
"line": 100,
|
||||
"verification": {
|
||||
"code_examined": "def process(self, data):\n # 50 lines of nested if statements",
|
||||
"line_range_examined": [100, 150],
|
||||
"verification_method": "direct_code_inspection",
|
||||
},
|
||||
}
|
||||
],
|
||||
"comment_findings": [],
|
||||
"verdict": "MERGE_WITH_CHANGES",
|
||||
"verdict_reasoning": "Minor issues found, safe to merge after review",
|
||||
}
|
||||
result = FollowupReviewResponse.model_validate(data)
|
||||
assert result.verdict == "MERGE_WITH_CHANGES"
|
||||
assert len(result.finding_resolutions) == 1
|
||||
assert len(result.new_findings) == 1
|
||||
assert len(result.comment_findings) == 0
|
||||
|
||||
def test_empty_findings_lists(self):
|
||||
"""Test response with empty findings lists."""
|
||||
data = {
|
||||
"finding_resolutions": [],
|
||||
"new_findings": [],
|
||||
"comment_findings": [],
|
||||
"verdict": "READY_TO_MERGE",
|
||||
"verdict_reasoning": "No issues found",
|
||||
}
|
||||
result = FollowupReviewResponse.model_validate(data)
|
||||
assert result.verdict == "READY_TO_MERGE"
|
||||
|
||||
def test_invalid_verdict_rejected(self):
|
||||
"""Test that invalid verdict is rejected."""
|
||||
data = {
|
||||
"finding_resolutions": [],
|
||||
"new_findings": [],
|
||||
"comment_findings": [],
|
||||
"verdict": "APPROVE", # Invalid
|
||||
"verdict_reasoning": "Test",
|
||||
}
|
||||
with pytest.raises(ValidationError) as exc_info:
|
||||
FollowupReviewResponse.model_validate(data)
|
||||
assert "verdict" in str(exc_info.value)
|
||||
|
||||
def test_all_verdict_values(self):
|
||||
"""Test all valid verdict values."""
|
||||
for verdict in [
|
||||
"READY_TO_MERGE",
|
||||
"MERGE_WITH_CHANGES",
|
||||
"NEEDS_REVISION",
|
||||
"BLOCKED",
|
||||
]:
|
||||
data = {
|
||||
"finding_resolutions": [],
|
||||
"new_findings": [],
|
||||
"comment_findings": [],
|
||||
"verdict": verdict,
|
||||
"verdict_reasoning": f"Testing {verdict}",
|
||||
}
|
||||
result = FollowupReviewResponse.model_validate(data)
|
||||
assert result.verdict == verdict
|
||||
|
||||
|
||||
class TestOrchestratorFinding:
|
||||
"""Tests for OrchestratorFinding model."""
|
||||
|
||||
def test_valid_finding(self):
|
||||
"""Test valid orchestrator finding with evidence field."""
|
||||
data = {
|
||||
"file": "src/api.py",
|
||||
"line": 25,
|
||||
"title": "Missing error handling",
|
||||
"description": "API endpoint lacks try-catch block",
|
||||
"category": "quality",
|
||||
"severity": "medium",
|
||||
"suggestion": "Add error handling with proper logging",
|
||||
"evidence": "def handle_request(req):\n result = db.query(req.id) # no try-catch",
|
||||
"verification": {
|
||||
"code_examined": "def handle_request(req):\n result = db.query(req.id) # no try-catch",
|
||||
"line_range_examined": [25, 26],
|
||||
"verification_method": "direct_code_inspection",
|
||||
},
|
||||
}
|
||||
result = OrchestratorFinding.model_validate(data)
|
||||
assert result.file == "src/api.py"
|
||||
assert result.evidence is not None
|
||||
assert "no try-catch" in result.evidence
|
||||
|
||||
def test_evidence_optional(self):
|
||||
"""Test that evidence field is optional."""
|
||||
data = {
|
||||
"file": "test.py",
|
||||
"title": "Test",
|
||||
"description": "Test finding",
|
||||
"category": "quality",
|
||||
"severity": "low",
|
||||
"verification": {
|
||||
"code_examined": "def test():\n pass",
|
||||
"line_range_examined": [1, 2],
|
||||
"verification_method": "direct_code_inspection",
|
||||
},
|
||||
}
|
||||
result = OrchestratorFinding.model_validate(data)
|
||||
assert result.evidence is None
|
||||
|
||||
|
||||
class TestOrchestratorReviewResponse:
|
||||
"""Tests for OrchestratorReviewResponse model."""
|
||||
|
||||
def test_valid_response(self):
|
||||
"""Test valid orchestrator review response."""
|
||||
data = {
|
||||
"verdict": "NEEDS_REVISION",
|
||||
"verdict_reasoning": "Critical security issue found",
|
||||
"findings": [
|
||||
{
|
||||
"file": "auth.py",
|
||||
"line": 10,
|
||||
"title": "Hardcoded secret",
|
||||
"description": "API key exposed in source",
|
||||
"category": "security",
|
||||
"severity": "critical",
|
||||
"evidence": "API_KEY = 'sk-prod-12345abcdef'",
|
||||
"verification": {
|
||||
"code_examined": "API_KEY = 'sk-prod-12345abcdef'",
|
||||
"line_range_examined": [10, 10],
|
||||
"verification_method": "direct_code_inspection",
|
||||
},
|
||||
}
|
||||
],
|
||||
"summary": "Found 1 critical security issue",
|
||||
}
|
||||
result = OrchestratorReviewResponse.model_validate(data)
|
||||
assert result.verdict == "NEEDS_REVISION"
|
||||
assert len(result.findings) == 1
|
||||
assert result.findings[0].severity == "critical"
|
||||
|
||||
def test_empty_findings(self):
|
||||
"""Test response with no findings."""
|
||||
data = {
|
||||
"verdict": "READY_TO_MERGE",
|
||||
"verdict_reasoning": "All checks passed",
|
||||
"findings": [],
|
||||
"summary": "Clean PR, ready for merge",
|
||||
}
|
||||
result = OrchestratorReviewResponse.model_validate(data)
|
||||
assert len(result.findings) == 0
|
||||
|
||||
|
||||
class TestQuickScanResult:
|
||||
"""Tests for QuickScanResult model."""
|
||||
|
||||
def test_valid_quick_scan(self):
|
||||
"""Test valid quick scan result."""
|
||||
data = {
|
||||
"purpose": "Add user authentication",
|
||||
"actual_changes": "Implements OAuth login flow",
|
||||
"purpose_match": True,
|
||||
"risk_areas": ["Security", "Session management"],
|
||||
"red_flags": [],
|
||||
"requires_deep_verification": True,
|
||||
"complexity": "medium",
|
||||
}
|
||||
result = QuickScanResult.model_validate(data)
|
||||
assert result.purpose_match is True
|
||||
assert result.complexity == "medium"
|
||||
assert len(result.risk_areas) == 2
|
||||
|
||||
def test_complexity_values(self):
|
||||
"""Test all valid complexity values."""
|
||||
for complexity in ["low", "medium", "high"]:
|
||||
data = {
|
||||
"purpose": "Test",
|
||||
"actual_changes": "Test",
|
||||
"purpose_match": True,
|
||||
"requires_deep_verification": False,
|
||||
"complexity": complexity,
|
||||
}
|
||||
result = QuickScanResult.model_validate(data)
|
||||
assert result.complexity == complexity
|
||||
|
||||
|
||||
class TestSchemaGeneration:
|
||||
"""Tests for JSON schema generation."""
|
||||
|
||||
def test_followup_schema_generation(self):
|
||||
"""Test that FollowupReviewResponse generates valid JSON schema."""
|
||||
schema = FollowupReviewResponse.model_json_schema()
|
||||
|
||||
assert "properties" in schema
|
||||
assert "verdict" in schema["properties"]
|
||||
assert "verdict_reasoning" in schema["properties"]
|
||||
assert "finding_resolutions" in schema["properties"]
|
||||
assert "new_findings" in schema["properties"]
|
||||
|
||||
# Check verdict enum values
|
||||
verdict_schema = schema["properties"]["verdict"]
|
||||
assert "enum" in verdict_schema or "$ref" in str(schema)
|
||||
|
||||
def test_orchestrator_schema_generation(self):
|
||||
"""Test that OrchestratorReviewResponse generates valid JSON schema."""
|
||||
schema = OrchestratorReviewResponse.model_json_schema()
|
||||
|
||||
assert "properties" in schema
|
||||
assert "verdict" in schema["properties"]
|
||||
assert "findings" in schema["properties"]
|
||||
assert "summary" in schema["properties"]
|
||||
|
||||
def test_schema_has_descriptions(self):
|
||||
"""Test that schema includes field descriptions for AI guidance."""
|
||||
schema = FollowupReviewResponse.model_json_schema()
|
||||
|
||||
# Check that descriptions are included (helps AI understand the schema)
|
||||
# The schema may have $defs for nested models
|
||||
assert "properties" in schema or "$defs" in schema
|
||||
|
||||
|
||||
class TestSecurityFinding:
|
||||
"""Tests for SecurityFinding model."""
|
||||
|
||||
def test_security_category_default(self):
|
||||
"""Test that SecurityFinding has security category by default."""
|
||||
data = {
|
||||
"id": "sec-1",
|
||||
"severity": "high",
|
||||
"title": "XSS vulnerability",
|
||||
"description": "Unescaped user input",
|
||||
"file": "template.html",
|
||||
"line": 50,
|
||||
"verification": {
|
||||
"code_examined": "<div>{{ user_input }}</div>",
|
||||
"line_range_examined": [50, 50],
|
||||
"verification_method": "direct_code_inspection",
|
||||
},
|
||||
}
|
||||
result = SecurityFinding.model_validate(data)
|
||||
assert result.category == "security"
|
||||
|
||||
|
||||
class TestDeepAnalysisFinding:
|
||||
"""Tests for DeepAnalysisFinding model."""
|
||||
|
||||
def test_evidence_field(self):
|
||||
"""Test evidence field for proof of issue."""
|
||||
data = {
|
||||
"id": "deep-1",
|
||||
"severity": "medium",
|
||||
"title": "Potential race condition",
|
||||
"description": "Concurrent access without lock",
|
||||
"file": "worker.py",
|
||||
"line": 100,
|
||||
"category": "logic",
|
||||
"evidence": "shared_state += 1 # no lock protection",
|
||||
"verification": {
|
||||
"code_examined": "shared_state += 1 # no lock protection",
|
||||
"line_range_examined": [100, 100],
|
||||
"verification_method": "direct_code_inspection",
|
||||
},
|
||||
}
|
||||
result = DeepAnalysisFinding.model_validate(data)
|
||||
assert result.evidence == "shared_state += 1 # no lock protection"
|
||||
|
||||
def test_verification_note(self):
|
||||
"""Test verification note field."""
|
||||
data = {
|
||||
"id": "deep-2",
|
||||
"severity": "low",
|
||||
"title": "Unverified assumption",
|
||||
"description": "Could not verify behavior",
|
||||
"file": "lib.py",
|
||||
"category": "verification_failed",
|
||||
"verification_note": "Unable to find test coverage",
|
||||
"verification": {
|
||||
"code_examined": "def some_function():\n return process_data()",
|
||||
"line_range_examined": [1, 2],
|
||||
"verification_method": "cross_file_trace",
|
||||
},
|
||||
}
|
||||
result = DeepAnalysisFinding.model_validate(data)
|
||||
assert result.verification_note == "Unable to find test coverage"
|
||||
|
||||
|
||||
class TestAICommentTriage:
|
||||
"""Tests for AICommentTriage model."""
|
||||
|
||||
def test_valid_triage(self):
|
||||
"""Test valid AI comment triage."""
|
||||
data = {
|
||||
"comment_id": 12345,
|
||||
"tool_name": "CodeRabbit",
|
||||
"verdict": "important",
|
||||
"reasoning": "Valid security concern raised",
|
||||
"response_comment": "Thank you, we will address this.",
|
||||
}
|
||||
result = AICommentTriage.model_validate(data)
|
||||
assert result.comment_id == 12345
|
||||
assert result.verdict == "important"
|
||||
|
||||
def test_all_verdict_values(self):
|
||||
"""Test all valid triage verdict values."""
|
||||
for verdict in [
|
||||
"critical",
|
||||
"important",
|
||||
"nice_to_have",
|
||||
"trivial",
|
||||
"false_positive",
|
||||
]:
|
||||
data = {
|
||||
"comment_id": 1,
|
||||
"tool_name": "Test",
|
||||
"verdict": verdict,
|
||||
"reasoning": f"Testing {verdict}",
|
||||
}
|
||||
result = AICommentTriage.model_validate(data)
|
||||
assert result.verdict == verdict
|
||||
|
||||
|
||||
# =============================================================================
|
||||
# Phase 2: Schema Enforcement Tests
|
||||
# =============================================================================
|
||||
|
||||
|
||||
class TestVerificationEvidence:
|
||||
"""Tests for VerificationEvidence model."""
|
||||
|
||||
def test_valid_verification(self):
|
||||
"""Test valid verification evidence."""
|
||||
data = {
|
||||
"code_examined": "def process_input(user_input):\n return eval(user_input)",
|
||||
"line_range_examined": [10, 11],
|
||||
"verification_method": "direct_code_inspection",
|
||||
}
|
||||
result = VerificationEvidence.model_validate(data)
|
||||
assert "eval" in result.code_examined
|
||||
assert result.line_range_examined == [10, 11]
|
||||
assert result.verification_method == "direct_code_inspection"
|
||||
|
||||
def test_empty_code_examined_accepted(self):
|
||||
"""Test that empty code_examined is accepted (no min_length constraint)."""
|
||||
data = {
|
||||
"code_examined": "",
|
||||
"line_range_examined": [1, 5],
|
||||
"verification_method": "direct_code_inspection",
|
||||
}
|
||||
result = VerificationEvidence.model_validate(data)
|
||||
assert result.code_examined == ""
|
||||
|
||||
def test_line_range_defaults_to_empty_list(self):
|
||||
"""Test that line_range_examined defaults to empty list when omitted."""
|
||||
data = {
|
||||
"code_examined": "some code",
|
||||
"verification_method": "direct_code_inspection",
|
||||
}
|
||||
result = VerificationEvidence.model_validate(data)
|
||||
assert result.line_range_examined == []
|
||||
|
||||
def test_single_element_line_range_accepted(self):
|
||||
"""Test that single element line range is accepted (list[int])."""
|
||||
data = {
|
||||
"code_examined": "some code",
|
||||
"line_range_examined": [1],
|
||||
"verification_method": "direct_code_inspection",
|
||||
}
|
||||
result = VerificationEvidence.model_validate(data)
|
||||
assert result.line_range_examined == [1]
|
||||
|
||||
def test_custom_verification_method_accepted(self):
|
||||
"""Test that any string verification method is accepted."""
|
||||
data = {
|
||||
"code_examined": "some code",
|
||||
"line_range_examined": [1, 5],
|
||||
"verification_method": "custom_method",
|
||||
}
|
||||
result = VerificationEvidence.model_validate(data)
|
||||
assert result.verification_method == "custom_method"
|
||||
|
||||
def test_all_verification_methods(self):
|
||||
"""Test common verification methods."""
|
||||
methods = [
|
||||
"direct_code_inspection",
|
||||
"cross_file_trace",
|
||||
"test_verification",
|
||||
"dependency_analysis",
|
||||
]
|
||||
for method in methods:
|
||||
data = {
|
||||
"code_examined": "code",
|
||||
"line_range_examined": [1, 5],
|
||||
"verification_method": method,
|
||||
}
|
||||
result = VerificationEvidence.model_validate(data)
|
||||
assert result.verification_method == method
|
||||
|
||||
|
||||
class TestParallelOrchestratorFindingVerification:
|
||||
"""Tests for verification field requirement on ParallelOrchestratorFinding."""
|
||||
|
||||
def test_missing_verification_rejected(self):
|
||||
"""Test that findings without verification are rejected."""
|
||||
data = {
|
||||
"id": "test-1",
|
||||
"file": "test.py",
|
||||
"line": 10,
|
||||
"title": "Test finding",
|
||||
"description": "A test finding without verification",
|
||||
"category": "quality",
|
||||
"severity": "medium",
|
||||
# No verification field - should fail
|
||||
}
|
||||
with pytest.raises(ValidationError) as exc_info:
|
||||
ParallelOrchestratorFinding.model_validate(data)
|
||||
assert "verification" in str(exc_info.value)
|
||||
|
||||
def test_valid_finding_with_verification(self):
|
||||
"""Test valid finding with verification evidence."""
|
||||
data = {
|
||||
"id": "test-1",
|
||||
"file": "test.py",
|
||||
"line": 10,
|
||||
"title": "SQL Injection vulnerability",
|
||||
"description": "User input passed directly to query",
|
||||
"category": "security",
|
||||
"severity": "critical",
|
||||
"verification": {
|
||||
"code_examined": "cursor.execute(f'SELECT * FROM users WHERE id={user_id}')",
|
||||
"line_range_examined": [10, 10],
|
||||
"verification_method": "direct_code_inspection",
|
||||
},
|
||||
}
|
||||
result = ParallelOrchestratorFinding.model_validate(data)
|
||||
assert result.verification.code_examined is not None
|
||||
assert result.verification.verification_method == "direct_code_inspection"
|
||||
|
||||
def test_is_impact_finding_default_false(self):
|
||||
"""Test is_impact_finding defaults to False."""
|
||||
data = {
|
||||
"id": "test-1",
|
||||
"file": "test.py",
|
||||
"line": 10,
|
||||
"title": "Test",
|
||||
"description": "Test",
|
||||
"category": "quality",
|
||||
"severity": "medium",
|
||||
"verification": {
|
||||
"code_examined": "code",
|
||||
"line_range_examined": [10, 10],
|
||||
"verification_method": "direct_code_inspection",
|
||||
},
|
||||
}
|
||||
result = ParallelOrchestratorFinding.model_validate(data)
|
||||
assert result.is_impact_finding is False
|
||||
|
||||
def test_is_impact_finding_true(self):
|
||||
"""Test is_impact_finding can be set True."""
|
||||
data = {
|
||||
"id": "test-1",
|
||||
"file": "caller.py",
|
||||
"line": 50,
|
||||
"title": "Breaking change affects caller",
|
||||
"description": "This file calls the changed function and will break",
|
||||
"category": "logic",
|
||||
"severity": "high",
|
||||
"is_impact_finding": True,
|
||||
"verification": {
|
||||
"code_examined": "result = changed_function(x)",
|
||||
"line_range_examined": [50, 50],
|
||||
"verification_method": "cross_file_trace",
|
||||
},
|
||||
}
|
||||
result = ParallelOrchestratorFinding.model_validate(data)
|
||||
assert result.is_impact_finding is True
|
||||
|
||||
def test_checked_for_handling_elsewhere_default_false(self):
|
||||
"""Test checked_for_handling_elsewhere defaults to False."""
|
||||
data = {
|
||||
"id": "test-1",
|
||||
"file": "test.py",
|
||||
"line": 10,
|
||||
"title": "Missing error handling",
|
||||
"description": "No try-catch",
|
||||
"category": "quality",
|
||||
"severity": "medium",
|
||||
"verification": {
|
||||
"code_examined": "code",
|
||||
"line_range_examined": [10, 10],
|
||||
"verification_method": "direct_code_inspection",
|
||||
},
|
||||
}
|
||||
result = ParallelOrchestratorFinding.model_validate(data)
|
||||
assert result.checked_for_handling_elsewhere is False
|
||||
|
||||
def test_checked_for_handling_elsewhere_true(self):
|
||||
"""Test checked_for_handling_elsewhere can be set True."""
|
||||
data = {
|
||||
"id": "test-1",
|
||||
"file": "api.py",
|
||||
"line": 25,
|
||||
"title": "Missing error handling",
|
||||
"description": "No try-catch around database call",
|
||||
"category": "quality",
|
||||
"severity": "medium",
|
||||
"checked_for_handling_elsewhere": True,
|
||||
"verification": {
|
||||
"code_examined": "result = db.query(user_input)",
|
||||
"line_range_examined": [25, 25],
|
||||
"verification_method": "cross_file_trace",
|
||||
},
|
||||
}
|
||||
result = ParallelOrchestratorFinding.model_validate(data)
|
||||
assert result.checked_for_handling_elsewhere is True
|
||||
|
||||
|
||||
class TestVerificationSchemaGeneration:
|
||||
"""Tests for JSON schema generation with VerificationEvidence."""
|
||||
|
||||
def test_verification_in_parallel_orchestrator_schema(self):
|
||||
"""Test that VerificationEvidence appears in schema."""
|
||||
schema = ParallelOrchestratorFinding.model_json_schema()
|
||||
|
||||
# verification should be in properties
|
||||
assert "verification" in schema["properties"]
|
||||
|
||||
# Check $defs includes VerificationEvidence
|
||||
assert "$defs" in schema
|
||||
assert "VerificationEvidence" in schema["$defs"]
|
||||
|
||||
# Check VerificationEvidence has correct fields
|
||||
ve_schema = schema["$defs"]["VerificationEvidence"]
|
||||
assert "code_examined" in ve_schema["properties"]
|
||||
assert "line_range_examined" in ve_schema["properties"]
|
||||
assert "verification_method" in ve_schema["properties"]
|
||||
|
||||
def test_new_boolean_fields_in_schema(self):
|
||||
"""Test is_impact_finding and checked_for_handling_elsewhere in schema."""
|
||||
schema = ParallelOrchestratorFinding.model_json_schema()
|
||||
|
||||
assert "is_impact_finding" in schema["properties"]
|
||||
assert "checked_for_handling_elsewhere" in schema["properties"]
|
||||
@@ -0,0 +1,61 @@
|
||||
#!/usr/bin/env python3
|
||||
"""
|
||||
Shared Test Utilities
|
||||
=====================
|
||||
|
||||
Common helper functions for test files.
|
||||
"""
|
||||
|
||||
from unittest.mock import MagicMock
|
||||
|
||||
|
||||
def _create_mock_module():
|
||||
"""Create a simple mock module with necessary attributes.
|
||||
|
||||
Used by test files that need to mock external modules at import time.
|
||||
"""
|
||||
mock = MagicMock()
|
||||
return mock
|
||||
|
||||
|
||||
def configure_build_mocks(
|
||||
mock_validate_env,
|
||||
mock_should_run_qa,
|
||||
mock_get_phase_model,
|
||||
mock_choose_workspace,
|
||||
mock_get_existing,
|
||||
mock_run_agent,
|
||||
successful_agent_fn,
|
||||
validate_env=True,
|
||||
should_run_qa=False,
|
||||
workspace_mode=None,
|
||||
existing_spec=None,
|
||||
):
|
||||
"""
|
||||
Configure common mock defaults for build command tests.
|
||||
|
||||
This helper reduces the boilerplate of setting up the same 6-line mock pattern
|
||||
that was repeated 27+ times across test_cli_build_commands.py.
|
||||
|
||||
Usage:
|
||||
def test_something(
|
||||
mock_validate_env, mock_should_run_qa, mock_get_phase_model,
|
||||
mock_choose_workspace, mock_get_existing, mock_run_agent,
|
||||
successful_agent_fn
|
||||
):
|
||||
from test_utils import configure_build_mocks
|
||||
configure_build_mocks(
|
||||
mock_validate_env, mock_should_run_qa, mock_get_phase_model,
|
||||
mock_choose_workspace, mock_get_existing, mock_run_agent,
|
||||
successful_agent_fn
|
||||
)
|
||||
# ... rest of test
|
||||
"""
|
||||
from workspace import WorkspaceMode
|
||||
|
||||
mock_validate_env.return_value = validate_env
|
||||
mock_should_run_qa.return_value = should_run_qa
|
||||
mock_get_phase_model.side_effect = lambda spec_dir, phase, model: model or "sonnet"
|
||||
mock_choose_workspace.return_value = workspace_mode or WorkspaceMode.DIRECT
|
||||
mock_get_existing.return_value = existing_spec
|
||||
mock_run_agent.side_effect = successful_agent_fn
|
||||
@@ -631,7 +631,7 @@ class TestEdgeCases:
|
||||
|
||||
def test_nonexistent_directory(self, builder):
|
||||
"""Test handling of non-existent directory."""
|
||||
fake_dir = Path("/nonexistent/path")
|
||||
fake_dir = Path("/tmp/test-nonexistent-validation-123456")
|
||||
|
||||
# Should not crash, returns unknown
|
||||
strategy = builder.build_strategy(fake_dir, fake_dir, "medium")
|
||||
|
||||
Reference in New Issue
Block a user