Andrew Nicols
968183714d
In previous versions of Moodle we recommended use of the fallback resource with /error/index.php. This is incompatible with the routing system because they use the same mechanism for responding to any unknown request. To better handle this we need to move the current error handler page to a routed page, and to provide a shim for the old location. At the same time we need to improve the Slim Error handling middleware to respond with our 404 handler for all 404s, except for those on API routes where we always respond with JSON.
63 lines
2.1 KiB
PHP
63 lines
2.1 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
namespace core\router;
|
|
|
|
use Slim\Exception\HttpNotFoundException;
|
|
use Slim\Interfaces\ErrorRendererInterface;
|
|
use Throwable;
|
|
|
|
// phpcs:disable moodle.NamingConventions.ValidVariableName.VariableNameLowerCase
|
|
|
|
/**
|
|
* Class routed_error_handler
|
|
*
|
|
* @package core
|
|
* @copyright Andrew Lyons <andrew@nicols.co.uk>
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class error_renderer implements ErrorRendererInterface {
|
|
#[\Override]
|
|
public function __invoke(Throwable $exception, bool $displayErrorDetails): string {
|
|
// @codeCoverageIgnoreStart
|
|
if (defined('ABORT_AFTER_CONFIG') && !defined('ABORT_AFTER_CONFIG_CANCEL')) {
|
|
define('ABORT_AFTER_CONFIG_CANCEL', true);
|
|
require(__DIR__ . '/../../setup.php');
|
|
}
|
|
// @codeCoverageIgnoreEnd
|
|
|
|
if ($exception instanceof HttpNotFoundException) {
|
|
// This is a 404 error.
|
|
$controller = \core\di::get(\core\route\controller\page_not_found_controller::class);
|
|
|
|
return $controller->page_not_found_handler(
|
|
$exception->getRequest(),
|
|
)->getBody();
|
|
}
|
|
|
|
if ($whoops = get_whoops()) {
|
|
if ($exception instanceof \Slim\Exception\HttpException) {
|
|
$whoops->sendHttpCode($exception->getCode());
|
|
}
|
|
$whoops->handleException($exception);
|
|
} else {
|
|
default_exception_handler($exception);
|
|
}
|
|
|
|
return '';
|
|
}
|
|
}
|