Moodle release 3.6.2

These ids didn't exists in form elements in Boost until now, so we'll
remove the rules to prevent them having any effect now.

.eslintignore

@@ -6,7 +6,6 @@ vendor/
 admin/tool/policy/amd/src/jquery-eu-cookie-law-popup.js
 admin/tool/usertours/amd/src/tour.js
 auth/cas/CAS/
-cache/stores/mongodb/MongoDB/
 enrol/lti/ims-blti/
 filter/algebra/AlgParser.pm
 filter/tex/mimetex.*
@@ -64,7 +63,6 @@ lib/amd/src/adapter.js
 lib/validateurlsyntax.php
 lib/amd/src/popper.js
 lib/geopattern-php/
-lib/php-jwt/
 media/player/videojs/amd/src/video-lazy.js
 media/player/videojs/amd/src/Youtube-lazy.js
 media/player/videojs/videojs/
@@ -85,4 +83,8 @@ theme/boost/amd/src/tab.js
 theme/boost/amd/src/tooltip.js
 theme/boost/amd/src/util.js
 theme/boost/amd/src/tether.js
-theme/boost/scss/fontawesome/
+theme/boost/scss/fontawesome/
+theme/bootstrapbase/less/bootstrap/
+theme/bootstrapbase/javascript/html5shiv.js
+theme/bootstrapbase/amd/src/bootstrap.js
+theme/bootstrapbase/less/fontawesome/

.gitattributes

@@ -1,3 +1,5 @@
 **/yui/build/** -diff
 **/amd/build/** -diff
 lib/dml/oci_native_moodle_package.sql text eol=lf
+theme/bootstrapbase/style/editor.css -diff
+theme/bootstrapbase/style/moodle.css -diff

.gitignore

@@ -9,18 +9,10 @@
 #
 # See gitignore(5) man page for more details
 #
-
-# Swap files (vim)
-[._]*.s[a-v][a-z]
-[._]*.sw[a-p]
-[._]s[a-rt-v][a-z]
-[._]ss[a-gi-z]
-[._]sw[a-p]
-# Temporary files including undo
-*~
-#
 /config.php
 /lib/editor/tinymce/extra/tools/temp/
+*~
+*.swp
 /tags
 /TAGS
 /cscope.*

.stylelintignore

@@ -1,13 +1,14 @@
 # Generated by "grunt ignorefiles"
 **/yui/build/*
+theme/bootstrapbase/style/
+theme/clean/style/custom.css
+theme/more/style/custom.css
 theme/boost/style/moodle.css
-theme/classic/style/moodle.css
 node_modules/
 vendor/
 admin/tool/policy/amd/src/jquery-eu-cookie-law-popup.js
 admin/tool/usertours/amd/src/tour.js
 auth/cas/CAS/
-cache/stores/mongodb/MongoDB/
 enrol/lti/ims-blti/
 filter/algebra/AlgParser.pm
 filter/tex/mimetex.*
@@ -65,7 +66,6 @@ lib/amd/src/adapter.js
 lib/validateurlsyntax.php
 lib/amd/src/popper.js
 lib/geopattern-php/
-lib/php-jwt/
 media/player/videojs/amd/src/video-lazy.js
 media/player/videojs/amd/src/Youtube-lazy.js
 media/player/videojs/videojs/
@@ -86,4 +86,8 @@ theme/boost/amd/src/tab.js
 theme/boost/amd/src/tooltip.js
 theme/boost/amd/src/util.js
 theme/boost/amd/src/tether.js
-theme/boost/scss/fontawesome/
+theme/boost/scss/fontawesome/
+theme/bootstrapbase/less/bootstrap/
+theme/bootstrapbase/javascript/html5shiv.js
+theme/bootstrapbase/amd/src/bootstrap.js
+theme/bootstrapbase/less/fontawesome/

.travis.yml

@@ -14,7 +14,7 @@ language: php
 php:
     # We only run the highest and lowest supported versions to reduce the load on travis-ci.org.
     - 7.2
-    - 7.1
+    - 7.0
 
 addons:
   postgresql: "9.6"
@@ -63,7 +63,7 @@ matrix:
         # Exclude it on all versions except for 7.2
 
         - env: DB=mysqli   TASK=PHPUNIT
-          php: 7.1
+          php: 7.0
 
 cache:
     directories:
@@ -207,7 +207,7 @@ before_script:
         # We need the official upstream for comparison
         git remote add upstream https://github.com/moodle/moodle.git;
 
-        git fetch upstream master;
+        git fetch upstream MOODLE_36_STABLE;
         export GIT_PREVIOUS_COMMIT="`git merge-base FETCH_HEAD $TRAVIS_COMMIT`";
         export GIT_COMMIT="$TRAVIS_COMMIT";
         export UPSTREAM_FETCH_HEAD=`git rev-parse FETCH_HEAD`

Gruntfile.js

@@ -126,15 +126,25 @@ module.exports = function(grunt) {
                 options: {report: 'none'}
             }
         },
+        less: {
+            bootstrapbase: {
+                files: {
+                    "theme/bootstrapbase/style/moodle.css": "theme/bootstrapbase/less/moodle.less",
+                    "theme/bootstrapbase/style/editor.css": "theme/bootstrapbase/less/editor.less",
+                },
+                options: {
+                    compress: false // We must not compress to keep the comments.
+                }
+           }
+        },
         sass: {
             dist: {
                 files: {
-                    "theme/boost/style/moodle.css": "theme/boost/scss/preset/default.scss",
-                    "theme/classic/style/moodle.css": "theme/classic/scss/classicgrunt.scss"
+                    "theme/boost/style/moodle.css": "theme/boost/scss/preset/default.scss"
                 }
             },
             options: {
-                includePaths: ["theme/boost/scss/", "theme/classic/scss/"]
+                includePaths: ["theme/boost/scss/"]
             }
         },
         watch: {
@@ -145,6 +155,10 @@ module.exports = function(grunt) {
                 files: ['**/amd/src/**/*.js'],
                 tasks: ['amd']
             },
+            bootstrapbase: {
+                files: ["theme/bootstrapbase/less/**/*.less"],
+                tasks: ["css"]
+            },
             yui: {
                 files: ['**/yui/src/**/*.js'],
                 tasks: ['yui']
@@ -166,6 +180,18 @@ module.exports = function(grunt) {
             }
         },
         stylelint: {
+            less: {
+                options: {
+                    syntax: 'less',
+                    configOverrides: {
+                        rules: {
+                            // These rules have to be disabled in .stylelintrc for scss compat.
+                            "at-rule-no-unknown": true,
+                        }
+                    }
+                },
+                src: ['theme/**/*.less']
+            },
             scss: {
                 options: {syntax: 'scss'},
                 src: ['*/**/*.scss']
@@ -197,8 +223,10 @@ module.exports = function(grunt) {
       var stylelintIgnores = [
           '# Generated by "grunt ignorefiles"',
           '**/yui/build/*',
-          'theme/boost/style/moodle.css',
-          'theme/classic/style/moodle.css',
+          'theme/bootstrapbase/style/',
+          'theme/clean/style/custom.css',
+          'theme/more/style/custom.css',
+          'theme/boost/style/moodle.css'
       ].concat(thirdPartyPaths);
       grunt.file.write('.stylelintignore', stylelintIgnores.join('\n'));
     };
@@ -332,6 +360,7 @@ module.exports = function(grunt) {
           grunt.config('eslint.yui.src', files);
           grunt.config('uglify.amd.files', [{expand: true, src: files, rename: uglifyRename}]);
           grunt.config('shifter.options.paths', files);
+          grunt.config('stylelint.less.src', files);
           grunt.config('gherkinlint.options.files', files);
           changedFiles = Object.create(null);
     }, 200);
@@ -343,6 +372,7 @@ module.exports = function(grunt) {
 
     // Register NPM tasks.
     grunt.loadNpmTasks('grunt-contrib-uglify');
+    grunt.loadNpmTasks('grunt-contrib-less');
     grunt.loadNpmTasks('grunt-contrib-watch');
     grunt.loadNpmTasks('grunt-sass');
     grunt.loadNpmTasks('grunt-eslint');
@@ -357,7 +387,7 @@ module.exports = function(grunt) {
     grunt.registerTask('js', ['amd', 'yui']);
 
     // Register CSS taks.
-    grunt.registerTask('css', ['stylelint:scss', 'sass', 'stylelint:css']);
+    grunt.registerTask('css', ['stylelint:scss', 'sass', 'stylelint:less', 'less:bootstrapbase', 'stylelint:css']);
 
     // Register the startup task.
     grunt.registerTask('startup', 'Run the correct tasks for the current directory', tasks.startup);

admin/classes/form/testoutgoingmailconf_form.php

@@ -1,59 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * Testing outgoing mail configuration form
- *
- * @package    core
- * @copyright  2019 Victor Deniz <victor@moodle.com>
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-namespace core_admin\form;
-
-defined('MOODLE_INTERNAL') || die();
-
-require_once($CFG->libdir.'/formslib.php');
-
-/**
- * Test mail form
- *
- * @package    core
- * @copyright 2019 Victor Deniz <victor@moodle.com>
- * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-class testoutgoingmailconf_form extends \moodleform {
-    /**
-     * Add elements to form
-     */
-    public function definition() {
-        $mform = $this->_form;
-
-        // Recipient.
-        $options = ['maxlength' => '100', 'size' => '25'];
-        $mform->addElement('text', 'recipient', get_string('testoutgoingmailconf_toemail', 'admin'), $options);
-        $mform->setType('recipient', PARAM_EMAIL);
-        $mform->addRule('recipient', get_string('required'), 'required');
-
-        $buttonarray = array();
-        $buttonarray[] = $mform->createElement('submit', 'send', get_string('testoutgoingmailconf_sendtest', 'admin'));
-        $buttonarray[] = $mform->createElement('cancel');
-
-        $mform->addGroup($buttonarray, 'buttonar', '', array(' '), false);
-        $mform->closeHeaderBefore('buttonar');
-
-    }
-}

admin/classes/task_log_table.php

@@ -1,288 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * Task log table.
- *
- * @package    core_admin
- * @copyright  2018 Andrew Nicols <andrew@nicols.co.uk>
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-namespace core_admin;
-
-defined('MOODLE_INTERNAL') || die();
-
-require_once($CFG->libdir . '/tablelib.php');
-
-/**
- * Table to display list of task logs.
- *
- * @copyright  2018 Andrew Nicols <andrew@nicols.co.uk>
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-class task_log_table extends \table_sql {
-
-    /**
-     * Constructor for the task_log table.
-     *
-     * @param   string      $filter
-     * @param   int         $resultfilter
-     */
-    public function __construct(string $filter = '', int $resultfilter = null) {
-        global $DB;
-
-        if (-1 === $resultfilter) {
-            $resultfilter = null;
-        }
-
-        parent::__construct('tasklogs');
-
-        $columnheaders = [
-            'classname'  => get_string('name'),
-            'type'       => get_string('tasktype', 'admin'),
-            'userid'     => get_string('user', 'admin'),
-            'timestart'  => get_string('task_starttime', 'admin'),
-            'duration'   => get_string('task_duration', 'admin'),
-            'db'         => get_string('task_dbstats', 'admin'),
-            'result'     => get_string('task_result', 'admin'),
-            'actions'    => '',
-        ];
-        $this->define_columns(array_keys($columnheaders));
-        $this->define_headers(array_values($columnheaders));
-
-        // The name column is a header.
-        $this->define_header_column('classname');
-
-        // This table is not collapsible.
-        $this->collapsible(false);
-
-        // The actions class should not wrap. Use the BS text utility class.
-        $this->column_class('actions', 'text-nowrap');
-
-        // Allow pagination.
-        $this->pageable(true);
-
-        // Allow sorting. Default to sort by timestarted DESC.
-        $this->sortable(true, 'timestart', SORT_DESC);
-
-        // Add filtering.
-        $where = [];
-        $params = [];
-        if (!empty($filter)) {
-            $orwhere = [];
-            $filter = str_replace('\\', '\\\\', $filter);
-
-            // Check the class name.
-            $orwhere[] = $DB->sql_like('classname', ':classfilter', false, false);
-            $params['classfilter'] = '%' . $DB->sql_like_escape($filter) . '%';
-
-            $orwhere[] = $DB->sql_like('output', ':outputfilter', false, false);
-            $params['outputfilter'] = '%' . $DB->sql_like_escape($filter) . '%';
-
-            $where[] = "(" . implode(' OR ', $orwhere) . ")";
-        }
-
-        if (null !== $resultfilter) {
-            $where[] = 'tl.result = :result';
-            $params['result'] = $resultfilter;
-        }
-
-        $where = implode(' AND ', $where);
-
-        $this->set_sql('', '', $where, $params);
-    }
-
-    /**
-     * Query the db. Store results in the table object for use by build_table.
-     *
-     * @param int $pagesize size of page for paginated displayed table.
-     * @param bool $useinitialsbar do you want to use the initials bar. Bar
-     * will only be used if there is a fullname column defined for the table.
-     */
-    public function query_db($pagesize, $useinitialsbar = true) {
-        global $DB;
-
-        // Fetch the attempts.
-        $sort = $this->get_sql_sort();
-        if ($sort) {
-            $sort = "ORDER BY $sort";
-        }
-
-        $extrafields = get_extra_user_fields(\context_system::instance());
-        $userfields = \user_picture::fields('u', $extrafields, 'userid2', 'user');
-
-        $where = '';
-        if (!empty($this->sql->where)) {
-            $where = "WHERE {$this->sql->where}";
-        }
-
-        $sql = "SELECT
-                    tl.*,
-                    tl.dbreads + tl.dbwrites AS db,
-                    tl.timeend - tl.timestart AS duration,
-                    {$userfields}
-                FROM {task_log} tl
-           LEFT JOIN {user} u ON u.id = tl.userid
-                {$where}
-                {$sort}";
-
-        $this->pagesize($pagesize, $DB->count_records_sql("SELECT COUNT('x') FROM {task_log} tl {$where}", $this->sql->params));
-        if (!$this->is_downloading()) {
-            $this->rawdata = $DB->get_records_sql($sql, $this->sql->params, $this->get_page_start(), $this->get_page_size());
-        } else {
-            $this->rawdata = $DB->get_records_sql($sql, $this->sql->params);
-        }
-    }
-
-    /**
-     * Format the name cell.
-     *
-     * @param   \stdClass $row
-     * @return  string
-     */
-    public function col_classname($row) : string {
-        $output = '';
-        if (class_exists($row->classname)) {
-            $task = new $row->classname;
-            if ($task instanceof \core\task\scheduled_task) {
-                $output = $task->get_name();
-            }
-        }
-
-        $output .= \html_writer::tag('div', "\\{$row->classname}", [
-                'class' => 'task-class',
-            ]);
-        return $output;
-    }
-
-    /**
-     * Format the type cell.
-     *
-     * @param   \stdClass $row
-     * @return  string
-     */
-    public function col_type($row) : string {
-        if (\core\task\database_logger::TYPE_SCHEDULED == $row->type) {
-            return get_string('task_type:scheduled', 'admin');
-        } else {
-            return get_string('task_type:adhoc', 'admin');
-        }
-    }
-
-    /**
-     * Format the timestart cell.
-     *
-     * @param   \stdClass $row
-     * @return  string
-     */
-    public function col_result($row) : string {
-        if ($row->result) {
-            return get_string('task_result:failed', 'admin');
-        } else {
-            return get_string('success');
-        }
-    }
-
-    /**
-     * Format the timestart cell.
-     *
-     * @param   \stdClass $row
-     * @return  string
-     */
-    public function col_timestart($row) : string {
-        return userdate($row->timestart, get_string('strftimedatetimeshort', 'langconfig'));
-    }
-
-    /**
-     * Format the duration cell.
-     *
-     * @param   \stdClass $row
-     * @return  string
-     */
-    public function col_duration($row) : string {
-        $duration = round($row->timeend - $row->timestart, 2);
-
-        if (empty($duration)) {
-            // The format_time function returns 'now' when the difference is exactly 0.
-            // Note: format_time performs concatenation in exactly this fashion so we should do this for consistency.
-            return '0 ' . get_string('secs', 'moodle');
-        }
-
-        return format_time($duration);
-    }
-
-    /**
-     * Format the DB details cell.
-     *
-     * @param   \stdClass $row
-     * @return  string
-     */
-    public function col_db($row) : string {
-        $output = '';
-
-        $output .= \html_writer::div(get_string('task_stats:dbreads', 'admin', $row->dbreads));
-        $output .= \html_writer::div(get_string('task_stats:dbwrites', 'admin', $row->dbwrites));
-
-        return $output;
-    }
-
-    /**
-     * Format the actions cell.
-     *
-     * @param   \stdClass $row
-     * @return  string
-     */
-    public function col_actions($row) : string {
-        global $OUTPUT;
-
-        $actions = [];
-
-        $url = new \moodle_url('/admin/tasklogs.php', ['logid' => $row->id]);
-
-        // Quick view.
-        $actions[] = $OUTPUT->action_icon(
-            $url,
-            new \pix_icon('e/search', get_string('view')),
-            new \popup_action('click', $url)
-        );
-
-        // Download.
-        $actions[] = $OUTPUT->action_icon(
-            new \moodle_url($url, ['download' => true]),
-            new \pix_icon('t/download', get_string('download'))
-        );
-
-        return implode('&nbsp;', $actions);
-    }
-
-    /**
-     * Format the user cell.
-     *
-     * @param   \stdClass $row
-     * @return  string
-     */
-    public function col_userid($row) : string {
-        if (empty($row->userid)) {
-            return '';
-        }
-
-        $user = (object) [];
-        username_load_fields_from_object($user, $row, 'user');
-
-        return fullname($user);
-    }
-}

admin/cli/cfg.php

@@ -83,7 +83,7 @@ Examples:
         Stores the given configuration variable in the shell variable, escaped
         so that it can be safely used as a shell argument.
 
-    # php cfg.php --name=theme --set=classic
+    # php cfg.php --name=theme --set=clean
         Sets the given configuration variable to the given value.
 
     # php cfg.php --name=noemailever --unset

admin/cli/install.php

@@ -710,7 +710,7 @@ if ($interactive) {
     cli_separator();
     cli_heading(get_string('cliadminemail', 'install'));
     $prompt = get_string('clitypevaluedefault', 'admin', $options['adminemail']);
-    $options['adminemail'] = cli_input($prompt, $options['adminemail']);
+    $options['adminemail'] = cli_input($prompt);
 }
 
 // Validate that the address provided was an e-mail address.

admin/cli/install_database.php

@@ -82,6 +82,11 @@ require_once($CFG->libdir.'/installlib.php');
 require_once($CFG->libdir.'/adminlib.php');
 require_once($CFG->libdir.'/componentlib.class.php');
 
+// make sure no tables are installed yet
+if ($DB->get_tables() ) {
+    cli_error(get_string('clitablesexist', 'install'));
+}
+
 $CFG->early_install_lang = true;
 get_string_manager(true);
 
@@ -104,17 +109,12 @@ list($options, $unrecognized) = cli_get_params(
     )
 );
 
-// We show help text even if tables are installed.
+
 if ($options['help']) {
     echo $help;
     die;
 }
 
-// Make sure no tables are installed yet.
-if ($DB->get_tables() ) {
-    cli_error(get_string('clitablesexist', 'install'));
-}
-
 if (!$options['agree-license']) {
     cli_error('You have to agree to the license. --help prints out the help'); // TODO: localize
 }

admin/cli/uninstall_plugins.php

@@ -1,163 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * CLI script to uninstall plugins.
- *
- * @package    core
- * @subpackage cli
- * @copyright  2018 Dmitrii Metelkin <dmitriim@catalyst-au.net>
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-define('CLI_SCRIPT', true);
-
-require(__DIR__ . '/../../config.php');
-require_once($CFG->libdir . '/clilib.php');
-require_once($CFG->libdir . '/adminlib.php');
-
-$help = "Command line tool to uninstall plugins.
-
-Options:
-    -h --help                   Print this help.
-    --show-all                  Displays a list of all installed plugins.
-    --show-missing              Displays a list of plugins missing from disk.
-    --purge-missing             Uninstall all missing from disk plugins.
-    --plugins=<plugin name>     A comma separated list of plugins to be uninstalled. E.g. mod_assign,mod_forum
-    --run                       Execute uninstall. If this option is not set, then the script will be run in a dry mode.
-
-Examples:
-
-    # php uninstall_plugins.php  --show-all
-        Prints tab-separated list of all installed plugins.
-
-    # php uninstall_plugins.php  --show-missing
-        Prints tab-separated list of all missing from disk plugins.
-
-    # php uninstall_plugins.php  --purge-missing
-        A dry run of uninstalling all missing plugins.
-
-    # php uninstall_plugins.php  --purge-missing --run
-        Run uninstall of all missing plugins.
-
-    # php uninstall_plugins.php  --plugins=mod_assign,mod_forum
-        A dry run of uninstalling mod_assign and mod_forum plugins.
-
-    # php uninstall_plugins.php  --plugins=mod_assign,mod_forum --run
-        Run uninstall for mod_assign and mod_forum plugins.
-";
-
-list($options, $unrecognised) = cli_get_params([
-    'help' => false,
-    'show-all' => false,
-    'show-missing' => false,
-    'purge-missing' => false,
-    'plugins' => false,
-    'run' => false,
-], [
-    'h' => 'help'
-]);
-
-if ($unrecognised) {
-    $unrecognised = implode(PHP_EOL.'  ', $unrecognised);
-    cli_error(get_string('cliunknowoption', 'core_admin', $unrecognised));
-}
-
-if ($options['help']) {
-    cli_writeln($help);
-    exit(0);
-}
-
-$pluginman = core_plugin_manager::instance();
-$plugininfo = $pluginman->get_plugins();
-
-if ($options['show-all'] || $options['show-missing']) {
-    foreach ($plugininfo as $type => $plugins) {
-        foreach ($plugins as $name => $plugin) {
-            $pluginstring = $plugin->component . "\t" . $plugin->displayname;
-
-            if ($options['show-all']) {
-                cli_writeln($pluginstring);
-            } else {
-                if ($plugin->get_status() === core_plugin_manager::PLUGIN_STATUS_MISSING) {
-                    cli_writeln($pluginstring);
-                }
-            }
-        }
-    }
-
-    exit(0);
-}
-
-if ($options['purge-missing']) {
-    foreach ($plugininfo as $type => $plugins) {
-        foreach ($plugins as $name => $plugin) {
-            if ($plugin->get_status() === core_plugin_manager::PLUGIN_STATUS_MISSING) {
-
-                $pluginstring = $plugin->component . "\t" . $plugin->displayname;
-
-                if ($pluginman->can_uninstall_plugin($plugin->component)) {
-                    if ($options['run']) {
-                        cli_writeln('Uninstalling: ' . $pluginstring);
-
-                        $progress = new progress_trace_buffer(new text_progress_trace(), true);
-                        $pluginman->uninstall_plugin($plugin->component, $progress);
-                        $progress->finished();
-                        cli_write($progress->get_buffer());
-                    } else {
-                        cli_writeln('Will be uninstalled: ' . $pluginstring);
-                    }
-                } else {
-                    cli_writeln('Can not be uninstalled: ' . $pluginstring);
-                }
-            }
-        }
-    }
-
-    exit(0);
-}
-
-if ($options['plugins']) {
-    $components = explode(',', $options['plugins']);
-    foreach ($components as $component) {
-        $plugin = $pluginman->get_plugin_info($component);
-
-        if (is_null($plugin)) {
-            cli_writeln('Unknown plugin: ' . $component);
-        } else {
-            $pluginstring = $plugin->component . "\t" . $plugin->displayname;
-
-            if ($pluginman->can_uninstall_plugin($plugin->component)) {
-                if ($options['run']) {
-                    cli_writeln('Uninstalling: ' . $pluginstring);
-                    $progress = new progress_trace_buffer(new text_progress_trace(), true);
-                    $pluginman->uninstall_plugin($plugin->component, $progress);
-                    $progress->finished();
-                    cli_write($progress->get_buffer());
-                } else {
-                    cli_writeln('Will be uninstalled: ' . $pluginstring);
-                }
-            } else {
-                cli_writeln('Can not be uninstalled: ' . $pluginstring);
-            }
-        }
-    }
-
-    exit(0);
-}
-
-cli_writeln($help);
-exit(0);

admin/customfields.php

@@ -1,62 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * Allows the admin to enable, disable and uninstall custom fields
- *
- * @package    core_admin
- * @copyright  2018 Daniel Neis Araujo
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-require_once('../config.php');
-require_once($CFG->libdir.'/adminlib.php');
-
-$action  = required_param('action', PARAM_ALPHANUMEXT);
-$customfieldname = required_param('field', PARAM_PLUGIN);
-
-$syscontext = context_system::instance();
-$PAGE->set_url('/admin/customfields.php');
-$PAGE->set_context($syscontext);
-
-require_login();
-require_capability('moodle/site:config', $syscontext);
-require_sesskey();
-
-$return = new moodle_url('/admin/settings.php', array('section' => 'managecustomfields'));
-
-$customfieldplugins = core_plugin_manager::instance()->get_plugins_of_type('customfield');
-$sortorder = array_flip(array_keys($customfieldplugins));
-
-if (!isset($customfieldplugins[$customfieldname])) {
-    print_error('customfieldnotfound', 'error', $return, $customfieldname);
-}
-
-switch ($action) {
-    case 'disable':
-        if ($customfieldplugins[$customfieldname]->is_enabled()) {
-            set_config('disabled', 1, 'customfield_'. $customfieldname);
-            core_plugin_manager::reset_caches();
-        }
-        break;
-    case 'enable':
-        if (!$customfieldplugins[$customfieldname]->is_enabled()) {
-            unset_config('disabled', 'customfield_'. $customfieldname);
-            core_plugin_manager::reset_caches();
-        }
-        break;
-}
-redirect($return);

admin/index.php

@@ -823,11 +823,9 @@ if (isset($SESSION->pluginuninstallreturn)) {
 // Print default admin page with notifications.
 $errorsdisplayed = defined('WARN_DISPLAY_ERRORS_ENABLED');
 
-$lastcron = get_config('tool_task', 'lastcronstart');
+// We make the assumption that at least one schedule task should run once per day.
+$lastcron = $DB->get_field_sql('SELECT MAX(lastruntime) FROM {task_scheduled}');
 $cronoverdue = ($lastcron < time() - 3600 * 24);
-$lastcroninterval = get_config('tool_task', 'lastcroninterval');
-$expectedfrequency = $CFG->expectedcronfrequency ?? 200;
-$croninfrequent = !$cronoverdue && ($lastcroninterval > $expectedfrequency || $lastcron < time() - $expectedfrequency);
 $dbproblems = $DB->diagnose();
 $maintenancemode = !empty($CFG->maintenance_enabled);
 
@@ -888,4 +886,4 @@ $output = $PAGE->get_renderer('core', 'admin');
 echo $output->admin_notifications_page($maturity, $insecuredataroot, $errorsdisplayed, $cronoverdue, $dbproblems,
                                        $maintenancemode, $availableupdates, $availableupdatesfetch, $buggyiconvnomb,
                                        $registered, $cachewarnings, $eventshandlers, $themedesignermode, $devlibdir,
-                                       $mobileconfigured, $overridetossl, $invalidforgottenpasswordurl, $croninfrequent);
+                                       $mobileconfigured, $overridetossl, $invalidforgottenpasswordurl);

admin/message.php

@@ -25,101 +25,47 @@ require_once(__DIR__ . '/../config.php');
 require_once($CFG->dirroot . '/message/lib.php');
 require_once($CFG->libdir.'/adminlib.php');
 
-// This is an admin page.
+// This is an admin page
 admin_externalpage_setup('managemessageoutputs');
 
-// Fetch processors.
-$allprocessors = get_message_processors();
-$processors = array_filter($allprocessors, function($processor) {
-    return $processor->enabled;
-});
-// Fetch message providers.
-$providers = get_message_providers();
-// Fetch the manage message outputs interface.
-$preferences = get_message_output_default_preferences();
+// Get the submitted params
+$disable    = optional_param('disable', 0, PARAM_INT);
+$enable     = optional_param('enable', 0, PARAM_INT);
 
-if (($form = data_submitted()) && confirm_sesskey()) {
-    $preferences = array();
-    // Prepare default message outputs settings.
-    foreach ($providers as $provider) {
-        $componentproviderbase = $provider->component.'_'.$provider->name;
-        $disableprovidersetting = $componentproviderbase.'_disable';
-        $providerdisabled = false;
-        if (!isset($form->$disableprovidersetting)) {
-            $providerdisabled = true;
-            $preferences[$disableprovidersetting] = 1;
-        } else {
-            $preferences[$disableprovidersetting] = 0;
-        }
+$headingtitle = get_string('managemessageoutputs', 'message');
 
-        foreach (array('permitted', 'loggedin', 'loggedoff') as $setting) {
-            $value = null;
-            $componentprovidersetting = $componentproviderbase.'_'.$setting;
-            if ($setting == 'permitted') {
-                // If we deal with permitted select element, we need to create individual
-                // setting for each possible processor. Note that this block will
-                // always be processed first after entring parental foreach iteration
-                // so we can change form values on this stage.
-                foreach ($allprocessors as $processor) {
-                    $value = '';
-                    if (isset($form->{$componentprovidersetting}[$processor->name])) {
-                        $value = $form->{$componentprovidersetting}[$processor->name];
-                    }
-                    // Ensure that loggedin loggedoff options are set correctly for this permission.
-                    if (($value == 'disallowed') || $providerdisabled) {
-                        // It might be better to unset them, but I can't figure out why that cause error.
-                        $form->{$componentproviderbase.'_loggedin'}[$processor->name] = 0;
-                        $form->{$componentproviderbase.'_loggedoff'}[$processor->name] = 0;
-                    } else if ($value == 'forced') {
-                        $form->{$componentproviderbase.'_loggedin'}[$processor->name] = 1;
-                        $form->{$componentproviderbase.'_loggedoff'}[$processor->name] = 1;
-                    }
-                    // Record the site preference.
-                    $preferences[$processor->name.'_provider_'.$componentprovidersetting] = $value;
-                }
-            } else if (array_key_exists($componentprovidersetting, $form)) {
-                // We must be processing loggedin or loggedoff checkboxes. Store
-                // defained comma-separated processors as setting value.
-                // Using array_filter eliminates elements set to 0 above.
-                $value = join(',', array_keys(array_filter($form->{$componentprovidersetting})));
-                if (empty($value)) {
-                    $value = null;
-                }
-            }
-            if ($setting != 'permitted') {
-                // We have already recoded site preferences for 'permitted' type.
-                $preferences['message_provider_'.$componentprovidersetting] = $value;
-            }
-        }
+if (!empty($disable) && confirm_sesskey()) {
+    if (!$processor = $DB->get_record('message_processors', array('id'=>$disable))) {
+        print_error('outputdoesnotexist', 'message');
     }
-
-    // Update database.
-    $transaction = $DB->start_delegated_transaction();
-
-    // Save processors enabled/disabled status.
-    foreach ($allprocessors as $processor) {
-        $enabled = isset($form->{$processor->name});
-        \core_message\api::update_processor_status($processor, $enabled);
-    }
-
-    foreach ($preferences as $name => $value) {
-        set_config($name, $value, 'message');
-    }
-    $transaction->allow_commit();
-
+    \core_message\api::update_processor_status($processor, 0);     // Disable output.
     core_plugin_manager::reset_caches();
+}
 
+if (!empty($enable) && confirm_sesskey()) {
+    if (!$processor = $DB->get_record('message_processors', array('id'=>$enable))) {
+        print_error('outputdoesnotexist', 'message');
+    }
+    \core_message\api::update_processor_status($processor, 1);      // Enable output.
+    core_plugin_manager::reset_caches();
+}
+
+if ($disable || $enable) {
     $url = new moodle_url('message.php');
     redirect($url);
 }
-
 // Page settings
 $PAGE->set_context(context_system::instance());
-$PAGE->requires->js_init_call('M.core_message.init_defaultoutputs');
 
+// Grab the renderer
 $renderer = $PAGE->get_renderer('core', 'message');
 
-// Display the page.
+// Display the manage message outputs interface
+$processors = get_message_processors();
+$messageoutputs = $renderer->manage_messageoutputs($processors);
+
+// Display the page
 echo $OUTPUT->header();
-echo $renderer->manage_messageoutput_settings($allprocessors, $processors, $providers, $preferences);
+echo $OUTPUT->heading($headingtitle);
+echo $messageoutputs;
 echo $OUTPUT->footer();

admin/renderer.php

@@ -281,7 +281,6 @@ class core_admin_renderer extends plugin_renderer_base {
      * @param bool $mobileconfigured Whether the mobile web services have been enabled
      * @param bool $overridetossl Whether or not ssl is being forced.
      * @param bool $invalidforgottenpasswordurl Whether the forgotten password URL does not link to a valid URL.
-     * @param bool $croninfrequent If true, warn that cron hasn't run in the past few minutes
      *
      * @return string HTML to output.
      */
@@ -289,7 +288,7 @@ class core_admin_renderer extends plugin_renderer_base {
             $cronoverdue, $dbproblems, $maintenancemode, $availableupdates, $availableupdatesfetch,
             $buggyiconvnomb, $registered, array $cachewarnings = array(), $eventshandlers = 0,
             $themedesignermode = false, $devlibdir = false, $mobileconfigured = false,
-            $overridetossl = false, $invalidforgottenpasswordurl = false, $croninfrequent = false) {
+            $overridetossl = false, $invalidforgottenpasswordurl = false) {
         global $CFG;
         $output = '';
 
@@ -303,7 +302,6 @@ class core_admin_renderer extends plugin_renderer_base {
         $output .= $this->display_errors_warning($errorsdisplayed);
         $output .= $this->buggy_iconv_warning($buggyiconvnomb);
         $output .= $this->cron_overdue_warning($cronoverdue);
-        $output .= $this->cron_infrequent_warning($croninfrequent);
         $output .= $this->db_problems($dbproblems);
         $output .= $this->maintenance_mode_warning($maintenancemode);
         $output .= $this->overridetossl_warning($overridetossl);
@@ -616,24 +614,6 @@ class core_admin_renderer extends plugin_renderer_base {
                 $this->help_icon('cron', 'admin'));
     }
 
-    /**
-     * Render an appropriate message if cron is not being run frequently (recommended every minute).
-     *
-     * @param bool $croninfrequent
-     * @return string HTML to output.
-     */
-    public function cron_infrequent_warning(bool $croninfrequent) : string {
-        global $CFG;
-
-        if (!$croninfrequent) {
-            return '';
-        }
-
-        $expectedfrequency = $CFG->expectedcronfrequency ?? 200;
-        return $this->warning(get_string('croninfrequent', 'admin', $expectedfrequency) . ' ' .
-                $this->help_icon('cron', 'admin'));
-    }
-
     /**
      * Render an appropriate message if there are any problems with the DB set-up.
      * @param bool $dbproblems
@@ -843,7 +823,8 @@ class core_admin_renderer extends plugin_renderer_base {
      */
     protected function registration_warning($registered) {
 
-        if (!$registered && site_is_public()) {
+        if (!$registered) {
+
             if (has_capability('moodle/site:config', context_system::instance())) {
                 $registerbutton = $this->single_button(new moodle_url('/admin/registration/index.php'),
                     get_string('register', 'admin'));
@@ -1062,10 +1043,10 @@ class core_admin_renderer extends plugin_renderer_base {
 
                 if ($isstandard = $plugin->is_standard()) {
                     $row->attributes['class'] .= ' standard';
-                    $sourcelabel = html_writer::span(get_string('sourcestd', 'core_plugin'), 'sourcetext badge badge-secondary');
+                    $sourcelabel = html_writer::span(get_string('sourcestd', 'core_plugin'), 'sourcetext label');
                 } else {
                     $row->attributes['class'] .= ' extension';
-                    $sourcelabel = html_writer::span(get_string('sourceext', 'core_plugin'), 'sourcetext badge badge-info');
+                    $sourcelabel = html_writer::span(get_string('sourceext', 'core_plugin'), 'sourcetext label label-info');
                 }
 
                 $coredependency = $plugin->is_core_dependency_satisfied($version);
@@ -1074,22 +1055,22 @@ class core_admin_renderer extends plugin_renderer_base {
 
                 $statuscode = $plugin->get_status();
                 $row->attributes['class'] .= ' status-' . $statuscode;
-                $statusclass = 'statustext badge ';
+                $statusclass = 'statustext label ';
                 switch ($statuscode) {
                     case core_plugin_manager::PLUGIN_STATUS_NEW:
-                        $statusclass .= $dependenciesok ? 'badge-success' : 'badge-warning';
+                        $statusclass .= $dependenciesok ? 'label-success' : 'label-warning';
                         break;
                     case core_plugin_manager::PLUGIN_STATUS_UPGRADE:
-                        $statusclass .= $dependenciesok ? 'badge-info' : 'badge-warning';
+                        $statusclass .= $dependenciesok ? 'label-info' : 'label-warning';
                         break;
                     case core_plugin_manager::PLUGIN_STATUS_MISSING:
                     case core_plugin_manager::PLUGIN_STATUS_DOWNGRADE:
                     case core_plugin_manager::PLUGIN_STATUS_DELETE:
-                        $statusclass .= 'badge-danger';
+                        $statusclass .= 'label-important';
                         break;
                     case core_plugin_manager::PLUGIN_STATUS_NODB:
                     case core_plugin_manager::PLUGIN_STATUS_UPTODATE:
-                        $statusclass .= $dependenciesok ? '' : 'badge-warning';
+                        $statusclass .= $dependenciesok ? '' : 'label-warning';
                         break;
                 }
                 $status = html_writer::span(get_string('status_' . $statuscode, 'core_plugin'), $statusclass);
@@ -1362,7 +1343,7 @@ class core_admin_renderer extends plugin_renderer_base {
             $supportedmoodles = array();
             foreach ($plugin->version->supportedmoodles as $moodle) {
                 if ($CFG->branch == str_replace('.', '', $moodle->release)) {
-                    $supportedmoodles[] = html_writer::span($moodle->release, 'badge badge-success');
+                    $supportedmoodles[] = html_writer::span($moodle->release, 'label label-success');
                 } else {
                     $supportedmoodles[] = html_writer::span($moodle->release, 'label');
                 }
@@ -1467,7 +1448,7 @@ class core_admin_renderer extends plugin_renderer_base {
                     $label = '';
                 } else {
                     $class = 'requires-failed';
-                    $label = html_writer::span(get_string('dependencyfails', 'core_plugin'), 'badge badge-danger');
+                    $label = html_writer::span(get_string('dependencyfails', 'core_plugin'), 'label label-important');
                 }
                 $requires[] = html_writer::tag('li',
                     html_writer::span(get_string('moodleversion', 'core_plugin', $plugin->versionrequires), 'dep dep-core').
@@ -1482,8 +1463,8 @@ class core_admin_renderer extends plugin_renderer_base {
 
                 } else if ($reqinfo->status == $pluginman::REQUIREMENT_STATUS_MISSING) {
                     if ($reqinfo->availability == $pluginman::REQUIREMENT_AVAILABLE) {
-                        $label = html_writer::span(get_string('dependencymissing', 'core_plugin'), 'badge badge-warning');
-                        $label .= ' '.html_writer::span(get_string('dependencyavailable', 'core_plugin'), 'badge badge-warning');
+                        $label = html_writer::span(get_string('dependencymissing', 'core_plugin'), 'label label-warning');
+                        $label .= ' '.html_writer::span(get_string('dependencyavailable', 'core_plugin'), 'label label-warning');
                         $class = 'requires-failed requires-missing requires-available';
                         $actions[] = html_writer::link(
                             new moodle_url('https://moodle.org/plugins/view.php', array('plugin' => $reqname)),
@@ -1491,24 +1472,24 @@ class core_admin_renderer extends plugin_renderer_base {
                         );
 
                     } else {
-                        $label = html_writer::span(get_string('dependencymissing', 'core_plugin'), 'badge badge-danger');
+                        $label = html_writer::span(get_string('dependencymissing', 'core_plugin'), 'label label-important');
                         $label .= ' '.html_writer::span(get_string('dependencyunavailable', 'core_plugin'),
-                            'badge badge-danger');
+                            'label label-important');
                         $class = 'requires-failed requires-missing requires-unavailable';
                     }
                     $displayuploadlink = true;
 
                 } else if ($reqinfo->status == $pluginman::REQUIREMENT_STATUS_OUTDATED) {
                     if ($reqinfo->availability == $pluginman::REQUIREMENT_AVAILABLE) {
-                        $label = html_writer::span(get_string('dependencyfails', 'core_plugin'), 'badge badge-warning');
-                        $label .= ' '.html_writer::span(get_string('dependencyavailable', 'core_plugin'), 'badge badge-warning');
+                        $label = html_writer::span(get_string('dependencyfails', 'core_plugin'), 'label label-warning');
+                        $label .= ' '.html_writer::span(get_string('dependencyavailable', 'core_plugin'), 'label label-warning');
                         $class = 'requires-failed requires-outdated requires-available';
                         $displayupdateslink = true;
 
                     } else {
-                        $label = html_writer::span(get_string('dependencyfails', 'core_plugin'), 'badge badge-danger');
+                        $label = html_writer::span(get_string('dependencyfails', 'core_plugin'), 'label label-important');
                         $label .= ' '.html_writer::span(get_string('dependencyunavailable', 'core_plugin'),
-                            'badge badge-danger');
+                            'label label-important');
                         $class = 'requires-failed requires-outdated requires-unavailable';
                     }
                     $displayuploadlink = true;
@@ -1772,13 +1753,13 @@ class core_admin_renderer extends plugin_renderer_base {
                     $source = '';
                 } else {
                     $row->attributes['class'] .= ' extension';
-                    $source = html_writer::div(get_string('sourceext', 'core_plugin'), 'source badge badge-info');
+                    $source = html_writer::div(get_string('sourceext', 'core_plugin'), 'source label label-info');
                 }
 
                 if ($status === core_plugin_manager::PLUGIN_STATUS_MISSING) {
-                    $msg = html_writer::div(get_string('status_missing', 'core_plugin'), 'statusmsg badge badge-danger');
+                    $msg = html_writer::div(get_string('status_missing', 'core_plugin'), 'statusmsg label label-important');
                 } else if ($status === core_plugin_manager::PLUGIN_STATUS_NEW) {
-                    $msg = html_writer::div(get_string('status_new', 'core_plugin'), 'statusmsg badge badge-success');
+                    $msg = html_writer::div(get_string('status_new', 'core_plugin'), 'statusmsg label label-success');
                 } else {
                     $msg = '';
                 }
@@ -2017,15 +1998,15 @@ class core_admin_renderer extends plugin_renderer_base {
                 // Format error or warning line
                 if ($errorline) {
                     $messagetype = 'error';
-                    $statusclass = 'badge-danger';
+                    $statusclass = 'label-important';
                 } else if ($warningline) {
                     $messagetype = 'warn';
-                    $statusclass = 'badge-warning';
+                    $statusclass = 'label-warning';
                 } else {
                     $messagetype = 'ok';
-                    $statusclass = 'badge-success';
+                    $statusclass = 'label-success';
                 }
-                $status = html_writer::span($status, 'badge ' . $statusclass);
+                $status = html_writer::span($status, 'label ' . $statusclass);
                 // Here we'll store all the feedback found
                 $feedbacktext = '';
                 // Append the feedback if there is some

admin/roles/classes/check_users_selector.php

@@ -69,11 +69,8 @@ class core_role_check_users_selector extends user_selector_base {
 
         if ($coursecontext and $coursecontext != SITEID) {
             $sql1 = " FROM {user} u
-                      JOIN (SELECT DISTINCT subu.id
-                              FROM {user} subu
-                              JOIN {user_enrolments} ue ON (ue.userid = subu.id)
-                              JOIN {enrol} e ON (e.id = ue.enrolid AND e.courseid = :courseid1)
-                           ) subq ON subq.id = u.id
+                      JOIN {user_enrolments} ue ON (ue.userid = u.id)
+                      JOIN {enrol} e ON (e.id = ue.enrolid AND e.courseid = :courseid1)
                      WHERE $wherecondition";
             $params['courseid1'] = $coursecontext->instanceid;
 

admin/roles/module.js

@@ -51,7 +51,7 @@ M.core_role.init_cap_table_filter = function(Y, tableid, contextid) {
                 marginRight : 'auto'
             });
             // Create the capability search input.
-            this.input = Y.Node.create('<input class="form-control mx-1" type="text"' +
+            this.input = Y.Node.create('<input class="form-control m-x-1" type="text"' +
                 ' id="'+this.table.get('id')+'capabilitysearch" value="'+Y.Escape.html(filtervalue)+'" />');
             // Create a label for the search input.
             this.label = Y.Node.create('<label for="' + this.input.get('id') + '">' +

admin/searchareas.php

@@ -153,7 +153,6 @@ $table = new html_table();
 $table->id = 'core-search-areas';
 $table->head = [
     get_string('searcharea', 'search'),
-    get_string('searchareacategories', 'search'),
     get_string('enable'),
     get_string('newestdocindexed', 'admin'),
     get_string('searchlastrun', 'admin'),
@@ -166,14 +165,6 @@ foreach ($searchareas as $area) {
     $areaid = $area->get_area_id();
     $columns = array(new html_table_cell($area->get_visible_name()));
 
-    $areacategories = [];
-    foreach (\core_search\manager::get_search_area_categories() as $category) {
-        if (key_exists($areaid, $category->get_areas())) {
-            $areacategories[] = $category->get_visiblename();
-        }
-    }
-    $columns[] = new html_table_cell(implode(', ', $areacategories));
-
     if ($area->is_enabled()) {
         $columns[] = $OUTPUT->action_icon(admin_searcharea_action_url('disable', $areaid),
             new pix_icon('t/hide', get_string('disable'), 'moodle', array('title' => '', 'class' => 'iconsmall')),

admin/settings.php

@@ -156,11 +156,4 @@ $PAGE->requires->yui_module('moodle-core-formchangechecker',
 );
 $PAGE->requires->string_for_js('changesmadereallygoaway', 'moodle');
 
-if ($settingspage->has_dependencies()) {
-    $opts = [
-        'dependencies' => $settingspage->get_dependencies_for_javascript()
-    ];
-    $PAGE->requires->js_call_amd('core/showhidesettings', 'init', [$opts]);
-}
-
 echo $OUTPUT->footer();

admin/settings/analytics.php

@@ -25,52 +25,10 @@
 defined('MOODLE_INTERNAL') || die();
 
 if ($hassiteconfig) {
-
-    $settings = new admin_settingpage('analyticssite', new lang_string('analyticssiteinfo', 'analytics'));
-    $ADMIN->add('analytics', $settings);
-
-    if ($ADMIN->fulltree) {
-        $modeinstructions = [
-            'facetoface' => get_string('modeinstructionfacetoface', 'analytics'),
-            'blendedhybrid' => get_string('modeinstructionblendedhybrid', 'analytics'),
-            'fullyonline' => get_string('modeinstructionfullyonline', 'analytics'),
-        ];
-        $settings->add(new admin_setting_configmultiselect('analytics/modeinstruction', get_string('modeinstruction', 'analytics'),
-            '', [], $modeinstructions));
-
-        $settings->add(new admin_setting_configtext_with_maxlength('analytics/percentonline',
-            get_string('percentonline', 'analytics'),
-            get_string('percentonline_help', 'analytics'), '', PARAM_INT, 3, 3));
-
-        $typeinstitutions = [
-            'typeinstitutionacademic' => get_string('typeinstitutionacademic', 'analytics'),
-            'typeinstitutiontraining' => get_string('typeinstitutiontraining', 'analytics'),
-            'typeinstitutionngo' => get_string('typeinstitutionngo', 'analytics'),
-        ];
-        $settings->add(new admin_setting_configmultiselect('analytics/typeinstitution', get_string('typeinstitution', 'analytics'),
-            '', [], $typeinstitutions));
-
-        $levelinstitutions = [
-            'levelinstitutionisced0' => get_string('levelinstitutionisced0', 'analytics'),
-            'levelinstitutionisced1' => get_string('levelinstitutionisced1', 'analytics'),
-            'levelinstitutionisced2' => get_string('levelinstitutionisced2', 'analytics'),
-            'levelinstitutionisced3' => get_string('levelinstitutionisced3', 'analytics'),
-            'levelinstitutionisced4' => get_string('levelinstitutionisced4', 'analytics'),
-            'levelinstitutionisced5' => get_string('levelinstitutionisced5', 'analytics'),
-            'levelinstitutionisced6' => get_string('levelinstitutionisced6', 'analytics'),
-            'levelinstitutionisced7' => get_string('levelinstitutionisced7', 'analytics'),
-            'levelinstitutionisced8' => get_string('levelinstitutionisced8', 'analytics'),
-        ];
-        $settings->add(new admin_setting_configmultiselect('analytics/levelinstitution',
-            get_string('levelinstitution', 'analytics'), '', [], $levelinstitutions));
-    }
-
     $settings = new admin_settingpage('analyticssettings', new lang_string('analyticssettings', 'analytics'));
     $ADMIN->add('analytics', $settings);
 
     if ($ADMIN->fulltree) {
-
-
         // Select the site prediction's processor.
         $predictionprocessors = \core_analytics\manager::get_all_prediction_processors();
         $predictors = array();
@@ -117,7 +75,7 @@ if ($hassiteconfig) {
             $defaultreader, $options));
 
         // Enable/disable time splitting methods.
-        $alltimesplittings = \core_analytics\manager::get_time_splitting_methods_for_evaluation(true);
+        $alltimesplittings = \core_analytics\manager::get_all_time_splittings();
 
         $timesplittingoptions = array();
         $timesplittingdefaults = array('\core\analytics\time_splitting\quarters_accum',
@@ -125,9 +83,8 @@ if ($hassiteconfig) {
         foreach ($alltimesplittings as $key => $timesplitting) {
             $timesplittingoptions[$key] = $timesplitting->get_name();
         }
-        $settings->add(new admin_setting_configmultiselect('analytics/defaulttimesplittingsevaluation',
-            new lang_string('defaulttimesplittingmethods', 'analytics'),
-            new lang_string('defaulttimesplittingmethods_help', 'analytics'),
+        $settings->add(new admin_setting_configmultiselect('analytics/timesplittings',
+            new lang_string('enabledtimesplittings', 'analytics'), new lang_string('timesplittingmethod_help', 'analytics'),
             $timesplittingdefaults, $timesplittingoptions)
         );
 

admin/settings/appearance.php

@@ -25,6 +25,7 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) { // sp
     $temp->add(new admin_setting_configcheckbox('allowcohortthemes',  new lang_string('allowcohortthemes', 'admin'), new lang_string('configallowcohortthemes', 'admin'), 0));
     $temp->add(new admin_setting_configcheckbox('allowthemechangeonurl',  new lang_string('allowthemechangeonurl', 'admin'), new lang_string('configallowthemechangeonurl', 'admin'), 0));
     $temp->add(new admin_setting_configcheckbox('allowuserblockhiding', new lang_string('allowuserblockhiding', 'admin'), new lang_string('configallowuserblockhiding', 'admin'), 1));
+    $temp->add(new admin_setting_configcheckbox('allowblockstodock', new lang_string('allowblockstodock', 'admin'), new lang_string('configallowblockstodock', 'admin'), 1));
     $temp->add(new admin_setting_configtextarea('custommenuitems', new lang_string('custommenuitems', 'admin'),
         new lang_string('configcustommenuitems', 'admin'), '', PARAM_RAW, '50', '10'));
     $temp->add(new admin_setting_configtextarea(

admin/settings/badges.php

@@ -57,11 +57,9 @@ if (($hassiteconfig || has_any_capability(array(
             new lang_string('badgesalt_desc', 'badges'),
             'badges' . $SITE->timecreated, PARAM_ALPHANUM));
 
-    $backpacks = badges_get_site_backpacks();
-    $choices = array();
-    foreach ($backpacks as $backpack) {
-        $choices[$backpack->id] = $backpack->backpackweburl;
-    }
+    $globalsettings->add(new admin_setting_configcheckbox('badges_allowexternalbackpack',
+            new lang_string('allowexternalbackpack', 'badges'),
+            new lang_string('allowexternalbackpack_desc', 'badges'), 1));
 
     $globalsettings->add(new admin_setting_configcheckbox('badges_allowcoursebadges',
             new lang_string('allowcoursebadges', 'badges'),
@@ -93,32 +91,4 @@ if (($hassiteconfig || has_any_capability(array(
             array('moodle/badges:createbadge'), empty($CFG->enablebadges)
         )
     );
-    $backpacksettings = new admin_settingpage('backpacksettings', new lang_string('backpacksettings', 'badges'),
-            array('moodle/badges:manageglobalsettings'), empty($CFG->enablebadges));
-
-    $backpacksettings->add(new admin_setting_configcheckbox('badges_allowexternalbackpack',
-            new lang_string('allowexternalbackpack', 'badges'),
-            new lang_string('allowexternalbackpack_desc', 'badges'), 1));
-
-    $backpacksettings->add(new admin_setting_configselect('badges_site_backpack',
-            new lang_string('sitebackpack', 'badges'),
-            new lang_string('sitebackpack_help', 'badges'),
-            1, $choices));
-
-    $warning = badges_verify_site_backpack();
-    if (!empty($warning)) {
-        $backpacksettings->add(new admin_setting_description('badges_site_backpack_verify',
-            new lang_string('sitebackpackverify', 'badges'),
-            $warning));
-    }
-
-    $ADMIN->add('badges', $backpacksettings);
-
-    $ADMIN->add('badges',
-        new admin_externalpage('managebackpacks',
-            new lang_string('managebackpacks', 'badges'),
-            new moodle_url('/badges/backpacks.php'),
-            array('moodle/badges:manageglobalsettings'), empty($CFG->enablebadges) || empty($CFG->badges_allowexternalbackpack)
-        )
-    );
 }

admin/settings/courses.php

@@ -37,12 +37,6 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) {
             array('moodle/category:manage', 'moodle/course:create')
         )
     );
-    $ADMIN->add('courses',
-        new admin_externalpage('course_customfield', new lang_string('course_customfield', 'admin'),
-            $CFG->wwwroot . '/course/customfield.php',
-            array('moodle/course:configurecustomfields')
-        )
-    );
     $ADMIN->add('courses',
         new admin_externalpage('addcategory', new lang_string('addcategory', 'admin'),
             new moodle_url('/course/editcategory.php', array('parent' => 0)),
@@ -336,7 +330,7 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) {
     $temp->add(new admin_setting_configcheckbox('backup/backup_auto_skip_modif_prev', new lang_string('skipmodifprev', 'backup'), new lang_string('skipmodifprevhelp', 'backup'), 0));
 
     // Automated defaults section.
-    $temp->add(new admin_setting_heading('automatedsettings', new lang_string('automatedsettings','backup'), new lang_string('recyclebin_desc', 'backup')));
+    $temp->add(new admin_setting_heading('automatedsettings', new lang_string('automatedsettings','backup'), ''));
     $temp->add(new admin_setting_configcheckbox('backup/backup_auto_users', new lang_string('generalusers', 'backup'), new lang_string('configgeneralusers', 'backup'), 1));
     $temp->add(new admin_setting_configcheckbox('backup/backup_auto_role_assignments', new lang_string('generalroleassignments','backup'), new lang_string('configgeneralroleassignments','backup'), 1));
     $temp->add(new admin_setting_configcheckbox('backup/backup_auto_activities', new lang_string('generalactivities','backup'), new lang_string('configgeneralactivities','backup'), 1));
@@ -458,28 +452,4 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) {
 
     $ADMIN->add('backups', $temp);
 
-    // Create a page for asynchronous backup and restore configuration and defaults.
-    if (!empty($CFG->enableasyncbackup)) {  // Only add settings if async mode is enable at site level.
-        $temp = new admin_settingpage('asyncgeneralsettings', new lang_string('asyncgeneralsettings', 'backup'));
-
-        $temp->add(new admin_setting_configcheckbox(
-                'backup/backup_async_message_users',
-                new lang_string('asyncemailenable', 'backup'),
-                new lang_string('asyncemailenabledetail', 'backup'), 0));
-
-        $temp->add(new admin_setting_configtext(
-                'backup/backup_async_message_subject',
-                new lang_string('asyncmessagesubject', 'backup'),
-                new lang_string('asyncmessagesubjectdetail', 'backup'),
-                new lang_string('asyncmessagesubjectdefault', 'backup')));
-
-        $temp->add(new admin_setting_confightmleditor(
-                'backup/backup_async_message',
-                new lang_string('asyncmessagebody', 'backup'),
-                new lang_string('asyncmessagebodydetail', 'backup'),
-                new lang_string('asyncmessagebodydefault', 'backup')));
-
-        $ADMIN->add('backups', $temp);
-    }
-
 }

admin/settings/development.php

@@ -59,8 +59,6 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
     $temp->add(new admin_setting_configcheckbox('profilingallowme', new lang_string('profilingallowme', 'admin'), new lang_string('profilingallowme_help', 'admin'), false));
     // Allow PROFILEALL/PROFILEALLSTOP GPC.
     $temp->add(new admin_setting_configcheckbox('profilingallowall', new lang_string('profilingallowall', 'admin'), new lang_string('profilingallowall_help', 'admin'), false));
-    $temp->add(new admin_setting_configtext('profilingslow', new lang_string('profilingslow', 'admin'),
-        new lang_string('profilingslow_help', 'admin'), 0, PARAM_FLOAT));
     // TODO: Allow to skip PHP functions (XHPROF_FLAGS_NO_BUILTINS)
     // TODO: Allow to skip call_user functions (ignored_functions array)
     // Specify the life time (in minutes) of profiling runs.

admin/settings/messaging.php

@@ -1,78 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * Adds messaging related settings links for Messaging category to admin tree.
- *
- * @copyright 2019 Amaia Anabitarte <amaia@moodle.com>
- * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-defined('MOODLE_INTERNAL') || die();
-
-if ($hassiteconfig) {
-    $temp = new admin_settingpage('messages', new lang_string('messagingssettings', 'admin'));
-    $temp->add(new admin_setting_configcheckbox('messaging',
-        new lang_string('messaging', 'admin'),
-        new lang_string('configmessaging', 'admin'),
-        1));
-    $temp->add(new admin_setting_configcheckbox('messagingallusers',
-            new lang_string('messagingallusers', 'admin'),
-            new lang_string('configmessagingallusers', 'admin'),
-             0)
-    );
-    $temp->add(new admin_setting_configcheckbox('messagingdefaultpressenter',
-            new lang_string('messagingdefaultpressenter', 'admin'),
-            new lang_string('configmessagingdefaultpressenter', 'admin'),
-            1)
-    );
-    $options = array(
-        DAYSECS => new lang_string('secondstotime86400'),
-        WEEKSECS => new lang_string('secondstotime604800'),
-        2620800 => new lang_string('nummonths', 'moodle', 1),
-        7862400 => new lang_string('nummonths', 'moodle', 3),
-        15724800 => new lang_string('nummonths', 'moodle', 6),
-        0 => new lang_string('never')
-    );
-    $temp->add(new admin_setting_configselect(
-            'messagingdeletereadnotificationsdelay',
-            new lang_string('messagingdeletereadnotificationsdelay', 'admin'),
-            new lang_string('configmessagingdeletereadnotificationsdelay', 'admin'),
-            604800,
-            $options)
-    );
-    $temp->add(new admin_setting_configselect(
-            'messagingdeleteallnotificationsdelay',
-            new lang_string('messagingdeleteallnotificationsdelay', 'admin'),
-            new lang_string('configmessagingdeleteallnotificationsdelay', 'admin'),
-            2620800,
-            $options)
-    );
-    $temp->add(new admin_setting_configcheckbox('messagingallowemailoverride',
-        new lang_string('messagingallowemailoverride', 'admin'),
-        new lang_string('configmessagingallowemailoverride', 'admin'),
-        0));
-    $ADMIN->add('messaging', $temp);
-    $ADMIN->add('messaging', new admin_page_managemessageoutputs());
-
-    // Notification outputs plugins.
-    $plugins = core_plugin_manager::instance()->get_plugins_of_type('message');
-    core_collator::asort_objects_by_property($plugins, 'displayname');
-    foreach ($plugins as $plugin) {
-        /** @var \core\plugininfo\message $plugin */
-        $plugin->load_settings($ADMIN, 'messaging', $hassiteconfig);
-    }
-}

admin/settings/plugins.php

@@ -59,18 +59,6 @@ if ($hassiteconfig) {
         $plugin->load_settings($ADMIN, 'formatsettings', $hassiteconfig);
     }
 
-    // Custom fields.
-    $ADMIN->add('modules', new admin_category('customfieldsettings', new lang_string('customfields', 'core_customfield')));
-    $temp = new admin_settingpage('managecustomfields', new lang_string('managecustomfields', 'core_admin'));
-    $temp->add(new admin_setting_managecustomfields());
-    $ADMIN->add('customfieldsettings', $temp);
-    $plugins = core_plugin_manager::instance()->get_plugins_of_type('customfield');
-    core_collator::asort_objects_by_property($plugins, 'displayname');
-    foreach ($plugins as $plugin) {
-        /** @var \core\plugininfo\customfield $plugin */
-        $plugin->load_settings($ADMIN, 'customfieldsettings', $hassiteconfig);
-    }
-
     // blocks
     $ADMIN->add('modules', new admin_category('blocksettings', new lang_string('blocks')));
     $ADMIN->add('blocksettings', new admin_page_manageblocks());
@@ -81,6 +69,17 @@ if ($hassiteconfig) {
         $plugin->load_settings($ADMIN, 'blocksettings', $hassiteconfig);
     }
 
+    // message outputs
+    $ADMIN->add('modules', new admin_category('messageoutputs', new lang_string('messageoutputs', 'message')));
+    $ADMIN->add('messageoutputs', new admin_page_managemessageoutputs());
+    $ADMIN->add('messageoutputs', new admin_page_defaultmessageoutputs());
+    $plugins = core_plugin_manager::instance()->get_plugins_of_type('message');
+    core_collator::asort_objects_by_property($plugins, 'displayname');
+    foreach ($plugins as $plugin) {
+        /** @var \core\plugininfo\message $plugin */
+        $plugin->load_settings($ADMIN, 'messageoutputs', $hassiteconfig);
+    }
+
     // authentication plugins
     $ADMIN->add('modules', new admin_category('authsettings', new lang_string('authentication', 'admin')));
 
@@ -565,37 +564,14 @@ if ($hassiteconfig) {
     $temp->add(new admin_setting_configduration('searchindextime',
             new lang_string('searchindextime', 'admin'), new lang_string('searchindextime_desc', 'admin'),
             600));
-    $temp->add(new admin_setting_heading('searchcoursesheading', new lang_string('searchablecourses', 'admin'), ''));
     $options = [
         0 => new lang_string('searchallavailablecourses_off', 'admin'),
         1 => new lang_string('searchallavailablecourses_on', 'admin')
     ];
     $temp->add(new admin_setting_configselect('searchallavailablecourses',
             new lang_string('searchallavailablecourses', 'admin'),
-            new lang_string('searchallavailablecoursesdesc', 'admin'),
+            new lang_string('searchallavailablecourses_desc', 'admin'),
             0, $options));
-    $temp->add(new admin_setting_configcheckbox('searchincludeallcourses',
-        new lang_string('searchincludeallcourses', 'admin'), new lang_string('searchincludeallcourses_desc', 'admin'),
-        0));
-
-    // Search display options.
-    $temp->add(new admin_setting_heading('searchdisplay', new lang_string('searchdisplay', 'admin'), ''));
-    $temp->add(new admin_setting_configcheckbox('searchenablecategories',
-        new lang_string('searchenablecategories', 'admin'),
-        new lang_string('searchenablecategories_desc', 'admin'),
-        0));
-    $options = [];
-    foreach (\core_search\manager::get_search_area_categories() as $category) {
-        $options[$category->get_name()] = $category->get_visiblename();
-    }
-    $temp->add(new admin_setting_configselect('searchdefaultcategory',
-        new lang_string('searchdefaultcategory', 'admin'),
-        new lang_string('searchdefaultcategory_desc', 'admin'),
-        \core_search\manager::SEARCH_AREA_CATEGORY_ALL, $options));
-    $temp->add(new admin_setting_configcheckbox('searchhideallcategory',
-        new lang_string('searchhideallcategory', 'admin'),
-        new lang_string('searchhideallcategory_desc', 'admin'),
-        0));
 
     $ADMIN->add('searchplugins', $temp);
     $ADMIN->add('searchplugins', new admin_externalpage('searchareas', new lang_string('searchareas', 'admin'),

admin/settings/server.php

@@ -4,6 +4,7 @@
 
 if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
 
+
 // "systempaths" settingpage
 $temp = new admin_settingpage('systempaths', new lang_string('systempaths','admin'));
 $temp->add(new admin_setting_configexecutable('pathtophp', new lang_string('pathtophp', 'admin'),
@@ -176,8 +177,6 @@ $ADMIN->add('server', $temp);
 
 $ADMIN->add('server', new admin_externalpage('environment', new lang_string('environment','admin'), "$CFG->wwwroot/$CFG->admin/environment.php"));
 $ADMIN->add('server', new admin_externalpage('phpinfo', new lang_string('phpinfo'), "$CFG->wwwroot/$CFG->admin/phpinfo.php"));
-$ADMIN->add('server', new admin_externalpage('testoutgoingmailconf', new lang_string('testoutgoingmailconf', 'admin'),
-            new moodle_url("$CFG->wwwroot/$CFG->admin/testoutgoingmailconf.php"), 'moodle/site:config', true));
 
 
 // "performance" settingpage
@@ -213,92 +212,6 @@ $temp->add(new admin_setting_configtext('curltimeoutkbitrate', new lang_string('
 $ADMIN->add('server', $temp);
 
 
-$ADMIN->add('server', new admin_category('taskconfig', new lang_string('taskadmintitle', 'admin')));
-$temp = new admin_settingpage('taskprocessing', new lang_string('taskprocessing','admin'));
-$temp->add(
-    new admin_setting_configtext(
-        'task_scheduled_concurrency_limit',
-        new lang_string('task_scheduled_concurrency_limit', 'admin'),
-        new lang_string('task_scheduled_concurrency_limit_desc', 'admin'),
-        3,
-        PARAM_INT
-    )
-);
-
-$temp->add(
-    new admin_setting_configduration(
-        'task_scheduled_max_runtime',
-        new lang_string('task_scheduled_max_runtime', 'admin'),
-        new lang_string('task_scheduled_max_runtime_desc', 'admin'),
-        30 * MINSECS
-    )
-);
-
-$temp->add(
-    new admin_setting_configtext(
-        'task_adhoc_concurrency_limit',
-        new lang_string('task_adhoc_concurrency_limit', 'admin'),
-        new lang_string('task_adhoc_concurrency_limit_desc', 'admin'),
-        3,
-        PARAM_INT
-    )
-);
-
-$temp->add(
-    new admin_setting_configduration(
-        'task_adhoc_max_runtime',
-        new lang_string('task_adhoc_max_runtime', 'admin'),
-        new lang_string('task_adhoc_max_runtime_desc', 'admin'),
-        30 * MINSECS
-    )
-);
-$ADMIN->add('taskconfig', $temp);
-
-$temp = new admin_settingpage('tasklogging', new lang_string('tasklogging','admin'));
-$temp->add(
-    new admin_setting_configselect(
-        'task_logmode',
-        new lang_string('task_logmode', 'admin'),
-        new lang_string('task_logmode_desc', 'admin'),
-        \core\task\logmanager::MODE_ALL,
-        [
-            \core\task\logmanager::MODE_ALL => new lang_string('task_logmode_all', 'admin'),
-            \core\task\logmanager::MODE_FAILONLY => new lang_string('task_logmode_failonly', 'admin'),
-            \core\task\logmanager::MODE_NONE => new lang_string('task_logmode_none', 'admin'),
-        ]
-    )
-);
-
-if (\core\task\logmanager::uses_standard_settings()) {
-    $temp->add(
-        new admin_setting_configduration(
-            'task_logretention',
-            new \lang_string('task_logretention', 'admin'),
-            new \lang_string('task_logretention_desc', 'admin'),
-            28 * DAYSECS
-        )
-    );
-
-    $temp->add(
-        new admin_setting_configtext(
-            'task_logretainruns',
-            new \lang_string('task_logretainruns', 'admin'),
-            new \lang_string('task_logretainruns_desc', 'admin'),
-            20,
-            PARAM_INT
-        )
-    );
-}
-$ADMIN->add('taskconfig', $temp);
-
-if (\core\task\logmanager::uses_standard_settings()) {
-    $ADMIN->add('taskconfig', new admin_externalpage(
-        'tasklogs',
-        new lang_string('tasklogs','admin'),
-        "{$CFG->wwwroot}/{$CFG->admin}/tasklogs.php"
-    ));
-}
-
 // E-mail settings.
 $ADMIN->add('server', new admin_category('email', new lang_string('categoryemail', 'admin')));
 
@@ -328,10 +241,6 @@ $temp->add(new admin_setting_configtextarea('allowedemaildomains',
         new lang_string('allowedemaildomains', 'admin'),
         new lang_string('configallowedemaildomains', 'admin'),
         ''));
-$url = new moodle_url('/admin/testoutgoingmailconf.php');
-$link = html_writer::link($url, get_string('testoutgoingmailconf', 'admin'));
-$temp->add(new admin_setting_heading('testoutgoinmailc', new lang_string('testoutgoingmailconf', 'admin'),
-        new lang_string('testoutgoingmaildetail', 'admin', $link)));
 $temp->add(new admin_setting_heading('emaildoesnotfit', new lang_string('doesnotfit', 'admin'),
         new lang_string('doesnotfitdetail', 'admin')));
 $charsets = get_list_of_charsets();
@@ -354,8 +263,6 @@ $choices = array(new lang_string('never', 'admin'),
                  new lang_string('onlynoreply', 'admin'));
 $temp->add(new admin_setting_configselect('emailfromvia', new lang_string('emailfromvia', 'admin'),
           new lang_string('configemailfromvia', 'admin'), 1, $choices));
-    $temp->add(new admin_setting_configtext('emailsubjectprefix', new lang_string('emailsubjectprefix', 'admin'),
-        new lang_string('configemailsubjectprefix', 'admin'), '', PARAM_RAW));
 
 $ADMIN->add('email', $temp);
 

admin/settings/subsystems.php

@@ -13,6 +13,39 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
 
     $optionalsubsystems->add(new admin_setting_configcheckbox('enablewebservices', new lang_string('enablewebservices', 'admin'), new lang_string('configenablewebservices', 'admin'), 0));
 
+    $optionalsubsystems->add(new admin_setting_configcheckbox('messaging', new lang_string('messaging', 'admin'), new lang_string('configmessaging','admin'), 1));
+
+    $optionalsubsystems->add(new admin_setting_configcheckbox('messagingallusers',
+        new lang_string('messagingallusers', 'admin'),
+        new lang_string('configmessagingallusers', 'admin'),
+        0)
+    );
+
+    $options = array(
+        DAYSECS => new lang_string('secondstotime86400'),
+        WEEKSECS => new lang_string('secondstotime604800'),
+        2620800 => new lang_string('nummonths', 'moodle', 1),
+        7862400 => new lang_string('nummonths', 'moodle', 3),
+        15724800 => new lang_string('nummonths', 'moodle', 6),
+        0 => new lang_string('never')
+    );
+    $optionalsubsystems->add(new admin_setting_configselect(
+        'messagingdeletereadnotificationsdelay',
+        new lang_string('messagingdeletereadnotificationsdelay', 'admin'),
+        new lang_string('configmessagingdeletereadnotificationsdelay', 'admin'),
+        604800,
+        $options)
+    );
+    $optionalsubsystems->add(new admin_setting_configselect(
+        'messagingdeleteallnotificationsdelay',
+        new lang_string('messagingdeleteallnotificationsdelay', 'admin'),
+        new lang_string('configmessagingdeleteallnotificationsdelay', 'admin'),
+        2620800,
+        $options)
+    );
+
+    $optionalsubsystems->add(new admin_setting_configcheckbox('messagingallowemailoverride', new lang_string('messagingallowemailoverride', 'admin'), new lang_string('configmessagingallowemailoverride','admin'), 0));
+
     $optionalsubsystems->add(new admin_setting_configcheckbox('enablestats', new lang_string('enablestats', 'admin'), new lang_string('configenablestats', 'admin'), 0));
 
     $optionalsubsystems->add(new admin_setting_configcheckbox('enablerssfeeds', new lang_string('enablerssfeeds', 'admin'), new lang_string('configenablerssfeeds', 'admin'), 0));
@@ -48,10 +81,4 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
 
     $optionalsubsystems->add(new admin_setting_configcheckbox('allowstealth', new lang_string('allowstealthmodules'),
         new lang_string('allowstealthmodules_help'), 0, 1, 0));
-
-    $optionalsubsystems->add(new admin_setting_configcheckbox('enablecoursepublishing',
-        new lang_string('enablecoursepublishing', 'hub'), new lang_string('enablecoursepublishing_help', 'hub'), 0));
-
-    $optionalsubsystems->add(new admin_setting_configcheckbox('enableasyncbackup', new lang_string('enableasyncbackup', 'backup'),
-        new lang_string('enableasyncbackup_help', 'backup'), 0, 1, 0));
 }

admin/settings/top.php

@@ -33,7 +33,6 @@ $ADMIN->add('root', new admin_category('competencies', new lang_string('competen
 $ADMIN->add('root', new admin_category('badges', new lang_string('badges'), empty($CFG->enablebadges)));
 $ADMIN->add('root', new admin_category('location', new lang_string('location','admin')));
 $ADMIN->add('root', new admin_category('language', new lang_string('language')));
-$ADMIN->add('root', new admin_category('messaging', new lang_string('messagingcategory', 'admin')));
 $ADMIN->add('root', new admin_category('modules', new lang_string('plugins', 'admin')));
 $ADMIN->add('root', new admin_category('security', new lang_string('security','admin')));
 $ADMIN->add('root', new admin_category('appearance', new lang_string('appearance','admin')));

admin/settings/users.php

@@ -174,11 +174,12 @@ if ($hassiteconfig
         // Options include fields from the user table that might be helpful to
         // distinguish when adding or listing users ('I want to add the John
         // Smith from Science faculty').
+        // Username is not included as an option because in some sites, it might
+        // be a security problem to reveal usernames even to trusted staff.
         // Custom user profile fields are not currently supported.
         $temp->add(new admin_setting_configmulticheckbox('showuseridentity',
                 new lang_string('showuseridentity', 'admin'),
                 new lang_string('showuseridentity_desc', 'admin'), array('email' => 1), array(
-                    'username'    => new lang_string('username'),
                     'idnumber'    => new lang_string('idnumber'),
                     'email'       => new lang_string('email'),
                     'phone1'      => new lang_string('phone1'),
@@ -254,4 +255,4 @@ if ($hassiteconfig) {
         new lang_string('sitepolicyguest_help', 'core_admin'), (isset($CFG->sitepolicy) ? $CFG->sitepolicy : ''), PARAM_RAW));
 
     $ADMIN->add('privacy', $temp);
-}
+}

admin/tasklogs.php

@@ -1,92 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * Task log.
- *
- * @package    admin
- * @copyright  2018 Andrew Nicols <andrew@nicols.co.uk>
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-require_once(__DIR__ . '/../config.php');
-require_once("{$CFG->libdir}/adminlib.php");
-require_once("{$CFG->libdir}/tablelib.php");
-require_once("{$CFG->libdir}/filelib.php");
-
-$filter = optional_param('filter', '', PARAM_RAW);
-$result = optional_param('result', null, PARAM_INT);
-
-$pageurl = new \moodle_url('/admin/tasklogs.php');
-$pageurl->param('filter', $filter);
-
-$PAGE->set_url($pageurl);
-$PAGE->set_context(context_system::instance());
-$PAGE->set_pagelayout('admin');
-$strheading = get_string('tasklogs', 'tool_task');
-$PAGE->set_title($strheading);
-$PAGE->set_heading($strheading);
-
-require_login();
-
-require_capability('moodle/site:config', context_system::instance());
-admin_externalpage_setup('tasklogs');
-
-$logid = optional_param('logid', null, PARAM_INT);
-$download = optional_param('download', false, PARAM_BOOL);
-
-if (null !== $logid) {
-    $log = $DB->get_record('task_log', ['id' => $logid], '*', MUST_EXIST);
-
-    if ($download) {
-        $filename = str_replace('\\', '_', $log->classname) . "-{$log->id}.log";
-        header("Content-Disposition: attachment; filename=\"{$filename}\"");
-    }
-
-    readstring_accel($log->output, 'text/plain', false);
-    exit;
-}
-
-$renderer = $PAGE->get_renderer('tool_task');
-
-echo $OUTPUT->header();
-echo $OUTPUT->render_from_template('core_admin/tasklogs', (object) [
-    'action' => $pageurl->out(),
-    'filter' => $filter,
-    'resultfilteroptions' => [
-        (object) [
-            'value' => -1,
-            'title' => get_string('all'),
-            'selected' => (-1 === $result),
-        ],
-        (object) [
-            'value' => 0,
-            'title' => get_string('success'),
-            'selected' => (0 === $result),
-        ],
-        (object) [
-            'value' => 1,
-            'title' => get_string('task_result:failed', 'admin'),
-            'selected' => (1 === $result),
-        ],
-    ],
-]);
-
-$table = new \core_admin\task_log_table($filter, $result);
-$table->baseurl = $pageurl;
-$table->out(100, false);
-
-echo $OUTPUT->footer();

admin/templates/setting.mustache

@@ -29,7 +29,6 @@
     * element - The Element HTML
     * forceltr - Force this element to be displayed LTR
     * default - Default value
-    * dependenton - optional message listing the settings this one is dependent on
 
     Example context (json):
     {
@@ -44,11 +43,8 @@
         "default": "Default value"
     }
 }}
-{{!
-    Setting.
-}}
-<div class="form-item row" id="{{id}}">
-    <div class="form-label col-sm-3 text-sm-right">
+<div class="form-item clearfix" id="{{id}}">
+    <div class="form-label">
         <label {{#labelfor}}for="{{labelfor}}"{{/labelfor}}>
             {{{title}}}
             {{#override}}
@@ -58,17 +54,16 @@
                 <div class="form-warning">{{warning}}</div>
             {{/warning}}
         </label>
-        <span class="form-shortname d-block small text-muted">{{{name}}}</span>
+        <span class="form-shortname">{{{name}}}</span>
     </div>
-    <div class="form-setting col-sm-9">
+    <div class="form-setting">
         {{#error}}
             <div><span class="error">{{error}}</span></div>
         {{/error}}
         {{{element}}}
         {{#default}}
-            <div class="form-defaultinfo text-muted {{#forceltr}}text-ltr{{/forceltr}}">{{{default}}}</div>
+            <div class="form-defaultinfo {{#forceltr}}text-ltr{{/forceltr}}">{{{default}}}</div>
         {{/default}}
-        <div class="form-description mt-3">{{{description}}}</div>
-        {{#dependenton}}<div class="form-dependenton mb-4 text-muted">{{{.}}}</div>{{/dependenton}}
     </div>
+    <div class="form-description">{{{description}}}</div>
 </div>

admin/templates/setting_configcolourpicker.mustache

@@ -35,16 +35,13 @@
         "haspreviewconfig": false
     }
 }}
-{{!
-    Setting configcolourpicker.
-}}
 <div class="form-colourpicker defaultsnext">
     <div class="admin_colourpicker clearfix">
         {{#icon}}
             {{>core/pix_icon}}
         {{/icon}}
     </div>
-    <input type="text" name="{{name}}" id="{{id}}" value="{{value}}" size="12" class="form-control text-ltr">
+    <input type="text" name="{{name}}" id="{{id}}" value="{{value}}" size="12" class="text-ltr">
     {{#haspreviewconfig}}
         <input type="button" id="{{id}}_preview" value={{#quote}}{{#str}}preview{{/str}}{{/quote}} class="admin_colourpicker_preview">
     {{/haspreviewconfig}}

admin/templates/setting_configduration.mustache

@@ -33,18 +33,13 @@
         "options": [ { "name": "Minutes", "value": "mins", "selected": true } ]
     }
 }}
-{{!
-    Setting configduration.
-}}
 <div class="form-duration defaultsnext">
-    <div class="form-inline">
-        <input type="text" size="5" id="{{id}}v" name="{{name}}[v]" value="{{value}}" class="form-control text-ltr">
-        <label class="sr-only" for="{{id}}u">{{#str}}durationunits, admin{{/str}}</label>
-        <select id="{{id}}u" name="{{name}}[u]" class="form-control custom-select">
-            {{#options}}
-                <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
-            {{/options}}
-        </select>
-    </div>
+    <input type="text" size="5" id="{{id}}v" name="{{name}}[v]" value="{{value}}" class="text-ltr">
+    <label class="accesshide" for="{{id}}u">{{#str}}durationunits, admin{{/str}}</label>
+    <select id="{{id}}u" name="{{name}}[u]">
+        {{#options}}
+            <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
+        {{/options}}
+    </select>
 </div>
 

admin/templates/setting_configfile.mustache

@@ -38,20 +38,15 @@
         "valid": false
     }
 }}
-{{!
-    Setting configfile.
-}}
 <div class="form-file defaultsnext">
-    <div class="form-inline">
-        <input type="text" name="{{name}}" id="{{id}}" size="{{size}}" value="{{value}}" class="form-control text-ltr" {{#readonly}}readonly{{/readonly}}>
-        {{#showvalidity}}
-            {{#valid}}
-                <span class="text-success">&#x2714;</span>
-            {{/valid}}
-            {{^valid}}
-                <span class="text-danger">&#x2718;</span>
-            {{/valid}}
-        {{/showvalidity}}
-    </div>
+    <input type="text" name="{{name}}" id="{{id}}" size="{{size}}" value="{{value}}" class="text-ltr" {{#readonly}}readonly{{/readonly}}>
+    {{#showvalidity}}
+        {{#valid}}
+            <span class="pathok">&#x2714;</span>
+        {{/valid}}
+        {{^valid}}
+            <span class="patherror">&#x2718;</span>
+        {{/valid}}
+    {{/showvalidity}}
 </div>
 

admin/templates/setting_configmultiselect.mustache

@@ -34,12 +34,9 @@
                      { "name": "Option 2", "value": "V", "selected": true } ]
     }
 }}
-{{!
-    Setting configmultiselect.
-}}
 <div class="form-select">
     <input type="hidden" name="{{name}}[xxxxx]" value="1">
-    <select id="{{id}}" name="{{name}}[]" size="{{size}}" class="form-control" multiple>
+    <select id="{{id}}" name="{{name}}[]" size="{{size}}" multiple>
         {{#options}}
             <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
         {{/options}}

admin/templates/setting_configmultiselect_optgroup.mustache

@@ -53,16 +53,13 @@
         ]
     }
 }}
-{{!
-    Setting configmultiselect with optgroup support.
-}}
 <div class="form-select">
     <input type="hidden" name="{{name}}[xxxxx]" value="1">
-    <select id="{{id}}" name="{{name}}[]" size="{{size}}" class="form-control" multiple>
-    {{#options}}
-        <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
-    {{/options}}
-    {{#optgroups}}
+    <select id="{{id}}" name="{{name}}[]" size="{{size}}" multiple>
+        {{#options}}
+            <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
+        {{/options}}
+        {{#optgroups}}
             <optgroup label="{{label}}">
                 {{#options}}
                     <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>

admin/templates/setting_configselect.mustache

@@ -34,11 +34,8 @@
         ]
     }
 }}
-{{!
-    Setting configselect.
-}}
 <div class="form-select defaultsnext">
-    <select id="{{id}}" name="{{name}}" class="custom-select">
+    <select id="{{id}}" name="{{name}}">
         {{#options}}
             <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
         {{/options}}

admin/templates/setting_configselect_optgroup.mustache

@@ -51,11 +51,8 @@
         ]
     }
 }}
-{{!
-    Setting configselect with optgroup support.
-}}
 <div class="form-select defaultsnext">
-    <select id="{{id}}" name="{{name}}" class="custom-select">
+    <select id="{{id}}" name="{{name}}">
         {{#options}}
             <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
         {{/options}}
@@ -69,4 +66,3 @@
     </select>
 </div>
 
-

admin/templates/setting_configtext.mustache

@@ -37,9 +37,6 @@
         "attributes": [ { "name": "readonly", "value": "readonly" } ]
     }
 }}
-{{!
-    Setting configtext.
-}}
 <div class="form-text defaultsnext">
-    <input type="text" name="{{name}}" value="{{value}}" size="{{size}}" id="{{id}}" class="form-control {{#forceltr}}text-ltr{{/forceltr}}">
+    <input type="text" name="{{name}}" value="{{value}}" size="{{size}}" id="{{id}}" class="{{#forceltr}}text-ltr{{/forceltr}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}}>
 </div>

admin/templates/setting_configtextarea.mustache

@@ -36,9 +36,6 @@
         "id": "test0"
     }
 }}
-{{!
-    Setting configtextarea.
-}}
 <div class="form-textarea">
-    <textarea rows="{{rows}}" cols="{{cols}}" id="{{id}}" name="{{name}}" spellcheck="true" class="form-control {{#forceltr}}text-ltr{{/forceltr}}">{{value}}</textarea>
+    <textarea rows="{{rows}}" cols="{{cols}}" id="{{id}}" name="{{name}}" spellcheck="true" class="{{#forceltr}}text-ltr{{/forceltr}}">{{value}}</textarea>
 </div>

admin/templates/setting_configtime.mustache

@@ -39,23 +39,18 @@
         ]
     }
 }}
-{{!
-    Setting configtime.
-}}
-<div class="form-time defaultsnext">
-    <div class="form-inline text-ltr">
-        <label class="sr-only" for="{{id}}h">{{#str}}hours{{/str}}</label>
-        <select id="{{id}}h" name="{{name}}[h]" class="custom-select">
-            {{#hours}}
-                <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
-            {{/hours}}
-        </select>:
-        <label class="sr-only" for="{{id}}m">{{#str}}minutes{{/str}}</label>
-        <select id="{{id}}m" name="{{name}}[m]" class="custom-select">
-            {{#minutes}}
-                <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
-            {{/minutes}}
-        </select>
-    </div>
+<div class="form-time defaultsnext text-ltr">
+    <label class="accesshide" for="{{id}}h">{{#str}}hours{{/str}}</label>
+    <select id="{{id}}h" name="{{name}}[h]">
+        {{#hours}}
+            <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
+        {{/hours}}
+    </select>:
+    <label class="accesshide" for="{{id}}m">{{#str}}minutes{{/str}}</label>
+    <select id="{{id}}m" name="{{name}}[m]">
+        {{#minutes}}
+            <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
+        {{/minutes}}
+    </select>
 </div>
 

admin/templates/setting_courselist_frontpage.mustache

@@ -37,12 +37,9 @@
         ]
     }
 }}
-{{!
-    Setting courselist_frontpage.
-}}
 <div class="form-group">
     {{#selects}}
-        <select id="{{id}}{{key}}" name="{{name}}[]" class="custom-select">
+        <select id="{{id}}{{key}}" name="{{name}}[]" class="form-select">
             {{#options}}
                 <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
             {{/options}}

admin/templates/setting_description.mustache

@@ -34,13 +34,12 @@
 {{!
     Setting description.
 }}
-<div class="form-item row">
-    <div class="form-label col-sm-3 text-sm-right">
+<div class="form-item form-horizontal clearfix">
+    <div class="form-label">
         <label>
             {{{title}}}
         </label>
+        <span class="form-shortname ">{{{name}}}</span>
     </div>
-    <div class="form-setting col-sm-9">
-        <div class="form-description">{{{description}}}</div>
-    </div>
-</div>
+    <div class="controls felement fstatic">{{{description}}}</div>
+</div>

admin/templates/setting_devicedetectregex.mustache

@@ -29,10 +29,7 @@
         ]
     }
 }}
-{{!
-    Setting devicedetectregex.
-}}
-<table class="table table-striped">
+<table class="generaltable">
     <thead>
         <tr>
             <th>{{#str}}devicedetectregexexpression, admin{{/str}}</th>
@@ -43,10 +40,10 @@
         {{#expressions}}
             <tr>
                 <td class="c{{index}}">
-                    <input type="text" name="{{name}}[expression{{index}}]" class="form-control" value="{{expression}}">
+                    <input type="text" name="{{name}}[expression{{index}}]" class="form-text text-ltr" value="{{expression}}">
                 </td>
                 <td class="c{{index}}">
-                    <input type="text" name="{{name}}[value{{index}}]" class="form-control" value="{{value}}">
+                    <input type="text" name="{{name}}[value{{index}}]" class="form-text text-ltr" value="{{value}}">
                 </td>
             </tr>
         {{/expressions}}

admin/templates/setting_emoticons.mustache

@@ -32,9 +32,6 @@
         ]
     }
 }}
-{{!
-    Setting emoticons.
-}}
 <div class="form-group">
     <table id="emoticonsetting" class="admintable generaltable">
         <thead>
@@ -51,7 +48,7 @@
                 <tr>
                     {{#fields}}
                         <td class="c{{index}}">
-                            <input type="text" name="{{name}}[{{field}}]" class="form-text form-control text-ltr" value="{{value}}">
+                            <input type="text" name="{{name}}[{{field}}]" class="form-text text-ltr" value="{{value}}">
                         </td>
                     {{/fields}}
                     <td>

admin/templates/setting_gradecat_combo.mustache

@@ -37,11 +37,8 @@
         "advanced": true
     }
 }}
-{{!
-    Setting configselect.
-}}
 <div class="form-group">
-    <select id="{{id}}" name="{{name}}[value]" class="form-select custom-select">
+    <select id="{{id}}" name="{{name}}[value]" class="form-select">
         {{#options}}
             <option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
         {{/options}}

admin/templates/settings.mustache

@@ -36,11 +36,8 @@
         "showsave": true
     }
 }}
-{{!
-    Settings.
-}}
 <form action="{{actionurl}}" method="post" id="adminsettings">
-    <div class="settingsform">
+    <div class="settingsform clearfix">
         {{#params}}
             <input type="hidden" name="{{name}}" value="{{value}}">
             <input type="hidden" name="action" value="save-settings">
@@ -52,10 +49,8 @@
         {{/title}}
         {{{settings}}}
         {{#showsave}}
-            <div class="row">
-                <div class="offset-sm-3 col-sm-3">
-                    <button type="submit" class="btn btn-primary">{{#str}}savechanges, admin{{/str}}</button>
-                </div>
+            <div class="form-buttons">
+                <input type="submit" class="form-submit" value={{#quote}}{{#str}}savechanges, admin{{/str}}{{/quote}}>
             </div>
         {{/showsave}}
     </div>

admin/templates/settings_search_results.mustache

@@ -58,10 +58,8 @@
                 </fieldset>
             {{/results}}
             {{#showsave}}
-                <div class="row">
-                    <div class="offset-sm-3 col-sm-3">
-                        <button type="submit" class="btn btn-primary">{{#str}}savechanges, admin{{/str}}</button>
-                    </div>
+                <div class="form-buttons">
+                    <input type="submit" class="form-submit" value={{#quote}}{{#str}}savechanges, admin{{/str}}{{/quote}}>
                 </div>
             {{/showsave}}
         {{/hasresults}}

admin/templates/tasklogs.mustache

@@ -1,34 +0,0 @@
-{{!
-    This file is part of Moodle - http://moodle.org/
-
-    Moodle is free software: you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation, either version 3 of the License, or
-    (at your option) any later version.
-
-    Moodle is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-}}
-{{!
-    @template core_admin/tasklogs
-
-    Task Logs template.
-}}
-<form class="form-inline" method="GET" action="{{{action}}}">
-    <label class="sr-only" for="tasklog-filter">{{#str}}filter{{/str}}</label>
-    <input class="form-control" type="text" id="tasklog-filter" name="filter" value="{{{filter}}}">
-
-    <label class="sr-only" for="tasklog-resultfilter">{{#str}}resultfilter, admin{{/str}}</label>
-    <select class="form-control custom-select" name="result" id="tasklog-resultfilter">
-        {{#resultfilteroptions}}
-        <option value="{{{value}}}"{{#selected}} selected="selected"{{/selected}}>{{title}}</option>
-        {{/resultfilteroptions}}
-    </select>
-
-    <input class="btn btn-primary" type="submit" value="{{#str}}filter{{/str}}">
-</form>

admin/testoutgoingmailconf.php

@@ -1,92 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * Test output mail configuration page
- *
- * @copyright 2019 Victor Deniz <victor@moodle.com>, based on Michael Milette <michael.milette@tngconsulting.ca> code
- * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-require_once(__DIR__ . '/../config.php');
-require_once($CFG->libdir.'/adminlib.php');
-
-// This is an admin page.
-admin_externalpage_setup('testoutgoingmailconf');
-
-$headingtitle = get_string('testoutgoingmailconf', 'admin');
-$homeurl = new moodle_url('/admin/category.php', array('category' => 'email'));
-$returnurl = new moodle_url('/admin/testoutgoingconf.php');
-
-$form = new core_admin\form\testoutgoingmailconf_form(null, ['returnurl' => $returnurl]);
-if ($form->is_cancelled()) {
-    redirect($homeurl);
-}
-
-// Display the page.
-echo $OUTPUT->header();
-echo $OUTPUT->heading($headingtitle);
-
-$data = $form->get_data();
-if ($data) {
-    $emailuser = new stdClass();
-    $emailuser->email = $data->recipient;
-    $emailuser->id = -99;
-
-    $subject = get_string('testoutgoingmailconf_subject', 'admin', $SITE->fullname);
-    $messagetext = get_string('testoutgoingmailconf_message', 'admin');
-
-    // Manage Moodle debugging options.
-    $debuglevel = $CFG->debug;
-    $debugdisplay = $CFG->debugdisplay;
-    $debugsmtp = $CFG->debugsmtp;
-    $CFG->debugdisplay = true;
-    $CFG->debugsmtp = true;
-    $CFG->debug = 15;
-
-    // Send test email.
-    ob_start();
-    $success = email_to_user($emailuser, $USER, $subject, $messagetext);
-    $smtplog = ob_get_contents();
-    ob_end_clean();
-
-    // Restore Moodle debugging options.
-    $CFG->debug = $debuglevel;
-    $CFG->debugdisplay = $debugdisplay;
-    $CFG->debugsmtp = $debugsmtp;
-
-    if ($success) {
-        $msgparams = new stdClass();
-        $msgparams->fromemail = $USER->email;
-        $msgparams->toemail = $emailuser->email;
-        $msg = get_string('testoutgoingmailconf_sentmail', 'admin', $msgparams);
-        $notificationtype = 'notifysuccess';
-    } else {
-        $notificationtype = 'notifyproblem';
-        // No communication between Moodle and the SMTP server - no error output.
-        if (trim($smtplog) == false) {
-            $msg = get_string('testoutgoingmailconf_errorcommunications', 'admin');
-        } else {
-            $msg = $smtplog;
-        }
-    }
-
-    // Show result.
-    echo $OUTPUT->notification($msg, $notificationtype);
-}
-
-$form->display();
-echo $OUTPUT->footer();

admin/tests/behat/behat_admin.php

@@ -55,11 +55,19 @@ class behat_admin extends behat_base {
 
         foreach ($data as $label => $value) {
 
-            $this->execute('behat_navigation::i_select_from_flat_navigation_drawer', [get_string('administrationsite')]);
+            // We expect admin block to be visible, otherwise go to homepage.
+            if (!$this->getSession()->getPage()->find('css', '.block_settings')) {
+                $this->getSession()->visit($this->locate_path('/'));
+                $this->wait(self::TIMEOUT * 1000, self::PAGE_READY_JS);
+            }
 
             // Search by label.
-            $this->execute('behat_forms::i_set_the_field_to', [get_string('query', 'admin'), $label]);
-            $this->execute("behat_forms::press_button", get_string('search', 'admin'));
+            $searchbox = $this->find_field(get_string('searchinsettings', 'admin'));
+            $searchbox->setValue($label);
+            $submitsearch = $this->find('css', 'form.adminsearchform input[type=submit]');
+            $submitsearch->press();
+
+            $this->wait(self::TIMEOUT * 1000, self::PAGE_READY_JS);
 
             // Admin settings does not use the same DOM structure than other moodle forms
             // but we also need to use lib/behat/form_field/* to deal with the different moodle form elements.
@@ -70,24 +78,21 @@ class behat_admin extends behat_base {
 
             // Single element settings.
             try {
-                $fieldxpath = "//*[self::input | self::textarea | self::select]" .
-                        "[not(./@type = 'submit' or ./@type = 'image' or ./@type = 'hidden')]" .
-                        "[@id=//label[contains(normalize-space(.), $label)]/@for or " .
-                        "@id=//span[contains(normalize-space(.), $label)]/preceding-sibling::label[1]/@for]";
+                $fieldxpath = "//*[self::input | self::textarea | self::select][not(./@type = 'submit' or ./@type = 'image' or ./@type = 'hidden')]" .
+                    "[@id=//label[contains(normalize-space(.), $label)]/@for or " .
+                    "@id=//span[contains(normalize-space(.), $label)]/preceding-sibling::label[1]/@for]";
                 $fieldnode = $this->find('xpath', $fieldxpath, $exception);
 
-                $formfieldtypenode = $this->find('xpath', $fieldxpath .
-                        "/ancestor::div[contains(concat(' ', @class, ' '), ' form-setting ')]" .
-                        "/child::div[contains(concat(' ', @class, ' '),  ' form-')]/child::*/parent::div");
+                $formfieldtypenode = $this->find('xpath', $fieldxpath . "/ancestor::div[@class='form-setting']" .
+                    "/child::div[contains(concat(' ', @class, ' '),  ' form-')]/child::*/parent::div");
 
             } catch (ElementNotFoundException $e) {
 
                 // Multi element settings, interacting only the first one.
-                $fieldxpath = "//*[label[contains(., $label)]|span[contains(., $label)]]" .
-                        "/ancestor::div[contains(concat(' ', normalize-space(@class), ' '), ' form-item ')]" .
-                        "/descendant::div[contains(concat(' ', @class, ' '), ' form-group ')]" .
-                        "/descendant::*[self::input | self::textarea | self::select]" .
-                        "[not(./@type = 'submit' or ./@type = 'image' or ./@type = 'hidden')]";
+                $fieldxpath = "//*[label[normalize-space(.)= $label]|span[normalize-space(.)= $label]]/" .
+                    "ancestor::div[contains(concat(' ', normalize-space(@class), ' '), ' form-item ')]" .
+                    "/descendant::div[@class='form-group']/descendant::*[self::input | self::textarea | self::select]" .
+                    "[not(./@type = 'submit' or ./@type = 'image' or ./@type = 'hidden')]";
                 $fieldnode = $this->find('xpath', $fieldxpath);
 
                 // It is the same one that contains the type.
@@ -96,7 +101,6 @@ class behat_admin extends behat_base {
 
             // Getting the class which contains the field type.
             $classes = explode(' ', $formfieldtypenode->getAttribute('class'));
-            $type = false;
             foreach ($classes as $class) {
                 if (substr($class, 0, 5) == 'form-') {
                     $type = substr($class, 5);

admin/tests/behat/enable_multiple_accounts_use_same_email.feature

@@ -1,74 +1,57 @@
-@core @core_admin @core_user
-Feature: Allowing multiple accounts to have the same email address
-  In order to manage user accounts
+@core @core_admin
+Feature: Enable multiple accounts to have the same email address
+  In order to have multiple accounts registerd on the system with the same email address
   As an admin
-  I need to be able to set whether to allow multiple accounts with the same email or not
+  I need to enable multiple accounts to be registered with the same email address and verify it is applied
 
-  Scenario Outline: Create a user with the same email as an existing user
+  Background:
+    Given I log in as "admin"
+
+  Scenario: Enable registration of multiple accounts with the same email address
     Given the following config values are set as admin:
-      | allowaccountssameemail | <allowsameemail> |
-    And the following "users" exist:
-      | username  | firstname | lastname | email           |
-      | s1        | John      | Doe      | s1@example.com  |
-    When I log in as "admin"
-    And I navigate to "Users > Accounts > Add a new user" in site administration
+      | allowaccountssameemail | 1 |
+    When I navigate to "Users > Accounts > Add a new user" in site administration
     And I set the following fields to these values:
-      | Username      | s2      |
-      | First name    | Jane    |
-      | Surname       | Doe     |
-      | Email address | <email> |
-      | New password  | test    |
+      | Username                        | testmultiemailuser1             |
+      | Choose an authentication method | Manual accounts                 |
+      | New password                    | test@User1                      |
+      | First name                      | Test                            |
+      | Surname                         | Multi1                          |
+      | Email address                   | testmultiemailuser@example.com  |
     And I press "Create user"
-    Then I should <expect> "This email address is already registered."
+    And I should see "Test Multi1"
+    And I press "Add a new user"
+    And I set the following fields to these values:
+      | Username                        | testmultiemailuser2             |
+      | Choose an authentication method | Manual accounts                 |
+      | New password                    | test@User2                      |
+      | First name                      | Test                            |
+      | Surname                         | Multi2                          |
+      | Email address                   | testmultiemailuser@example.com  |
+    And I press "Create user"
+    Then I should see "Test Multi2"
+    And I should not see "This email address is already registered"
 
-    Examples:
-      | allowsameemail | email          | expect  |
-      | 0              | s1@example.com | see     |
-      | 0              | S1@EXAMPLE.COM | see     |
-      | 1              | s1@example.com | not see |
-      | 1              | S1@EXAMPLE.COM | not see |
-
-  Scenario Outline: Update a user with the same email as an existing user
+  Scenario: Disable registration of multiple accounts with the same email address
     Given the following config values are set as admin:
-      | allowaccountssameemail | <allowsameemail> |
-    And the following "users" exist:
-      | username  | firstname | lastname | email           |
-      | s1        | John      | Doe      | s1@example.com  |
-      | s2        | Jane      | Doe      | s2@example.com  |
-    When I log in as "admin"
-    And I navigate to "Users > Accounts > Browse list of users" in site administration
-    And I click on "Edit" "link" in the "Jane Doe" "table_row"
-    And I set the field "Email address" to "<email>"
-    And I press "Update profile"
-    Then I should <expect> "This email address is already registered."
-
-    Examples:
-      | allowsameemail | email          | expect  |
-      | 0              | s1@example.com | see     |
-      | 0              | S1@EXAMPLE.COM | see     |
-      | 1              | s1@example.com | not see |
-      | 1              | S1@EXAMPLE.COM | not see |
-      | 0              | S2@EXAMPLE.COM | not see |
-      | 1              | S2@EXAMPLE.COM | not see |
-
-  Scenario Outline: Update own user profile with the same email as an existing user
-    Given the following config values are set as admin:
-      | allowaccountssameemail | <allowsameemail> |
-    And the following "users" exist:
-      | username  | firstname | lastname | email           |
-      | s1        | John      | Doe      | s1@example.com  |
-      | s2        | Jane      | Doe      | s2@example.com  |
-    When I log in as "s2"
-    And I open my profile in edit mode
-    And I set the field "Email address" to "<email>"
-    And I press "Update profile"
-    Then I should <expect> "This email address is already registered."
-
-    Examples:
-      | allowsameemail | email          | expect  |
-      | 0              | s1@example.com | see     |
-      | 0              | S1@EXAMPLE.COM | see     |
-      | 1              | s1@example.com | not see |
-      | 1              | S1@EXAMPLE.COM | not see |
-      | 0              | S2@EXAMPLE.COM | not see |
-      | 1              | S2@EXAMPLE.COM | not see |
+      | allowaccountssameemail | 0 |
+    When I navigate to "Users > Accounts > Add a new user" in site administration
+    And I set the following fields to these values:
+      | Username                        | testmultiemailuser1             |
+      | Choose an authentication method | Manual accounts                 |
+      | New password                    | test@User1                      |
+      | First name                      | Test                            |
+      | Surname                         | Multi1                          |
+      | Email address                   | testmultiemailuser@example.com  |
+    And I press "Create user"
+    And I should see "Test Multi1"
+    And I press "Add a new user"
+    And I set the following fields to these values:
+      | Username                        | testmultiemailuser2             |
+      | Choose an authentication method | Manual accounts                 |
+      | New password                    | test@User2                      |
+      | First name                      | Test                            |
+      | Surname                         | Multi2                          |
+      | Email address                   | testmultiemailuser@example.com  |
+    And I press "Create user"
+    Then I should see "This email address is already registered"

admin/tool/analytics/amd/build/model.min.js

@@ -1 +1 @@
-define(["jquery","core/str","core/log","core/notification","core/modal_factory","core/modal_events","core/templates"],function(a,b,c,d,e,f,g){var h={clear:{title:{key:"clearpredictions",component:"tool_analytics"},body:{key:"clearmodelpredictions",component:"tool_analytics"}},"delete":{title:{key:"delete",component:"tool_analytics"},body:{key:"deletemodelconfirmation",component:"tool_analytics"}}},i=function(b){return a(b.closest("tr")[0]).find("span.target-name").text()};return{confirmAction:function(g,j){a('[data-action-id="'+g+'"]').on("click",function(g){g.preventDefault();var k=a(g.currentTarget);if("undefined"==typeof h[j])return void c.error('Action "'+j+'" is not allowed.');var l=[h[j].title,h[j].body];l[1].param=i(k);var m=b.get_strings(l),n=e.create({type:e.types.SAVE_CANCEL});a.when(m,n).then(function(a,b){return b.setTitle(a[0]),b.setBody(a[1]),b.setSaveButtonText(a[0]),b.getRoot().on(f.save,function(){window.location.href=k.attr("href")}),b.show(),b}).fail(d.exception)})},selectEvaluationOptions:function(c,h,i){a('[data-action-id="'+c+'"]').on("click",function(c){c.preventDefault();var j=a(c.currentTarget),k=b.get_strings([{key:"evaluatemodel",component:"tool_analytics"},{key:"evaluate",component:"tool_analytics"}]),l=e.create({type:e.types.SAVE_CANCEL}),m=g.render("tool_analytics/evaluation_options",{trainedexternally:h,timesplittingmethods:i});a.when(k,l).then(function(b,c){return c.getRoot().on(f.hidden,c.destroy.bind(c)),c.setTitle(b[0]),c.setSaveButtonText(b[1]),c.setBody(m),c.getRoot().on(f.save,function(){var b=a("input[name='evaluationmode']:checked").val();"trainedmodel"==b&&j.attr("href",j.attr("href")+"&mode=trainedmodel");var c=a("#id-evaluation-timesplitting").val();j.attr("href",j.attr("href")+"&timesplitting="+c),window.location.href=j.attr("href")}),c.show(),c}).fail(d.exception)})},selectExportOptions:function(c,h){a('[data-action-id="'+c+'"]').on("click",function(c){c.preventDefault();var i=a(c.currentTarget);if(!h)return i.attr("href",i.attr("href")+"&action=exportmodel&includeweights=0"),void(window.location.href=i.attr("href"));var j=b.get_strings([{key:"export",component:"tool_analytics"}]),k=e.create({type:e.types.SAVE_CANCEL}),l=g.render("tool_analytics/export_options",{});a.when(j,k).then(function(b,c){return c.getRoot().on(f.hidden,c.destroy.bind(c)),c.setTitle(b[0]),c.setSaveButtonText(b[0]),c.setBody(l),c.getRoot().on(f.save,function(){var b=a("input[name='exportoption']:checked").val();"exportdata"==b?i.attr("href",i.attr("href")+"&action=exportdata"):(i.attr("href",i.attr("href")+"&action=exportmodel"),a("#id-includeweights").is(":checked")?i.attr("href",i.attr("href")+"&includeweights=1"):i.attr("href",i.attr("href")+"&includeweights=0")),window.location.href=i.attr("href")}),c.show(),c}).fail(d.exception)})}}});
+define(["jquery","core/str","core/log","core/notification","core/modal_factory","core/modal_events"],function(a,b,c,d,e,f){var g={clear:{title:{key:"clearpredictions",component:"tool_analytics"},body:{key:"clearmodelpredictions",component:"tool_analytics"}}},h=function(b){return a(b.closest("tr")[0]).find("span.target-name").text()};return{confirmAction:function(i,j){a('[data-action-id="'+i+'"]').on("click",function(i){i.preventDefault();var k=a(i.currentTarget);if("undefined"==typeof g[j])return void c.error('Action "'+j+'" is not allowed.');var l=[g[j].title,g[j].body];l[1].param=h(k);var m=b.get_strings(l),n=e.create({type:e.types.SAVE_CANCEL});a.when(m,n).then(function(a,b){return b.setTitle(a[0]),b.setBody(a[1]),b.setSaveButtonText(a[0]),b.getRoot().on(f.save,function(){window.location.href=k.attr("href")}),b.show(),b}).fail(d.exception)})}}});

admin/tool/analytics/amd/src/model.js

@@ -20,8 +20,8 @@
  * @copyright  2017 David Monllao
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-define(['jquery', 'core/str', 'core/log', 'core/notification', 'core/modal_factory', 'core/modal_events', 'core/templates'],
-    function($, Str, log, Notification, ModalFactory, ModalEvents, Templates) {
+define(['jquery', 'core/str', 'core/log', 'core/notification', 'core/modal_factory', 'core/modal_events'],
+    function($, Str, log, Notification, ModalFactory, ModalEvents) {
 
     /**
      * List of actions that require confirmation and confirmation message.
@@ -36,15 +36,6 @@ define(['jquery', 'core/str', 'core/log', 'core/notification', 'core/modal_facto
                 component: 'tool_analytics'
             }
 
-        },
-        'delete': {
-            title: {
-                key: 'delete',
-                component: 'tool_analytics'
-            }, body: {
-                key: 'deletemodelconfirmation',
-                component: 'tool_analytics'
-            }
         }
     };
 
@@ -94,133 +85,10 @@ define(['jquery', 'core/str', 'core/log', 'core/notification', 'core/modal_facto
                     modal.getRoot().on(ModalEvents.save, function() {
                         window.location.href = a.attr('href');
                     });
-                    modal.show();
-                    return modal;
-                }).fail(Notification.exception);
-            });
-        },
-
-        /**
-         * Displays evaluation mode and time-splitting method choices.
-         *
-         * @param  {String}  actionId
-         * @param  {Boolean} trainedOnlyExternally
-         */
-        selectEvaluationOptions: function(actionId, trainedOnlyExternally, timeSplittingMethods) {
-            $('[data-action-id="' + actionId + '"]').on('click', function(ev) {
-                ev.preventDefault();
-
-                var a = $(ev.currentTarget);
-
-                var stringsPromise = Str.get_strings([
-                    {
-                        key: 'evaluatemodel',
-                        component: 'tool_analytics'
-                    }, {
-                        key: 'evaluate',
-                        component: 'tool_analytics'
-                    }
-                ]);
-                var modalPromise = ModalFactory.create({type: ModalFactory.types.SAVE_CANCEL});
-                var bodyPromise = Templates.render('tool_analytics/evaluation_options', {
-                    trainedexternally: trainedOnlyExternally,
-                    timesplittingmethods: timeSplittingMethods
-                });
-
-                $.when(stringsPromise, modalPromise).then(function(strings, modal) {
-
-
-                    modal.getRoot().on(ModalEvents.hidden, modal.destroy.bind(modal));
-
-                    modal.setTitle(strings[0]);
-                    modal.setSaveButtonText(strings[1]);
-                    modal.setBody(bodyPromise);
-
-                    modal.getRoot().on(ModalEvents.save, function() {
-
-                        // Evaluation mode.
-                        var evaluationMode = $("input[name='evaluationmode']:checked").val();
-                        if (evaluationMode == 'trainedmodel') {
-                            a.attr('href', a.attr('href') + '&mode=trainedmodel');
-                        }
-
-                        // Selected time-splitting id.
-                        var timeSplittingMethod = $("#id-evaluation-timesplitting").val();
-                        a.attr('href', a.attr('href') + '&timesplitting=' + timeSplittingMethod);
-
-                        window.location.href = a.attr('href');
-                        return;
-                    });
-
-                    modal.show();
-                    return modal;
-                }).fail(Notification.exception);
-            });
-        },
-
-        /**
-         * Displays export options.
-         *
-         * We have two main options: export training data and export configuration.
-         * The 2nd option has an extra option: include the trained algorithm weights.
-         *
-         * @param  {String}  actionId
-         * @param  {Boolean} isTrained
-         */
-        selectExportOptions: function(actionId, isTrained) {
-            $('[data-action-id="' + actionId + '"]').on('click', function(ev) {
-                ev.preventDefault();
-
-                var a = $(ev.currentTarget);
-
-                if (!isTrained) {
-                    // Export the model configuration if the model is not trained. We can't export anything else.
-                    a.attr('href', a.attr('href') + '&action=exportmodel&includeweights=0');
-                    window.location.href = a.attr('href');
-                    return;
-                }
-
-                var stringsPromise = Str.get_strings([
-                    {
-                        key: 'export',
-                        component: 'tool_analytics'
-                    }
-                ]);
-                var modalPromise = ModalFactory.create({type: ModalFactory.types.SAVE_CANCEL});
-                var bodyPromise = Templates.render('tool_analytics/export_options', {});
-
-                $.when(stringsPromise, modalPromise).then(function(strings, modal) {
-
-                    modal.getRoot().on(ModalEvents.hidden, modal.destroy.bind(modal));
-
-                    modal.setTitle(strings[0]);
-                    modal.setSaveButtonText(strings[0]);
-                    modal.setBody(bodyPromise);
-
-                    modal.getRoot().on(ModalEvents.save, function() {
-
-                        var exportOption = $("input[name='exportoption']:checked").val();
-
-                        if (exportOption == 'exportdata') {
-                            a.attr('href', a.attr('href') + '&action=exportdata');
-
-                        } else {
-                            a.attr('href', a.attr('href') + '&action=exportmodel');
-                            if ($("#id-includeweights").is(':checked')) {
-                                a.attr('href', a.attr('href') + '&includeweights=1');
-                            } else {
-                                a.attr('href', a.attr('href') + '&includeweights=0');
-                            }
-                        }
-
-                        window.location.href = a.attr('href');
-                        return;
-                    });
-
                     modal.show();
                     return modal;
                 }).fail(Notification.exception);
             });
         }
     };
-});
+});

admin/tool/analytics/classes/clihelper.php

@@ -48,7 +48,7 @@ class clihelper {
         foreach ($models as $model) {
             $modelid = $model->get_id();
             $isenabled = $model->is_enabled() ? get_string('enabled', 'tool_analytics') : get_string('disabled', 'tool_analytics');
-            $name = $model->get_name();
+            $name = $model->get_target()->get_name();
             echo str_pad($modelid, 15, ' ') . ' ' . str_pad($name, 50, ' ') . ' ' . str_pad($isenabled, 15, ' ') . "\n";
         }
     }

admin/tool/analytics/classes/output/form/edit_model.php

@@ -45,76 +45,54 @@ class edit_model extends \moodleform {
 
         $mform = $this->_form;
 
-        if ($this->_customdata['trainedmodel'] && $this->_customdata['staticmodel'] === false) {
+        if ($this->_customdata['model']->is_trained()) {
             $message = get_string('edittrainedwarning', 'tool_analytics');
             $mform->addElement('html', $OUTPUT->notification($message, \core\output\notification::NOTIFY_WARNING));
         }
 
         $mform->addElement('advcheckbox', 'enabled', get_string('enabled', 'tool_analytics'));
 
-        // Target.
-        if (!empty($this->_customdata['targets'])) {
-            $targets = array('' => '');
-            foreach ($this->_customdata['targets'] as $classname => $target) {
-                $optionname = \tool_analytics\output\helper::class_to_option($classname);
-                $targets[$optionname] = $target->get_name();
-            }
-
-            $mform->addElement('select', 'target', get_string('target', 'tool_analytics'), $targets);
-            $mform->addHelpButton('target', 'target', 'tool_analytics');
-            $mform->addRule('target', get_string('required'), 'required', null, 'client');
+        $indicators = array();
+        foreach ($this->_customdata['indicators'] as $classname => $indicator) {
+            $optionname = \tool_analytics\output\helper::class_to_option($classname);
+            $indicators[$optionname] = $indicator->get_name();
         }
+        $options = array(
+            'multiple' => true
+        );
+        $mform->addElement('autocomplete', 'indicators', get_string('indicators', 'tool_analytics'), $indicators, $options);
+        $mform->setType('indicators', PARAM_ALPHANUMEXT);
 
-        // Indicators.
-        if (!$this->_customdata['staticmodel']) {
-            $indicators = array();
-            foreach ($this->_customdata['indicators'] as $classname => $indicator) {
-                $optionname = \tool_analytics\output\helper::class_to_option($classname);
-                $indicators[$optionname] = $indicator->get_name();
-            }
-            $options = array(
-                'multiple' => true
-            );
-            $mform->addElement('autocomplete', 'indicators', get_string('indicators', 'tool_analytics'), $indicators, $options);
-            $mform->setType('indicators', PARAM_ALPHANUMEXT);
-            $mform->addHelpButton('indicators', 'indicators', 'tool_analytics');
-        }
-
-        // Time-splitting methods.
         $timesplittings = array('' => '');
         foreach ($this->_customdata['timesplittings'] as $classname => $timesplitting) {
             $optionname = \tool_analytics\output\helper::class_to_option($classname);
             $timesplittings[$optionname] = $timesplitting->get_name();
         }
+
         $mform->addElement('select', 'timesplitting', get_string('timesplittingmethod', 'analytics'), $timesplittings);
         $mform->addHelpButton('timesplitting', 'timesplittingmethod', 'analytics');
 
-        // Predictions processor.
-        if (!$this->_customdata['staticmodel']) {
-            $defaultprocessor = \core_analytics\manager::get_predictions_processor_name(
-                \core_analytics\manager::get_predictions_processor()
-            );
-            $predictionprocessors = ['' => get_string('defaultpredictoroption', 'analytics', $defaultprocessor)];
-            foreach ($this->_customdata['predictionprocessors'] as $classname => $predictionsprocessor) {
-                if ($predictionsprocessor->is_ready() !== true) {
-                    continue;
-                }
-                $optionname = \tool_analytics\output\helper::class_to_option($classname);
-                $predictionprocessors[$optionname] = \core_analytics\manager::get_predictions_processor_name($predictionsprocessor);
+        $defaultprocessor = \core_analytics\manager::get_predictions_processor_name(
+            \core_analytics\manager::get_predictions_processor()
+        );
+        $predictionprocessors = ['' => get_string('defaultpredictoroption', 'analytics', $defaultprocessor)];
+        foreach ($this->_customdata['predictionprocessors'] as $classname => $predictionsprocessor) {
+            if ($predictionsprocessor->is_ready() !== true) {
+                continue;
             }
-
-            $mform->addElement('select', 'predictionsprocessor', get_string('predictionsprocessor', 'analytics'),
-                $predictionprocessors);
-            $mform->addHelpButton('predictionsprocessor', 'predictionsprocessor', 'analytics');
+            $optionname = \tool_analytics\output\helper::class_to_option($classname);
+            $predictionprocessors[$optionname] = \core_analytics\manager::get_predictions_processor_name($predictionsprocessor);
         }
 
-        if (!empty($this->_customdata['id'])) {
-            $mform->addElement('hidden', 'id', $this->_customdata['id']);
-            $mform->setType('id', PARAM_INT);
+        $mform->addElement('select', 'predictionsprocessor', get_string('predictionsprocessor', 'analytics'),
+            $predictionprocessors);
+        $mform->addHelpButton('predictionsprocessor', 'predictionsprocessor', 'analytics');
 
-            $mform->addElement('hidden', 'action', 'edit');
-            $mform->setType('action', PARAM_ALPHANUMEXT);
-        }
+        $mform->addElement('hidden', 'id', $this->_customdata['id']);
+        $mform->setType('id', PARAM_INT);
+
+        $mform->addElement('hidden', 'action', 'edit');
+        $mform->setType('action', PARAM_ALPHANUMEXT);
 
         $this->add_action_buttons();
     }
@@ -137,15 +115,13 @@ class edit_model extends \moodleform {
             }
         }
 
-        if (!$this->_customdata['staticmodel']) {
-            if (empty($data['indicators'])) {
-                $errors['indicators'] = get_string('errornoindicators', 'analytics');
-            } else {
-                foreach ($data['indicators'] as $indicator) {
-                    $realindicatorname = \tool_analytics\output\helper::option_to_class($indicator);
-                    if (\core_analytics\manager::is_valid($realindicatorname, '\core_analytics\local\indicator\base') === false) {
-                        $errors['indicators'] = get_string('errorinvalidindicator', 'analytics', $realindicatorname);
-                    }
+        if (empty($data['indicators'])) {
+            $errors['indicators'] = get_string('errornoindicators', 'analytics');
+        } else {
+            foreach ($data['indicators'] as $indicator) {
+                $realindicatorname = \tool_analytics\output\helper::option_to_class($indicator);
+                if (\core_analytics\manager::is_valid($realindicatorname, '\core_analytics\local\indicator\base') === false) {
+                    $errors['indicators'] = get_string('errorinvalidindicator', 'analytics', $realindicatorname);
                 }
             }
         }

admin/tool/analytics/classes/output/form/import_model.php

@@ -1,58 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * Model upload form.
- *
- * @package   tool_analytics
- * @copyright 2017 onwards Ankit Agarwal
- * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-namespace tool_analytics\output\form;
-
-defined('MOODLE_INTERNAL') || die();
-
-require_once($CFG->libdir.'/formslib.php');
-
-/**
- * Model upload form.
- *
- * @package   tool_analytics
- * @copyright 2017 onwards Ankit Agarwal
- * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-class import_model extends \moodleform {
-
-    /**
-     * Form definition.
-     *
-     * @return null
-     */
-    public function definition () {
-        $mform = $this->_form;
-
-        $mform->addElement('header', 'settingsheader', get_string('importmodel', 'tool_analytics'));
-
-        $mform->addElement('filepicker', 'modelfile', get_string('file'), null, ['accepted_types' => '.zip']);
-        $mform->addRule('modelfile', null, 'required');
-
-        $mform->addElement('advcheckbox', 'ignoreversionmismatches', get_string('ignoreversionmismatches', 'tool_analytics'),
-            get_string('ignoreversionmismatchescheckbox', 'tool_analytics'));
-
-        $this->add_action_buttons(true, get_string('import'));
-    }
-}

admin/tool/analytics/classes/output/helper.php

@@ -45,7 +45,7 @@ class helper {
         // Form field is PARAM_ALPHANUMEXT and we are sending fully qualified class names
         // as option names, but replacing the backslash for a string that is really unlikely
         // to ever be part of a class name.
-        return str_replace('\\', '__', $class);
+        return str_replace('\\', '2015102400ouuu', $class);
     }
 
     /**
@@ -56,53 +56,6 @@ class helper {
      */
     public static function option_to_class($option) {
         // Really unlikely but yeah, I'm a bad booyyy.
-        return str_replace('__', '\\', $option);
-    }
-
-    /**
-     * Sets an analytics > analytics models > $title breadcrumb.
-     *
-     * @param string $title
-     * @param \moodle_url $url
-     * @param \context|null $context Defaults to context_system
-     * @return null
-     */
-    public static function set_navbar(string $title, \moodle_url $url, ?\context $context = null) {
-        global $PAGE;
-
-        if (!$context) {
-            $context = \context_system::instance();
-        }
-
-        $PAGE->set_context($context);
-        $PAGE->set_url($url);
-
-        if ($siteadmin = $PAGE->settingsnav->find('root', \navigation_node::TYPE_SITE_ADMIN)) {
-            $PAGE->navbar->add($siteadmin->get_content(), $siteadmin->action());
-        }
-        if ($analytics = $PAGE->settingsnav->find('analytics', \navigation_node::TYPE_SETTING)) {
-            $PAGE->navbar->add($analytics->get_content(), $analytics->action());
-        }
-        if ($analyticmodels = $PAGE->settingsnav->find('analyticmodels', \navigation_node::TYPE_SETTING)) {
-            $PAGE->navbar->add($analyticmodels->get_content(), $analyticmodels->action());
-        }
-        $PAGE->navbar->add($title);
-
-        $PAGE->set_pagelayout('report');
-        $PAGE->set_title($title);
-        $PAGE->set_heading($title);
-    }
-
-    /**
-     * Resets the current page.
-     *
-     * Note that this function can only be used by analytics pages that work at the system context.
-     *
-     * @return null
-     */
-    public static function reset_page() {
-        global $PAGE;
-        $PAGE->reset_theme_and_output();
-        $PAGE->set_context(\context_system::instance());
+        return str_replace('2015102400ouuu', '\\', $option);
     }
 }

admin/tool/analytics/classes/output/invalid_analysables.php

@@ -76,17 +76,13 @@ class invalid_analysables implements \renderable, \templatable {
 
         $offset = $this->page * $this->perpage;
 
-        $analysables = $this->model->get_analyser(['notimesplitting' => true])->get_analysables_iterator();
+        $analysables = $this->model->get_analyser(['notimesplitting' => true])->get_analysables();
 
         $skipped = 0;
         $enoughresults = false;
         $morepages = false;
         $results = array();
-        foreach ($analysables as $analysable) {
-
-            if (!$analysable) {
-                continue;
-            }
+        foreach ($analysables as $key => $analysable) {
 
             $validtraining = $this->model->get_target()->is_valid_analysable($analysable, true);
             if ($validtraining === true) {
@@ -121,11 +117,13 @@ class invalid_analysables implements \renderable, \templatable {
                 $morepages = true;
                 break;
             }
+
+            unset($analysables[$key]);
         }
 
         // Prepare the context object.
         $data = new \stdClass();
-        $data->modelname = $this->model->get_name();
+        $data->modelname = $this->model->get_target()->get_name();
 
         if ($this->page > 0) {
             $prev = clone $PAGE->url;
@@ -155,12 +153,6 @@ class invalid_analysables implements \renderable, \templatable {
             $data->analysables[] = $obj;
         }
 
-        if (empty($data->analysables)) {
-            $data->noanalysables = [
-                'message' => get_string('noinvalidanalysables', 'tool_analytics'),
-                'announce' => true,
-            ];
-        }
         return $data;
     }
 }

admin/tool/analytics/classes/output/model_logs.php

@@ -41,11 +41,6 @@ class model_logs extends \table_sql {
      */
     protected $model = null;
 
-    /**
-     * @var string|false
-     */
-    protected $evaluationmode = false;
-
     /**
      * Sets up the table_log parameters.
      *
@@ -62,32 +57,21 @@ class model_logs extends \table_sql {
         $this->set_attribute('class', 'modellog generaltable generalbox');
         $this->set_attribute('aria-live', 'polite');
 
-        $this->define_columns(array('time', 'version', 'evaluationmode', 'indicators', 'timesplitting',
-            'accuracy', 'info', 'usermodified'));
+        $this->define_columns(array('time', 'version', 'indicators', 'timesplitting', 'accuracy', 'info', 'usermodified'));
         $this->define_headers(array(
             get_string('time'),
             get_string('version'),
-            get_string('evaluationmode', 'tool_analytics'),
             get_string('indicators', 'tool_analytics'),
             get_string('timesplittingmethod', 'analytics'),
             get_string('accuracy', 'tool_analytics'),
             get_string('info', 'tool_analytics'),
             get_string('fullnameuser'),
         ));
-
-        $evaluationmodehelp = new \help_icon('evaluationmode', 'tool_analytics');
-        $this->define_help_for_headers([null, null, $evaluationmodehelp, null, null, null, null, null]);
-
         $this->pageable(true);
         $this->collapsible(false);
         $this->sortable(false);
         $this->is_downloadable(false);
 
-        $this->evaluationmode = optional_param('evaluationmode', false, PARAM_ALPHANUM);
-        if ($this->evaluationmode && $this->evaluationmode != 'configuration' && $this->evaluationmode != 'trainedmodel') {
-            $this->evaluationmode = '';
-        }
-
         $this->define_baseurl($PAGE->url);
     }
 
@@ -102,15 +86,6 @@ class model_logs extends \table_sql {
         return userdate($log->version, $recenttimestr);
     }
 
-    /**
-     * Generate the evaluation mode column.
-     *
-     * @param \stdClass $log log data.
-     * @return string HTML for the evaluationmode column
-     */
-    public function col_evaluationmode($log) {
-        return get_string('evaluationmodecol' . $log->evaluationmode, 'tool_analytics');
-    }
     /**
      * Generate the time column.
      *

admin/tool/analytics/classes/output/models_list.php

@@ -63,53 +63,15 @@ class models_list implements \renderable, \templatable {
 
         $data = new \stdClass();
 
-        $newmodelmenu = new \action_menu();
-        $newmodelmenu->set_menu_trigger(get_string('newmodel', 'tool_analytics'), 'btn btn-default');
-        $newmodelmenu->set_alignment(\action_menu::TL, \action_menu::BL);
-
-        $newmodelmenu->add(new \action_menu_link(
-            new \moodle_url('/admin/tool/analytics/createmodel.php'),
-            new \pix_icon('i/edit', ''),
-            get_string('createmodel', 'tool_analytics'),
-            false
-        ));
-
-        $newmodelmenu->add(new \action_menu_link(
-            new \moodle_url('/admin/tool/analytics/importmodel.php'),
-            new \pix_icon('i/import', ''),
-            get_string('importmodel', 'tool_analytics'),
-            false
-        ));
-
-        $newmodelmenu->add(new \action_menu_link(
-            new \moodle_url('/admin/tool/analytics/restoredefault.php'),
-            new \pix_icon('i/reload', ''),
-            get_string('restoredefault', 'tool_analytics'),
-            false
-        ));
-
-        $data->newmodelmenu = $newmodelmenu->export_for_template($output);
-
         $onlycli = get_config('analytics', 'onlycli');
         if ($onlycli === false) {
             // Default applied if no config found.
             $onlycli = 1;
         }
 
-        // Evaluation options.
-        $timesplittingmethods = [
-            ['id' => 'all', 'text' => get_string('alltimesplittingmethods', 'tool_analytics')],
-        ];
-        foreach (\core_analytics\manager::get_time_splitting_methods_for_evaluation(true) as $timesplitting) {
-            $timesplittingmethods[] = [
-                'id' => \tool_analytics\output\helper::class_to_option($timesplitting->get_id()),
-                'text' => $timesplitting->get_name()->out(),
-            ];
-        }
-
         $data->models = array();
         foreach ($this->models as $model) {
-            $modeldata = $model->export($output);
+            $modeldata = $model->export();
 
             // Check if there is a help icon for the target to show.
             $identifier = $modeldata->target->get_identifier();
@@ -145,8 +107,6 @@ class models_list implements \renderable, \templatable {
                 $modeldata->indicators = $indicators;
             }
 
-            $modeldata->indicatorsnum = count($modeldata->indicators);
-
             // Check if there is a help icon for the time splitting method.
             if (!empty($modeldata->timesplitting)) {
                 $identifier = $modeldata->timesplitting->get_identifier();
@@ -225,30 +185,15 @@ class models_list implements \renderable, \templatable {
 
             // Evaluate machine-learning-based models.
             if (!$onlycli && $model->get_indicators() && !$model->is_static()) {
-
-                // Extra is_trained call as trained_locally returns false if the model has not been trained yet.
-                $trainedonlyexternally = !$model->trained_locally() && $model->is_trained();
-
-                $actionid = 'evaluate-' . $model->get_id();
-
-                $modeltimesplittingmethods = $timesplittingmethods;
-                // Include the current time-splitting method as the default selection method the model already have one.
-                if ($model->get_model_obj()->timesplitting) {
-                    $currenttimesplitting = ['id' => 'current', 'text' => get_string('currenttimesplitting', 'tool_analytics')];
-                    array_unshift($modeltimesplittingmethods, $currenttimesplitting);
-                }
-
-                $evaluateparams = [$actionid, $trainedonlyexternally, $modeltimesplittingmethods];
-                $PAGE->requires->js_call_amd('tool_analytics/model', 'selectEvaluationOptions', $evaluateparams);
                 $urlparams['action'] = 'evaluate';
                 $url = new \moodle_url('model.php', $urlparams);
                 $icon = new \action_menu_link_secondary($url, new \pix_icon('i/calc', get_string('evaluate', 'tool_analytics')),
-                    get_string('evaluate', 'tool_analytics'), ['data-action-id' => $actionid]);
+                    get_string('evaluate', 'tool_analytics'));
                 $actionsmenu->add($icon);
             }
 
             // Machine-learning-based models evaluation log.
-            if (!$model->is_static() && $model->get_logs()) {
+            if (!$model->is_static()) {
                 $urlparams['action'] = 'log';
                 $url = new \moodle_url('model.php', $urlparams);
                 $icon = new \action_menu_link_secondary($url, new \pix_icon('i/report', get_string('viewlog', 'tool_analytics')),
@@ -257,10 +202,12 @@ class models_list implements \renderable, \templatable {
             }
 
             // Edit model.
-            $urlparams['action'] = 'edit';
-            $url = new \moodle_url('model.php', $urlparams);
-            $icon = new \action_menu_link_secondary($url, new \pix_icon('t/edit', get_string('edit')), get_string('edit'));
-            $actionsmenu->add($icon);
+            if (!$model->is_static()) {
+                $urlparams['action'] = 'edit';
+                $url = new \moodle_url('model.php', $urlparams);
+                $icon = new \action_menu_link_secondary($url, new \pix_icon('t/edit', get_string('edit')), get_string('edit'));
+                $actionsmenu->add($icon);
+            }
 
             // Enable / disable.
             if ($model->is_enabled() || !empty($modeldata->timesplitting)) {
@@ -280,27 +227,13 @@ class models_list implements \renderable, \templatable {
                 $actionsmenu->add($icon);
             }
 
-            // Export.
-            if (!$model->is_static()) {
-
-                $fullysetup = $model->get_indicators() && !empty($modeldata->timesplitting);
-                $istrained = $model->is_trained();
-
-                if ($fullysetup || $istrained) {
-
-                    $url = new \moodle_url('model.php', $urlparams);
-                    // Clear the previous action param from the URL, we will set it in JS.
-                    $url->remove_params('action');
-
-                    $actionid = 'export-' . $model->get_id();
-                    $PAGE->requires->js_call_amd('tool_analytics/model', 'selectExportOptions',
-                        [$actionid, $istrained]);
-
-                    $icon = new \action_menu_link_secondary($url, new \pix_icon('i/export',
-                        get_string('export', 'tool_analytics')), get_string('export', 'tool_analytics'),
-                        ['data-action-id' => $actionid]);
-                    $actionsmenu->add($icon);
-                }
+            // Export training data.
+            if (!$model->is_static() && $model->is_trained()) {
+                $urlparams['action'] = 'export';
+                $url = new \moodle_url('model.php', $urlparams);
+                $icon = new \action_menu_link_secondary($url, new \pix_icon('i/export',
+                    get_string('exporttrainingdata', 'tool_analytics')), get_string('export', 'tool_analytics'));
+                $actionsmenu->add($icon);
             }
 
             // Invalid analysables.
@@ -314,7 +247,7 @@ class models_list implements \renderable, \templatable {
             }
 
             // Clear model.
-            if (!empty($predictioncontexts) || $model->is_trained()) {
+            if (!empty($predictioncontexts)) {
                 $actionid = 'clear-' . $model->get_id();
                 $PAGE->requires->js_call_amd('tool_analytics/model', 'confirmAction', [$actionid, 'clear']);
                 $urlparams['action'] = 'clear';
@@ -325,16 +258,6 @@ class models_list implements \renderable, \templatable {
                 $actionsmenu->add($icon);
             }
 
-            // Delete model.
-            $actionid = 'delete-' . $model->get_id();
-            $PAGE->requires->js_call_amd('tool_analytics/model', 'confirmAction', [$actionid, 'delete']);
-            $urlparams['action'] = 'delete';
-            $url = new \moodle_url('model.php', $urlparams);
-            $icon = new \action_menu_link_secondary($url, new \pix_icon('t/delete',
-                get_string('delete', 'tool_analytics')), get_string('delete', 'tool_analytics'),
-                ['data-action-id' => $actionid]);
-            $actionsmenu->add($icon);
-
             $modeldata->actions = $actionsmenu->export_for_template($output);
 
             $data->models[] = $modeldata;

admin/tool/analytics/classes/output/renderer.php

@@ -81,7 +81,7 @@ class renderer extends plugin_renderer_base {
         foreach ($results as $timesplittingid => $result) {
 
             if (!CLI_SCRIPT) {
-                $output .= $OUTPUT->box_start('generalbox mb-3');
+                $output .= $OUTPUT->box_start('generalbox m-b-3');
             }
 
             // Check that the array key is a string, not all results depend on time splitting methods (e.g. general errors).
@@ -177,7 +177,7 @@ class renderer extends plugin_renderer_base {
         }
 
         if ($predictresults || (!empty($predictlogs) && debugging())) {
-            $output .= $OUTPUT->heading(get_string('predictionresults', 'tool_analytics'), 3, 'main mt-3');
+            $output .= $OUTPUT->heading(get_string('predictionresults', 'tool_analytics'), 3, 'main m-t-3');
         }
 
         if ($predictresults) {

admin/tool/analytics/classes/output/restorable_models.php

@@ -1,142 +0,0 @@
-<?php
-// This file is part of Moodle - https://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * Provides {@link \tool_analytics\output\restorable_models} class.
- *
- * @package     tool_analytics
- * @category    output
- * @copyright   2019 David Mudrák <david@moodle.com>
- * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-namespace tool_analytics\output;
-
-defined('MOODLE_INTERNAL') || die();
-
-/**
- * Represents the list of default models that can be eventually restored.
- *
- * @copyright 2019 David Mudrák <david@moodle.com>
- * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-class restorable_models implements \renderable, \templatable {
-
-    /** @var array */
-    protected $models;
-
-    /**
-     * Instantiate an object of this class.
-     *
-     * @param array $models List of models as returned by {@link \core_analytics\manager::load_default_models_for_all_components()}
-     */
-    public function __construct(array $models) {
-
-        $this->models = $models;
-    }
-
-    /**
-     * Export the list of models to be rendered.
-     *
-     * @param renderer_base $output
-     * @return string
-     */
-    public function export_for_template(\renderer_base $output) {
-
-        $components = [];
-
-        foreach ($this->models as $componentname => $modelslist) {
-            $component = [
-                'name' => $this->component_name($componentname),
-                'component' => $componentname,
-                'models' => [],
-            ];
-
-            foreach ($modelslist as $definition) {
-                list($target, $indicators) = \core_analytics\manager::get_declared_target_and_indicators_instances($definition);
-
-                if (\core_analytics\model::exists($target, $indicators)) {
-                    continue;
-                }
-
-                $targetnamelangstring = $target->get_name();
-
-                $model = [
-                    'defid' => \core_analytics\manager::model_declaration_identifier($definition),
-                    'targetname' => $targetnamelangstring,
-                    'targetclass' => $definition['target'],
-                    'indicatorsnum' => count($definition['indicators']),
-                    'indicators' => [],
-                ];
-
-                if (get_string_manager()->string_exists($targetnamelangstring->get_identifier().'_help',
-                        $targetnamelangstring->get_component())) {
-                    $helpicon = new \help_icon($targetnamelangstring->get_identifier(), $targetnamelangstring->get_component());
-                    $model['targethelp'] = $helpicon->export_for_template($output);
-                }
-
-                foreach ($indicators as $indicator) {
-                    $indicatornamelangstring = $indicator->get_name();
-                    $indicatordata = [
-                        'name' => $indicatornamelangstring,
-                        'classname' => $indicator->get_id(),
-                    ];
-
-                    if (get_string_manager()->string_exists($indicatornamelangstring->get_identifier().'_help',
-                            $indicatornamelangstring->get_component())) {
-                        $helpicon = new \help_icon($indicatornamelangstring->get_identifier(),
-                            $indicatornamelangstring->get_component());
-                        $indicatordata['indicatorhelp'] = $helpicon->export_for_template($output);
-                    }
-
-                    $model['indicators'][] = $indicatordata;
-                }
-
-                $component['models'][] = $model;
-            }
-
-            if (!empty($component['models'])) {
-                $components[] = $component;
-            }
-        }
-
-        $result = [
-            'hasdata' => !empty($components),
-            'components' => array_values($components),
-            'submiturl' => new \moodle_url('/admin/tool/analytics/restoredefault.php'),
-            'backurl' => new \moodle_url('/admin/tool/analytics/index.php'),
-            'sesskey' => sesskey(),
-        ];
-
-        return $result;
-    }
-
-    /**
-     * Return a human readable name for the given frankenstyle component.
-     *
-     * @param string $component Frankenstyle component such as 'core', 'core_analytics' or 'mod_workshop'
-     * @return string Human readable name of the component
-     */
-    protected function component_name(string $component): string {
-
-        if ($component === 'core' || strpos($component, 'core_')) {
-            return get_string('componentcore', 'tool_analytics');
-
-        } else {
-            return get_string('pluginname', $component);
-        }
-    }
-}

admin/tool/analytics/classes/task/predict_models.php

@@ -60,12 +60,8 @@ class predict_models extends \core\task\scheduled_task {
 
         foreach ($models as $model) {
             $result = $model->predict();
-
-            // Reset the page as some indicators may call external functions that overwrite the page context.
-            \tool_analytics\output\helper::reset_page();
-
             if ($result) {
-                echo $OUTPUT->heading(get_string('modelresults', 'tool_analytics', $model->get_name()));
+                echo $OUTPUT->heading(get_string('modelresults', 'tool_analytics', $model->get_target()->get_name()));
                 $renderer = $PAGE->get_renderer('tool_analytics');
                 echo $renderer->render_get_predictions_results(false, array(), $result, $model->get_analyser()->get_logs());
             }

admin/tool/analytics/classes/task/train_models.php

@@ -71,12 +71,8 @@ class train_models extends \core\task\scheduled_task {
             }
 
             $result = $model->train();
-
-            // Reset the page as some indicators may call external functions that overwrite the page context.
-            \tool_analytics\output\helper::reset_page();
-
             if ($result) {
-                echo $OUTPUT->heading(get_string('modelresults', 'tool_analytics', $model->get_name()));
+                echo $OUTPUT->heading(get_string('modelresults', 'tool_analytics', $model->get_target()->get_name()));
 
                 $renderer = $PAGE->get_renderer('tool_analytics');
                 echo $renderer->render_get_predictions_results($result, $model->get_analyser()->get_logs());

admin/tool/analytics/cli/evaluate_model.php

@@ -35,8 +35,6 @@ Options:
 --non-interactive      Not interactive questions
 --timesplitting        Restrict the evaluation to 1 single time splitting method (Optional)
 --filter               Analyser dependant. e.g. A courseid would evaluate the model using a single course (Optional)
---mode                 'configuration' or 'trainedmodel'. You can only use mode=trainedmodel when the trained" .
-    " model was imported" . "
 --reuse-prev-analysed  Reuse recently analysed courses instead of analysing the whole site. Set it to false while" .
     " coding indicators. Defaults to true (Optional)" . "
 -h, --help             Print out this help
@@ -52,7 +50,6 @@ list($options, $unrecognized) = cli_get_params(
         'modelid'               => false,
         'list'                  => false,
         'timesplitting'         => false,
-        'mode'                  => 'configuration',
         'reuse-prev-analysed'   => true,
         'non-interactive'       => false,
         'filter'                => false
@@ -67,30 +64,16 @@ if ($options['help']) {
     exit(0);
 }
 
-if ($options['list']) {
+if ($options['list'] || $options['modelid'] === false) {
     \tool_analytics\clihelper::list_models();
     exit(0);
 }
 
-if ($options['modelid'] === false) {
-    // All actions but --list require a modelid.
-    echo $help;
-    exit(0);
-}
-
 // Reformat them as an array.
 if ($options['filter'] !== false) {
     $options['filter'] = explode(',', $options['filter']);
 }
 
-if ($options['mode'] !== 'configuration' && $options['mode'] !== 'trainedmodel') {
-    cli_error('Error: The provided mode is not supported');
-}
-
-if ($options['mode'] == 'trainedmodel' && $options['timesplitting']) {
-    cli_error('Sorry, no time splitting method can be specified when using \'trainedmodel\' mode.');
-}
-
 // We need admin permissions.
 \core\session\manager::set_user(get_admin());
 
@@ -106,14 +89,10 @@ $analyseroptions = array(
     'filter' => $options['filter'],
     'timesplitting' => $options['timesplitting'],
     'reuseprevanalysed' => $options['reuse-prev-analysed'],
-    'mode' => $options['mode'],
 );
 // Evaluate its suitability to predict accurately.
 $results = $model->evaluate($analyseroptions);
 
-// Reset the page as some indicators may call external functions that overwrite the page context.
-\tool_analytics\output\helper::reset_page();
-
 $renderer = $PAGE->get_renderer('tool_analytics');
 echo $renderer->render_evaluate_results($results, $model->get_analyser()->get_logs());
 

admin/tool/analytics/cli/guess_course_start_and_end.php

@@ -204,9 +204,9 @@ function tool_analytics_calculate_course_dates($course, $options) {
 
                 $updateit = false;
                 if ($course->enddate < $course->startdate) {
-                    $notification .= PHP_EOL . '  ' . get_string('errorendbeforestart', 'course', userdate($course->enddate));
+                    $notification .= PHP_EOL . '  ' . get_string('errorendbeforestart', 'analytics', userdate($course->enddate));
                 } else if ($course->startdate + (YEARSECS + (WEEKSECS * 4)) > $course->enddate) {
-                    $notification .= PHP_EOL . '  ' . get_string('coursetoolong', 'course');
+                    $notification .= PHP_EOL . '  ' . get_string('coursetoolong', 'analytics');
                 } else {
                     $notification .= PHP_EOL . '  ' . get_string('enddate') . ': ' . userdate($course->enddate);
                     $updateit = true;

admin/tool/analytics/createmodel.php

@@ -1,95 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * Create model form.
- *
- * @package    tool_analytics
- * @copyright  2019 David Monllao {@link http://www.davidmonllao.com}
- * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-require_once(__DIR__ . '/../../../config.php');
-
-require_login();
-\core_analytics\manager::check_can_manage_models();
-
-$returnurl = new \moodle_url('/admin/tool/analytics/index.php');
-$url = new \moodle_url('/admin/tool/analytics/createmodel.php');
-$title = get_string('createmodel', 'tool_analytics');
-
-\tool_analytics\output\helper::set_navbar($title, $url);
-
-// Static targets are not editable, we discard them.
-$targets = array_filter(\core_analytics\manager::get_all_targets(), function($target) {
-    return (!$target->based_on_assumptions());
-});
-
-$customdata = array(
-    'trainedmodel' => false,
-    'staticmodel' => false,
-    'targets' => $targets,
-    'indicators' => \core_analytics\manager::get_all_indicators(),
-    'timesplittings' => \core_analytics\manager::get_all_time_splittings(),
-    'predictionprocessors' => \core_analytics\manager::get_all_prediction_processors(),
-);
-$mform = new \tool_analytics\output\form\edit_model(null, $customdata);
-
-if ($mform->is_cancelled()) {
-    redirect($returnurl);
-
-} else if ($data = $mform->get_data()) {
-
-    // Converting option names to class names.
-    $targetclass = \tool_analytics\output\helper::option_to_class($data->target);
-    if (empty($targets[$targetclass])) {
-        throw new \moodle_exception('errorinvalidtarget', 'analytics', '', $targetclass);
-    }
-    $target = $targets[$targetclass];
-
-    $indicators = array();
-    foreach ($data->indicators as $indicator) {
-        $indicatorinstance = \core_analytics\manager::get_indicator(
-            \tool_analytics\output\helper::option_to_class($indicator)
-        );
-        $indicators[$indicatorinstance->get_id()] = $indicatorinstance;
-    }
-    $timesplitting = \tool_analytics\output\helper::option_to_class($data->timesplitting);
-    $predictionsprocessor = \tool_analytics\output\helper::option_to_class($data->predictionsprocessor);
-
-    // Insert the model into db.
-    $model = \core_analytics\model::create($target, []);
-
-    // Filter out indicators that can not be used by this target.
-    $invalidindicators = array_diff_key($indicators, $model->get_potential_indicators());
-    if ($invalidindicators) {
-        $indicators = array_diff_key($indicators, $invalidindicators);
-    }
-
-    // Update the model with the valid list of indicators.
-    $model->update($data->enabled, $indicators, $timesplitting, $predictionsprocessor);
-
-    $message = '';
-    $messagetype = \core\output\notification::NOTIFY_SUCCESS;
-    if (!empty($invalidindicators)) {
-        $message = get_string('invalidindicatorsremoved', 'tool_analytics');
-    }
-    redirect($returnurl, $message, 0, $messagetype);
-}
-
-echo $OUTPUT->header();
-$mform->display();
-echo $OUTPUT->footer();

admin/tool/analytics/importmodel.php

@@ -1,59 +0,0 @@
-<?php
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * Import models tool frontend.
- *
- * @package tool_analytics
- * @copyright 2017 onwards Ankit Agarwal
- * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-require_once(__DIR__ . '/../../../config.php');
-
-require_login();
-\core_analytics\manager::check_can_manage_models();
-
-$returnurl = new \moodle_url('/admin/tool/analytics/index.php');
-$url = new \moodle_url('/admin/tool/analytics/importmodel.php');
-$title = get_string('importmodel', 'tool_analytics');
-
-\tool_analytics\output\helper::set_navbar($title, $url);
-
-$form = new \tool_analytics\output\form\import_model();
-if ($form->is_cancelled()) {
-    redirect($returnurl);
-} else if ($data = $form->get_data()) {
-
-    $modelconfig = new \core_analytics\model_config();
-
-    $zipfilepath = $form->save_temp_file('modelfile');
-
-    list ($modeldata, $unused) = $modelconfig->extract_import_contents($zipfilepath);
-
-    if ($error = $modelconfig->check_dependencies($modeldata, $data->ignoreversionmismatches)) {
-        // The file is not available until the form is validated so we need an alternative method to show errors.
-        redirect($url, $error, 0, \core\output\notification::NOTIFY_ERROR);
-    }
-    \core_analytics\model::import_model($zipfilepath);
-
-    redirect($returnurl, get_string('importedsuccessfully', 'tool_analytics'), 0,
-        \core\output\notification::NOTIFY_SUCCESS);
-}
-
-echo $OUTPUT->header();
-$form->display();
-echo $OUTPUT->footer();

admin/tool/analytics/lang/en/tool_analytics.php

@@ -24,26 +24,16 @@
 
 $string['accuracy'] = 'Accuracy';
 $string['allpredictions'] = 'All predictions';
-$string['alltimesplittingmethods'] = 'All time-splitting methods';
 $string['analysingsitedata'] = 'Analysing the site';
 $string['analyticmodels'] = 'Analytics models';
 $string['bettercli'] = 'Evaluating models and generating predictions may involve heavy processing. It is recommended to run these actions from the command line.';
 $string['cantguessstartdate'] = 'Can\'t guess the start date';
 $string['cantguessenddate'] = 'Can\'t guess the end date';
-$string['classdoesnotexist'] = 'Class {$a} does not exist';
 $string['clearpredictions'] = 'Clear predictions';
 $string['clearmodelpredictions'] = 'Are you sure you want to clear all "{$a}" predictions?';
 $string['clienablemodel'] = 'You can enable the model by selecting a time-splitting method by its ID. Note that you can also enable it later using the web interface (\'none\' to exit).';
 $string['clievaluationandpredictions'] = 'A scheduled task iterates through enabled models and gets predictions. Models evaluation via the web interface is disabled. You can allow these processes to be executed manually via the web interface by disabling the <a href="{$a}">\'onlycli\'</a> analytics setting.';
 $string['clievaluationandpredictionsnoadmin'] = 'A scheduled task iterates through enabled models and gets predictions. Models evaluation via the web interface is disabled. It may be enabled by a site administrator.';
-$string['component'] = 'Component';
-$string['componentcore'] = 'Core';
-$string['componentselect'] = 'Select all models provided by the component \'{$a}\'';
-$string['componentselectnone'] = 'Unselect all';
-$string['createmodel'] = 'Create model';
-$string['currenttimesplitting'] = 'Current time-splitting method';
-$string['delete'] = 'Delete';
-$string['deletemodelconfirmation'] = 'Are you sure you want to delete "{$a}"? These changes cannot be reverted.';
 $string['disabled'] = 'Disabled';
 $string['editmodel'] = 'Edit "{$a}" model';
 $string['edittrainedwarning'] = 'This model has already been trained. Note that changing its indicators or its time-splitting method will delete its previous predictions and start generating new predictions.';
@@ -52,64 +42,39 @@ $string['errorcantenablenotimesplitting'] = 'You need to select a time-splitting
 $string['errornoenabledandtrainedmodels'] = 'There are no enabled and trained models to predict.';
 $string['errornoenabledmodels'] = 'There are no enabled models to train.';
 $string['errornoexport'] = 'Only trained models can be exported';
+$string['errornostaticedit'] = 'Models based on assumptions cannot be edited.';
 $string['errornostaticevaluated'] = 'Models based on assumptions cannot be evaluated. They are always 100% correct according to how they were defined.';
 $string['errornostaticlog'] = 'Models based on assumptions cannot be evaluated because there is no performance log.';
 $string['erroronlycli'] = 'Execution only allowed via command line';
 $string['errortrainingdataexport'] = 'The model training data could not be exported';
 $string['evaluate'] = 'Evaluate';
 $string['evaluatemodel'] = 'Evaluate model';
-$string['evaluationmode'] = 'Evaluation mode';
-$string['evaluationmode_help'] = 'There are two evaluation modes:
-
-* Trained model -  Site data is used as testing data to evaluate the accuracy of the trained model.
-* Configuration - Site data is split into training and testing data, to both train and test the accuracy of the model configuration.
-
-Trained model is only available if a trained model has been imported into the site, and has not yet been re-trained using site data.';
-$string['evaluationmodeinfo'] = 'This model has been imported into the site. You can either evaluate the performance of the model, or you can evaluate the performance of the model configuration using site data.';
-$string['evaluationmodetrainedmodel'] = 'Evaluate the trained model';
-$string['evaluationmodecoltrainedmodel'] = 'Trained model';
-$string['evaluationmodecolconfiguration'] = 'Configuration';
-$string['evaluationmodeconfiguration'] = 'Evaluate the model configuration';
 $string['evaluationinbatches'] = 'The site contents are calculated and stored in batches. The evaluation process may be stopped at any time. The next time it is run, it will continue from the point when it was stopped.';
 $string['export'] = 'Export';
-$string['exportincludeweights'] = 'Include the weights of the trained model';
-$string['exportmodel'] = 'Export configuration';
 $string['exporttrainingdata'] = 'Export training data';
-$string['getpredictionsresultscli'] = 'Results using {$a->name} (id: {$a->id}) time-splitting method';
-$string['getpredictionsresults'] = 'Results using {$a->name} time-splitting method';
+$string['getpredictionsresultscli'] = 'Results using {$a->name} (id: {$a->id}) course duration splitting';
+$string['getpredictionsresults'] = 'Results using {$a->name} course duration splitting';
 $string['extrainfo'] = 'Info';
 $string['generalerror'] = 'Evaluation error. Status code {$a}';
 $string['getpredictions'] = 'Get predictions';
 $string['goodmodel'] = 'This is a good model for using to obtain predictions. Enable it to start obtaining predictions.';
-$string['importmodel'] = 'Import model';
 $string['indicators'] = 'Indicators';
-$string['indicators_help'] = 'The indicators are what you think will lead to an accurate prediction of the target.';
-$string['indicators_link'] = 'Indicators';
-$string['indicatorsnum'] = 'Number of indicators: {$a}';
 $string['info'] = 'Info';
-$string['ignoreversionmismatches'] = 'Ignore version mismatches';
-$string['ignoreversionmismatchescheckbox'] = 'Ignore the differences between this site version and the original site version.';
-$string['importedsuccessfully'] = 'The model has been successfully imported.';
 $string['insights'] = 'Insights';
 $string['invalidanalysables'] = 'Invalid site elements';
-$string['invalidanalysablesinfo'] = 'This page lists analysable elements that can\'t be used by this prediction model. The listed elements can\'t be used either to train the prediction model nor can the prediction model obtain predictions for them.';
+$string['invalidanalysablesinfo'] = 'This pages lists this site analysable elements that can not be used by this prediction model. The listed elements can not be used neither to train the prediction model nor the prediction model can get predictions for them.';
 $string['invalidanalysablestable'] = 'Invalid site analysable elements table';
-$string['invalidindicatorsremoved'] = 'A new model has been added. Indicators that do not work with the selected target have been automatically removed.';
 $string['invalidprediction'] = 'Invalid to get predictions';
 $string['invalidtraining'] = 'Invalid to train the model';
 $string['loginfo'] = 'Log extra info';
-$string['missingmoodleversion'] = 'Imported file doesn\'t define a version number';
 $string['modelid'] = 'Model ID';
 $string['modelinvalidanalysables'] = 'Invalid analysable elements for "{$a}" model';
-$string['modelname'] = 'Model name';
 $string['modelresults'] = '{$a} results';
 $string['modeltimesplitting'] = 'Time splitting';
-$string['newmodel'] = 'New model';
 $string['nextpage'] = 'Next page';
 $string['nodatatoevaluate'] = 'There is no data to evaluate the model';
 $string['nodatatopredict'] = 'No new elements to get predictions for';
 $string['nodatatotrain'] = 'There is no new data that can be used for training';
-$string['noinvalidanalysables'] = 'This site does not contain any invalid analysable element.';
 $string['notdefined'] = 'Not yet defined';
 $string['pluginname'] = 'Analytic models';
 $string['predictionresults'] = 'Prediction results';
@@ -117,26 +82,16 @@ $string['predictmodels'] = 'Predict models';
 $string['predictorresultsin'] = 'Predictor logged information in {$a} directory';
 $string['predictionprocessfinished'] = 'Prediction process finished';
 $string['previouspage'] = 'Previous page';
-$string['restoredefault'] = 'Restore default models';
-$string['restoredefaultempty'] = 'Please select models to be restored.';
-$string['restoredefaultinfo'] = 'These default models are missing or have changed since being installed. You can restore selected default models.';
-$string['restoredefaultnone'] = 'All default models provided by core and installed plugins have been created. No new models were found; there is nothing to restore.';
-$string['restoredefaultsome'] = 'Succesfully re-created {$a->count} new model(s).';
-$string['restoredefaultsubmit'] = 'Restore selected';
 $string['samestartdate'] = 'Current start date is good';
 $string['sameenddate'] = 'Current end date is good';
-$string['selecttimesplittingforevaluation'] = 'Select the time-splitting method you want to use to evaluate the model configuration.';
 $string['target'] = 'Target';
-$string['target_help'] = 'The target is what the model will predict.';
-$string['target_link'] = 'Targets';
 $string['timesplittingnotdefined'] = 'Time splitting is not defined.';
 $string['timesplittingnotdefined_help'] = 'You need to select a time-splitting method before enabling the model.';
 $string['trainandpredictmodel'] = 'Training model and calculating predictions';
 $string['trainingprocessfinished'] = 'Training process finished';
 $string['trainingresults'] = 'Training results';
 $string['trainmodels'] = 'Train models';
-$string['versionnotsame'] = 'Imported file was from a different version ({$a->importedversion}) than the current one ({$a->version})';
-$string['viewlog'] = 'Evaluation log';
+$string['viewlog'] = 'Log';
 $string['weeksenddateautomaticallyset'] = 'End date automatically set based on start date and the number of sections';
 $string['weeksenddatedefault'] = 'End date automatically calculated from the course start date.';
 $string['privacy:metadata'] = 'The Analytic models plugin does not store any personal data.';

admin/tool/analytics/model.php

@@ -23,24 +23,24 @@
  */
 
 require_once(__DIR__ . '/../../../config.php');
-require_once($CFG->libdir . '/filelib.php');
 
 $id = required_param('id', PARAM_INT);
 $action = required_param('action', PARAM_ALPHANUMEXT);
 
+$context = context_system::instance();
+
 require_login();
 
 $model = new \core_analytics\model($id);
 \core_analytics\manager::check_can_manage_models();
 
-$returnurl = new \moodle_url('/admin/tool/analytics/index.php');
 $params = array('id' => $id, 'action' => $action);
 $url = new \moodle_url('/admin/tool/analytics/model.php', $params);
 
 switch ($action) {
 
     case 'edit':
-        $title = get_string('editmodel', 'tool_analytics', $model->get_name());
+        $title = get_string('editmodel', 'tool_analytics', $model->get_target()->get_name());
         break;
     case 'evaluate':
         $title = get_string('evaluatemodel', 'tool_analytics');
@@ -57,14 +57,8 @@ switch ($action) {
     case 'disable':
         $title = get_string('disable');
         break;
-    case 'delete':
-        $title = get_string('delete');
-        break;
-    case 'exportdata':
-        $title = get_string('exporttrainingdata', 'tool_analytics');
-        break;
-    case 'exportmodel':
-        $title = get_string('exportmodel', 'tool_analytics');
+    case 'export':
+        $title = get_string('export', 'tool_analytics');
         break;
     case 'clear':
         $title = get_string('clearpredictions', 'tool_analytics');
@@ -76,7 +70,11 @@ switch ($action) {
         throw new moodle_exception('errorunknownaction', 'analytics');
 }
 
-\tool_analytics\output\helper::set_navbar($title, $url);
+$PAGE->set_context($context);
+$PAGE->set_url($url);
+$PAGE->set_pagelayout('report');
+$PAGE->set_title($title);
+$PAGE->set_heading($title);
 
 $onlycli = get_config('analytics', 'onlycli');
 if ($onlycli === false) {
@@ -90,59 +88,48 @@ switch ($action) {
         confirm_sesskey();
 
         $model->enable();
-        redirect($returnurl);
+        redirect(new \moodle_url('/admin/tool/analytics/index.php'));
         break;
 
     case 'disable':
         confirm_sesskey();
 
         $model->update(0, false, false);
-        redirect($returnurl);
-        break;
-
-    case 'delete':
-        confirm_sesskey();
-
-        $model->delete();
-        redirect($returnurl);
+        redirect(new \moodle_url('/admin/tool/analytics/index.php'));
         break;
 
     case 'edit':
         confirm_sesskey();
 
+        if ($model->is_static()) {
+            echo $OUTPUT->header();
+            throw new moodle_exception('errornostaticedit', 'tool_analytics');
+        }
+
         $customdata = array(
             'id' => $model->get_id(),
-            'trainedmodel' => $model->is_trained(),
-            'staticmodel' => $model->is_static(),
+            'model' => $model,
             'indicators' => $model->get_potential_indicators(),
-            'timesplittings' => \core_analytics\manager::get_all_time_splittings(),
+            'timesplittings' => \core_analytics\manager::get_enabled_time_splitting_methods(),
             'predictionprocessors' => \core_analytics\manager::get_all_prediction_processors()
         );
         $mform = new \tool_analytics\output\form\edit_model(null, $customdata);
 
         if ($mform->is_cancelled()) {
-            redirect($returnurl);
+            redirect(new \moodle_url('/admin/tool/analytics/index.php'));
 
         } else if ($data = $mform->get_data()) {
 
-            $timesplitting = \tool_analytics\output\helper::option_to_class($data->timesplitting);
-
-            if (!$model->is_static()) {
-                // Converting option names to class names.
-                $indicators = array();
-                foreach ($data->indicators as $indicator) {
-                    $indicatorclass = \tool_analytics\output\helper::option_to_class($indicator);
-                    $indicators[] = \core_analytics\manager::get_indicator($indicatorclass);
-                }
-                $predictionsprocessor = \tool_analytics\output\helper::option_to_class($data->predictionsprocessor);
-            } else {
-                // These fields can not be modified.
-                $indicators = false;
-                $predictionsprocessor = false;
+            // Converting option names to class names.
+            $indicators = array();
+            foreach ($data->indicators as $indicator) {
+                $indicatorclass = \tool_analytics\output\helper::option_to_class($indicator);
+                $indicators[] = \core_analytics\manager::get_indicator($indicatorclass);
             }
-
+            $timesplitting = \tool_analytics\output\helper::option_to_class($data->timesplitting);
+            $predictionsprocessor = \tool_analytics\output\helper::option_to_class($data->predictionsprocessor);
             $model->update($data->enabled, $indicators, $timesplitting, $predictionsprocessor);
-            redirect($returnurl);
+            redirect(new \moodle_url('/admin/tool/analytics/index.php'));
         }
 
         echo $OUTPUT->header();
@@ -160,6 +147,8 @@ switch ($action) {
     case 'evaluate':
         confirm_sesskey();
 
+        echo $OUTPUT->header();
+
         if ($model->is_static()) {
             throw new moodle_exception('errornostaticevaluate', 'tool_analytics');
         }
@@ -171,31 +160,7 @@ switch ($action) {
         // Web interface is used by people who can not use CLI nor code stuff, always use
         // cached stuff as they will change the model through the web interface as well
         // which invalidates the previously analysed stuff.
-        $options = ['reuseprevanalysed' => true];
-
-        $mode = optional_param('mode', false, PARAM_ALPHANUM);
-        if ($mode == 'trainedmodel') {
-            $options['mode'] = 'trainedmodel';
-        } else {
-
-            // All is the default in core_analytics\model::evaluate() as well.
-            $timesplitting = optional_param('timesplitting', 'all', PARAM_ALPHANUMEXT);
-            if ($timesplitting === 'current') {
-                $options['timesplitting'] = \core_analytics\manager::get_time_splitting($model->get_model_obj()->timesplitting);
-            } else if ($timesplitting !== 'all') {
-                $options['timesplitting'] = \core_analytics\manager::get_time_splitting(
-                    \tool_analytics\output\helper::option_to_class($timesplitting)
-                );
-            }
-        }
-
-        $results = $model->evaluate($options);
-
-        // We reset the theme and the output as some indicators may be using external functions
-        // which reset $PAGE.
-        \tool_analytics\output\helper::reset_page();
-        echo $OUTPUT->header();
-
+        $results = $model->evaluate(array('reuseprevanalysed' => true));
         $renderer = $PAGE->get_renderer('tool_analytics');
         echo $renderer->render_evaluate_results($results, $model->get_analyser()->get_logs());
         break;
@@ -203,6 +168,8 @@ switch ($action) {
     case 'getpredictions':
         confirm_sesskey();
 
+        echo $OUTPUT->header();
+
         if ($onlycli) {
             throw new moodle_exception('erroronlycli', 'tool_analytics');
         }
@@ -220,11 +187,6 @@ switch ($action) {
             $predictlogs = array();
         }
 
-        // We reset the theme and the output as some indicators may be using external functions
-        // which reset $PAGE.
-        \tool_analytics\output\helper::reset_page();
-        echo $OUTPUT->header();
-
         $renderer = $PAGE->get_renderer('tool_analytics');
         echo $renderer->render_get_predictions_results($trainresults, $trainlogs, $predictresults, $predictlogs);
         break;
@@ -241,7 +203,7 @@ switch ($action) {
         echo $renderer->render_table($modellogstable);
         break;
 
-    case 'exportdata':
+    case 'export':
 
         if ($model->is_static() || !$model->is_trained()) {
             throw new moodle_exception('errornoexport', 'tool_analytics');
@@ -249,7 +211,7 @@ switch ($action) {
 
         $file = $model->get_training_data();
         if (!$file) {
-            redirect($returnurl, get_string('errortrainingdataexport', 'tool_analytics'),
+            redirect(new \moodle_url('/admin/tool/analytics/index.php'), get_string('errortrainingdataexport', 'tool_analytics'),
                 null, \core\output\notification::NOTIFY_ERROR);
         }
 
@@ -257,20 +219,11 @@ switch ($action) {
         send_file($file, $filename, null, 0, false, true);
         break;
 
-    case 'exportmodel':
-
-        $includeweights = optional_param('includeweights', 1, PARAM_INT);
-
-        $zipfilename = 'model-' . $model->get_unique_id() . '-' . microtime(false) . '.zip';
-        $zipfilepath = $model->export_model($zipfilename, $includeweights);
-        send_temp_file($zipfilepath, $zipfilename);
-        break;
-
     case 'clear':
         confirm_sesskey();
 
         $model->clear();
-        redirect($returnurl);
+        redirect(new \moodle_url('/admin/tool/analytics/index.php'));
         break;
 
     case 'invalidanalysables':

admin/tool/analytics/restoredefault.php

@@ -1,79 +0,0 @@
-<?php
-// This file is part of Moodle - https://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
-/**
- * Check and create missing default prediction models.
- *
- * @package     tool_analytics
- * @copyright   2019 David Mudrák <david@moodle.com>
- * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
- */
-
-require_once(__DIR__ . '/../../../config.php');
-
-require_login();
-\core_analytics\manager::check_can_manage_models();
-
-$confirmed = optional_param('confirmed', false, PARAM_BOOL);
-$restoreids = optional_param_array('restoreid', [], PARAM_ALPHANUM);
-
-$returnurl = new \moodle_url('/admin/tool/analytics/index.php');
-$myurl = new \moodle_url('/admin/tool/analytics/restoredefault.php');
-
-\tool_analytics\output\helper::set_navbar(get_string('restoredefault', 'tool_analytics'), $myurl);
-
-if (data_submitted()) {
-    require_sesskey();
-
-    if (empty($restoreids)) {
-        $message = get_string('restoredefaultempty', 'tool_analytics');
-        $type = \core\output\notification::NOTIFY_WARNING;
-        redirect($myurl, $message, null, $type);
-    }
-
-    $numcreated = 0;
-
-    foreach (\core_analytics\manager::load_default_models_for_all_components() as $componentname => $modelslist) {
-        foreach ($modelslist as $definition) {
-            if (!in_array(\core_analytics\manager::model_declaration_identifier($definition), $restoreids)) {
-                // This model has not been selected by the user.
-                continue;
-            }
-
-            list($target, $indicators) = \core_analytics\manager::get_declared_target_and_indicators_instances($definition);
-
-            if (\core_analytics\model::exists($target, $indicators)) {
-                // This model exists (normally this should not happen as we do not show such models in the UI to select).
-                continue;
-            }
-
-            \core_analytics\manager::create_declared_model($definition);
-            $numcreated++;
-        }
-    }
-
-    $message = get_string('restoredefaultsome', 'tool_analytics', ['count' => $numcreated]);
-    $type = \core\output\notification::NOTIFY_SUCCESS;
-
-    redirect($returnurl, $message, null, $type);
-}
-
-$models = \core_analytics\manager::load_default_models_for_all_components();
-$ui = new \tool_analytics\output\restorable_models($models);
-
-echo $OUTPUT->header();
-echo $PAGE->get_renderer('tool_analytics')->render($ui);
-echo $OUTPUT->footer();

admin/tool/analytics/templates/evaluation_options.mustache

@@ -1,82 +0,0 @@
-{{!
-    This file is part of Moodle - http://moodle.org/
-
-    Moodle is free software: you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation, either version 3 of the License, or
-    (at your option) any later version.
-
-    Moodle is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-}}
-{{!
-    @template tool_analytics/evaluation_options
-
-    Evaluation selector.
-
-    The purpose of this template is to render the evaluation mode options.
-
-    Classes required for JS:
-    * none
-
-    Data attributes required for JS:
-    * none
-
-    Example context (json):
-    {
-        "trainedexternally": "1",
-        "timesplittingmethods": [
-            {
-                "id": "ou",
-                "name": "Quarters"
-            }, {
-                "id": "yeah",
-                "name": "Tenths"
-            }
-        ]
-    }
-}}
-
-{{#trainedexternally}}
-    <div class="box mb-4">{{#str}} evaluationmodeinfo, tool_analytics {{/str}}</div>
-
-    <div class="custom-control custom-radio">
-        <input class="custom-control-input" type="radio" name="evaluationmode" id="id-mode-trainedmodel" value="trainedmodel" checked>
-        <label class="custom-control-label" for="id-mode-trainedmodel">{{#str}} evaluationmodetrainedmodel, tool_analytics {{/str}}</label>
-    </div>
-
-    <div class="custom-control custom-radio">
-        <input class="custom-control-input" type="radio" name="evaluationmode" id="id-mode-configuration" value="configuration">
-        <label class="custom-control-label" for="id-mode-configuration">{{#str}} evaluationmodeconfiguration, tool_analytics {{/str}}</label>
-    </div>
-{{/trainedexternally}}
-
-{{! Hidden by default if #trainedexternally as the default option is trainedmodel in this case.}}
-<div id="id-evaluation-timesplitting-container" class="m-t-1 {{#trainedexternally}}hidden{{/trainedexternally}}">
-    {{#str}} selecttimesplittingforevaluation, tool_analytics {{/str}}
-    <div>
-        <select id="id-evaluation-timesplitting" name="timesplitting" class="custom-select m-t-1">
-            {{#timesplittingmethods}}
-                <option value="{{id}}">{{text}}</option>
-            {{/timesplittingmethods}}
-        </select>
-    </div>
-</div>
-
-
-{{#js}}
-    require(['jquery'], function($) {
-        $("input[name='evaluationmode']:radio").change(function() {
-            if ($(this).val() == 'configuration') {
-                $('#id-evaluation-timesplitting-container').show();
-            } else {
-                $('#id-evaluation-timesplitting-container').hide();
-            }
-        });
-    });
-{{/js}}

admin/tool/analytics/templates/export_options.mustache

@@ -1,57 +0,0 @@
-{{!
-    This file is part of Moodle - http://moodle.org/
-
-    Moodle is free software: you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation, either version 3 of the License, or
-    (at your option) any later version.
-
-    Moodle is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-}}
-{{!
-    @template tool_analytics/export_options
-
-    Export options.
-
-    The purpose of this template is to render the exporting options.
-
-    Classes required for JS:
-    * none
-
-    Data attributes required for JS:
-    * none
-
-    Example context (json):
-    {
-    }
-}}
-<div class="custom-control custom-radio">
-    <input class="custom-control-input" type="radio" name="exportoption" id="id-mode-exportdata" value="exportdata">
-    <label class="custom-control-label" for="id-mode-exportdata">{{#str}} exporttrainingdata, tool_analytics {{/str}}</label>
-</div>
-<div class="custom-control custom-radio">
-    <input class="custom-control-input" type="radio" name="exportoption" id="id-mode-exportmodel" value="exportmodel" checked>
-    <label class="custom-control-label" for="id-mode-exportmodel">{{#str}} exportmodel, tool_analytics {{/str}}</label>
-</div>
-<div class="custom-control custom-checkbox m-l-2" id="id-includeweights-container">
-  <input class="custom-control-input" type="checkbox" id="id-includeweights" value="1" checked>
-  <label class="custom-control-label" for="id-includeweights">{{#str}} exportincludeweights, tool_analytics {{/str}}</label>
-</div>
-
-{{#js}}
-    require(['jquery'], function($) {
-        $("input[name='exportoption']:radio").change(function() {
-            if ($(this).val() == 'exportdata') {
-                $('#id-includeweights-container').hide();
-            } else {
-                $('#id-includeweights-container').show();
-            }
-        });
-    });
-{{/js}}

admin/tool/analytics/templates/invalid_analysables.mustache

@@ -48,38 +48,31 @@
 <div class="box">
     <h3>{{#str}}modelinvalidanalysables, tool_analytics, {{modelname}}{{/str}}</h3>
     <div>{{#str}}invalidanalysablesinfo, tool_analytics{{/str}}</div>
-    {{#noanalysables}}
-        <div class="mt-2 mb-1">
-            {{> core/notification_info}}
-        </div>
-    {{/noanalysables}}
-    {{^noanalysables}}
-        <div class="mt-2 mb-1">
-            <span>{{#prev}}{{> core/single_button}}{{/prev}}</span>
-            <span>{{#next}}{{> core/single_button}}{{/next}}</span>
-        </div>
-        <table class="generaltable fullwidth">
-            <caption class="accesshide">{{#str}}invalidanalysablestable, tool_analytics{{/str}}</caption>
-            <thead>
-                <tr>
-                    <th scope="col">{{#str}}name{{/str}}</th>
-                    <th scope="col">{{#str}}invalidtraining, tool_analytics{{/str}}</th>
-                    <th scope="col">{{#str}}invalidprediction, tool_analytics{{/str}}</th>
-                </tr>
-            </thead>
-            <tbody>
-            {{#analysables}}
-                <tr>
-                    <td>{{{url}}}</td>
-                    <td>{{validtraining}}</td>
-                    <td>{{validprediction}}</td>
-                </tr>
-            {{/analysables}}
-            </tbody>
-        </table>
-        <div class="mt-1 mb-2">
-            <span>{{#prev}}{{> core/single_button}}{{/prev}}</span>
-            <span>{{#next}}{{> core/single_button}}{{/next}}</span>
-        </div>
-    {{/noanalysables}}
+    <div class="m-t-2 m-b-1">
+        <span>{{#prev}}{{> core/single_button}}{{/prev}}</span>
+        <span>{{#next}}{{> core/single_button}}{{/next}}</span>
+    </div>
+    <table class="generaltable fullwidth">
+        <caption class="accesshide">{{#str}}invalidanalysablestable, tool_analytics{{/str}}</caption>
+        <thead>
+            <tr>
+                <th scope="col">{{#str}}name{{/str}}</th>
+                <th scope="col">{{#str}}invalidtraining, tool_analytics{{/str}}</th>
+                <th scope="col">{{#str}}invalidprediction, tool_analytics{{/str}}</th>
+            </tr>
+        </thead>
+        <tbody>
+        {{#analysables}}
+            <tr>
+                <td>{{{url}}}</td>
+                <td>{{validtraining}}</td>
+                <td>{{validprediction}}</td>
+            </tr>
+        {{/analysables}}
+        </tbody>
+    </table>
+    <div class="m-t-1 m-b-2">
+        <span>{{#prev}}{{> core/single_button}}{{/prev}}</span>
+        <span>{{#next}}{{> core/single_button}}{{/next}}</span>
+    </div>
 </div>

admin/tool/analytics/templates/models_list.mustache

@@ -20,118 +20,85 @@
     Template for models list.
 
     Classes required for JS:
-    * The list od models wrapped within a id="predictionmodelslist" element.
+    * none
 
     Data attributes required for JS:
-    * [data-widget="toggle"] indicates the clickable element for expanding/collapsing
-      the list of indicators used by the given model.
+    * none
 
     Context variables required for this template:
-    * models: array - list of models to display
-        - id: int - model unique identifier
-        - name: object - data for the inplace editable element template
-        - target: string - name of the target associated with the model
-        - targetclass: string - fully qualified name of the target class
-        - targethelp: object - data for the help tooltip template
-        - enabled: bool - is the model enabled
-        - indicatorsnum: int - number of indicators
-        - indicators: array - list of indicators used by the model
-            + name: string - name of the indicator
-            + help: object - data for the help tooltip template
-        - insights: object - data for the single select template
-        - noinsights: string - text to display instead of insights
-    * warnings: array - list of data for notification warning template
-    * infos: array - list of data for notification info template
-    * createmodelurl: string - URL to create a new model
-    * importmodelurl: string - URL to import a model
+    * none
 
     Example context (json):
     {
         "models": [
             {
-                "id": 11,
-                "name": {
-                    "component": "local_analyticsdemo",
-                    "itemtype": "modelname",
-                    "itemid": 42,
-                    "displayvalue": "Prevent devs at risk",
-                    "value": ""
-                },
                 "target": "Prevent devs at risk",
-                "targetclass": "\\local_analyticsdemo\\analytics\\target\\dev_risk",
-                "targethelp": {
-                    "title": "Help with Prevent devs at risk",
-                    "text": "This target blah blah ...",
-                    "url": "http://example.org/help",
-                    "linktext": "",
-                    "icon": {
-                        "extraclasses": "iconhelp",
-                        "attributes": [
-                            {"name": "src", "value": "../../../pix/help.svg"},
-                            {"name": "alt", "value": "Help icon"}
-                        ]
-                    }
-                },
-                "enabled": 1,
-                "indicatorsnum": 2,
-                "indicators": [
+                "targethelp": [
                     {
-                        "name": "Indicator 1",
-                        "help": {
-                            "text": "This indicator blah blah ...",
-                            "title": "Help with Indicator 1",
-                            "url": "http://example.org/help",
-                            "linktext": "",
-                            "icon": {
-                                "extraclasses": "iconhelp",
-                                "attributes": [
-                                    {"name": "src", "value": "../../../pix/help.svg"},
-                                    {"name": "alt", "value": "Help icon"}
-                                ]
-                            }
-                        }
-                    },
-                    {
-                        "name": "Indicator 2",
-                        "help": {
-                            "text": "This indicator blah blah ...",
-                            "title": "Help with Indicator 2",
-                            "url": "http://example.org/help",
-                            "linktext": "",
-                            "icon": {
-                                "extraclasses": "iconhelp",
-                                "attributes": [
-                                    {"name": "src", "value": "../../../pix/help.svg"},
-                                    {"name": "alt", "value": "Help icon"}
-                                ]
-                            }
+                        "title": "Help with something",
+                        "url": "http://example.org/help",
+                        "linktext": "",
+                        "icon":{
+                            "extraclasses": "iconhelp",
+                            "attributes": [
+                                {"name": "src", "value": "../../../pix/help.svg"},
+                                {"name": "alt", "value": "Help icon"}
+                            ]
                         }
                     }
                 ],
+                "enabled": 1,
+                "indicators": [{
+                    "name": "Indicator 1",
+                    "help": [{
+                            "title": "Help with something",
+                            "url": "http://example.org/help",
+                            "linktext": "",
+                            "icon":{
+                                "extraclasses": "iconhelp",
+                                "attributes": [
+                                    {"name": "src", "value": "../../../pix/help.svg"},
+                                    {"name": "alt", "value": "Help icon"}
+                                ]
+                            }
+                        }]
+                    },
+                    {
+                    "name": "Indicator 2",
+                    "help": [{
+                            "title": "Help with something",
+                            "url": "http://example.org/help",
+                            "linktext": "",
+                            "icon":{
+                                "extraclasses": "iconhelp",
+                                "attributes": [
+                                    {"name": "src", "value": "../../../pix/help.svg"},
+                                    {"name": "alt", "value": "Help icon"}
+                                ]
+                            }
+                        }]
+                    }],
                 "timesplitting": "Quarters",
-                "timesplittinghelp": {
-                    "text": "This time splitting methof blah blah ...",
-                    "title": "Help with Quarters",
-                    "url": "http://example.org/help",
-                    "linktext": "",
-                    "icon": {
-                        "extraclasses": "iconhelp",
-                        "attributes": [
-                            {"name": "src", "value": "../../../pix/help.svg"},
-                            {"name": "alt", "value": "Help icon"}
-                        ]
+                "timesplittinghelp": [
+                    {
+                        "title": "Help with something",
+                        "url": "http://example.org/help",
+                        "linktext": "",
+                        "icon":{
+                            "extraclasses": "iconhelp",
+                            "attributes": [
+                                {"name": "src", "value": "../../../pix/help.svg"},
+                                {"name": "alt", "value": "Help icon"}
+                            ]
+                        }
                     }
-                },
+                ],
                 "noinsights": "No insights available yet"
             }
         ],
-        "warnings": [
-            {
-                "message": "Be ware, this is just an example!"
-            }
-        ],
-        "createmodelurl": "#",
-        "importmodelurl": "#"
+        "warnings": {
+            "message": "Hey, this is a warning"
+        }
     }
 }}
 
@@ -143,16 +110,11 @@
 {{/infos}}
 
 <div class="box">
-    <div class="top-nav d-flex">
-        {{#newmodelmenu}}
-        {{>core/action_menu}}
-        {{/newmodelmenu}}
-    </div>
-    <table id="predictionmodelslist" class="generaltable fullwidth">
+    <table class="generaltable fullwidth">
         <caption>{{#str}}analyticmodels, tool_analytics{{/str}}</caption>
         <thead>
             <tr>
-                <th scope="col">{{#str}}modelname, tool_analytics{{/str}}</th>
+                <th scope="col">{{#str}}target, tool_analytics{{/str}}</th>
                 <th scope="col">{{#str}}enabled, tool_analytics{{/str}}</th>
                 <th scope="col">{{#str}}indicators, tool_analytics{{/str}}</th>
                 <th scope="col">{{#str}}modeltimesplitting, tool_analytics{{/str}}</th>
@@ -164,15 +126,10 @@
         {{#models}}
             <tr>
                 <td>
-                    {{#name}}
-                        <span class="model-name">{{>core/inplace_editable}}</span>
-                    {{/name}}
-                    <div>
-                        <small class="target-class">{{targetclass}}</small>
-                        {{#targethelp}}
-                            {{>core/help_icon}}
-                        {{/targethelp}}
-                    </div>
+                    <span class="target-name">{{target}}</span>
+                    {{#targethelp}}
+                        {{>core/help_icon}}
+                    {{/targethelp}}
                 </td>
                 <td>
                     {{#enabled}}
@@ -183,15 +140,7 @@
                     {{/enabled}}
                 </td>
                 <td>
-                    <a data-widget="toggle"
-                           title="{{#str}} clicktohideshow {{/str}}"
-                           aria-expanded="false"
-                           aria-controls="indicators-{{id}}"
-                           role="button"
-                           href="">
-                        {{#str}} indicatorsnum, tool_analytics, {{indicatorsnum}} {{/str}}
-                    </a>
-                    <ul class="hidden" id="indicators-{{id}}">
+                    <ul>
                     {{#indicators}}
                         <li>
                             {{name}}
@@ -235,22 +184,3 @@
         </tbody>
     </table>
 </div>
-{{#js}}
-require(['jquery'], function($) {
-
-    // Toggle the visibility of the indicators list.
-    $('#predictionmodelslist').on('click', '[data-widget="toggle"]', function(e) {
-        e.preventDefault();
-        var toggle = $(e.currentTarget);
-        var listid = toggle.attr('aria-controls');
-
-        $(document.getElementById(listid)).toggle();
-
-        if (toggle.attr('aria-expanded') == 'false') {
-            toggle.attr('aria-expanded', 'true');
-        } else {
-            toggle.attr('aria-expanded', 'false');
-        }
-    });
-});
-{{/js}}

admin/tool/analytics/templates/restorable_models.mustache

@@ -1,225 +0,0 @@
-{{!
-    This file is part of Moodle - http://moodle.org/
-
-    Moodle is free software: you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation, either version 3 of the License, or
-    (at your option) any later version.
-
-    Moodle is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-}}
-{{!
-    @template tool_analytics/restorable_models
-
-    Displays the list of missing prediction models that can be restored.
-
-    Classes required for JS:
-    * The list should be wrapped within a id="restorablemodelslist" element.
-
-    Data attributes required for JS:
-    * [data-widget="toggle"] indicates the clickable element for expanding/collapsing
-      the list of indicators used by the given model.
-    * [data-select] indicates a clickable element used for selecting multiple checkboxes.
-    * [data-component] should be set for checkboxes that select the particular model.
-
-    Context variables required for this template:
-    * hasdata: boolean - do we have data to display
-    * submiturl: string - URL where the form should be submitted
-    * backurl: string - URL where the user should be sent without making any changes
-    * sesskey: string
-    * components: array - list of components to display
-        - name: string - human readable name of the component
-        - component: string - frankenstyle name of the component
-        - models: array - list of restorable models provided by the component
-            + defid: string - model definition identifier
-            + targetname: string - human readable name of the target
-            + targetclass: string - fully qualified classname of the target
-            + indicatorsnum: int - number of indicators
-            + indicators: array - list of indicators
-                ~ name: string - human readable name of the indicator
-                ~ classname: string - fully qualified classname of the indicator
-
-    Example context (json):
-    {
-        "hasdata": true,
-        "submiturl": "https://example.com/moodle/admin/tool/analytics/restoredefault.php",
-        "backurl": "https://example.com/moodle/admin/tool/analytics/index.php",
-        "sesskey": "abcdefg123456",
-        "components": [
-            {
-                "name": "Core",
-                "component": "core",
-                "models": [
-                    {
-                        "defid": "id24680aceg",
-                        "targetname": "No teaching",
-                        "targetclass": "\\core\\analytics\\target\\no_teaching",
-                        "indicatorsnum": 2,
-                        "indicators": [
-                            {
-                                "name": "There are no teachers",
-                                "classname": "\\core\\analytics\\indicator\\no_teacher"
-                            },
-                            {
-                                "name": "There are no students",
-                                "classname": "\\core\\analytics\\indicator\\no_students"
-                            }
-                        ]
-                    },
-                    {
-                        "defid": "id13579bdfi",
-                        "targetname": "Students at risk of dropping out",
-                        "targetclass": "\\core\\analytics\\target\\course_dropout",
-                        "indicatorsnum": 1,
-                        "indicators": [
-                            {
-                                "name": "Read actions amount",
-                                "classname": "\\core\\analytics\\indicator\\read_actions"
-                            }
-                        ]
-                    }
-                ]
-            },
-            {
-                "name": "Custom analytics plugin",
-                "component": "tool_customanalytics",
-                "models": [
-                    {
-                        "defid": "id566dsgffg655",
-                        "targetname": "Cheater",
-                        "targetclass": "\\tool_customanalytics\\analytics\\target\\cheater",
-                        "indicatorsnum": 1,
-                        "indicators": [
-                            {
-                                "name": "Copy-pasted submissions",
-                                "classname": "\\tool_customanalytics\\analytics\\indicator\\copy_paster_submissions"
-                            }
-                        ]
-                    }
-                ]
-            }
-        ]
-    }
-}}
-<div class="box">
-    {{^hasdata}}
-    <p>{{#str}} restoredefaultnone, tool_analytics {{/str}}</p>
-    <div><a href="{{backurl}}" class="btn btn-secondary">{{#str}} back {{/str}}</a></div>
-    {{/hasdata}}
-
-    {{#hasdata}}
-    <p>{{#str}} restoredefaultinfo, tool_analytics {{/str}}</p>
-    <form method="post" action="{{submiturl}}">
-        <table id="restorablemodelslist" class="generaltable fullwidth">
-            <colgroup>
-                <col width="10%">
-                <col width="45%">
-                <col width="45%">
-            </colgroup>
-            <thead>
-                <tr>
-                    <th scope="col"><a href="" data-select="*">{{#str}} selectall {{/str}}</a></th>
-                    <th scope="col">{{#str}} target, tool_analytics {{/str}}</th>
-                    <th scope="col">{{#str}} indicators, tool_analytics {{/str}}</th>
-                </tr>
-            </thead>
-            <tbody>
-            {{#components}}
-                <tr>
-                    <th scope="rowgroup" colspan="3">
-                        <span class="component-name">
-                            <a href=""
-                                    title="{{#str}} componentselect, tool_analytics, {{name}} {{/str}}"
-                                    data-select="{{component}}">
-                                {{name}}
-                            </a>
-                        </span>
-                        <div><small class="component-frankenstyle">{{component}}</small></div>
-                    </th>
-                </tr>
-                {{#models}}
-                <tr>
-                    <td>
-                        <input data-component="{{component}}" type="checkbox" name="restoreid[]" value="{{defid}}">
-                    </td>
-                    <td>
-                        <span class="target-name">{{targetname}}</span>
-                        {{#targethelp}}
-                            {{>core/help_icon}}
-                        {{/targethelp}}
-                        <div><small class="target-class">{{targetclass}}</small></div>
-                    </td>
-                    <td>
-                        <a data-widget="toggle"
-                                title="{{#str}} clicktohideshow {{/str}}"
-                                aria-expanded="false"
-                                aria-controls="indicators-{{defid}}"
-                                role="button"
-                                href="">
-                            {{#str}} indicatorsnum, tool_analytics, {{indicatorsnum}} {{/str}}
-                        </a>
-                        <ul class="hidden listunstyled" id="indicators-{{defid}}">
-                        {{#indicators}}
-                            <li>
-                                {{name}}
-                                {{#indicatorhelp}}
-                                    {{>core/help_icon}}
-                                {{/indicatorhelp}}
-                                <div><small>{{classname}}</small></div>
-                            </li>
-                        {{/indicators}}
-                        </ul>
-                    </td>
-                </tr>
-                {{/models}}
-            {{/components}}
-            </tbody>
-        </table>
-        <div>
-            <input class="btn btn-primary" type="submit" value="{{#str}} restoredefaultsubmit, tool_analytics {{/str}}">
-            <input class="btn btn-secondary" type="reset" value="{{#str}} componentselectnone, tool_analytics {{/str}}">
-            <a href="{{backurl}}" class="btn btn-secondary">{{#str}} back {{/str}}</a>
-            <input type="hidden" name="sesskey" value="{{sesskey}}">
-        </div>
-    </form>
-    {{/hasdata}}
-</div>
-
-{{#js}}
-require(['jquery'], function($) {
-
-    // Toggle the visibility of the indicators list.
-    $('#restorablemodelslist').on('click', '[data-widget="toggle"]', function(e) {
-        e.preventDefault();
-        var toggle = $(e.currentTarget);
-        var listid = toggle.attr('aria-controls');
-
-        $(document.getElementById(listid)).toggle();
-
-        if (toggle.attr('aria-expanded') == 'false') {
-            toggle.attr('aria-expanded', 'true');
-        } else {
-            toggle.attr('aria-expanded', 'false');
-        }
-    });
-
-    // Selecting all / all in component checkboxes.
-    $('#restorablemodelslist').on('click', '[data-select]', function(e) {
-        e.preventDefault();
-        var handler = $(e.currentTarget);
-        var component = handler.attr('data-select');
-
-        if (component == '*') {
-            $('input[data-component]').prop('checked', true);
-        } else {
-            $('input[data-component="' + component + '"]').prop('checked', true);
-        }
-    });
-});
-{{/js}}

admin/tool/analytics/tests/behat/restoredefault.feature

@@ -1,103 +0,0 @@
-@tool @tool_analytics
-Feature: Restoring default models
-  In order to get prediction models into their initial state
-  As a manager
-  I need to be able to restore deleted default models
-
-  Background:
-    Given the following "users" exist:
-      | username 	| firstname	| lastname | email          	|
-      | manager  	| Max      	| Manager  | man@example.com	|
-    And the following "role assigns" exist:
-      | user    	| role    	| contextlevel	| reference		|
-      | manager 	| manager		| System      	|							|
-
-  Scenario: Restore a single deleted default model
-    Given I log in as "manager"
-    And I navigate to "Analytics > Analytics models" in site administration
-    # Delete 'No teaching' model.
-    And I click on "Delete" "link" in the "No teaching" "table_row"
-    And I should see "Analytics models"
-    And I should not see "No teaching"
-    # Delete 'Students at risk of dropping out' model.
-    And I click on "Delete" "link" in the "Students at risk of dropping out" "table_row"
-    And I should see "Analytics models"
-    And I should not see "Students at risk of dropping out"
-    # Go to the page for restoring deleted models.
-    When I click on "Restore default models" "link"
-    And I should see "No teaching"
-    And I should see "Students at risk of dropping out"
-    # Select and restore the 'No teaching' model.
-    And I set the field with xpath "//tr[contains(normalize-space(.), 'No teaching')]//input[@type='checkbox']" to "1"
-    And I click on "Restore selected" "button"
-    Then I should see "Succesfully re-created 1 new model(s)."
-    And I should see "Analytics models"
-    And I should see "No teaching"
-    And I should not see "Students at risk of dropping out"
-
-  Scenario: Restore multiple deleted default models at once
-    Given I log in as "manager"
-    And I navigate to "Analytics > Analytics models" in site administration
-    # Delete 'No teaching' model.
-    And I click on "Delete" "link" in the "No teaching" "table_row"
-    And I should see "Analytics models"
-    And I should not see "No teaching"
-    # Delete 'Students at risk of dropping out' model.
-    And I click on "Delete" "link" in the "Students at risk of dropping out" "table_row"
-    And I should see "Analytics models"
-    And I should not see "Students at risk of dropping out"
-    # Go to the page for restoring deleted models.
-    When I click on "Restore default models" "link"
-    And I should see "No teaching"
-    And I should see "Students at risk of dropping out"
-    # Select and restore both models.
-    And I set the field with xpath "//tr[contains(normalize-space(.), 'No teaching')]//input[@type='checkbox']" to "1"
-    And I set the field with xpath "//tr[contains(normalize-space(.), 'Students at risk of dropping out')]//input[@type='checkbox']" to "1"
-    And I click on "Restore selected" "button"
-    Then I should see "Succesfully re-created 2 new model(s)."
-    And I should see "Analytics models"
-    And I should see "No teaching"
-    And I should see "Students at risk of dropping out"
-
-  Scenario: Going to the restore page while no models can be restored
-    Given I log in as "manager"
-    And I navigate to "Analytics > Analytics models" in site administration
-    And I should see "Analytics models"
-    And I should see "No teaching"
-    When I click on "Restore default models" "link"
-    Then I should see "All default models provided by core and installed plugins have been created. No new models were found; there is nothing to restore."
-    And I click on "Back" "link"
-    And I should see "Analytics models"
-
-  @javascript
-  Scenario: User can select and restore all missing models
-    Given I log in as "manager"
-    And I navigate to "Analytics > Analytics models" in site administration
-    # Delete 'No teaching' model.
-    And I click on "Actions" "link" in the "No teaching" "table_row"
-    And I click on "Delete" "link" in the "No teaching" "table_row"
-    And I click on "Delete" "button" in the "Delete" "dialogue"
-    And I should see "Analytics models"
-    And I should not see "No teaching"
-    # Delete 'Students at risk of dropping out' model.
-    And I click on "Actions" "link" in the "Students at risk of dropping out" "table_row"
-    And I click on "Delete" "link" in the "Students at risk of dropping out" "table_row"
-    And I click on "Delete" "button" in the "Delete" "dialogue"
-    And I should see "Analytics models"
-    And I should not see "No teaching"
-    And I should not see "Students at risk of dropping out"
-    # Go to the page for restoring deleted models.
-    And I click on "New model" "link"
-    And I click on "Restore default models" "link"
-    And I should see "No teaching"
-    And I should see "Students at risk of dropping out"
-    # Attempt to submit the form without selecting any model.
-    And I click on "Restore selected" "button"
-    And I should see "Please select models to be restored."
-    # Select all models.
-    When I click on "Select all" "link"
-    And I click on "Restore selected" "button"
-    Then I should see "Succesfully re-created 2 new model(s)."
-    And I should see "Analytics models"
-    And I should see "No teaching"
-    And I should see "Students at risk of dropping out"

admin/tool/analytics/version.php

@@ -24,6 +24,6 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version   = 2019052000; // The current plugin version (Date: YYYYMMDDXX).
-$plugin->requires  = 2019051100; // Requires this Moodle version.
+$plugin->version   = 2018120300; // The current plugin version (Date: YYYYMMDDXX).
+$plugin->requires  = 2018112800; // Requires this Moodle version.
 $plugin->component = 'tool_analytics'; // Full name of the plugin (used for diagnostics).

admin/tool/availabilityconditions/version.php

@@ -24,6 +24,6 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version = 2019052000;
-$plugin->requires = 2019051100;
+$plugin->version = 2018120300;
+$plugin->requires = 2018112800;
 $plugin->component = 'tool_availabilityconditions';

admin/tool/behat/cli/util.php

@@ -109,17 +109,6 @@ require_once(__DIR__ . '/../../../../lib/behat/lib.php');
 require_once(__DIR__ . '/../../../../lib/behat/classes/behat_command.php');
 require_once(__DIR__ . '/../../../../lib/behat/classes/behat_config_manager.php');
 
-// Remove error handling overrides done in config.php. This is consistent with admin/tool/behat/cli/util_single_run.php.
-$CFG->debug = (E_ALL | E_STRICT);
-$CFG->debugdisplay = 1;
-error_reporting($CFG->debug);
-ini_set('display_errors', '1');
-ini_set('log_errors', '1');
-
-// Import the necessary libraries.
-require_once($CFG->libdir . '/setuplib.php');
-require_once($CFG->libdir . '/behat/classes/util.php');
-
 // For drop option check if parallel site.
 if ((empty($options['parallel'])) && ($options['drop']) || $options['updatesteps']) {
     $options['parallel'] = behat_config_manager::get_behat_run_config_value('parallel');

admin/tool/behat/cli/util_single_run.php

@@ -218,7 +218,7 @@ if ($options['install']) {
     // Run behat command to get steps in feature files.
     $featurestepscmd = behat_command::get_behat_command(true);
     $featurestepscmd .= ' --config ' . behat_config_manager::get_behat_cli_config_filepath();
-    $featurestepscmd .= ' --dry-run --format=moodle_stepcount';
+    $featurestepscmd .= ' --dry-run --format=moodle_step_count';
     $processes = cli_execute_parallel(array($featurestepscmd), __DIR__ . "/../../../../");
     $status = print_update_step_output(array_pop($processes), $behatstepfile);
 

admin/tool/behat/lang/en/tool_behat.php

@@ -24,7 +24,6 @@
 
 $string['aim'] = 'This administration tool helps developers and test writers to create .feature files describing Moodle\'s functionalities and run them automatically. Step definitions available for use in .feature files are listed below.';
 $string['allavailablesteps'] = 'All available step definitions';
-$string['errorapproot'] = '$CFG->behat_ionic_dirroot is not pointing to a valid Moodle Mobile developer install.';
 $string['errorbehatcommand'] = 'Error running behat CLI command. Try running "{$a} --help" manually from CLI to find out more about the problem.';
 $string['errorcomposer'] = 'Composer dependencies are not installed.';
 $string['errordataroot'] = '$CFG->behat_dataroot is not set or is invalid.';

admin/tool/behat/renderer.php

@@ -162,11 +162,11 @@ class tool_behat_renderer extends plugin_renderer_base {
         $html .= $this->output->heading($title);
 
         // Info.
-        $installurl = behat_command::DOCS_URL;
+        $installurl = behat_command::DOCS_URL . '#Installation';
         $installlink = html_writer::tag('a', $installurl, array('href' => $installurl, 'target' => '_blank'));
-        $writetestsurl = 'https://docs.moodle.org/dev/Writing acceptance tests';
+        $writetestsurl = behat_command::DOCS_URL . '#Writing_features';
         $writetestslink = html_writer::tag('a', $writetestsurl, array('href' => $writetestsurl, 'target' => '_blank'));
-        $writestepsurl = 'https://docs.moodle.org/dev/Writing_new_acceptance_test_step_definitions';
+        $writestepsurl = behat_command::DOCS_URL . '#Adding_steps_definitions';
         $writestepslink = html_writer::tag('a', $writestepsurl, array('href' => $writestepsurl, 'target' => '_blank'));
         $infos = array(
             get_string('installinfo', 'tool_behat', $installlink),

admin/tool/behat/tests/behat/manipulate_forms.feature

@@ -28,6 +28,6 @@ Feature: Forms manipulation
     When I expand all fieldsets
     Then I should see "Close the quiz"
     And I should see "Group mode"
-    And I should see "ID number"
+    And I should see "Grouping"
     And I should not see "Show more..." in the "region-main" "region"
     And I should see "Show less..."

admin/tool/behat/tests/fixtures/core/behat_test_context_1.php

@@ -24,7 +24,7 @@
 
 // NOTE: no MOODLE_INTERNAL test here, this file may be required by behat before including /config.php.
 
-require_once(__DIR__ . '/../../../../../../lib/behat/behat_base.php');
+require_once(__DIR__ . '/../../../../../lib/behat/behat_base.php');
 
 /**
  * Test context 1

admin/tool/behat/tests/fixtures/core/behat_test_context_2.php

@@ -24,7 +24,7 @@
 
 // NOTE: no MOODLE_INTERNAL test here, this file may be required by behat before including /config.php.
 
-require_once(__DIR__ . '/../../../../../../lib/behat/behat_base.php');
+require_once(__DIR__ . '/../../../../../lib/behat/behat_base.php');
 
 /**
  * Test context 2

admin/tool/behat/tests/fixtures/theme/defaulttheme/behat_theme_defaulttheme_test_context_1.php

@@ -24,7 +24,7 @@
 
 // NOTE: no MOODLE_INTERNAL test here, this file may be required by behat before including /config.php.
 
-require_once(__DIR__ . '/../../../../../../../lib/behat/behat_base.php');
+require_once(__DIR__ . '/../../../../../lib/behat/behat_base.php');
 
 /**
  * Default Theme test context 1

admin/tool/behat/tests/fixtures/theme/nofeatures/behat_theme_nofeatures_behat_test_context_2.php

@@ -24,7 +24,7 @@
 
 // NOTE: no MOODLE_INTERNAL test here, this file may be required by behat before including /config.php.
 
-require_once(__DIR__ . '/../../core/behat_test_context_1.php');
+require_once(__DIR__ . '/../behat_test_context_1.php');
 
 /**
  * Theme test context 1
@@ -33,6 +33,6 @@ require_once(__DIR__ . '/../../core/behat_test_context_1.php');
  * @copyright  2016 Rajesh Taneja <rajesh@moodle.com>
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class behat_theme_nofeatures_behat_test_context_2 extends behat_test_context_2 {
+class behat_theme_nofeatures_behat_test_context_1 extends behat_test_context_1 {
 
 }

admin/tool/behat/tests/fixtures/theme/nofeatures/behat_theme_nofeatures_test_context_1.php

@@ -24,7 +24,7 @@
 
 // NOTE: no MOODLE_INTERNAL test here, this file may be required by behat before including /config.php.
 
-require_once(__DIR__ . '/../../../../../../../lib/behat/behat_base.php');
+require_once(__DIR__ . '/../../../../../lib/behat/behat_base.php');
 
 /**
  * Theme test context 2
@@ -33,6 +33,6 @@ require_once(__DIR__ . '/../../../../../../../lib/behat/behat_base.php');
  * @copyright  2016 Rajesh Taneja <rajesh@moodle.com>
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class behat_theme_nofeatures_test_context_1 extends behat_base {
+class behat_theme_nofeatures_test_context_2 extends behat_base {
 
 }

admin/tool/behat/tests/fixtures/theme/withfeatures/behat_theme_withfeatures_behat_test_context_1.php

@@ -24,7 +24,7 @@
 
 // NOTE: no MOODLE_INTERNAL test here, this file may be required by behat before including /config.php.
 
-require_once(__DIR__ . '/../../core/behat_test_context_1.php');
+require_once(__DIR__ . '/../behat_test_context_1.php');
 
 /**
  * Theme test context 1

admin/tool/behat/tests/fixtures/theme/withfeatures/behat_theme_withfeatures_test_context_2.php

@@ -24,7 +24,7 @@
 
 // NOTE: no MOODLE_INTERNAL test here, this file may be required by behat before including /config.php.
 
-require_once(__DIR__ . '/../../../../../../../lib/behat/behat_base.php');
+require_once(__DIR__ . '/../../../../../lib/behat/behat_base.php');
 
 /**
  * Theme test context 2

admin/tool/behat/tests/manager_util_test.php

@@ -108,6 +108,7 @@ class tool_behat_manager_util_testcase extends advanced_testcase {
             array('nofeatures', __DIR__.'/fixtures/theme/nofeatures'),
             array('defaulttheme', __DIR__.'/fixtures/theme/defaulttheme'),
         );
+
         // List of themes is const for test.
         if ($notheme) {
             $themelist = array('defaulttheme');
@@ -115,13 +116,6 @@ class tool_behat_manager_util_testcase extends advanced_testcase {
             $themelist = array('withfeatures', 'nofeatures', 'defaulttheme');
         }
 
-        $thememap = [];
-        foreach ($themelist as $themename) {
-            $mock = $this->getMockBuilder('theme_config');
-            $mock->disableOriginalConstructor();
-            $thememap[] = [$themename, $mock->getMock()];
-        }
-
         $behatconfigutil->expects($this->any())
             ->method('get_list_of_themes')
             ->will($this->returnValue($themelist));
@@ -131,11 +125,6 @@ class tool_behat_manager_util_testcase extends advanced_testcase {
             ->method('get_theme_test_directory')
             ->will($this->returnValueMap($map));
 
-        // Theme directory for testing.
-        $behatconfigutil->expects($this->any())
-                ->method('get_theme_config')
-                ->will($this->returnValueMap($thememap));
-
         $behatconfigutil->expects($this->any())
             ->method('get_default_theme')
             ->will($this->returnValue('defaulttheme'));
@@ -149,7 +138,7 @@ class tool_behat_manager_util_testcase extends advanced_testcase {
     public function test_get_config_file_contents_with_single_run() {
 
         $mockbuilder = $this->getMockBuilder('behat_config_util');
-        $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_default_theme', 'get_theme_config'));
+        $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_default_theme'));
 
         $behatconfigutil = $mockbuilder->getMock();
 
@@ -188,7 +177,7 @@ class tool_behat_manager_util_testcase extends advanced_testcase {
     public function test_get_config_file_contents_with_single_run_no_theme() {
 
         $mockbuilder = $this->getMockBuilder('behat_config_util');
-        $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_default_theme', 'get_theme_config'));
+        $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_default_theme'));
 
         $behatconfigutil = $mockbuilder->getMock();
 
@@ -242,7 +231,7 @@ class tool_behat_manager_util_testcase extends advanced_testcase {
     public function test_get_config_file_contents_with_parallel_run() {
 
         $mockbuilder = $this->getMockBuilder('behat_config_util');
-        $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_default_theme', 'get_theme_config'));
+        $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_default_theme'));
 
         $behatconfigutil = $mockbuilder->getMock();
 
@@ -345,7 +334,7 @@ class tool_behat_manager_util_testcase extends advanced_testcase {
     public function test_get_config_file_contents_with_parallel_run_optimize_tags() {
 
         $mockbuilder = $this->getMockBuilder('behat_config_util');
-        $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_default_theme', 'get_theme_config'));
+        $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_default_theme'));
 
         $behatconfigutil = $mockbuilder->getMock();
 
@@ -490,7 +479,7 @@ class tool_behat_manager_util_testcase extends advanced_testcase {
 
         $mockbuilder = $this->getMockBuilder('behat_config_util');
         $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_blacklisted_tests_for_theme',
-            'get_default_theme', 'get_theme_config'));
+            'get_default_theme'));
 
         $behatconfigutil = $mockbuilder->getMock();
 
@@ -554,7 +543,7 @@ class tool_behat_manager_util_testcase extends advanced_testcase {
 
         $mockbuilder = $this->getMockBuilder('behat_config_util');
         $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_blacklisted_tests_for_theme',
-            'get_default_theme', 'get_theme_config'));
+            'get_default_theme'));
 
         $behatconfigutil = $mockbuilder->getMock();
 
@@ -632,7 +621,7 @@ class tool_behat_manager_util_testcase extends advanced_testcase {
     public function test_core_features_to_include_in_specified_theme() {
 
         $mockbuilder = $this->getMockBuilder('behat_config_util');
-        $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_default_theme', 'get_theme_config'));
+        $mockbuilder->setMethods(array('get_theme_test_directory', 'get_list_of_themes', 'get_default_theme'));
 
         $behatconfigutil = $mockbuilder->getMock();
 

admin/tool/behat/upgrade.txt

@@ -1,8 +1,5 @@
 This files describes API changes in the tool_behat code.
 
-=== 3.7 ===
-* Behat will now look for behat step definitions in the current
-  theme and any parents the theme may have.
 === 2.7 ===
 * Constants behat_base::cap_allow, behat_base::cap_prevent and
   behat_base::cap_prohibit have been removed in favour of the

admin/tool/behat/version.php

@@ -24,6 +24,6 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version   = 2019052000;   // The current plugin version (Date: YYYYMMDDXX)
-$plugin->requires  = 2019051100;   // Requires this Moodle version
+$plugin->version   = 2018120300;   // The current plugin version (Date: YYYYMMDDXX)
+$plugin->requires  = 2018112800;   // Requires this Moodle version
 $plugin->component = 'tool_behat'; // Full name of the plugin (used for diagnostics)

admin/tool/capability/version.php

@@ -24,6 +24,6 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$plugin->version   = 2019052000; // The current plugin version (Date: YYYYMMDDXX).
-$plugin->requires  = 2019051100; // Requires this Moodle version.
+$plugin->version   = 2018120300; // The current plugin version (Date: YYYYMMDDXX).
+$plugin->requires  = 2018112800; // Requires this Moodle version.
 $plugin->component = 'tool_capability'; // Full name of the plugin (used for diagnostics).

admin/tool/cohortroles/templates/cohort-in-list.mustache

@@ -39,7 +39,7 @@
       "visible": true,
       "idnumber": "014",
       "description": "Some users",
-      "theme": "classic"
+      "theme": "clean"
     }
 }}
 {{> tool_lp/form-cohort-selector-suggestion }}

admin/tool/cohortroles/version.php

@@ -25,8 +25,8 @@
 defined('MOODLE_INTERNAL') || die();
 
 
-$plugin->version   = 2019052000; // The current plugin version (Date: YYYYMMDDXX).
-$plugin->requires  = 2019051100; // Requires this Moodle version.
+$plugin->version   = 2018120300; // The current plugin version (Date: YYYYMMDDXX).
+$plugin->requires  = 2018112800; // Requires this Moodle version.
 $plugin->component = 'tool_cohortroles'; // Full name of the plugin (used for diagnostics).
 
 $plugin->dependencies = array(