Commit Graph

975 Commits

Author SHA1 Message Date
tjhunt 3f544a2481 MDL-11699 - Making one more common case a bit nicer for callers. Merged from MOODLE_19_STABLE. 2007-10-12 15:11:57 +00:00
tjhunt c04f93b092 MDL-11699 - Further, backwards-compatible, improvement to the build navigation API to simplify a common case. Also, further improvements to the doc comment, so it is easy to use. Merged from MOODLE_19_STABLE. 2007-10-12 10:36:11 +00:00
tjhunt dd9a2dcc75 MDL-11699 - Addendum - fix typo in fixup code. Sorry. 2007-10-11 16:45:43 +00:00
nfreear 12b9aee7d7 Fixes MDL-11695, Skip block links inaccessible for many keyboard-only users 2007-10-11 16:35:20 +00:00
tjhunt 7243c7c822 Small tidy-up in print_header_simple. Merged from MOODLE_19_STABLE. 2007-10-11 15:25:27 +00:00
tjhunt 67e56c0a3c MDL-11699 - Addendum - rewrite the other half of the function too, so I can understand what it is doing, and fix a couple of minor logic errors along the way. Merged from MOODLE_19_STABLE. 2007-10-11 11:52:34 +00:00
jmg324 38a1e55d8a MDL-10296 adding in the global for https 2007-10-10 16:02:45 +00:00
tjhunt 1ba3ad7df5 MDL-11699 - Make build_navigation more helpful by having it optionally build the activity and activityinstance links too, if you pass a $cm object. Note that this only does extra DB queries if you do pass a $cm object, and it does not have all the required fields, but in this case it will winge at you in developer debug mode. If you get your $cm using get_coursemodule_from_instance or get_coursemodule_from_id, which is best practice these days, then you won't have a problem. 2007-10-10 14:00:41 +00:00
nicolasconnault b7064779f5 Updated copyright notice in header 2007-10-10 05:25:14 +00:00
sam_marshall ca3b6e52d1 MDL-11681 Changed it so current tab no longer is a link to # 2007-10-09 16:56:00 +00:00
moodler 69d0f96a53 Fixed typo from MDL-11642, thanks Gary 2007-10-08 05:11:15 +00:00
toyomoyo a21fed9df5 using correct capability for displaying activity report link in print_user() 2007-10-08 00:42:41 +00:00
skodak 7d0c81b3ba MDL-11521 fixed problems when creating contexts and aprents does not exist yet
MDL-11527 fixed warning from $CFG->defaultuserroleid when installing and upgrading
+ removed reusing of previous contexts in has_capability() and get_context_instance()  because it was hiding critical errors when context was false, not specified, etc.
+ tweaked roles defaults - faster and defaults are applied when roles exist
+ SYSCONTEXTID may be specified in config.php to eliminate 1 db query
+ static context cache is now reset after rebuilding of context paths
+ path field in context table is now nullable - pg compatibility requirement
+ other minor fixes
2007-10-05 15:06:38 +00:00
moodler b649ef92e3 Small efficiency improvement for print_user_picture() when it does access the db 2007-10-05 06:32:53 +00:00
toyomoyo d292d1d2b0 MDL-11549, print_user() should also check user context when printing activity report link 2007-10-05 06:31:11 +00:00
skodak 178bcb7523 MDL-11568 warnings - can not use $USER->property when not logged in - quick fix, please review last commits 2007-10-02 23:08:00 +00:00
tjhunt 75afe0e7e4 PHP docs for choose_from_menu function. Merged from MOODLE_18_STABLE. 2007-10-02 18:49:04 +00:00
donal72 1673e13423 Choose the correct theme for SSO-authenticated users. Roaming themes 2007-10-02 16:14:39 +00:00
skodak 42626376f3 MDL-11442 removed last instances of global $course 2007-09-27 08:18:28 +00:00
tjhunt c6f9234ce3 Comment out an if (ajaxenabled()) check that was stopping any javascript included with require_js before print_header from being included, (but not js included afterwareds). See
http://moodle.org/mod/forum/discuss.php?d=81050 for discussion.
2007-09-26 17:48:27 +00:00
nfreear b741d2ef95 Fixes "Notice: Undefined property: stdClass::$hideactivitytypenavlink..." 2007-09-26 12:44:35 +00:00
skodak 0352cd2ffa MDL-11413 I hope now it is correct solution 2007-09-25 14:02:53 +00:00
nfreear 1d75edd0ae MDL-11436, Encapsulate "accesshide" HTML class in function. 2007-09-25 11:33:30 +00:00
skodak 6db001b535 MDL-11413 revisited 2007-09-24 15:24:21 +00:00
urs_hunkler c7a66cc4e1 MDL-11370 :: added a global var $THEME->customcornersopen to track properly closed custom corners divs. In function print_footer I added a check if some custom_corneres divs are still open and eventually close them. 2007-09-24 11:08:02 +00:00
skodak 09c42a363d MDL-11413 improved text cleaning (problem reported by Andreas Nolden) 2007-09-23 12:28:03 +00:00
skodak 4b533b2791 MDL-11413 improved text cleaning (problem reported by Andreas Nolden) 2007-09-23 12:20:29 +00:00
stronk7 8cf6cb9018 Now XML strict headers are controlled by new setting
(xmlstrictheaders) separating it from debug->developer. MDL-11216
2007-09-21 17:28:16 +00:00
jmg324 874851f610 MDL-10296 made print_user_picture cater for https possibility in user/edit 2007-09-20 09:18:24 +00:00
martinlanghoff c6f01310ad weblib: print_user_picture() fix typoed classname when faking user object 2007-09-19 07:55:29 +00:00
martinlanghoff 8f9a180282 weblib: build_navigation() try to avoid pointless capchecks
Prevent calls to has_capability() in build_navigation() from messing
with upgrades.

Most calls to has_capability() in weblib should be moved to the callers.
2007-09-19 07:52:42 +00:00
martinlanghoff aebfa1546e weblib: print_user()/print_user_picture() optimisations
print_user_picture() was forcing an unneeded dbquery
if you need an imagealt. And who doesn't need one these days.

So - teach print_user_picture() to take either $userid
_or_ $userobj as the first parameter. If that first
parameter has the fields we need, never touch the db.

In other words, only touch the DB as a last resort.

There is a bit of ugliness in testing whether we have
the fields or not, because these fields are inconsistently
with/without NOT NULL in the DB definitions. So we cannot
use isset() because it barfs on nulls. And we cannot use empty()
because it will match both on "missing key" and ''.

And while at it, silence warnings that we are missing string
for the year(s). Also fixes a missing string bug in really boring
courses that noone's visitied in many years ;-)
2007-09-19 07:19:35 +00:00
martinlanghoff b1178725a8 weblib: switchroles_form() user_login_string() handle the new switchroles
The switched role data bits have moved to a
different place in the session. Trivial to fix here.
2007-09-19 07:06:17 +00:00
martinlanghoff 0532aec946 weblib:update_course_icon() - remove access control from here
Access control for the course icon display should happen
at the page level, as we'll need to ask "can edit?" quite
a few times in the page.

The fact that this is weblib should be a good hint that
functions that print html should not be doing access control...
2007-09-19 06:52:52 +00:00
skodak e193724e38 MDL-11295 editorshortcutshelpbutton breaking xhtml strict 2007-09-15 19:36:31 +00:00
martinlanghoff cf1348caae PERF logging - move handling to moodle_request_shutdown()
By moving the performance profile logging to the very
end of PHP processing, we cover more pages, notably those
that don't end up with a footer or a redirect, like file
serving.

This should improve quality of our performance logs, and
help catch some piggies...
2007-09-12 02:57:26 +00:00
martinlanghoff 3446daa3da redirect() - log performance profiling info
Many heavy pages end in a redirect. Log their profiling data!

Thanks to Matt Clarkson for spotting the problem.
2007-09-12 02:57:08 +00:00
moodler 3a1ac34002 Fixed some notices on some custom pages 2007-08-31 03:45:59 +00:00
moodler 7b0d5cd551 Merged fixes for MDL-7425 from 1.8 stable 2007-08-30 06:01:57 +00:00
moodler 432038e084 The home page is the only exception to the rule of navigation 2007-08-27 09:40:14 +00:00
moodler 0ae31f38fb Removed unnecessary BR 2007-08-27 05:17:11 +00:00
moodler c77f9f07db Don't include AJAX libraries is AJAX is off across the site 2007-08-27 04:36:09 +00:00
mattc-catalyst e683967738 MDL-10888: groupings - added function to get all grouping members, cleaned up some notices 2007-08-26 23:47:24 +00:00
skodak e6260a456b MDL-10635 improved performance of update_course_icon() and friends; fixed parameter of iseditting() - removed $userid which was not used and did not make much sense there anyway 2007-08-25 11:28:37 +00:00
nicolasconnault 54c0f82b1d MDL-10970 Reverted changes 2007-08-24 12:45:16 +00:00
nicolasconnault 364fffda3b MDL-10723 Removed all uses of print_navigation() throughout moodle, the function call is now entirely deprecated. 2007-08-24 04:22:30 +00:00
skodak 5adad31057 MDL-10937 upgraded html purifier to 2.1.1 2007-08-21 22:06:47 +00:00
mattc-catalyst 43b49d039d MDL-10888: groupings - make 'jump to...' menu respect groupmembersonly flag 2007-08-21 03:18:19 +00:00
skodak 9d66deb3ce MDL-10383 - some more refactoring and new grouping related functions for modules 2007-08-20 13:56:39 +00:00
Martin Langhoff 13534ef716 cvsimport fixups 2007-08-29 13:10:11 +12:00