L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PERF logging - move handling to moodle_request_shutdown()

Browse Source 
By moving the performance profile logging to the very
end of PHP processing, we cover more pages, notably those
that don't end up with a footer or a redirect, like file
serving.

This should improve quality of our performance logs, and
help catch some piggies...
This commit is contained in:
martinlanghoff
2007-09-12 02:57:26 +00:00
parent 3446daa3da
commit cf1348caae
3 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/moodlelib.php
+6
View File
@@ -6791,6 +6791,12 @@ function moodle_request_shutdown() {
@apache_child_terminate();
}
}
if (defined('MDL_PERF') || (!empty($CFG->perfdebug) and $CFG->perfdebug > 7)) {
if (defined('MDL_PERFTOLOG')) {
$perf = get_performance_info();
error_log("PERF: " . $perf['txt']);
}
}
}
/**
lib/setup.php
+1 -1
View File
@@ -227,7 +227,7 @@ global $HTTPSPAGEREQUIRED;
/// For now, only needed under apache (and probably unstable in other contexts)
if (function_exists('apache_child_terminate')) {
if (function_exists('register_shutdown_function')) {
register_shutdown_function('moodle_request_shutdown');
}
lib/weblib.php
+2 -2
View File
@@ -2655,7 +2655,7 @@ function print_footer($course=NULL, $usercourse=NULL, $return=false) {
$performanceinfo = '';
if (defined('MDL_PERF') || (!empty($CFG->perfdebug) and $CFG->perfdebug > 7)) {
$perf = get_performance_info();
if (defined('MDL_PERFTOLOG')) {
if (defined('MDL_PERFTOLOG') && !function_exists('register_shutdown_function')) {
error_log("PERF: " . $perf['txt']);
}
if (defined('MDL_PERFTOFOOT') || debugging() || $CFG->perfdebug > 7) {
@@ -5469,7 +5469,7 @@ function redirect($url, $message='', $delay=-1) {
$performanceinfo = '';
if (defined('MDL_PERF') || (!empty($CFG->perfdebug) and $CFG->perfdebug > 7)) {
if (defined('MDL_PERFTOLOG')) {
if (defined('MDL_PERFTOLOG') && !function_exists('register_shutdown_function')) {
$perf = get_performance_info();
error_log("PERF: " . $perf['txt']);
}