Commit Graph

405 Commits

Author SHA1 Message Date
Sam Chaffee e8ec840f3c MDL-42065 core_grade: Modified some grade_item queries for improved performance
* Modified 2 queries in grade_item::depends_on to improve performance
* Added additional unit tests to cover those queries better
2013-10-09 12:34:29 -06:00
Tim Hunt 5039961852 MDL-31487 fix FEATURE_CONTROLS_GRADE_VISIBILITY for quiz.
This is a followup to MDL-18301. That fix missed the following points:

1. On the edit categories and items screens, all items had an eye-con to
control the visibility, even if the visibility was controlled by the
module.

2. Changing the visibility of a grade category change the visibility of
all items within it, even if the visibility was controlled by the
module.

3. The quiz ingored $cm->visible when controlling whether its grade item
was visible.
2013-08-08 09:56:53 +01:00
Andrew Davis 501afed36a MDL-31713 core_grade: added updating of grade min and max to update_final_grade() 2013-05-07 12:25:08 +08:00
Andrew Davis e4f7ad5d55 MDL-31713 core_grade:added a unit test to replicate a raw grade max bug 2013-04-30 09:37:23 +08:00
Damyon Wiese 870f78b0fd MDL-29877 Grades - version bump for upgrade step.
And whitespace...
2013-04-12 11:41:54 +08:00
Andrew Davis 166102e9b3 MDL-29877 core_grade:add some upgrade code to fix broken grade items introduced by bad restores 2013-04-10 08:28:05 +08:00
Eloy Lafuente (stronk7) dcaeeda60c MDL-37952 make helper descendants abstract 2013-02-09 16:21:49 +01:00
Sam Hemelryk cd281ce1b4 Merge branch 'MDL-29733_master' of git://github.com/andyjdavis/moodle into MOODLE_24_STABLE 2012-12-18 09:42:41 +13:00
Andrew Davis 415b15ccd6 MDL-29733 grade: SQL and comment cleanup 2012-12-11 09:15:31 +08:00
Jonathan Champ 8a592bd551 MDL-29733 grade: Query for Identifying Grade Grades to Precreate is SLOW 2012-12-11 09:15:31 +08:00
Andrew Davis f92305bfa9 MDL-36761 core_grade:shifted a call to count() out of a loop 2012-12-10 10:54:43 +13:00
Andrew Davis 69bcca5e9c MDL-36061 core_grade: added some unit tests related to refresh_grades() 2012-11-15 11:14:21 +08:00
Matt Switlik 0a757cf033 MDL-36061 gradebook: grade_item->refresh_grades doesn't propagate $userid 2012-11-12 11:19:20 +08:00
Andrew Davis 97512dd36b MDL-35667 core_grade: added a new test for grade_category::apply_limit_rules() 2012-10-01 12:53:26 +08:00
Andrew Davis 5292948648 MDL-31782 core_grade: fixed a potential infinite loop 2012-10-01 11:32:06 +08:00
Rajesh Taneja dea75f643d MDL-32759 Assignment: Grades will not be scaled for new assignment module, and added warning message for user 2012-08-14 11:23:33 +08:00
Adrian Greeve b0c6dc1cac MDL-34465 - lib - Replacing get_context_instance with context_XXXX::instance (group 8) 2012-07-27 10:10:46 +08:00
Andrew Davis fb80cb2aa4 MDL-13629 grade: added some unit tests to clarify the handling of droplow and improved apply_limit_rules() 2012-07-25 09:35:28 +08:00
Frederic Massart 455dc0de61 MDL-18301 Gradebook: Added feature for components to control grade visibility 2012-07-06 09:52:46 +08:00
Petr Skoda 4ca04fb58b MDL-32569 remove remaining references to simpletest and improve events test 2012-04-21 17:08:30 +02:00
Petr Skoda 6b04fdc0b6 MDL-32400 improve module generators
Module generators are using standard *_add_instance() methods which helps with testing, it also updates grades and calendar events if used.
2012-04-15 14:16:59 +02:00
Petr Skoda bd42a2657e MDL-32323 do try to fetch all other grade objects with existing test fields 2012-04-11 22:56:27 +02:00
Petr Skoda 15db9f7d66 MDL-32323 do try to fetch grades with existing test fields 2012-04-11 22:41:37 +02:00
Petr Skoda 948d46da34 MDL-32323 add grade tests 2012-04-10 15:27:10 +02:00
Petr Skoda caee6e6c26 MDL-32251 E_STRICT fixes part 3 2012-03-29 15:24:30 +02:00
Petr Skoda e2bb3c9275 MDL-32094 some more E_STRICT fixes 2012-03-18 20:40:20 +01:00
Petr Skoda f20edd5208 MDL-32094 fix various E_STRICT compatibility problems 2012-03-18 18:37:24 +01:00
Andrew Davis ca540697f1 MDL-31362 grade: removed GRADE_UPDATE_ITEM_DELETED as it is not genuinely being used anywhere 2012-03-03 10:00:01 +07:00
Eloy Lafuente (stronk7) cee44e2d96 Merge branch 'MDL-31363_grade_constants' of git://github.com/andyjdavis/moodle
Conflicts:
	lib/grade/constants.php
2012-02-28 12:37:44 +01:00
Andrew Davis 0e7f31b42b MDL-31363 grade: removed 3 constants that are not being used anywhere 2012-02-23 08:51:19 +07:00
Eloy Lafuente (stronk7) 11ce79b05d MDL-30999 whitespace fix 2012-02-20 12:17:33 +01:00
Eloy Lafuente (stronk7) a4d7604977 MDL-30999 grade phpdocs - change some inline @see by correct @link 2012-02-20 12:09:50 +01:00
Andrew Davis a153c9f2fe MDL-30999 grade: updated Grade API phpdocs 2012-02-14 14:04:19 +07:00
sam marshall ad275cb4ad MDL-28643 Fix debugging message when deleting activity with grade completion 2011-08-10 11:02:56 +01:00
Petr Skoda 431ac39634 MDL-26623 fix file permissions
The permissions are now going to be verified as part of the weekly release process.
2011-03-01 12:26:49 +01:00
Eloy Lafuente (stronk7) 1b42e67747 MDL-25708 recordsets - fix lib/grade/xxx stuff 2011-01-25 19:59:00 +01:00
Petr Skoda 99d19c13ae MDL-25855 some more missing filelib includes 2011-01-23 18:34:41 +01:00
Petr Skoda c3b1c4f097 MDL-25713 fixing trailing whitespace 2010-12-27 12:04:26 +01:00
andyjdavis fc61acce12 gradebook MDL-25713 now closing the recordset even when theres a problem 2010-12-23 10:07:08 +08:00
andyjdavis 2f9ea7d78e gradebook MDL-25713 switched grade_object fetch_all_helper() over to using a recordset 2010-12-20 16:39:46 +08:00
Andrew Davis 2b574cc4e0 gradebook MDL-24330 massively reduced grade objects unit tests execution time so I can actually run them 2010-12-10 03:05:49 +00:00
Andrew Davis b146d98455 gradebook MDL-24504 made grade item sorting work and prevented a bunch of sortorder shuffling 2010-10-04 08:05:05 +00:00
Petr Skoda 365a594107 MDL-24321 switching to stdClass in /lib/ 2010-09-21 08:07:44 +00:00
Petr Skoda 7c109ea3f0 MDL-24276 "static abstract" combination is deprecated since PHP 5.2, replacing with our coding_style exception 2010-09-19 18:43:52 +00:00
Petr Skoda c10244114a spelling improvements 2010-09-18 10:46:53 +00:00
Petr Skoda 22a9b6d873 fixed phpdocs and marked methods as static 2010-09-18 10:43:50 +00:00
Andrew Davis bfc7353d96 gradebook MDL-23928 fixed grade history recording to correctly save the user id of the user making the change pt 2 2010-09-17 03:08:45 +00:00
Andrew Davis f64e29e133 gradebook MDL-23928 fixed grade history recording to correctly save the user id of the user making the change 2010-09-17 03:02:27 +00:00
Petr Skoda f685e83030 MDL-14679 fixed remaining old style set_field()s 2010-09-03 18:14:55 +00:00
Andrew Davis 59ee314414 gradebook MDL-24045 added a guard for when the user report is accessed outside of a course context 2010-09-02 02:38:29 +00:00