L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-29733 grade: SQL and comment cleanup

Browse Source
This commit is contained in:
Andrew Davis
2012-12-11 09:15:31 +08:00
parent 8a592bd551
commit 415b15ccd6
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/grade/grade_item.php
+8 -7
View File
@@ -1730,6 +1730,7 @@ class grade_item extends grade_object {
return true; // no need to recalculate locked items
}
// Precreate grades - we need them to exist
if ($userid) {
$missing = array();
if (!$DB->record_exists('grade_grades', array('itemid'=>$this->id, 'userid'=>$userid))) {
@@ -1738,14 +1739,14 @@ class grade_item extends grade_object {
$missing[] = $m;
}
} else {
// precreate grades - we need them to exist
$params = array($this->courseid, $this->id);
$sql = "SELECT go.userid
FROM {grade_grades} go
// Find any users who have grades for some but not all grade items in this course
$params = array('gicourseid' => $this->courseid, 'ggitemid' => $this->id);
$sql = "SELECT gg.userid
FROM {grade_grades} gg
JOIN {grade_items} gi
ON (gi.id = go.itemid AND gi.courseid = ?)
GROUP BY go.userid
HAVING SUM(go.itemid = ?) = 0";
ON (gi.id = gg.itemid AND gi.courseid = :gicourseid)
GROUP BY gg.userid
HAVING SUM(CASE WHEN gg.itemid = :ggitemid THEN 1 ELSE 0 END) = 0";
$missing = $DB->get_records_sql($sql, $params);
}