Commit Graph

9 Commits

Author SHA1 Message Date
Andrew Nicols a6b8fc7830 MDL-55609 assignfeedback_comments: Remove shared setUp 2018-06-01 07:30:32 +08:00
David Monllao ab1058247c MDL-56122 editpdf: Fix ghostscript checking 2017-02-14 13:45:21 +01:00
Tony Butler 63a117dcb2 MDL-56122 assignfeedback_editpdf: Add test assertions for pdf generation 2017-02-13 17:27:24 +00:00
David Monllao 4edd8e773d MDL-52397 editpdf: Fix draft vs nondraft comparison
We can not rely on the db engine returning results in the same order
if no order is specified in get_comments and get_annotations.

Also fixing a related unit test.
2016-03-01 12:29:13 +08:00
Adrian Greeve 50c734e8a5 MDL-52397 mod_assign: Unit tests for feedback plugins.
Testing that the new method is_feedback_modified() works
as it should with the standard plugins.
2016-02-24 15:09:27 +08:00
Eloy Lafuente (stronk7) 095ecde727 MDL-49998 unit tests: files left open are our fault.
Get rid of the gc_collect_cycles() that only was
hiding incorrectly left open files. This must be fixed
in code when possible. And pdf libs allow us to do so.

Note that a lot of gc_collect_cycles() were added
in MDL-47675, I'd recommend to take a look to all them,
being replaced by fixes in code when possible.
2015-04-28 19:46:50 +02:00
Adrian Greeve c42d18183a MDL-47675 phpunit: Update unit tests to pass on MSSQL
Unit tests were failing on MSSQL. gc_collect_cycles() was
removed from the phpunit utils.php file to save time in running
the tests, but MSSQL doesn't clean up open files as well as
other databases.

This patch includes the garbage collection for the unit tests
that require it.
2014-10-20 14:26:11 +08:00
Rajesh Taneja 9dbe0313ce MDL-42222 Assignment: Added type check before checking mimetype
Online submission type pass string in files, so added check
to see if file is of type stored_file then check mimetype
2013-10-09 16:53:46 +08:00
Damyon Wiese 5c3864723a MDL-42023 assign: Edit PDF plugin - Damyon's contributions 2013-10-03 09:30:32 +08:00