L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-42222 Assignment: Added type check before checking mimetype

Browse Source 
Online submission type pass string in files, so added check
to see if file is of type stored_file then check mimetype
This commit is contained in:
Rajesh Taneja
2013-10-09 16:53:46 +08:00
parent 56cc9b387e
commit 9dbe0313ce
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/assign/feedback/editpdf/classes/document_services.php
+1 -1
View File
@@ -117,7 +117,7 @@ class document_services {
if ($plugin->is_enabled() && $plugin->is_visible()) {
$pluginfiles = $plugin->get_files($submission, $user);
foreach ($pluginfiles as $filename => $file) {
if ($file->get_mimetype() === 'application/pdf') {
if (($file instanceof \stored_file) && ($file->get_mimetype() === 'application/pdf')) {
$files[$filename] = $file;
}
}
mod/assign/feedback/editpdf/tests/editpdf_test.php
+2 -1
View File
@@ -54,7 +54,8 @@ class assignfeedback_editpdf_testcase extends mod_assign_base_testcase {
protected function create_assign_and_submit_pdf() {
global $CFG;
$assign = $this->create_instance(array('assignsubmission_file_enabled' => 1,
$assign = $this->create_instance(array('assignsubmission_onlinetext_enabled' => 1,
'assignsubmission_file_enabled' => 1,
'assignsubmission_file_maxfiles' => 1,
'assignfeedback_editpdf_enabled' => 1,
'assignsubmission_file_maxsizebytes' => 1000000));