Commit Graph

76 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7) 4f510bea17 Merge branch 'MDL-62384-master' of git://github.com/andrewnicols/moodle 2018-05-11 18:12:45 +02:00
Adrian Greeve 5a329d81f9 MDL-62384 core_competency: Update to sql to increase performance. 2018-05-11 09:15:27 +08:00
Marina Glancy 468c8d39c3 MDL-62351 privacy: check that subsystem/plugintype exist 2018-05-09 17:37:31 +08:00
Frédéric Massart 9967731256 MDL-61877 core_competency: False negative due to random ordering 2018-05-04 11:18:42 +02:00
Frédéric Massart 739b59610a MDL-61877 core_competency: Handle comments in privacy API 2018-04-27 11:29:30 +08:00
Frédéric Massart f8a6a533c2 MDL-61877 core_competency: Implement privacy API 2018-04-27 11:29:29 +08:00
Eloy Lafuente (stronk7) a4e7e6f345 Merge branch 'MDL-60567-master' of git://github.com/damyon/moodle 2017-12-19 11:30:08 +01:00
Jun Pataleta 24131d08c0 Merge branch 'MDL-59970-master' of git://github.com/damyon/moodle 2017-12-12 18:52:49 +13:00
Simey Lameze f9bb74c037 MDL-58058 competency: replace other sortorder usages 2017-12-08 15:58:52 +08:00
Frederic Massart f250cdbb34 MDL-58058 competency: Allow unspecified sortorder for new competencies 2017-12-08 15:58:52 +08:00
Damyon Wiese 9a7671da80 MDL-59970 competencies: performance
Remove useless get_records call in get_least_proficient_competencies_for_course function.
On big sites this would cause huge memory usage.
2017-11-22 15:35:20 +08:00
Damyon Wiese f09f01fcad MDL-60567 competencies: list_competencies wrong type
"validate_params" returns arrays in external functions.
2017-10-27 11:49:13 +08:00
Simey Lameze 8c13028c9d MDL-59994 competency: dont list competencies from deleted users 2017-09-18 08:32:12 +08:00
Tony Levi 95c0b810bf MDL-49398 accesslib: Change competency to use new accesslib function 2017-06-02 10:04:09 +01:00
Simey Lameze b991325da2 MDL-58884 core_competency: add exporter required course fields 2017-05-17 13:02:48 +08:00
Issam Taboubi 013982e3c4 MDL-58884 competency: Inaccurate stats proficient competencies in course 2017-05-10 15:08:21 -04:00
Andrew Nicols 458e5f66c2 MDL-58754 competency: Change query for DISTINCT COUNT 2017-05-02 14:48:35 +08:00
Ankit Agarwal f939ae13f9 MDL-58624 persistent: Use correct namespace for exception 2017-04-18 13:54:45 +05:30
Damyon Wiese ac40d8b589 MDL-57596 forms: CLEANHTML in persistent forms
Add special handling for text fields with the CLEANHTML type. This should
be used when students and teachers can edit the same field (you can't trust those students).

Applies cleaning on submitted data, and on data stored in the DB before it is put back in an editing form.
2017-03-10 18:04:48 +00:00
Damyon Wiese 6b206c5309 MDL-57273 persistent: Dont allow set and get for helpers
Helper methods (ie custom methods on a persistent) should not be callable via set() or get() even
if they start with set_ or get_. They are not the same as custom getters and setters for real persistent
properties.
2017-01-24 15:39:53 +08:00
Damyon Wiese 0ce135f65d MDL-57273 persistent: Some more magic __call conversions
I missed all the entry pages when converting from set_abc() and get_abc() to set('abc', ) and get('abc').

Also fixed a wrong namespace for core_competency\external\performance_helper
2017-01-24 15:20:07 +08:00
Damyon Wiese d5818626c0 MDL-57273 persistent: Improved style
Use \blah::class instead of '\\blah' in define_class functions.
Allow chaining of setters by returning $this.
2017-01-23 11:58:59 +08:00
Damyon Wiese 599acbe776 MDL-57273 persistent: protected custom getters
(and setters).
2017-01-20 12:56:19 +08:00
Damyon Wiese 9c91a9593d MDL-57273 core: Remove magic setters and getters
Remove the magic getters and setters from persistent. They are deprecated only in the persistent
class for competencies.
2017-01-20 12:56:19 +08:00
Frederic Massart 32896dcbab MDL-57273 core: Using $renamedclasses for deprecated classes 2017-01-20 12:56:19 +08:00
Frederic Massart c59e531301 MDL-57273 exporter: Clarify why contextname needs to be PARAM_RAW 2017-01-20 12:56:19 +08:00
Frederic Massart 4bc68a416e MDL-57273 core: Exporters support custom formatting parameters 2017-01-20 12:56:19 +08:00
Frederic Massart 268beda8e9 MDL-57273 core_competency: Fatal error in external update_plan 2017-01-20 12:56:18 +08:00
Frederic Massart f5f02ac0d3 MDL-57273 core: Migrating some exporters from tool_lp & core_competency 2017-01-20 12:56:18 +08:00
Frederic Massart 476bf96f4d MDL-57273 core: Added a performance helper to use with exporters 2017-01-20 12:56:18 +08:00
Frederic Massart 6e28143599 MDL-57273 core: Migrating core_competency exporters into core 2017-01-20 12:56:18 +08:00
Frederic Massart 2198e0e94a MDL-57273 core: Migrating persistent from core_competency into core 2017-01-20 12:56:18 +08:00
Frederic Massart 0eda810d17 MDL-56459 competency: Invalid use of indirect property key
This change ensures that PHP7 and earlier work the same way. Before
the patch PHP < 7 would not expand the property as we expected it.

More information here:
http://php.net/manual/en/migration70.incompatible.php#migration70.incompatible.variable-handling.indirect
2016-11-16 13:53:31 +08:00
Michael Aherne fc60769302 MDL-56668 competencies: Correct namespacing of coding_exception 2016-11-03 13:59:13 +00:00
Issam Taboubi fd8043b2de MDL-56285 competency: fix move competencies capabilities
In learning plan templates, cannot move competencies
around even if capability templatemanage is given
to the role because of bad context check
2016-10-06 10:33:32 -04:00
Andrew Nicols dbab30b127 MDL-55767 competency: Deprecate langstring and replace 2016-10-03 12:59:32 +08:00
Damyon Wiese 9e14057444 MDL-55767 competencies: Better exceptions for persistent
The persistent exceptions "squash" all the details and only display
them to developers. This leads to generic "Invalid persistent" messages
with no explanation. Instead lets include the message detail always.
2016-10-03 12:01:56 +08:00
Andrew Nicols aa49ee0f29 Merge branch 'wip-mdl-55043' of https://github.com/rajeshtaneja/moodle 2016-07-07 11:27:58 +08:00
Rajesh Taneja 56c5c9a08a MDL-55043 core_competency: Sort by id to ensure we get expected result. 2016-07-10 11:25:06 +08:00
Eloy Lafuente (stronk7) 6e24e529c9 Merge branch 'wip-mdl-55043' of https://github.com/rajeshtaneja/moodle 2016-07-06 03:19:08 +02:00
Rajesh Taneja 2648dddd2a MDL-55043 core_competency: Set proper sort order for each field 2016-07-06 08:12:13 +08:00
Marina Glancy 799e001c15 MDL-55032 tool_lp: check access when showing link to competencies
Also if course competencies page is accessed without capabilities do
redirect before starting output.
2016-07-01 13:42:27 +08:00
Damyon Wiese e824cd502d MDL-54997 competencies: Fix random unit test fail
Sorting on timecreated is not unique enough to
guarantee a predictable ordering.
2016-06-25 08:04:15 -07:00
Damyon Wiese da880d320c MDL-54997 competencies: Listing evidence contexts
When listing the evidence for a user competency in a course,
the query is missing evidences for sub-contexts in the course.
2016-06-23 09:14:19 -07:00
Frederic Massart d309f3e218 MDL-54542 competency: Really handle false negatives in plans to review 2016-05-19 11:42:15 +08:00
Frederic Massart c07712db17 MDL-54542 competency: False negative when listing plans to review 2016-05-19 10:23:46 +08:00
Andrew Nicols 60e75de317 Merge branch 'MDL-54542-master' of git://github.com/FMCorz/moodle 2016-05-18 09:48:27 +08:00
Dan Poltawski 6967b71a34 Merge branch 'MDL-54546-master' of git://github.com/junpataleta/moodle 2016-05-13 18:11:29 +08:00
Andrew Nicols 07d4b49760 Merge branch 'MDL-54073-master' of git://github.com/junpataleta/moodle 2016-05-13 18:11:28 +08:00
Jun Pataleta e5336562db MDL-54546 tool_lp: Use correct property types for user/course exporters 2016-05-12 19:04:58 +08:00