L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-57273 core_competency: Fatal error in external update_plan

Browse Source
This commit is contained in:
Frederic Massart
2017-01-20 12:56:18 +08:00
committed by Damyon Wiese
parent f5f02ac0d3
commit 268beda8e9
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
competency/classes/external.php
+2 -3
View File
@@ -2705,9 +2705,8 @@ class external extends external_api {
$params = (object) $params;
$result = api::update_plan($params);
$exporter = plan_exporter($result);
$record = $exporter->export($output);
return external_api::clean_returnvalue(self::update_plan_returns(), $record);
$exporter = new plan_exporter($result, ['template' => $plan->get_template()]);
return $exporter->export($output);
}
/**
competency/tests/external_test.php
+5
View File
@@ -1207,6 +1207,11 @@ class core_competency_external_testcase extends externallib_advanced_testcase {
$plan2 = $this->create_plan(3, $this->user->id, 0, plan::STATUS_DRAFT, 0);
// Basic update on the plan.
$this->assertNotEquals('Updated plan 2 name', $plan2->name);
$plan2 = external::update_plan(['id' => $plan2->id, 'name' => 'Updated plan 2 name']);
$this->assertEquals('Updated plan 2 name', $plan2->name);
try {
$plan3 = $this->create_plan(4, $this->user->id, 0, plan::STATUS_ACTIVE, 0);
$this->fail('Exception expected due to not permissions to create active plans');