Commit Graph

64 Commits

Author SHA1 Message Date
Damyon Wiese 5db5c22c15 MDL-52064 cbe: Exporters are generic exporters - not for output
Making the persistent_exporter implement templatable, implies that the
exporters are designed for output - but they are not - they are designed
for any data returned through an external function. So lets not make them templatable,
and make the default function name "export".
2016-04-18 10:58:41 +08:00
Damyon Wiese a214d35ec2 MDL-52064: Improve persistent exporter
- Use to_record instead of custom getters
- Remove custom formatting for taxonomies
- Fix bugs in exporter (PARAM_FORMAT was wrong)
- use $comp->get_context() instead of $comp->get_framework()->get_context()
2016-04-18 10:58:41 +08:00
Damyon Wiese 86938d0613 MDL-52064 cbe: Clean many common errors in external functions
Fixes include format_text/format_string
New persistent_exporter class to export persistent objects for use in external apis.
Always validate_context
Always use validated params - not raw params
Do not use "xxformatted" properties.
2016-04-18 10:58:41 +08:00
Frederic Massart fdaf46adbb MDL-51029 tool_lp: Before validate was not always called
When the validation already happened we did not call before_validate().
It must always be called as before_validate() can be used as if it was
a before_all() callback.
2016-04-18 10:58:41 +08:00
Frederic Massart 1896274ff5 MDL-51029 tool_lp: Implement competency rules 2016-04-18 10:58:41 +08:00
Jean-Philippe Gaudreau 192569ed17 MDL-51805 tool_lp: Freeze learning plan when it is marked as completed
This includes:
* Copy user competencies to user_competency_plan when updating plan
  with status complete.
* User competencies in user_competency_plan are deleted when the plan
  is set back to draft or active.
* the api::list_plan_competencies method is now returning
  user_competency_plan objects if plan status is complete.
* external functions and renderer have been adapted to the new api
  methods.
* Remove fields status and reviewerid from user_competency_plan
2016-04-18 10:58:41 +08:00
Damyon Wiese 60bf8bb0aa MDL-51957 cbe: Cleanup data_for_manage_competencies_page webservice
Declare the correct return type and remove the commented code from the renderable.
2016-04-18 10:58:40 +08:00
Damyon Wiese fff88ad17d MDL-51957: Super pimp the performance of the aria tree. 2016-04-18 10:58:40 +08:00
Frederic Massart 8ff9ae8d6f MDL-50328 tool_lp: Unit test failure and little clean-up of plans page 2016-04-18 10:58:40 +08:00
Issam Taboubi 554b369b60 MDL-50328 tool_lp: Allow competencies to be assigned to a user plan 2016-04-18 10:58:40 +08:00
Frederic Massart 2ec1b70bcd MDL-51866 tool_lp: Framework scale cannot be changed once it is used 2016-04-18 10:58:40 +08:00
Issam Taboubi 4ad3ac34f4 MDL-51987 tool_lp: Create persistent plan_competencies 2016-04-18 10:58:40 +08:00
Frederic Massart 1d8f0a6f50 MDL-51034 tool_lp: List competencies in a user's plan 2016-04-18 10:58:40 +08:00
Issam Taboubi 58405003f8 MDL-51646 tool_lp: Implement plan status 2016-04-18 10:58:40 +08:00
Serge Gauthier 8a9030c18e MDL-51862 tool_lp: Create a persistent model user_competency_plan 2016-04-18 10:58:39 +08:00
Frederic Massart 5159d6794b MDL-51965 tool_lp: Revisit capabilities to read/manage plans
Templates can no longer be linked to the plan via the plan editing
page because we will need to handle plan linking/unlinking directly.
2016-04-18 10:58:37 +08:00
Serge Gauthier 6d57a987bf MDL-51644 tool_lp: Create persistent model for user_competency 2016-04-18 10:58:37 +08:00
Jean-Philippe Gaudreau 67e0b72fb2 MDL-51870 tool_lp: Use new ajax definition of external functions 2016-04-18 10:58:37 +08:00
Damyon Wiese dccdd4da87 MDL-51958 cbe: Increase the limit for the number of levels in a tree 2016-04-18 10:58:37 +08:00
Damyon Wiese 7605c5f40f MDL-51959 cbe: Validate the depth of the path of a competency 2016-04-18 10:58:37 +08:00
Serge Gauthier 53084abb75 MDL-51645 tool_lp: Rename the plan capabilities 2016-04-18 10:58:36 +08:00
Frederic Massart 3a4c71dc22 MDL-51856 tool_lp: Fixing PHPUnit notices and plan errors 2016-04-18 10:58:36 +08:00
Serge Gauthier e9831af3c2 MDL-51233 tool_lp: Remove unused ID number from learning plan templates
Conflicts:
	admin/tool/lp/version.php
2016-04-18 10:58:36 +08:00
Frederic Massart e52513ee2b MDL-51602 tool_lp: Use parent ID rather than node when building tree 2016-04-18 10:58:36 +08:00
Issam Taboubi c61db7bb6a MDL-51602 tool_lp: Add ability to duplicate a competency framework 2016-04-18 10:58:36 +08:00
Frederic Massart 03c6665894 MDL-51791 tool_lp: Improving persistent validation
- Validation methods must be protected
- An ID cannot be set when calling create()
2016-04-18 10:58:36 +08:00
Frederic Massart bf61cd0cf3 MDL-51442 tool_lp: Validate the frameworks' scale ID 2016-04-18 10:58:36 +08:00
Serge Gauthier 31582c1638 MDL-51442 tool_lp: Framework scales configuration must be mandatory 2016-04-18 10:58:36 +08:00
Frederic Massart 8cb101a7d2 MDL-51638 tool_lp: Display the taxonomy terms where relevant 2016-04-18 10:58:36 +08:00
Frederic Massart 0c65d52c7f MDL-51504 tool_lp: Validate the templates' due date 2016-04-18 10:58:36 +08:00
Frederic Massart a54d5b042a MDL-51026 tool_lp: Taxonomy terms can be defined on a framework 2016-04-18 10:58:36 +08:00
Frederic Massart 2327fe75f2 MDL-51598 tool_lp: Frameworks page displays correct competency count 2016-04-18 10:58:36 +08:00
Frederic Massart 14d9abc261 MDL-50482 tool_lp: Use list_competencies as static and bump version 2016-04-18 10:58:36 +08:00
Issam Taboubi 76c107eac1 MDL-50482 tool_lp: Add ability to duplicate a learning plan template 2016-04-18 10:58:36 +08:00
Frederic Massart 46fdd1d8ef MDL-50253 tool_lp: Port course competencies to new persistent model 2016-04-18 10:58:36 +08:00
Frederic Massart aec5363ec1 MDL-50253 tool_lp: Clean up implementation of related competencies 2016-04-18 10:58:35 +08:00
David Monllao 4f81545979 MDL-50253 tool_lp: Adding related competencies
Conflicts:
	admin/tool/lp/classes/api.php
	admin/tool/lp/classes/external.php
	admin/tool/lp/classes/output/renderer.php
	admin/tool/lp/db/install.xml
	admin/tool/lp/db/services.php
	admin/tool/lp/lang/en/tool_lp.php
	admin/tool/lp/version.php
2016-04-18 10:58:35 +08:00
Frederic Massart cf2cc1e2b0 MDL-51696 tool_lp: Record was overridden by record description 2016-04-18 10:58:35 +08:00
Serge Gauthier 3392a313c0 MDL-51507 tool_lp: External functions frameworks lack scale information 2016-04-18 10:58:35 +08:00
Issam Taboubi b397969665 MDL-51460 tool_lp: List frameworks' API function does not support order 2016-04-18 10:58:35 +08:00
Frederic Massart 6420fbab9b MDL-51506 tool_lp: Forms drop submitbutton from data 2016-04-18 10:58:34 +08:00
Frederic Massart cc643d16dd MDL-51506 tool_lp: Migrating template_competency to new model API 2016-04-18 10:58:34 +08:00
Frederic Massart 5af3778e13 MDL-51506 tool_lp: Migrating plan to new model API 2016-04-18 10:58:34 +08:00
Frederic Massart cda17bd961 MDL-51506 tool_lp: Migrating template to new model API 2016-04-18 10:58:34 +08:00
Frederic Massart b60702643c MDL-51506 tool_lp: Migrating competency_framework to new model API 2016-04-18 10:58:34 +08:00
Frederic Massart c27113d93e MDL-51506 tool_lp: Migrating competency to new model API 2016-04-18 10:58:34 +08:00
Frederic Massart 7bec03c5d0 MDL-51506 tool_lp: Implementing before/after (C)RUD hooks 2016-04-18 10:58:34 +08:00
Frederic Massart dee2fb575e MDL-51506 tool_lp: Implementing validation in the models 2016-04-18 10:58:34 +08:00
Issam Taboubi d192e248b7 MDL-51459 tool_lp: Template external functions do not return the duedate 2016-04-18 10:58:34 +08:00
Damyon Wiese d65b912df2 MDL-51139 tool_lp: Fix some javascript that was broken by a merge
The user learning plans page menus were broken by some refactoring.

Fixed during merge by Fred:
- Added space between icons and strings in action menu
- Recent changes caused the plans page to die when listing templates
2016-04-18 10:58:34 +08:00