L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-51460 tool_lp: List frameworks' API function does not support order

Browse Source
This commit is contained in:
Issam Taboubi
2016-04-18 10:58:35 +08:00
committed by Frederic Massart
parent 904291f21f
commit b397969665
2 changed files with 62 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/tool/lp/classes/api.php
+1 -1
View File
@@ -413,7 +413,7 @@ class api {
// OK - all set.
list($insql, $inparams) = $DB->get_in_or_equal(array_keys($contexts), SQL_PARAMS_NAMED);
return competency_framework::get_records_select("contextid $insql", $inparams, $sort, '*', $skip, $limit);
return competency_framework::get_records_select("contextid $insql", $inparams, $sort . ' ' . $order, '*', $skip, $limit);
}
/**
admin/tool/lp/tests/api_test.php
+61
View File
@@ -182,4 +182,65 @@ class tool_lp_api_testcase extends advanced_testcase {
api::update_template((object) array('id' => $template->get_id(), 'contextid' => context_coursecat::instance($cat->id)));
}
/**
* Test listing framework with order param.
*/
public function test_list_frameworks() {
$this->resetAfterTest(true);
$this->setAdminUser();
// Create a list of frameworks.
$params1 = array(
'shortname' => 'shortname_a',
'idnumber' => 'idnumber_c',
'description' => 'description',
'descriptionformat' => FORMAT_HTML,
'visible' => true,
'contextid' => context_system::instance()->id
);
$framework1 = api::create_framework((object) $params1);
$params2 = array(
'shortname' => 'shortname_b',
'idnumber' => 'idnumber_a',
'description' => 'description',
'descriptionformat' => FORMAT_HTML,
'visible' => true,
'contextid' => context_system::instance()->id
);
$framework2 = api::create_framework((object) $params2);
$params3 = array(
'shortname' => 'shortname_c',
'idnumber' => 'idnumber_b',
'description' => 'description',
'descriptionformat' => FORMAT_HTML,
'visible' => true,
'contextid' => context_system::instance()->id
);
$framework3 = api::create_framework((object) $params3);
// Get frameworks list order by shortname desc.
$result = api::list_frameworks('shortname', 'DESC', null, 3, context_system::instance());
$r1 = (object) $result[0];
$r2 = (object) $result[1];
$r3 = (object) $result[2];
$this->assertEquals($framework1->get_id(), $r3->get_id());
$this->assertEquals($framework2->get_id(), $r2->get_id());
$this->assertEquals($framework3->get_id(), $r1->get_id());
// Get frameworks list order by idnumber asc.
$result = api::list_frameworks('idnumber', 'ASC', null, 3, context_system::instance());
$r1 = (object) $result[0];
$r2 = (object) $result[1];
$r3 = (object) $result[2];
$this->assertEquals($framework1->get_id(), $r3->get_id());
$this->assertEquals($framework2->get_id(), $r1->get_id());
$this->assertEquals($framework3->get_id(), $r2->get_id());
}
}