Commit Graph

177 Commits

Author SHA1 Message Date
Tim Hunt e1ded0ff55 MDL-31407 quiz: review all uses of global $USER 2012-02-02 18:13:34 +00:00
Eloy Lafuente (stronk7) e4715ab74a Merge branch 'MDL-31080_22' of git://github.com/timhunt/moodle into MOODLE_22_STABLE 2012-01-17 02:01:49 +01:00
Tim Hunt ef0376f4ef MDL-31095 quiz editing: only set quiz->grade to 0 if really necessary.
It is only necessary when there are (non-preview) attempts. However,
after making this change we have to ensure users cannot start attempts
when ->grade > 0 and ->sumgrades = 0.

Display ->grade on the order and paging tab of edit.php, so it is clear
what is going on when you are using that tab.

Finally, improve the error message a student gets if they try to start a
quiz with no questions.
2012-01-13 11:42:57 +00:00
Tim Hunt d16597b557 MDL-31080 quiz editing, must be able to see and delete missing questions 2012-01-12 11:32:22 +00:00
Tim Hunt 76ffac7f93 MDL-30646 default qbank sort should only use visible columns. 2011-12-15 18:40:32 +00:00
Tim Hunt 00aa596e8e MDL-30558 question bank, missing string with obscure permissions.
AMOS BEGIN
 MOV [selectcategoryabove,mod_quiz],[selectcategoryabove,question]
AMOS END
2011-12-09 10:47:19 +08:00
Tim Hunt 5cc021a00b MDL-30069 Question type icons missing in lots of places. 2011-11-15 11:17:18 +00:00
Tim Hunt 72bbb091a4 MDL-29570 Quiz editing page displays the wrong time in the status line sometimes. 2011-09-29 09:06:11 +01:00
Eloy Lafuente (stronk7) bae0925b4d Merge branch 'MDL-29141' of git://github.com/timhunt/moodle 2011-08-29 13:00:21 +02:00
Tom Cubanski 14bf45747d MDL-26302 quiz editing: top move button on the order and paging tab does not work.
It is strange that processes the submission already handles the submitted data from this change to the HTML.
2011-08-27 08:20:46 +01:00
Tim Hunt e20ad67d7b MDL-29141 question bank show question text checkbox does not match state. 2011-08-26 17:01:06 +01:00
Eloy Lafuente (stronk7) 09e35896d4 Merge branch 'MDL-27631' of git://github.com/mkassaei/moodle 2011-08-10 03:00:17 +02:00
M Kassaei 92e6e128ff MDL-27631 question bank Show question text in the question list when top level category is used 2011-08-05 10:40:06 +01:00
Tim Hunt b72b413759 MDL-28604 Question bank display forgets sort order 2011-08-04 13:53:02 +01:00
Wale Olujide 8418e5b77c MDL-28051 Question numbers on the question edit page shoud be the same as during the quiz attempt. 2011-07-28 18:02:53 +01:00
Tim Hunt c5da295b85 MDL-28012 Quiz editing status line can display screwy dates. 2011-06-23 18:53:07 +01:00
Tim Hunt 612106b3a4 MDL-20636 fix URL handling for previews to always use Moodle URL.
Also, make the preview window big enough. #367
2011-05-27 11:49:23 +01:00
Tim Hunt aac80ff319 MDL-20636 fix most of the remaining codechecker issues in mod/quiz and lib/questionlib.php. 2011-05-13 00:33:44 +01:00
Tim Hunt 25a03faaca MDL-20636 fix many code-checker issues in mod/quiz. 2011-05-12 00:30:25 +01:00
Tim Hunt 6b5f24d376 MDL-20636 Handle deleting response files when the usage is deleted. #216 2011-03-31 12:45:17 +01:00
Tim Hunt 42663bb78e MDL-20636 Fix a bunch of missing strings caused by separating question from quiz. 2011-03-02 17:42:53 +00:00
Tim Hunt 22cebed503 MDL-20636 Review and fix the format parameter to all calls to format_text. 2011-02-24 20:18:16 +00:00
Tim Hunt f7970e3ca7 MDL-20636 Eliminate integer and boolean in PHPdoc comments. should be int and bool. 2011-02-23 16:25:25 +00:00
Tim Hunt a17b297d60 MDL-20636 Add missing defined('MOODLE_INTERNAL') || die(); 2011-02-23 16:00:20 +00:00
Tim Hunt 0ff4bd0877 MDL-20636 Fix new stdClass -> stdClass(), and trailing whitespace. 2011-02-21 18:10:19 +00:00
Tim Hunt ba6438471b MDL-20636 Fix top of file boilerplate in mod/quiz. 2011-02-21 16:13:25 +00:00
Tim Hunt fd214b596d MDL-20636 Preserve scroll position when doing action on the quiz edit page. 2011-02-11 17:36:02 +00:00
Tim Hunt f9b0500f7f MDL-20636 Quiz editing now works, as does the random question type.
However, all this needs more testing.

Also, a bit of a purge of training whitespace and global .
2011-02-10 20:50:18 +00:00
Tim Hunt f2956c9813 quiz editing MDL-25391 creating a new question and adding it directly to the quiz was broken.
Thanks to Chad Outten for finding this before it was too late, and skodak for the review.
2010-11-24 09:05:22 +00:00
Tim Hunt 94dbfb3a82 quiz editing MDL-24750 The Add random button should also let you add questions from an existing category.
Also includes a fix for MDL-24749 by Sam Hemelryk. Thanks Sam.

This commit also includes a certain amount of code cleaning up.
2010-11-22 09:52:42 +00:00
Tim Hunt fb6dcdab11 quiz & qbank MDL-24453 fix all the ways you can edit a question, so that that returnurl paramterer acutally works.
I hope. Please test thoroughly.
2010-10-18 15:28:59 +00:00
Petr Skoda f685e83030 MDL-14679 fixed remaining old style set_field()s 2010-09-03 18:14:55 +00:00
Petr Skoda b11681e036 MDL-23784 fixed more incorrect pix links 2010-08-12 18:38:56 +00:00
Tim Hunt 90c7912e93 quiz editing MDL-22371 with JS off, clicking add question, then cancel, did not work.
Also, other simpilar issues with other buttons.
And, finally fix the absolute URLs being passed as returnurl. Apache mod_security did not like that.
2010-08-04 19:44:59 +00:00
Tim Hunt 5be2373649 quiz editing MDL-23572 Make it possible to delete empty pages of the quiz. 2010-08-04 16:47:57 +00:00
David Mudrak 7292c11f51 MDL-21695 quiz: deprecated setHelpButton() and old_help_icon() replaced with new calls
Some help icons dropped without replacement as suggested by Helen, the
Help Writer. Some strings moved to core_question.

AMOS BEGIN
 HLP quiz/timelimit.html,[timelimit_help,mod_quiz]
 HLP quiz/grademethod.html,[grademethod_help,mod_quiz]
 HLP quiz/questionsperpage.html,[newpage_help,mod_quiz]
 HLP quiz/shufflewithin.html,[shufflewithin_help,mod_quiz]
 HLP quiz/penaltyscheme.html,[penaltyscheme_help,mod_quiz]
 HLP quiz/repeatattempts.html,[eachattemptbuildsonthelast_help,mod_quiz]
 HLP quiz/reviewoptions.html,[reviewoptionsheading_help,mod_quiz]
 HLP quiz/showuserpicture.html,[showuserpicture_help,mod_quiz]
 HLP quiz/decimalpoints.html,[decimalplaces_help,mod_quiz]
 HLP quiz/decimalplacesquestion.html,[decimalplacesquestion_help,mod_quiz]
 HLP quiz/requirepassword.html,[requirepassword_help,mod_quiz]
 HLP quiz/requiresubnet.html,[requiresubnet_help,mod_quiz]
 HLP quiz/timedelay1.html,[delay1st2nd_help,mod_quiz]
 HLP quiz/timedelay2.html,[delaylater_help,mod_quiz]
 HLP quiz/overallfeedback.html,[overallfeedback_help,mod_quiz]
 HLP quiz_statistics/negcovar.html,[negcovar_help,quiz_statistics]
 MOV [penaltyfactor,mod_quiz],[penaltyfactor,core_question]
 MOV [penaltyfactor_help,mod_quiz],[penaltyfactor_help,core_question]
 HLP quiz/penalty.html,[penaltyfactor_help,core_question]
AMOS END
2010-08-02 20:56:15 +00:00
Tim Hunt 175a3fd83a quiz settings: Revert some changes I committed by accident while commiting the patch for MDL-21780. 2010-05-11 14:12:49 +00:00
Pierre Pichet 78e5300ded MDL-21780 removing a DO NO COMMIT echo ;) 2010-05-11 13:13:17 +00:00
Tim Hunt 7bc488dc3d quiz settings MDL-21780 more work on group and user setting overrides
The group setting tab is now disabled if there are no groups in the course.
The code also now respects groupings.
Thanks to Matt Petro for this patch.
2010-05-10 22:15:17 +00:00
Tim Hunt 78634f1e06 quiz editing: MDL-17284 Add question here garbled layout when adding to an empty quiz.
That then lead to an incorrect display of the number of questions in the quiz.
2010-05-01 08:11:25 +00:00
Petr Skoda 596509e431 MDL-21695 renaming ->help_icon() to old_help_icon() and going to introduce new help_icon() with new parameters and detailed debugging - hopefully this will help during the conversion to new help 2010-04-13 20:34:27 +00:00
Tim Hunt 453b28d818 Fix $PAGE->set_url initialisation order. 2010-04-12 13:31:42 +00:00
Petr Skoda 54aa3239c7 MDL-20204 fixed regression from button conversion 2010-02-10 11:35:54 +00:00
Petr Skoda 8afba50b84 MDL-21233 get_query_string() is definitely not recommended in new code, instead use moodle_url constructors with proper parameters; removed some more legacy url concatenation operations; realized out_action is not needed often, because we shoudl pass arounf moodle_url instances instead of old url strings 2010-01-17 10:54:13 +00:00
Petr Skoda b9bc201962 MDL-21233 escaped parameter is far more importatnt than the overrideparams in out() method - especially all JS urls should be converted to out(false); also it is possible to create new url with overrided parameters in constructor which might be actually work around the double encoding problems in the url (we should never use the out() in moodle_url constructor itself!) 2010-01-17 09:50:55 +00:00
Petr Skoda eb7880654f MDL-21233 finally removed the omitquerystring parameters from the out method because: 1/ the least used parameter should nto be first, 2/ it is colliding with the other two paramters, now we have separate funtion for that instead 2010-01-17 09:37:30 +00:00
Petr Skoda 6ea66ff36c MDL-21233 obviously input tag writing does not belong into the moodle_url class, moving to html_writer instead + simplifying api 2010-01-17 09:06:55 +00:00
Petr Skoda 5c2ed7e215 MDL-21198 $OUTPUT->single_button() resurrection, hopefully much easier to use than $OUTPUT->button(); fixed some regressions and code style improvements 2010-01-03 15:46:14 +00:00
Petr Skoda 4bcc51185c MDL-21217, MDL-21198 simplified/improved outputlib help icon related apis + several fixed regresions 2009-12-30 15:19:55 +00:00
Petr Skoda 92e01ab771 MDL-21125 obsoleting global $THEME 2009-12-23 17:44:17 +00:00