Commit Graph

59 Commits

Author SHA1 Message Date
Petr Skoda caee6e6c26 MDL-32251 E_STRICT fixes part 3 2012-03-29 15:24:30 +02:00
Petr Skoda e2bb3c9275 MDL-32094 some more E_STRICT fixes 2012-03-18 20:40:20 +01:00
Petr Skoda 6f3451e540 MDL-31301 remove all uses of moodle_strtolower() and deprecated it 2012-03-03 11:46:26 +01:00
Petr Skoda f8311defeb MDL-31301 use static textlib methods 2012-03-03 11:46:13 +01:00
Iñaki Arenaza ab8b1d15a5 MDL-16168 auth/cas CAS crashes if no LDAP is set up
Fix was pending for master. Credit goes to Ivan Dackiewicz.
2011-08-28 15:31:14 +02:00
Inaki 40293947bb auth/cas: MDL-25062 CAS authentication plugin does not validate the CAS server certificate
If we enable the server validation but don't specify a certificate file path
flag the error and don't let the user save the settings.
2010-11-18 00:57:06 +00:00
Inaki 387d1dc0d5 auth/cas: MDL-25062 CAS authentication plugin does not validate the CAS server certificate
The CAS protocol security model requires that you verify the cas server
certificate before you trust the answer (valid authentication and username
etc.).

Credit goes to Joachim Fritschi for reporting it and providing a patch.
2010-11-18 00:12:23 +00:00
Petr Skoda 99f9f85f00 MDL-23489 auth plugins can specify own edit profile url - patch submitted by Jay Knight + tweaking change password url to use new moodle_url at the same time, it is backwards compatible, custom plugins may still use string url for now 2010-08-18 22:07:00 +00:00
Inaki 1298e78b24 auth/cas MDL-23371 Still some bits missing from setting name convertion. 2010-07-26 15:24:50 +00:00
Inaki 840fcf0c30 auth/cas MDL-23371 Add missing detection of PHP LDAP module like we do in auth/ldap 2010-07-25 22:55:45 +00:00
Inaki fcf46da1c5 auth/ldap cas/ldap MDL-23371 auth/ldap and auth/cas refactor
They now share most of the code again, this time via subclassing, and they
share some code with enrol/ldap. They have also gained some features and a few
fixes.
2010-07-25 22:36:15 +00:00
Petr Skoda df997f841f MDL-21782 reworked enrolment framework, the core infrastructure is in place, the basic plugins are all implemented; see the tracker issue for list of unfinished bits, expect more changes and improvements during the next week
AMOS START
    MOV [sendcoursewelcomemessage,core_admin],[sendcoursewelcomemessage,enrol_self]
    MOV [configsendcoursewelcomemessage,core_admin],[sendcoursewelcomemessage_desc,enrol_self]
    MOV [enrolstartdate,core],[enrolstartdate,enrol_self]
    MOV [enrolenddate,core],[enrolenddate,enrol_self]
    CPY [welcometocourse,core],[welcometocourse,enrol_self]
    CPY [welcometocoursetext,core],[welcometocoursetext,enrol_self]
    MOV [notenrollable,core],[notenrollable,core_enrol]
    MOV [enrolenddaterror,core],[enrolenddaterror,enrol_self]
    MOV [enrolmentkeyhint,core],[passwordinvalidhint,enrol_self]
    MOV [coursemanager,core_admin],[coursecontact,core_admin]
    MOV [configcoursemanager,core_admin],[coursecontact_desc,core_admin]
    MOV [enrolledincourserole,core],[enrolledincourserole,enrol_manual]
    MOV [enrolme,core],[enrolme,core_enrol]
    MOV [unenrol,core],[unenrol,core_enrol]
    MOV [unenrolme,core],[unenrolme,core_enrol]
    MOV [enrolmentnew,core],[enrolmentnew,core_enrol]
    MOV [enrolmentnewuser,core],[enrolmentnewuser,core_enrol]
    MOV [enrolments,core],[enrolments,core_enrol]
    MOV [enrolperiod,core],[enrolperiod,core_enrol]
    MOV [unenrolroleusers,core],[unenrolroleusers,core_enrol]
AMOS END
2010-06-21 15:30:49 +00:00
Petr Skoda 6b8ad965dc MDL-16919 we have to really use the username cleaning only when manually adding new accounts, any sync with external system needs the exact match without any cleaning! 2010-06-06 14:06:30 +00:00
Inaki 389d6f72b8 auth cas: MDL-20029 upgrade phpCAS version to the latest available version
Also make sure phpCAS doesn't try to start a new PHP session. We have already
started our own and want to keep it :). In addition to it, it emitted a PHP
notice that could block the authentication process under certain
configurations.

And pretty much the same with the wantsurl and loginguest checks.
2010-04-18 12:08:43 +00:00
Petr Skoda 2c10db3b3c MDL-22060 fixed $a in string to match new rules
AMOS START
 REM fixed $a[] in [auth_dbdeleteuser, auth_db]
 REM fixed $a[] in [auth_dbinsertuser, auth_db]
 REM fixed $a[] in [auth_dbreviveduser, auth_db]
 REM fixed $a[] in [auth_dbsuspenduser, auth_db]
 REM fixed $a[] in [auth_dbupdatinguser, auth_db]
AMOS END
2010-04-11 16:55:17 +00:00
Inaki b8fc9582e6 auth cas/db/ldap: MDL-18689 Fix typos in auth/{cas,db,ldap}/auth.php
Forward-ported from MOODLE_18_STABLE
2010-04-10 15:26:39 +00:00
Petr Skoda 4f0c2d0009 MDL-21655 big scary enrolment and roles improvements - see tacker for list of changes, includes other minor fixes too 2010-03-31 07:41:31 +00:00
Inaki 95cb3955a6 authentication plugins: MDL-21343 Add missing $OUTPUT global variables used in plugins' configuration pages 2010-01-14 18:54:12 +00:00
Rossiani Wijaya 07ed083e4e MDL-16919 - Allow username to contain alphanumeric lowercase characters, underscore (_), hyphen (-), period (.) or at symbol (@) 2010-01-13 06:23:54 +00:00
Petr Skoda 4454447d56 MDL-20700 whitespace terror returns 2009-12-16 22:14:17 +00:00
Petr Skoda edb5da8331 MDL-20934 'not cached' flag used in all auth plugins that do not need the password 2009-11-23 21:50:40 +00:00
Petr Skoda d5a8d9aa71 MDL-20625 new delegated transaction support in DML 2009-11-07 08:52:56 +00:00
Petr Skoda 5117d59899 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 11:55:14 +00:00
samhemelryk cfc5b79b86 auth MDL-19788 Upgraded print_header and build_navigation calls to use PAGE and OUTPUT equivilants 2009-09-03 05:40:41 +00:00
skodak ebdd9fed4b MDL-20169 fixed coding style, parameter type required 2009-08-27 08:49:54 +00:00
nicolasconnault 119550a5b2 MDL-19788 Converted all print_footer() calls 2009-08-06 14:23:04 +00:00
iarenaza afacbf004a CAS authentication: MDL-19671 phpCAS::getUser can return a mixed-case username, so lower-case it for comparison.
Merged from MOODLE_18_STABLE
2009-06-30 23:33:11 +00:00
jerome 2b06294b9a authentication MDL-19182 split auth.php lang file into multiple files separate for each plugin 2009-06-11 03:34:46 +00:00
skodak 3db835d1ae MDL-18744 cas fix, credit goes to Thibault Le Meur 2009-05-08 07:54:24 +00:00
stronk7 2a88f626f7 MDL-18577 drop enums support - step2: enums out from editor, dbmanager and all upgrade scripts. 2009-05-01 01:19:16 +00:00
iarenaza eee34307b9 Cache LDAP connections: MDL-18130 Properly handle open LDAP connections.
Both CAS and LDAP auth plugins open new connections to the LDAP server
to get the user account details. While this is the desired behaviour
for regular logins (we probably don't have an already open connection
to the LDAP server), this is a ressource hog when we are doing user
synchronization, as the closed connections remain in the TCP_WAIT
state for a while before the server can reuse them. If we are syncing
a lot of users, we can make the server run out of available TCP
ressources.

So we cache the connection the first time we establish it and return
the same connection handle everytime, unless we've closed all the
'open' connections, or the auth object is destroyed.

In addition to that, there were a few missing calls to ldap_close().
2009-02-15 15:03:33 +00:00
iarenaza 5261baf11e MDL-16061 Revert incorrect fix for "Remove 'username' from the $moodleattributes array"
Merged from MOODLE_18_STABLE.

The fix is wrong, as it breaks auth_db_sync_users.php and
auth_ldap_sync_users.php at least. No new users are added to Moodle, as the
username is missing from the new user info record.

The fix needs to go into update_user_record() in lib/moodlelib.php to make it
skip the 'username' key, as we really need get_userinfo() to return the
username as part of the user info array.
2008-08-25 22:44:45 +00:00
iarenaza 19ac43c7a6 MDL-16061 Remove 'username' from the $moodleattributes array.
It doesn't make sense at all (username is not part of the externally mapped
fields) and produces a notice that breaks HTTP headers with debugging enabled.
2008-08-15 11:22:57 +00:00
skodak df884cd852 MDL-15098 dml auth conversion 2008-06-07 15:41:25 +00:00
skodak 185721a498 MDL-14679 towards /admin/auth conversion 2008-05-31 13:57:49 +00:00
skodak be544ec380 MDL-14679 towards authlib conversion 2008-05-30 20:54:19 +00:00
skodak f33e1ed4ae MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs 2008-05-15 21:40:00 +00:00
skodak 59669b63f0 MDL-14543 fixed broken deleting from auth sync - credit goes to Juris Treibahs ; merged from MOODLE_19_STABLE 2008-04-25 13:22:02 +00:00
dongsheng 4105cafff9 MDL-12531, make the new member value available to all the affected plugins, thanks, Robert 2008-04-08 05:53:12 +00:00
dongsheng 6f87ef52b9 MDL-14055, change to human-readable strings from hard-coded integer, thanks for Matt's patch. 2008-03-26 01:35:04 +00:00
jgutierr25 c39e721374 Pb with autologinguest 2007-09-11 07:54:55 +00:00
jgutierr25 5128f0b3fa problem with autologinguest 2007-08-31 09:49:15 +00:00
skodak 90afcf3280 MDL-10260 added new user_delete() hook into auth plugins; refactored user delete code = new function delete_user() in moodlelib.php + improved cleanup in core tables when deleting user 2007-08-21 20:52:36 +00:00
nicolasconnault e295df447f MDL-10870 All files updated to new build_navigation() method. 2007-08-17 11:18:58 +00:00
jgutierr25 6dfddff7ce *** empty log message *** 2007-07-23 11:37:21 +00:00
jgutierr25 df5b8b8895 test if auth cas activated and no parameters 2007-07-17 12:08:26 +00:00
jgutierr25 017f1a617d *** empty log message *** 2007-07-17 11:46:19 +00:00
jgutierr25 f535ea21fd *** empty log message *** 2007-07-09 08:49:47 +00:00
jgutierr25 74c9f514ab pb case sensitive when get ldap attribute 2007-06-28 09:35:32 +00:00
jgutierr25 209596cb6a automatic authentication when direct access from another CAS application and multiauth 2007-06-05 08:35:57 +00:00