L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

auth/cas: MDL-25062 CAS authentication plugin does not validate the CAS server certificate

Browse Source 
If we enable the server validation but don't specify a certificate file path
flag the error and don't let the user save the settings.
This commit is contained in:
Inaki
2010-11-18 00:57:06 +00:00
parent 1a92193c7f
commit 40293947bb
3 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
auth/cas/auth.php
+13
View File
@@ -209,6 +209,19 @@ class auth_plugin_cas extends auth_plugin_ldap {
include($CFG->dirroot.'/auth/cas/config.html');
}
/**
* A chance to validate form data, and last chance to
* do stuff before it is inserted in config_plugin
* @param object object with submitted configuration settings (without system magic quotes)
* @param array $err array of error messages
*/
function validate_form(&$form, &$err) {
$certificate_path = trim($form->certificate_path);
if ($form->certificate_check && empty($certificate_path)) {
$err['certificate_path'] = get_string('auth_cas_certificate_path_empty', 'auth_cas');
}
}
/**
* Returns the URL for changing the user's pw, or empty if the default can
* be used.
auth/cas/config.html
+1 -1
View File
@@ -195,7 +195,7 @@ $yesno = array( get_string('no'), get_string('yes') );
<td align="right"><?php print_string('auth_cas_certificate_path_key', 'auth_cas') ?>:</td>
<td>
<input name="certificate_path" id="certificate_path" type="text" size="30" value="<?php echo $config->certificate_path ?>" />
<?php if (isset($err['certificate_path'])) formerr($err['certificate_path']); ?>
<?php if (isset($err['certificate_path'])) echo $OUTPUT->error_text($err['certificate_path']); ?>
</td>
<td>
<?php print_string('auth_cas_certificate_path', 'auth_cas') ?>
auth/cas/lang/en/auth_cas.php
+1
View File
@@ -32,6 +32,7 @@ $string['auth_cas_broken_password'] = 'You cannot proceed without changing your
$string['auth_cas_cantconnect'] = 'LDAP part of CAS-module cannot connect to server: {$a}';
$string['auth_cas_casversion'] = 'Version';
$string['auth_cas_certificate_check'] = 'Turn this to \'yes\' if you want to validate the server certificate';
$string['auth_cas_certificate_path_empty'] = 'If you turn on Server validation, you need to specify a certificate path';
$string['auth_cas_certificate_check_key'] = 'Server validation';
$string['auth_cas_certificate_path'] = 'Path of the CA chain file (PEM Format) to validate the server certificate';
$string['auth_cas_certificate_path_key'] = 'Certificate path';