Commit Graph

4882 Commits

Author SHA1 Message Date
Huong Nguyen b7a7263c17 Merge branch 'MDL-80087_403' of https://github.com/PhilippImhof/moodle into MOODLE_403_STABLE 2024-04-25 09:38:12 +07:00
Andrew Nicols a341231108 Merge branch 'MDL-81114_403' of https://github.com/timhunt/moodle into MOODLE_403_STABLE 2024-04-11 23:25:43 +08:00
Sara Arjona b6394a0b60 Merge branch 'MDL-81383_403' of https://github.com/timhunt/moodle into MOODLE_403_STABLE 2024-04-11 12:49:36 +02:00
Tim Hunt 6edfe1b415 MDL-81383 questions: get_filtered_questions order should be predictable
This method supports $limit and $offset paramters. The query must have
a predictable ORDER BY for that to make sense.
2024-04-11 10:27:41 +01:00
Andrew Nicols 59cf12eca4 Merge branch 'MDL-81227_403' of https://github.com/timhunt/moodle into MOODLE_403_STABLE 2024-04-11 10:59:53 +08:00
Luca Bösch 9c5db33257 MDL-81451 qtype_missingtype: adopt icon size to other. 2024-04-08 17:27:03 +02:00
Luca Bösch 2f5def5d83 MDL-81451 qtype_gapfill: adopt icon size to other. 2024-04-08 17:27:03 +02:00
Philipp Imhof e35eb6b9eb MDL-80087 Questions: warn if preload_all_step_users was not called
Co-authored-by: Tim Hunt <T.J.Hunt@open.ac.uk>
2024-03-15 19:41:04 +01:00
Tim Hunt bf505f1075 MDL-81227 question bank: improve the order of the action menu 2024-03-14 17:38:02 +00:00
Tim Hunt 81fafbc199 MDL-81039 qtype_multichoice: better way to control feedback display 2024-03-12 12:00:05 +01:00
Tim Hunt 842dd9f729 MDL-81039 question: Improve some comments in question_display_options 2024-03-12 12:00:00 +01:00
Tim Hunt 36e03243da MDL-81114 question: fix selection of random questions with draft status
We need to pick the latest 'ready' version of each question
(not questions where the latest version is ready).

There are test of the behaviour of random_question_loader, and
then a test in the quiz to prove it works in use.
2024-03-11 10:45:19 +00:00
Tim Hunt db8d3fef9c MDL-81114 question: clarify the SQL in ensure_filtered_questions_loaded
This should not change the (currently buggy) behaviour at all,
but my brain needs this to understand how to fix the bug.
2024-03-08 19:31:32 +00:00
Tim Hunt 14ce932d9a MDL-81114 question: fix coding style in random_question_loader_test 2024-03-08 19:31:32 +00:00
Tim Hunt dcff2a039f MDL-78547 quiz: in a preview, if a question has been edited, update it
As part of implementing this, there is a new more efficient method
get_version_information_for_questions_in_attempt to see if any
questions in a quiz need to be updated. The regrade code was updated
to take advantage of this.

Co-authored-by: Khoa Nguyen Dang <khoanguyend7@nashtechglobal.com>
2024-03-07 16:13:01 +00:00
Tim Hunt 189464ade2 MDL-78547 questions: a way to replace a attempt in a usage
... without keeping the old attempt

Co-authored-by: Khoa Nguyen Dang <khoanguyend7@nashtechglobal.com>
2024-03-07 16:13:01 +00:00
Matthias Opitz 997ca5d78e MDL-52891 calculatedsimple question: forcing new gen. values into form
* forcing new generated sets of wildcard values into the question edit form so they can be saved.
* added Behat test to check new generated values are used.
2024-02-27 11:13:26 +00:00
Jun Pataleta a8fa0e61ac Merge branch 'MDL-79003-403' of https://github.com/andrewnicols/moodle into MOODLE_403_STABLE 2024-02-21 10:36:10 +08:00
Huong Nguyen ae17dcde01 MDL-76024 qtype calculated: Fix deprecation related to dynamic property 2024-02-20 12:29:31 +01:00
Matthias Opitz 5e3470fd4a MDL-76024 calculated questions: improving coding style 2024-02-16 10:22:07 +00:00
Matthias Opitz c93271e1d6 MDL-76024 calculated questions: cast float type before comparison
* added calculated question for multiplication to tests/helper.php.
* added test_grading_of_negative_responses() test to question/type/calculated/tests/question_test.php
2024-02-16 10:22:07 +00:00
Andrew Nicols 2264b79dbe Merge branch 'MDL-36733-MOODLE_403_STABLE' of https://github.com/PascalHamar/moodle into MOODLE_403_STABLE 2024-02-08 16:06:12 +08:00
Ilya Tregubov f8d5db3ea7 Merge branch 'MDL-79527_403' of https://github.com/timhunt/moodle into MOODLE_403_STABLE 2024-02-07 09:28:28 +08:00
Tim Hunt eee0a8e89f MDL-79527 questions: category tree loading handling bad data
It should always be the case that a question category and its parent
category belong to the same context. However, over the years, we have
observed that this becomes violated by some data in some Moodle sites.
(The suspicion is that this is a backup/restor bug of some sort which
has never been tracked down.)

Since this happens, we should make the code robust to it, which is what
this change does. It ensure that when loading child categories, we only
consider ones in the same context.
2024-02-02 11:35:23 +00:00
Tim Hunt 6505fbbdb1 MDL-80537 question bank: escape plain text display of question text 2024-02-01 16:26:54 +00:00
Andrew Nicols 6038897710 MDL-79003 js: Use our own jsdoc wrapper
grunt-jsdoc is abandoned and only works with an older version of jsdoc.

This is a very simple wrapper around jsdoc itself.

This commit also includes a fix for broken docs.
2024-01-30 12:21:01 +08:00
Ilya Tregubov 67666fda0e MDL-79708 question_bank: Fix legacy filter condition.
build_query_from_filter method expects includesubcategories
to be inside filteroptions array
2023-12-11 11:49:45 +08:00
Huong Nguyen 9a1a58e593 Merge branch 'MDL-77136-403' of https://github.com/lucaboesch/moodle into MOODLE_403_STABLE 2023-12-07 08:36:35 +07:00
Jun Pataleta b38413afe4 Merge branch 'MDL-80127_403' of https://github.com/timhunt/moodle into MOODLE_403_STABLE 2023-12-06 22:12:17 +08:00
Jun Pataleta 05ab53734b Merge branch 'MDL-80079-403' of https://github.com/andrewnicols/moodle into MOODLE_403_STABLE 2023-12-06 21:59:11 +08:00
Luca Bösch 708732ed72 MDL-77136 qtype_randomsamatch: Newest versions for shortanswer questions 2023-12-06 14:14:14 +01:00
Luca Bösch 121d6fb20a MDL-77136 core_question: Newest versions get_questions_from_categories 2023-12-06 14:14:14 +01:00
Tim Hunt e4acb387bb MDL-80127 question engine: prevent fatal errors from old bad data 2023-12-06 11:38:58 +00:00
Tim Hunt ff74bb2682 MDL-80127 question engine: don't convert null to '' before storing 2023-12-06 11:38:58 +00:00
Pascal Hamar 015b2a0cd8 MDL-36733 qtype_calculated: Wildcards in calculated question hints
The placeholders for the hints are properly replaced by this change and any formulas present are replaced.

The validation is performed by the existing function qtype_calculated_find_formula_errors(),
which is called by the calculate() function,
which in turn is called by the variable substituter "vs" using the replace_expressions_in_text() function.

vs -> replace_expressions_in_text() -> calculate() -> qtype_calculated_find_formula_errors().
2023-11-28 18:41:33 +01:00
Helen Foster 42022a1d26 MDL-80221 lang: Import fixed English strings (en_fix) 2023-11-24 18:30:16 +01:00
Andrew Nicols 136bd2c4c4 MDL-80079 core: Correct incorrect arg to format_string::$options 2023-11-14 22:28:55 +08:00
Mark Johnson 07a6698d01 MDL-79639 quiz_statistics: Prevent database deadlocks
This changes the cache purge code to select IDs for deletion
first, rather than using a subquery in a DELETE, since this
risks causing a deadlock in MySQL.
2023-10-19 08:57:34 +01:00
Jun Pataleta 2b5073a222 MDL-79626 upgrade: add the 4.3.0 separation line to all upgrade scripts 2023-10-11 09:40:13 +08:00
Paul Holden 228ee621e6 Merge branch 'MDL-79642-q_tags_off-403' of https://github.com/leonstr/moodle into MOODLE_403_STABLE 2023-10-10 21:18:55 +01:00
Leon Stringer 7cba44007c MDL-79642 qbank_tagquestion: Fix Return type err
Previously if $CFG->usetags was not enabled the course question bank
page would show:

  Exception - qbank_tagquestion\plugin_feature::get_question_filters():
  Return value must be of type array, none returned

This is now fixed.
2023-10-10 12:13:56 +01:00
Ilya Tregubov e857efcf28 Merge branch 'MDL-79279' of https://github.com/timhunt/moodle into MOODLE_403_STABLE 2023-10-10 11:20:58 +08:00
Jun Pataleta 98ac14eecb Merge branch 'MDL-79531-master-1' of https://github.com/mihailges/moodle 2023-10-05 07:37:02 +08:00
Mihail Geshoski 451614016e MDL-79531 mod_quiz: Fix exception when adding random questions
Moves the data-filtercondition property to an element that always
exists regardless of whether the selected category from the filter
has questions or not. This will effectively solve the exception
that is being thrown due to the non-existing element and also
enable creation of random questions in a category that does not
have any questions yet. Also, the data-filtercondition attribute
is no longer used when creating a random question in a new category
as this value is not relevant in this case. Instead, a default
filter condition is generated in the webservice for the random
question based on the newly created category.
2023-10-04 12:31:12 +02:00
Sara Arjona 9877a06246 Merge branch 'MDL-79551-master-rc' of https://github.com/junpataleta/moodle 2023-10-04 12:28:14 +02:00
Jun Pataleta d5d7835a0a MDL-79551 versions: Make CiBoT happy
* Use array short syntax for $plugin->dependencies
* Add trailing comma for multi-line $plugin->dependencies array
2023-10-04 14:04:29 +08:00
Jun Pataleta 94bc2cd38b MDL-79551 versions: bump all versions and requires near release 2023-10-04 13:57:17 +08:00
Sara Arjona 4101c5ee2a Merge branch 'MDL-69119_angle_bracket_character_in_answers_not_escaped_in_moodle_xml_export_of_multiple_choice_calculated_questions' of https://github.com/ziegenberg/moodle 2023-10-04 07:51:30 +02:00
Jake Dallimore e430e16c44 Merge branch 'MDL-79466_master' of https://github.com/marxjohnson/moodle 2023-10-04 10:21:08 +08:00
Daniel Ziegenberg 55ef05579b MDL-69119 qformat_xml: fix mc calculated export
The Moodle XML export of multiple choice calculated questions was
missing proper escaping of answers. Also the indentation of the
generated xml was off.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
2023-10-03 12:18:11 +02:00