L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-81114 question: clarify the SQL in ensure_filtered_questions_loaded

Browse Source 
This should not change the (currently buggy) behaviour at all,
but my brain needs this to understand how to fix the bug.
This commit is contained in:
Tim Hunt
2024-03-08 19:31:32 +00:00
parent 14ce932d9a
commit db8d3fef9c
1 changed files with 41 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/classes/local/bank/random_question_loader.php
+41 -41
View File
@@ -186,69 +186,69 @@ class random_question_loader {
protected function ensure_filtered_questions_loaded(array $filters) {
global $DB;
// Check if this is already done.
$key = $this->get_filtered_questions_key($filters);
if (isset($this->availablequestionscache[$key])) {
// Data is already in the cache, nothing to do.
return;
}
[$extraconditions, $extraparams] = $DB->get_in_or_equal($this->excludedqtypes,
SQL_PARAMS_NAMED, 'excludedqtype', false);
$previoussql = "SELECT COUNT(1)
FROM " . $this->qubaids->from_question_attempts('qa') . "
WHERE qa.questionid = q.id AND " . $this->qubaids->where();
$previousparams = $this->qubaids->from_where_params();
// Latest version.
$latestversionsql = "SELECT MAX(v.version)
FROM {question_versions} v
JOIN {question_bank_entries} be ON be.id = v.questionbankentryid
WHERE be.id = qbe.id";
$sql = "SELECT q.id, ($previoussql) AS previous_attempts
FROM {question} q
JOIN {question_versions} qv ON qv.questionid = q.id
JOIN {question_bank_entries} qbe ON qbe.id = qv.questionbankentryid
WHERE ";
$where = [
'q.parent = :noparent',
'qv.status = :ready',
"qv.version = ($latestversionsql)",
];
$params = array_merge(
$previousparams,
['noparent' => 0, 'ready' => question_version_status::QUESTION_STATUS_READY]);
// Get current enabled condition classes.
$conditionclasses = \core_question\local\bank\filter_condition_manager::get_condition_classes();
// Build filter conditions.
foreach ($conditionclasses as $conditionclass) {
$params = [];
$filterconditions = [];
foreach (filter_condition_manager::get_condition_classes() as $conditionclass) {
$filter = $conditionclass::get_filter_from_list($filters);
if (is_null($filter)) {
continue;
}
[$filterwhere, $filterparams] = $conditionclass::build_query_from_filter($filter);
if (!empty($filterwhere)) {
$where[] = '(' . $filterwhere . ')';
$filterconditions[] = '(' . $filterwhere . ')';
}
if (!empty($filterparams)) {
$params = array_merge($params, $filterparams);
}
}
$filtercondition = $filterconditions ? 'AND ' . implode(' AND ', $filterconditions) : '';
// Extra conditions.
if ($extraconditions) {
$where[] = 'q.qtype ' . $extraconditions;
$params = array_merge($params, $extraparams);
// Prepare qtype check.
[$qtypecondition, $qtypeparams] = $DB->get_in_or_equal($this->excludedqtypes,
SQL_PARAMS_NAMED, 'excludedqtype', false);
if ($qtypecondition) {
$qtypecondition = 'AND q.qtype ' . $qtypecondition;
}
// Build query.
$sql .= implode(' AND ', $where);
$sql .= "ORDER BY previous_attempts";
$questionidsandcounts = $DB->get_records_sql_menu("
SELECT q.id,
(
SELECT COUNT(1)
FROM {$this->qubaids->from_question_attempts('qa')}
WHERE qa.questionid = q.id AND {$this->qubaids->where()}
) AS previous_attempts
$questionidsandcounts = $DB->get_records_sql_menu($sql, $params);
FROM {question} q
JOIN {question_versions} qv ON qv.questionid = q.id
JOIN {question_bank_entries} qbe ON qbe.id = qv.questionbankentryid
WHERE q.parent = :noparent
AND qv.status = :ready
AND qv.version = (
SELECT MAX(v.version)
FROM {question_versions} v
JOIN {question_bank_entries} be ON be.id = v.questionbankentryid
WHERE be.id = qbe.id
)
$qtypecondition
$filtercondition
ORDER BY previous_attempts
", array_merge(
$params,
$this->qubaids->from_where_params(),
['noparent' => 0, 'ready' => question_version_status::QUESTION_STATUS_READY],
$qtypeparams,
));
if (!$questionidsandcounts) {
// No questions in this category.