L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-4746 - Course 01 of the ADL SCORM 1.2 test suite fails on point 4. Fix cmi.comments, and mastery_score checking. Backport to 1.8.

Browse Source
This commit is contained in:
piers
2008-08-27 02:53:27 +00:00
parent 6e5dfc1b4b
commit fff59beb90
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lang/en_utf8/scorm.php
+1 -1
View File
@@ -88,7 +88,7 @@ $string['no_children'] = 'Tag $a->tag must have children';
$string['noactivity'] = 'Nothing to report';
$string['nolimit'] = 'Unlimited attempts';
$string['nomanifest'] = 'Manifest not found';
$string['noprerequisites'] = 'Sorry but you don\'t reach enough prerequisites to access this learning object';
$string['noprerequisites'] = 'Sorry but you haven\'t reach enough prerequisites to access this learning object';
$string['noreports'] = 'No report to display';
$string['normal'] = 'Normal';
$string['noscriptnoscorm'] = 'Your browser does not support javascript or it has javascript support disabled. No tracks will recorded.';
mod/scorm/datamodels/scorm_12.js.php
+2 -2
View File
@@ -375,7 +375,7 @@ function SCORMapi1_2() {
}
} else {
if (element == 'cmi.comments') {
eval(element+'=value;');
cmi.comments = cmi.comments + value;
} else {
eval(element+'=value;');
}
@@ -578,7 +578,7 @@ function SCORMapi1_2() {
if (cmi.core.lesson_mode == 'normal') {
if (cmi.core.credit == 'credit') {
if (cmi.core.lesson_status == 'completed') {
if (cmi.student_data.mastery_score != '') {
if (cmi.student_data.mastery_score != '' && cmi.core.score.raw != '') {
if (parseFloat(cmi.core.score.raw) >= parseFloat(cmi.student_data.mastery_score)) {
cmi.core.lesson_status = 'passed';
} else {