L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-42625 behat: Wrapping select an option extra actions in a try & catch

Browse Source 
To select an option is specially painful, every browser
behaves differently and phantomjs just joined the party
throwing "Element does not exist in cache" random
exceptions that we need to catch.
This commit is contained in:
David Monllao
2013-12-12 12:16:45 +01:00
committed by Eloy Lafuente (stronk7)
parent bdd5a6c5c2
commit fff500c727
1 changed files with 27 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/behat/form_field/behat_form_select.php
+27 -6
View File
@@ -101,21 +101,42 @@ class behat_form_select extends behat_form_field {
// with elements inside containers.
$optionnodes = $this->session->getDriver()->find($optionxpath);
if ($optionnodes) {
current($optionnodes)->click();
// Wrapped in a try & catch as we can fall into race conditions
// and the element may not be there.
try {
current($optionnodes)->click();
} catch (Exception $e) {
// We continue and return as this means that the element is not there or it is not the same.
return;
}
}
} else {
// Multiple ones needs the click in the select.
$this->field->click();
// Wrapped in a try & catch as we can fall into race conditions
// and the element may not be there.
try {
// Multiple ones needs the click in the select.
$this->field->click();
} catch (Exception $e) {
// We continue and return as this means that the element is not there or it is not the same.
return;
}
// We ensure that the option is still there.
if (!$this->session->getDriver()->find($optionxpath)) {
return;
}
// Repeating the select as some drivers (chrome that I know) are moving
// to another option after the general select field click above.
$this->field->selectOption($value);
// Wrapped in a try & catch as we can fall into race conditions
// and the element may not be there.
try {
// Repeating the select as some drivers (chrome that I know) are moving
// to another option after the general select field click above.
$this->field->selectOption($value);
} catch (Exception $e) {
// We continue and return as this means that the element is not there or it is not the same.
return;
}
}
}