L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

moodlelib: sync_metacourse MDL-20626 wasn't respecting hidden role assignments

Browse Source 
This causes hidden role assignments to become public on metacourses

Many thanks to Daniel Neis for the patch

forward ported from MOODLE_19_STABLE
Signed-off-by: Dan Poltawski <[email protected]>
This commit is contained in:
Dan Poltawski
2010-02-24 09:03:11 +00:00
parent 209a123509
commit ff297eca79
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/moodlelib.php
+2 -2
View File
@@ -2957,7 +2957,7 @@ function sync_metacourse($course) {
// Get assignments of a user to a role that exist in a child course, but
// not in the meta coure. That is, get a list of the assignments that need to be made.
if (!$assignments = $DB->get_records_sql("
SELECT ra.id, ra.roleid, ra.userid
SELECT ra.id, ra.roleid, ra.userid, ra.hidden
FROM {role_assignments} ra, {context} con, {course_meta} cm
WHERE ra.contextid = con.id AND
con.contextlevel = ".CONTEXT_COURSE." AND
@@ -3005,7 +3005,7 @@ function sync_metacourse($course) {
// Make the assignments.
foreach ($assignments as $assignment) {
$success = role_assign($assignment->roleid, $assignment->userid, 0, $context->id) && $success;
$success = role_assign($assignment->roleid, $assignment->userid, 0, $context->id, 0, 0, $assignment->hidden) && $success;
}
return $success;