MDL-70941 contentbank: fix empty equality check when renaming content

contentbank/classes/content.php

@@ -140,7 +140,7 @@ abstract class content {
      */
     public function set_name(string $name): bool {
         $name = trim($name);
-        if (empty($name)) {
+        if ($name === '') {
             return false;
         }
 

contentbank/classes/external/rename_content.php

@@ -87,7 +87,7 @@ class rename_content extends external_api {
                 $content = new $contentclass($record);
                 // Check capability.
                 if ($contenttype->can_manage($content)) {
-                    if (empty(trim($name))) {
+                    if (trim($params['name']) === '') {
                         // If name is empty don't try to rename and return a more detailed message.
                         $warnings[] = [
                             'item' => $contentid,

contentbank/tests/contenttype_test.php

@@ -464,6 +464,7 @@ class core_contenttype_contenttype_testcase extends \advanced_testcase {
             'Too long name' => [str_repeat('a', 300), str_repeat('a', 255), true],
             'Empty name' => ['', 'Test content ', false],
             'Blanks only' => ['  ', 'Test content ', false],
+            'Zero name' => ['0', '0', true],
         ];
     }
 

contentbank/tests/external/rename_content_test.php

@@ -60,6 +60,7 @@ class rename_content_testcase extends \externallib_advanced_testcase {
             'Too long name' => [str_repeat('a', 300), str_repeat('a', 255), true],
             'Empty name' => ['', 'Test content ', false],
             'Blanks only' => ['  ', 'Test content ', false],
+            'Zero name' => ['0', '0', true],
         ];
     }