L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-85858 mod_scorm: Set page and iframe titles for the SCORM player

Browse Source
This commit is contained in:
Jun Pataleta
2025-11-28 10:22:23 +08:00
parent 52c6473e16
commit fda49855b8
2 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/mod/scorm/module.js
+1
View File
@@ -192,6 +192,7 @@ M.mod_scorm.init = function(Y, nav_display, navposition_left, navposition_top, h
obj.setAttribute('allowfullscreen', 'allowfullscreen');
obj.setAttribute('webkitallowfullscreen', 'webkitallowfullscreen');
obj.setAttribute('mozallowfullscreen', 'mozallowfullscreen');
obj.setAttribute('title', toc_title);
if (!window_name && node.title != null) {
obj.setAttribute('src', url_prefix + node.title);
}
public/mod/scorm/player.php
+19 -5
View File
@@ -106,12 +106,19 @@ $strexit = get_string('exitactivity', 'scorm');
$coursecontext = context_course::instance($course->id);
$scormname = format_string($scorm->name);
if ($mode === 'browse') {
$scormname = get_string('browsemodewithname', 'scorm', $scormname);
}
$titleparts = [
$scormname,
format_string($course->shortname, true, ['context' => $coursecontext]),
];
$PAGE->set_title(implode(moodle_page::TITLE_SEPARATOR, $titleparts));
if ($displaymode == 'popup') {
$PAGE->set_pagelayout('embedded');
} else {
$shortname = format_string($course->shortname, true, array('context' => $coursecontext));
$pagetitle = strip_tags("$shortname: ".format_string($scorm->name));
$PAGE->set_title($pagetitle);
$PAGE->set_heading($course->fullname);
}
if (!$cm->visible and !has_capability('moodle/course:viewhiddenactivities', context_module::instance($cm->id))) {
@@ -258,8 +265,15 @@ if ($result->prerequisites) {
js_writer::function_call('scorm_openpopup', Array($url->out(false),
$name, $scorm->options,
$scorm->width, $scorm->height)));
echo html_writer::tag('noscript', html_writer::tag('iframe', '', array('id' => 'main',
'class' => 'scoframe', 'name' => 'main', 'src' => 'loadSCO.php?id='.$cm->id.$scoidstr.$modestr)));
$frametitle = $result->toctitle ?? get_string('contents', 'scorm');
$iframe = html_writer::tag('iframe', '', [
'id' => 'main',
'class' => 'scoframe',
'name' => 'main',
'src' => 'loadSCO.php?id=' . $cm->id . $scoidstr . $modestr,
'title' => $frametitle,
]);
echo html_writer::tag('noscript', $iframe);
}
} else {
echo $OUTPUT->box(get_string('noprerequisites', 'scorm'));