MDL-24059 stripslashes TODO notes

This commit is contained in:
Petr Skoda
2010-09-02 12:57:04 +00:00
parent 00521032e9
commit fd8a6a7354
2 changed files with 2 additions and 2 deletions
+1 -1
View File
@@ -267,7 +267,7 @@
$value .= $datarow."\r\n";
next($datarows);
}
$value = rawurlencode(stripslashes($value));
$value = rawurlencode(stripslashes($value)); // TODO: this is probably wrong, the stripslashes() has undefined meaning now; was this related to JS quoting or magic quotes?
$id = scorm_insert_track($USER->id, $scorm->id, $sco->id, $attempt, $element, $value);
}
}
+1 -1
View File
@@ -431,7 +431,7 @@ function scorm_get_tracks($scoid,$userid,$attempt='') {
$usertrack->timemodified = 0;
foreach ($tracks as $track) {
$element = $track->element;
$track->value = stripslashes($track->value);
$track->value = stripslashes($track->value); // TODO: this is probably wrong, the stripslashes() has undefined meaning now; was this related to JS quoting or magic quotes?
$usertrack->{$element} = $track->value;
switch ($element) {
case 'cmi.core.lesson_status':