L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-67058 h5p: Correct PHPUNIT_LONGTEST usage

Browse Source
This commit is contained in:
Andrew Nicols
2019-11-08 15:48:58 +08:00
parent fd9333ca93
commit fc0ded848c
2 changed files with 3 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
h5p/tests/h5p_core_test.php
+2 -14
View File
@@ -50,19 +50,13 @@ class h5p_core_test extends \advanced_testcase {
/**
* Check that given an H5P content type machine name, the required library are fetched and installed from the official H5P
* repository.
*
* This test require access to an external URL (H5P libraries repository), so can take long time to execute.
* PHPUNIT_LONGTEST constant should be set in phpunit.xml or directly in config.php.
* define('PHPUNIT_LONGTEST', true);
*
* return void
*/
public function test_fetch_content_type(): void {
global $DB;
$this->resetAfterTest(true);
if (!defined('PHPUNIT_LONGTEST')) {
if (!PHPUNIT_LONGTEST) {
$this->markTestSkipped('PHPUNIT_LONGTEST is not defined');
}
@@ -91,19 +85,13 @@ class h5p_core_test extends \advanced_testcase {
/**
* Test that latest version of non installed H5P content type libraries are fetched and installed from the
* official H5P repository. To speed up the test, only if checked that one content type is installed.
*
* This test require access to an external URL (H5P libraries repository), so can take long time to execute.
* PHPUNIT_LONGTEST constant should be set in phpunit.xml or directly in config.php.
* define('PHPUNIT_LONGTEST', true);
*
* return void
*/
public function test_fetch_latest_content_types(): void {
global $DB;
$this->resetAfterTest(true);
if (!defined('PHPUNIT_LONGTEST')) {
if (!PHPUNIT_LONGTEST) {
$this->markTestSkipped('PHPUNIT_LONGTEST is not defined');
}
lib/tests/h5p_get_content_types_task_test.php
+1 -6
View File
@@ -38,15 +38,10 @@ class h5p_get_content_types_task_test extends advanced_testcase {
/**
* Test task execution
*
* This test require access to an external URL (H5P libraries repository), so can take long time to execute.
* PHPUNIT_LONGTEST constant should be set in phpunit.xml or directly in config.php.
* define('PHPUNIT_LONGTEST', true);
*
* return void
*/
public function test_task_execution(): void {
if (!defined('PHPUNIT_LONGTEST')) {
if (!PHPUNIT_LONGTEST) {
$this->markTestSkipped('PHPUNIT_LONGTEST is not defined');
}