Fix for bug 2648: call-time pass by reference has been deprecated, the constructor

of search_lexer now accepts the parser argument by reference all... one time it's called :)

lib/searchlib.php

@@ -44,7 +44,7 @@ class search_token {
 
 class search_lexer extends Lexer{
 
-  function search_lexer($parser){
+  function search_lexer(&$parser){
 
     // Call parent constructor.
     $this->Lexer($parser);

mod/forum/lib.php

@@ -1031,7 +1031,7 @@ function forum_search_posts($searchterms, $courseid, $page=0, $recordsperpage=50
     // by the parser, but this should be examined carefully for security implications.
     $searchstring = str_replace("\\\"","\"",$searchstring);
     $parser = new search_parser();
-    $lexer = new search_lexer(&$parser);
+    $lexer = new search_lexer($parser);
 
     if ($lexer->parse($searchstring)) {
         $parsearray = $parser->get_parsed_array();