L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'MDL-88003-main' of https://github.com/sarjona/moodle

Browse Source
This commit is contained in:
Sara Arjona
2026-03-06 09:04:34 +07:00
committed by Huong Nguyen
parent fd32880e0b 6ea3b1410f
commit f76784be42
2 changed files with 73 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
public/course/classes/route/controller/course_navigation.php
+3 -1
View File
@@ -143,7 +143,9 @@ class course_navigation {
// Skip modules that don't have a URL (like labels).
!empty($cm->get_url())
// Skip modules that are not visible to the user.
&& $cm->is_visible_on_course_page();
&& $cm->is_visible_on_course_page()
// Skip modules that are not displayable.
&& modinfo::is_mod_type_visible_on_course($cm->modname);
}
/**
public/course/tests/route/controller/course_navigation_test.php
+70
View File
@@ -566,6 +566,41 @@ final class course_navigation_test extends route_testcase {
'statuscode' => 404,
],
];
yield 'With module not supporting FEATURE_CAN_DISPLAY (student)' => [
'cmsdef' => [
['name' => 'cm1'],
['name' => 'cm2', 'type' => 'qbank'],
['name' => 'cm3'],
],
'current' => 'cm1',
'expected' => [
'id' => 'cm3', // The cm2 should be skipped as it does not support FEATURE_CAN_DISPLAY.
],
];
yield 'With module not supporting FEATURE_CAN_DISPLAY (teacher)' => [
'cmsdef' => [
['name' => 'cm1'],
['name' => 'cm2', 'type' => 'qbank'],
['name' => 'cm3'],
],
'current' => 'cm1',
'expected' => [
'id' => 'cm3', // The cm2 should be skipped as it does not support FEATURE_CAN_DISPLAY.
],
'role' => 'teacher',
];
yield 'With module not supporting FEATURE_CAN_DISPLAY (editingteacher)' => [
'cmsdef' => [
['name' => 'cm1'],
['name' => 'cm2', 'type' => 'qbank'],
['name' => 'cm3'],
],
'current' => 'cm1',
'expected' => [
'id' => 'cm3', // The cm2 should be skipped as it does not support FEATURE_CAN_DISPLAY.
],
'role' => 'editingteacher',
];
}
/**
@@ -1032,6 +1067,41 @@ final class course_navigation_test extends route_testcase {
'statuscode' => 404,
],
];
yield 'With module not supporting FEATURE_CAN_DISPLAY (student)' => [
'cmsdef' => [
['name' => 'cm1'],
['name' => 'cm2', 'type' => 'qbank'],
['name' => 'cm3'],
],
'current' => 'cm3',
'expected' => [
'id' => 'cm1', // The cm2 should be skipped as it does not support FEATURE_CAN_DISPLAY.
],
];
yield 'With module not supporting FEATURE_CAN_DISPLAY (teacher)' => [
'cmsdef' => [
['name' => 'cm1'],
['name' => 'cm2', 'type' => 'qbank'],
['name' => 'cm3'],
],
'current' => 'cm3',
'expected' => [
'id' => 'cm1', // The cm2 should be skipped as it does not support FEATURE_CAN_DISPLAY.
],
'role' => 'teacher',
];
yield 'With module not supporting FEATURE_CAN_DISPLAY (editingteacher)' => [
'cmsdef' => [
['name' => 'cm1'],
['name' => 'cm2', 'type' => 'qbank'],
['name' => 'cm3'],
],
'current' => 'cm3',
'expected' => [
'id' => 'cm1', // The cm2 should be skipped as it does not support FEATURE_CAN_DISPLAY.
],
'role' => 'editingteacher',
];
}
/**