backup MDL-22142 P18 - Removed unused ui related function and params from core backup classes

backup/controller/backup_controller.class.php

@@ -127,12 +127,6 @@ class backup_controller extends backup implements loggable {
         }
     }
 
-    public function show_ui() {
-    }
-
-    public function process_ui() {
-    }
-
     public function finish_ui() {
         if ($this->status != backup::STATUS_SETTING_UI) {
             throw new backup_controller_exception('cannot_finish_ui_if_not_setting_ui');

backup/util/settings/base_setting.class.php

@@ -72,18 +72,14 @@ abstract class base_setting {
     protected $dependencies; // array of dependent (observer) objects (usually setting_base ones)
 
     /**
-     *
+     * The user interface for this setting
      * @var backup_setting_ui|backup_setting_ui_checkbox|backup_setting_ui_radio|backup_setting_ui_select|backup_setting_ui_text
      */
     protected $uisetting;
 
-    // Note: all the UI stuff could go to independent classes in the future...
-    protected $ui_type;   // setting_base::UI_HTML_CHECKBOX/setting_base::UI_HTML_RADIOBUTTON...
-    protected $ui_label;  // UI label of the setting
-    protected $ui_values; // array of value => ui value of the setting
-    protected $ui_options;// array of custom ui options
-
     /**
+     * An array that contains the identifier and component of a help string if one
+     * has been set
      * @var array
      */
     protected $help = array();