MDL-75177 reportbuilder: preload context data for column callback.

Improve performance/reduce query count by requesting all necessary data as part of initial column SQL. See also dc60fe66.
2022-12-14 09:52:55 +00:00
parent 40a89d8a9a
commit f550239e78
1 changed files with 10 additions and 2 deletions
@@ -100,11 +100,19 @@ class course_category extends base {
            $this->get_entity_name()
        ))
            ->add_joins($this->get_joins())
+            ->add_join($this->get_context_join())
            ->set_type(column::TYPE_TEXT)
            ->add_fields("{$tablealias}.name, {$tablealias}.id")
+            ->add_fields(context_helper::get_preload_record_columns_sql($tablealiascontext))
            ->add_callback(static function(?string $name, stdClass $category): string {
-                return empty($category->id) ? '' :
-                    core_course_category::get($category->id, MUST_EXIST, true)->get_formatted_name();
+                if (empty($category->id)) {
+                    return '';
+                }
+
+                context_helper::preload_from_record($category);
+                $context = context_coursecat::instance($category->id);
+
+                return format_string($category->name, true, ['context' => $context]);
            })
            ->set_is_sortable(true);