L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-79373 admin: ensure all current password configs are defined.

Browse Source 
Ensure the admin preset export tool has an accurate record of each,
to be observed as sensitive settings when creating an export.
This commit is contained in:
Paul Holden
2024-08-08 09:21:50 +07:00
committed by Huong Nguyen
parent 68dacb79dc
commit f4d0fd92e8
3 changed files with 27 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/settings/security.php
+3 -1
View File
@@ -152,7 +152,9 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
$sensiblesettingsdefault .= 'server_password@@search_solr, ssl_keypassword@@search_solr, ';
$sensiblesettingsdefault .= 'alternateserver_password@@search_solr, alternatessl_keypassword@@search_solr, ';
$sensiblesettingsdefault .= 'test_password@@cachestore_redis, password@@mlbackend_python, ';
$sensiblesettingsdefault .= 'badges_badgesalt@@none, calendar_exportsalt@@none';
$sensiblesettingsdefault .= 'badges_badgesalt@@none, calendar_exportsalt@@none, ';
$sensiblesettingsdefault .= 'bigbluebuttonbn_shared_secret@@none, apikey@@tiny_premium, ';
$sensiblesettingsdefault .= 'matrixaccesstoken@@communication_matrix, api_secret@@factor_sms';
$temp->add(new admin_setting_configtextarea('adminpresets/sensiblesettings',
get_string('sensiblesettings', 'core_adminpresets'),
get_string('sensiblesettingstext', 'core_adminpresets'),
lib/db/upgrade.php
+23
View File
@@ -1217,5 +1217,28 @@ function xmldb_main_upgrade($oldversion) {
upgrade_main_savepoint(true, 2024072600.01);
}
if ($oldversion < 2024080500.00) {
// Fix missing default admin presets "sensible settings" (those that should be treated as sensitive).
$newsensiblesettings = [
'bigbluebuttonbn_shared_secret@@none',
'apikey@@tiny_premium',
'matrixaccesstoken@@communication_matrix',
'api_secret@@factor_sms',
];
$sensiblesettings = get_config('adminpresets', 'sensiblesettings');
foreach ($newsensiblesettings as $newsensiblesetting) {
if (strpos($sensiblesettings, $newsensiblesetting) === false) {
$sensiblesettings .= ", {$newsensiblesetting}";
}
}
set_config('sensiblesettings', $sensiblesettings, 'adminpresets');
// Main savepoint reached.
upgrade_main_savepoint(true, 2024080500.00);
}
return true;
}
version.php
+1 -1
View File
@@ -29,7 +29,7 @@
defined('MOODLE_INTERNAL') || die();
$version = 2024080200.00; // YYYYMMDD = weekly release date of this DEV branch.
$version = 2024080500.00; // YYYYMMDD = weekly release date of this DEV branch.
// RR = release increments - 00 in DEV branches.
// .XX = incremental changes.
$release = '4.5dev (Build: 20240802)'; // Human-friendly version name