MDL-42571 editpdf: Fix comments search and multiple views drawing

This commit is contained in:
David Monllao
2015-11-19 12:56:26 +08:00
committed by Andrew Nicols
parent 014be0ff8b
commit f4b608041c
5 changed files with 17 additions and 17 deletions
@@ -2224,7 +2224,7 @@ Y.extend(COMMENTSEARCH, M.core.dialogue, {
commentlist = Y.Node.create('<ul role="menu" class="assignfeedback_editpdf_menu"/>');
container.append(commentlist);
commentfilter.on('keyup', this.filter_search_comments, null, this);
commentfilter.on('keyup', this.filter_search_comments, this);
commentlist.delegate('click', this.focus_on_comment, 'a', this);
commentlist.delegate('key', this.focus_on_comment, 'enter,space', 'a', this);
@@ -2245,8 +2245,8 @@ Y.extend(COMMENTSEARCH, M.core.dialogue, {
commentslist,
filtertext;
filternode = this.get('editor').get_dialogue_element(SELECTOR.SEARCHFILTER);
commentslist = this.get('editor').get_dialogue_element(SELECTOR.SEARCHCOMMENTSLIST);
filternode = Y.one(SELECTOR.SEARCHFILTER);
commentslist = Y.one(SELECTOR.SEARCHCOMMENTSLIST);
filtertext = filternode.get('value');
@@ -3364,7 +3364,7 @@ EDITOR.prototype = {
this.loadingicon = this.get_dialogue_element(SELECTOR.LOADINGICON);
drawingcanvas = this.get_dialogue_element(SELECTOR.DRAWINGCANVAS);
this.graphic = new Y.Graphic({render : SELECTOR.DRAWINGCANVAS});
this.graphic = new Y.Graphic({render : drawingcanvas});
drawingregion = this.get_dialogue_element(SELECTOR.DRAWINGREGION);
drawingregion.on('scroll', this.move_canvas, this);
File diff suppressed because one or more lines are too long
@@ -2224,7 +2224,7 @@ Y.extend(COMMENTSEARCH, M.core.dialogue, {
commentlist = Y.Node.create('<ul role="menu" class="assignfeedback_editpdf_menu"/>');
container.append(commentlist);
commentfilter.on('keyup', this.filter_search_comments, null, this);
commentfilter.on('keyup', this.filter_search_comments, this);
commentlist.delegate('click', this.focus_on_comment, 'a', this);
commentlist.delegate('key', this.focus_on_comment, 'enter,space', 'a', this);
@@ -2245,8 +2245,8 @@ Y.extend(COMMENTSEARCH, M.core.dialogue, {
commentslist,
filtertext;
filternode = this.get('editor').get_dialogue_element(SELECTOR.SEARCHFILTER);
commentslist = this.get('editor').get_dialogue_element(SELECTOR.SEARCHCOMMENTSLIST);
filternode = Y.one(SELECTOR.SEARCHFILTER);
commentslist = Y.one(SELECTOR.SEARCHCOMMENTSLIST);
filtertext = filternode.get('value');
@@ -3364,7 +3364,7 @@ EDITOR.prototype = {
this.loadingicon = this.get_dialogue_element(SELECTOR.LOADINGICON);
drawingcanvas = this.get_dialogue_element(SELECTOR.DRAWINGCANVAS);
this.graphic = new Y.Graphic({render : SELECTOR.DRAWINGCANVAS});
this.graphic = new Y.Graphic({render : drawingcanvas});
drawingregion = this.get_dialogue_element(SELECTOR.DRAWINGREGION);
drawingregion.on('scroll', this.move_canvas, this);
@@ -52,7 +52,7 @@ Y.extend(COMMENTSEARCH, M.core.dialogue, {
commentlist = Y.Node.create('<ul role="menu" class="assignfeedback_editpdf_menu"/>');
container.append(commentlist);
commentfilter.on('keyup', this.filter_search_comments, null, this);
commentfilter.on('keyup', this.filter_search_comments, this);
commentlist.delegate('click', this.focus_on_comment, 'a', this);
commentlist.delegate('key', this.focus_on_comment, 'enter,space', 'a', this);
@@ -73,8 +73,8 @@ Y.extend(COMMENTSEARCH, M.core.dialogue, {
commentslist,
filtertext;
filternode = this.get('editor').get_dialogue_element(SELECTOR.SEARCHFILTER);
commentslist = this.get('editor').get_dialogue_element(SELECTOR.SEARCHCOMMENTSLIST);
filternode = Y.one(SELECTOR.SEARCHFILTER);
commentslist = Y.one(SELECTOR.SEARCHCOMMENTSLIST);
filtertext = filternode.get('value');
+1 -1
View File
@@ -311,7 +311,7 @@ EDITOR.prototype = {
this.loadingicon = this.get_dialogue_element(SELECTOR.LOADINGICON);
drawingcanvas = this.get_dialogue_element(SELECTOR.DRAWINGCANVAS);
this.graphic = new Y.Graphic({render : SELECTOR.DRAWINGCANVAS});
this.graphic = new Y.Graphic({render : drawingcanvas});
drawingregion = this.get_dialogue_element(SELECTOR.DRAWINGREGION);
drawingregion.on('scroll', this.move_canvas, this);