L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-59698 behat: Remove bad tests

Browse Source 
These tests are an abuse and should not have been accepted. Behat tests should use real pages.
Adding testing only entry points to Moodle is a bad security practice and is not the purpose of behat.
This commit is contained in:
Damyon Wiese
2017-08-03 10:28:54 +08:00
parent 760ed1dfde
commit f0ce31da5e
2 changed files with 0 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/form/tests/behat/multi_select_dependencies.feature
-24
View File
@@ -1,24 +0,0 @@
@core_form @javascript @_bug_phantomjs
Feature: Forms with a multi select field dependency
In order to test multi select field dependency
As an admin
I need forms field which depends on multiple select options
Scenario: Field should be enabled only when all select options are selected
# Get to the fixture page.
Given the following "courses" exist:
| fullname | shortname | format |
| Course 1 | C1 | topics |
And the following "activities" exist:
| activity | name | intro | course | idnumber |
| label | L1 | <a href="../lib/form/tests/fixtures/multi_select_dependencies.php">FixtureLink</a> | C1 | label1 |
And I log in as "admin"
And I am on "Course 1" course homepage
When I follow "FixtureLink"
Then the "Enter your name" "field" should be disabled
And I set the field "Choose one or more directions" to "South,West"
Then the "Enter your name" "field" should be enabled
And I set the field "Choose one or more directions" to "West"
Then the "Enter your name" "field" should be disabled
And I set the field "Choose one or more directions" to "North,West"
Then the "Enter your name" "field" should be disabled
lib/form/tests/fixtures/multi_select_dependencies.php
Vendored
-68
View File
@@ -1,68 +0,0 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Fixture for Behat test for testing multiple select dependencies.
*
* @package core_form
* @copyright 2016 Rajesh Taneja <[email protected]>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require(__DIR__ . '/../../../../config.php');
require_once($CFG->libdir . '/formslib.php');
// Behat test fixture only.
defined('BEHAT_SITE_RUNNING') || die('Only available on Behat test server');
/**
* Form for testing multiple select dependencies.
*
* @package core_form
* @copyright 2016 Rajesh Taneja <[email protected]>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class test_form extends moodleform {
/**
* Form definition.
*/
public function definition() {
$mform = $this->_form;
$labels = array('North', 'Est', 'South', 'West');
$select = $mform->addElement('select', 'mselect_name', 'Choose one or more directions', $labels);
$select->setMultiple(true);
$mform->addElement('text', 'text_name', 'Enter your name');
$mform->setType('text_name', PARAM_RAW);
$mform->disabledIf('text_name', 'mselect_name[]', 'neq', array(2, 3));
$this->add_action_buttons($cancel = true, $submitlabel = null);
}
}
$PAGE->set_context(context_system::instance());
$PAGE->set_url('/lib/form/tests/fixtures/multi_select_dependencies.php');
$PAGE->set_title('multi_select_dependencies');
$mform = new test_form(new moodle_url('/lib/form/tests/fixtures/multi_select_dependencies.php'));
echo $OUTPUT->header();
$mform->display();
echo $OUTPUT->footer();