MDL-66049 workshop: Fix the fully qualified class name

Because of the missing slash, the class 'workshop' was not found in the
current namespace and the cron failed to work.
This commit is contained in:
David Mudrák
2019-07-01 14:49:34 +02:00
parent 30d4327769
commit ee3b7666f2
2 changed files with 77 additions and 1 deletions
+1 -1
View File
@@ -65,7 +65,7 @@ class cron_task extends \core\task\scheduled_task {
$cm = get_coursemodule_from_instance('workshop', $workshop->id, $workshop->course, false, MUST_EXIST);
$course = $DB->get_record('course', ['id' => $cm->course], '*', MUST_EXIST);
$workshop = new \workshop($workshop, $cm, $course);
$workshop->switch_phase(workshop::PHASE_ASSESSMENT);
$workshop->switch_phase(\workshop::PHASE_ASSESSMENT);
$params = [
'objectid' => $workshop->id,
+76
View File
@@ -0,0 +1,76 @@
<?php
// This file is part of Moodle - https://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Provides the {@link mod_workshop_cron_task_testcase} class.
*
* @package mod_workshop
* @category test
* @copyright 2019 David Mudrák <[email protected]>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
defined('MOODLE_INTERNAL') || die();
global $CFG;
require_once($CFG->dirroot.'/mod/workshop/lib.php');
/**
* Test the functionality provided by the {@link mod_workshop\task\cron_task} scheduled task.
*
* @copyright 2019 David Mudrák <[email protected]>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class mod_workshop_cron_task_testcase extends advanced_testcase {
/**
* Test that the phase is automatically switched after the submissions deadline.
*/
public function test_phase_switching() {
global $DB;
$this->resetAfterTest();
$this->setAdminUser();
// Set up a test workshop with 'Switch to the next phase after the submissions deadline' enabled.
$generator = $this->getDataGenerator();
$course = $generator->create_course();
$workshop = $generator->create_module('workshop', [
'course' => $course,
'name' => 'Test Workshop',
]);
$DB->update_record('workshop', [
'id' => $workshop->id,
'phase' => workshop::PHASE_SUBMISSION,
'phaseswitchassessment' => 1,
'submissionend' => time() - 1,
]);
// Execute the cron.
ob_start();
cron_setup_user();
$cron = new \mod_workshop\task\cron_task();
$cron->execute();
$output = ob_get_contents();
ob_end_clean();
// Assert that the phase has been switched.
$this->assertContains('Processing automatic assessment phase switch', $output);
$this->assertEquals(workshop::PHASE_ASSESSMENT, $DB->get_field('workshop', 'phase', ['id' => $workshop->id]));
}
}