L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-15919 do not modify $file_record parameters when creating new files

Browse Source
This commit is contained in:
skodak
2008-09-06 21:33:07 +00:00
parent 4149edbd64
commit ec8b711fb3
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/file/file_storage.php
+6 -1
View File
@@ -360,7 +360,8 @@ class file_storage {
$fid = $fid->get_id();
}
$file_record = (array)$file_record; // we support arrays too
$file_record = (array)$file_record; // we support arrays too, do not modify the submitted record!
unset($file_record['id']);
unset($file_record['filesize']);
unset($file_record['contenthash']);
@@ -437,6 +438,8 @@ class file_storage {
* @return object stored_file instance
*/
public function create_file_from_url($file_record, $url, $options=null) {
$file_record = (array)$file_record; //do not modify the submitted record, this cast unlinks objects
$file_record = (object)$file_record; // we support arrays too
$headers = isset($options['headers']) ? $options['headers'] : null;
@@ -469,6 +472,7 @@ class file_storage {
public function create_file_from_pathname($file_record, $pathname) {
global $DB;
$file_record = (array)$file_record; //do not modify the submitted record, this cast unlinks objects
$file_record = (object)$file_record; // we support arrays too
// validate all parameters, we do not want any rubbish stored in database, right?
@@ -544,6 +548,7 @@ class file_storage {
public function create_file_from_string($file_record, $content) {
global $DB;
$file_record = (array)$file_record; //do not modify the submitted record, this cast unlinks objects
$file_record = (object)$file_record; // we support arrays too
// validate all parameters, we do not want any rubbish stored in database, right?