L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-67518 phpunit: avoid DB sorting randomness in test

Browse Source 
While reading from mdl_config, sometimes this test was failing
because an order was being presumed. Now we convert the records
array to an associative one to perform tests against it.
This commit is contained in:
Eloy Lafuente (stronk7)
2020-05-29 16:26:07 +02:00
parent 111fc893da
commit ec602d2f26
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
blocks/tests/externallib_test.php
+5 -3
View File
@@ -267,9 +267,11 @@ class core_block_externallib_testcase extends externallib_advanced_testcase {
$returnedblocks[] = $block['name'];
// Check the configuration returned for this default block.
if ($block['name'] == 'recentlyaccessedcourses') {
$this->assertEquals('displaycategories', $block['configs'][0]['name']);
$this->assertEquals(json_encode('0'), $block['configs'][0]['value']);
$this->assertEquals('plugin', $block['configs'][0]['type']);
// Convert config to associative array to avoid DB sorting randomness.
$config = array_column($block['configs'], null, 'name');
$this->assertArrayHasKey('displaycategories', $config);
$this->assertEquals(json_encode('0'), $config['displaycategories']['value']);
$this->assertEquals('plugin', $config['displaycategories']['type']);
}
}
// Remove lp block.