MDL-59195 assignsubmission_comments: fix permission checks

This commit is contained in:
Davo Smith
2017-08-21 10:23:01 +01:00
parent 27466d7548
commit ec0ecdaf6e
2 changed files with 0 additions and 10 deletions
-9
View File
@@ -48,15 +48,6 @@ function assignsubmission_comments_comment_validate(stdClass $options) {
if ($assignment->get_instance()->id != $submission->assignment) {
throw new comment_exception('invalidcontext');
}
$canview = false;
if ($submission->userid) {
$canview = $assignment->can_view_submission($submission->userid);
} else {
$canview = $assignment->can_view_group_submission($submission->groupid);
}
if (!$canview) {
throw new comment_exception('nopermissiontocomment');
}
return true;
}
@@ -69,7 +69,6 @@ class assign_submission_comments extends assign_submission_plugin {
$options->displaycancel = true;
$comment = new comment($options);
$comment->set_view_permission(true);
$o = $this->assignment->get_renderer()->container($comment->output(true), 'commentscontainer');
return $o;