L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoiding warning in last commit:

Browse Source 
mod/quiz/index changes to only display quiz grades when teacher allows
Changes to index.php to only allow student to view overall quiz scores when
teacher has not set options forbidding this, and it can't give away what
scores were for attempts where results should still be hidden.
Credit: Peter Bulmer [email protected]
This commit is contained in:
mjollnir_
2006-04-18 22:57:28 +00:00
parent 40377b188b
commit eb55a1bfb9
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/quiz/locallib.php
+8 -7
View File
@@ -565,13 +565,14 @@ function all_attempt_results_visible($quiz, $user) {
$sql = 'SELECT timefinish, preview FROM '.$CFG->prefix.'quiz_attempts qa'.
' WHERE qa.quiz='.$quiz->id.' AND qa.userid='.$user->id.
' ORDER BY id DESC';
$attempts = get_records_sql($sql);
foreach ($attempts as $attempt) {
$attemptoptions = quiz_get_reviewoptions($quiz, $attempt);
//if any attempt has scores option not set, not all attempt results are
//visible
if (!$attemptoptions->scores) {
return false;
if ($attempts = get_records_sql($sql)) {
foreach ($attempts as $attempt) {
$attemptoptions = quiz_get_reviewoptions($quiz, $attempt);
//if any attempt has scores option not set, not all attempt results are
//visible
if (!$attemptoptions->scores) {
return false;
}
}
}
return true;