Constant name fixed and improved empty input check
This commit is contained in:
@@ -70,7 +70,7 @@ class workshop_edit_accumulative_strategy_form extends workshop_edit_strategy_fo
|
||||
|
||||
$mform->registerNoSubmitButton('noadddims');
|
||||
$mform->addElement('submit', 'noadddims', get_string('addmoredimensions', 'workshopform_accumulative',
|
||||
WORKSHOP_STRATEGY_ADDDIMS));
|
||||
workshop_accumulative_strategy::ADDDIMS));
|
||||
$mform->closeHeaderBefore('noadddims');
|
||||
$this->set_data($current);
|
||||
}
|
||||
|
||||
@@ -84,7 +84,7 @@ class workshop_accumulative_strategy implements workshop_strategy {
|
||||
for ($i = 0; $i < $nodimensions; $i++) {
|
||||
// prepare all editor elements
|
||||
$fields = file_prepare_standard_editor($fields, 'description__idx_'.$i, $this->descriptionopts,
|
||||
$PAGE->context, 'workshop_dimension_description', $fields->{'dimensionid__idx_'.$i});
|
||||
$PAGE->context, 'workshopform_accumulative_description', $fields->{'dimensionid__idx_'.$i});
|
||||
}
|
||||
|
||||
$customdata = array();
|
||||
@@ -122,7 +122,7 @@ class workshop_accumulative_strategy implements workshop_strategy {
|
||||
|
||||
for ($i=0; $i < $norepeats; $i++) {
|
||||
$record = $records[$i];
|
||||
if (empty($record->description_editor['text'])) {
|
||||
if (0 == strlen(trim($record->description_editor['text']))) {
|
||||
if (!empty($record->id)) {
|
||||
// existing record with empty description - to be deleted
|
||||
$todelete[] = $record->id;
|
||||
|
||||
@@ -101,7 +101,7 @@ class workshop_edit_numerrors_strategy_form extends workshop_edit_strategy_form
|
||||
|
||||
$mform->registerNoSubmitButton('noadddims');
|
||||
$mform->addElement('submit', 'noadddims', get_string('addmoredimensions', 'workshopform_numerrors',
|
||||
WORKSHOP_STRATEGY_ADDDIMS));
|
||||
workshop_numerrors_strategy::ADDDIMS));
|
||||
$mform->closeHeaderBefore('noadddims');
|
||||
$this->set_data($current);
|
||||
|
||||
|
||||
@@ -128,7 +128,7 @@ class workshop_numerrors_strategy implements workshop_strategy {
|
||||
|
||||
for ($i=0; $i < $norepeats; $i++) {
|
||||
$record = $records[$i];
|
||||
if (empty($record->description_editor['text'])) {
|
||||
if (0 == strlen(trim($record->description_editor['text']))) {
|
||||
if (!empty($record->id)) {
|
||||
// existing dimension record with empty description - to be deleted
|
||||
$todelete[] = $record->id;
|
||||
|
||||
Reference in New Issue
Block a user