MDL-83750 core_form: Fix deprecated preg_replace in form

2025-01-13 15:05:08 +01:00
parent a843eab495
commit ea50d0b151
1 changed files with 6 additions and 5 deletions
@@ -2746,11 +2746,10 @@ require([
        ' . $valFunc . '
    });
 ';
-                }
-            }
-            // This handles both randomised (MDL-65217) and non-randomised IDs.
-            $errorid = preg_replace('/^id_/', 'id_error_', $elem->_attributes['id']);
-            $validateJS .= '
+
+                    // This handles both randomised (MDL-65217) and non-randomised IDs.
+                    $errorid = preg_replace('/^id_/', 'id_error_', $elem->_attributes['id']);
+                    $validateJS .= '
      ret = validate_' . $this->_formName . '_' . $escapedElementName.'(frm.elements[\''.$elementName.'\'], \''.$escapedElementName.'\') && ret;
      if (!ret && !first_focus) {
        first_focus = true;
@@ -2762,6 +2761,8 @@ require([
      }
 ';

+                }
+            }
            // Fix for bug displaying errors for elements in a group
            //unset($element);
            //$element =& $this->getElement($elementName);