MDL-38289: Custom profile fields - added unit test

Added a unit test to cover the case when you are fetching a custom
profile field but you are not logged in.

lib/conditionlib.php

@@ -1325,7 +1325,7 @@ abstract class condition_info_base {
         $iscurrentuser = $USER->id == $userid;
 
         if (isguestuser($userid) || ($iscurrentuser && !isloggedin())) {
-            // Must be logged in and can't be the guest. (this should never happen anyway)
+            // Must be logged in and can't be the guest. (e.g. front page)
             return false;
         }
 

lib/tests/conditionlib_test.php

@@ -776,6 +776,15 @@ class conditionlib_testcase extends advanced_testcase {
             // without error.
             $ci->get_cached_user_profile_field($USER->id, $fieldid);
         }
+
+        // Change to not logged in user.
+        $this->setUser(null);
+
+        foreach ($fields as $fieldid => $name) {
+            // Should get false always when not logged in.
+            $this->assertEquals(false, $ci->get_cached_user_profile_field($USER->id, $fieldid));
+        }
+
     }
 }