L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-13878 use ints for old values of scales in grader report

Browse Source
This commit is contained in:
skodak
2008-03-10 20:24:11 +00:00
parent e83460ac86
commit e694d551b5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
grade/report/grader/lib.php
+3 -3
View File
@@ -175,7 +175,7 @@ class grade_report_grader extends grade_report {
$oldvalue = $data->{'old'.$varname};
// was change requested?
if ($oldvalue == $postedvalue) {
if ($oldvalue == $postedvalue) { // string comparison
continue;
}
@@ -776,7 +776,7 @@ class grade_report_grader extends grade_report {
if ($item->scaleid && !empty($scales_array[$item->scaleid])) {
$scale = $scales_array[$item->scaleid];
$gradeval = (int)$gradeval; // scales use only integers
$scales = explode(",", $scale->scale);
// reindex because scale is off 1
@@ -805,7 +805,7 @@ class grade_report_grader extends grade_report {
$scales = explode(",", $scale->scale);
// invalid grade if gradeval < 1
if ((int) $gradeval < 1) {
if ($gradeval < 1) {
$studentshtml .= '<span class="gradevalue'.$hidden.$gradepass.'">-</span>';
} else {
$gradeval = (int)bounded_number($grade->grade_item->grademin, $gradeval, $grade->grade_item->grademax); //just in case somebody changes scale