MDL-9432 - Forgot to return success/failure in two places.

question/type/match/questiontype.php

@@ -614,6 +614,8 @@ class question_match_qtype extends default_questiontype {
      * @return bool success or failure.
      */ 
     function decode_content_links_caller($questionids, $restore, &$i) {
+        $status = true;
+
         // Decode links in the question_match_sub table.
         if ($subquestions = get_records_list('question_match_sub', 'question',
                 implode(',',  $questionids), '', 'id, questiontext')) {
@@ -637,6 +639,8 @@ class question_match_qtype extends default_questiontype {
                 }
             }
         }
+
+        return $status;
     }
 }
 //// END OF CLASS ////

question/type/multichoice/questiontype.php

@@ -558,6 +558,8 @@ class question_multichoice_qtype extends default_questiontype {
      * @return bool success or failure.
      */ 
     function decode_content_links_caller($questionids, $restore, &$i) {
+        $status = true;
+
         // Decode links in the question_multichoice table.
         if ($multichoices = get_records_list('question_multichoice', 'question',
                 implode(',',  $questionids), '', 'id, correctfeedback, partiallycorrectfeedback, incorrectfeedback')) {
@@ -587,6 +589,8 @@ class question_multichoice_qtype extends default_questiontype {
                 }
             }
         }
+
+        return $status;
     }
 
     /**