L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-85556 backup: Only update question refs in restored course

Browse Source 
The previous query updated all question references matching the original
question bank entry, regardless of whether they were part of the restore
or not. When we are dealing with duplicated questions, this means we
could accidentally change question references in the backed-up course as
well as the restored one.

This change filters the references to ensure they exist in a context
within the restored course, before updating them.
This commit is contained in:
Mark Johnson
2025-06-02 15:53:37 +01:00
parent 643eaa3418
commit dfd0dc28e8
1 changed files with 23 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backup/moodle2/restore_stepslib.php
+23 -2
View File
@@ -5487,18 +5487,39 @@ class restore_move_module_questions_categories extends restore_execution_step {
$originalcontext = context::instance_by_id($contextid, IGNORE_MISSING);
if ($originalcontext && has_capability('mod/qbank:view', $originalcontext)) {
$originalquestions = get_questions_category(question_get_top_category($contextid), false);
$targetcoursecontext = context_course::instance($this->get_courseid());
foreach ($originalquestions as $originalquestion) {
$backupids = restore_dbops::get_backup_ids_record(
$this->get_restoreid(),
'question',
$originalquestion->id,
);
// Restored question references will point to the restored copy of the question. Select question references
// that point to that restored copy, only if they are within the target course's context, so we can update
// them to point to the original question.
$conpathlike = $DB->sql_like('con.path', '?');
$references = $DB->get_records_sql(
"SELECT qr.id, qr.questionbankentryid
FROM {question_references} qr
JOIN {context} con ON qr.usingcontextid = con.id
JOIN {question_versions} qv ON qv.questionbankentryid = qr.questionbankentryid
WHERE qv.questionid = ?
AND {$conpathlike}",
[
$backupids->newitemid,
$targetcoursecontext->path . '/%',
],
);
if (empty($references)) {
continue;
}
[$refin, $refparams] = $DB->get_in_or_equal(array_keys($references));
$DB->set_field_select(
'question_references',
'questionbankentryid',
$DB->get_field('question_versions', 'questionbankentryid', ['questionid' => $backupids->itemid]),
'questionbankentryid = (SELECT questionbankentryid FROM {question_versions} WHERE questionid = ?)',
[$backupids->newitemid],
'id ' . $refin,
$refparams,
);
}
continue;