MDL-53529 tool_lp: Consistent 'add' buttons for templates and courses

admin/tool/lp/amd/src/competencies.js

@@ -42,7 +42,7 @@ define(['jquery',
         this.pageContextId = pagectxid;
         this.pickerInstance = null;
 
-        $('[data-region="actions"] button').show();
+        $('[data-region="actions"] button').prop('disabled', false);
         this.registerEvents();
         this.registerDragDrop();
     };

admin/tool/lp/lang/en/tool_lp.php

@@ -26,6 +26,7 @@ $string['actions'] = 'Actions';
 $string['activities'] = 'Activities';
 $string['addcohorts'] = 'Add cohorts';
 $string['addcompetency'] = 'Add competency';
+$string['addcoursecompetencies'] = 'Add competencies to course';
 $string['addcrossreferencedcompetency'] = 'Add cross-referenced competency';
 $string['addingcompetencywillresetparentrule'] = 'Adding a new competency will remove the rule set on \'{$a}\'. Do you want to continue?';
 $string['addnewcompetency'] = 'Add new competency';
@@ -33,6 +34,7 @@ $string['addnewcompetencyframework'] = 'Add new competency framework';
 $string['addnewplan'] = 'Add new learning plan';
 $string['addnewtemplate'] = 'Add new learning plan template';
 $string['addnewuserevidence'] = 'Add new evidence';
+$string['addtemplatecompetencies'] = 'Add competencies to learning plan template';
 $string['aisrequired'] = '\'{$a}\' is required';
 $string['allchildrenarecomplete'] = 'All children are complete';
 $string['aplanswerecreated'] = '{$a} plans were created.';
@@ -190,11 +192,9 @@ $string['learningplans'] = 'Learning plans';
 $string['levela'] = 'Level {$a}';
 $string['linkcompetency'] = 'Link competency';
 $string['linkcompetencies'] = 'Link competencies';
-$string['linkcoursecompetencies'] = 'Link course competencies';
 $string['linkedcompetencies'] = 'Linked competencies';
 $string['linkedcourses'] = 'Linked courses';
 $string['linkedcourseslist'] = 'Linked courses:';
-$string['linktemplatecompetencies'] = 'Link template competencies';
 $string['listcompetencyframeworkscaption'] = 'List of competency frameworks';
 $string['listofevidence'] = 'List of evidence';
 $string['listplanscaption'] = 'List of learning plans';

admin/tool/lp/templates/course_competencies_page.mustache

@@ -18,6 +18,13 @@
     Course competencies template.
 }}
 <div data-region="coursecompetenciespage">
+    <div data-region="actions" class="clearfix">
+        <div class="pull-right">
+            {{#canmanagecoursecompetencies}}
+                <button disabled>{{#str}}addcoursecompetencies, tool_lp{{/str}}</button>
+            {{/canmanagecoursecompetencies}}
+        </div>
+    </div>
 <div data-region="coursecompetencies">
 <table class="generaltable fullwidth managecompetencies">
 <tbody class="drag-parentnode">
@@ -83,14 +90,9 @@
 {{/competencies}}
 </div>
 <div data-region="actions">
-<div class="pull-right">
-{{#canmanagecoursecompetencies}}
-<button style="display: none">{{#str}}linkcoursecompetencies, tool_lp{{/str}}</button>
-{{/canmanagecoursecompetencies}}
-</div>
-{{#canmanagecompetencyframeworks}}
-<p><a href="{{manageurl}}">{{#str}}managecompetenciesandframeworks, tool_lp{{/str}}</a></p>
-{{/canmanagecompetencyframeworks}}
+    {{#canmanagecompetencyframeworks}}
+        <p><a href="{{manageurl}}">{{#str}}managecompetenciesandframeworks, tool_lp{{/str}}</a></p>
+    {{/canmanagecompetencyframeworks}}
 </div>
 </div>
 {{#js}}

admin/tool/lp/templates/template_competencies_page.mustache

@@ -21,18 +21,13 @@
     {{#statistics}}
         {{> tool_lp/template_statistics }}
     {{/statistics}}
-    <div data-region="actions">
-        {{#canmanagecompetencyframeworks}}
+    {{#canmanagetemplatecompetencies}}
+    <div data-region="actions" class="clearfix">
         <div class="pull-right">
-            <p><a href="{{manageurl}}">{{#str}}managecompetenciesandframeworks, tool_lp{{/str}}</a></p>
+            <button disabled>{{#str}}addtemplatecompetencies, tool_lp{{/str}}</button>
         </div>
-        {{/canmanagecompetencyframeworks}}
-        {{#canmanagetemplatecompetencies}}
-        <p>
-            <button style="display: none">{{#str}}linktemplatecompetencies, tool_lp{{/str}}</button>
-        </p>
-        {{/canmanagetemplatecompetencies}}
     </div>
+    {{/canmanagetemplatecompetencies}}
     <div data-region="templatecompetencies">
         <div class="managecompetencies">
             <div class="drag-parentnode">
@@ -71,6 +66,13 @@
         </p>
         {{/competencies}}
     </div>
+    <div data-region="actions">
+        {{#canmanagecompetencyframeworks}}
+        <div>
+            <p><a href="{{manageurl}}">{{#str}}managecompetenciesandframeworks, tool_lp{{/str}}</a></p>
+        </div>
+        {{/canmanagecompetencyframeworks}}
+    </div>
 </div>
 {{#js}}
 require(['tool_lp/competencies'], function(mod) {