L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-49244 course: Clean parameters in core_course_get_categories

Browse Source
This commit is contained in:
Juan Leyva
2016-06-30 13:27:51 +01:00
parent a7221c5f19
commit ddbd25d941
2 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
course/externallib.php
+1 -1
View File
@@ -1548,7 +1548,7 @@ class core_course_external extends external_api {
}
if (isset($value)) {
$conditions[$key] = $crit['value'];
$conditions[$key] = $value;
$wheres[] = $key . " = :" . $key;
}
}
course/tests/externallib_test.php
+10
View File
@@ -234,6 +234,16 @@ class core_course_externallib_testcase extends externallib_advanced_testcase {
$this->assertEquals(1, count($categories));
// Same query, but forcing a parameters clean.
$categories = core_course_external::get_categories(array(
array('key' => 'id', 'value' => "$category1->id"),
array('key' => 'idnumber', 'value' => $category1->idnumber),
array('key' => 'name', 'value' => $category1->name . "<br/>"),
array('key' => 'visible', 'value' => '1')), 0);
$categories = external_api::clean_returnvalue(core_course_external::get_categories_returns(), $categories);
$this->assertEquals(1, count($categories));
// Retrieve categories from parent.
$categories = core_course_external::get_categories(array(
array('key' => 'parent', 'value' => $category3->id)), 1);