L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-15530 "The Group menu in Quiz Module no longer works as before: all students are displayed regardless of what group is chosen" 'all attempts' mode for report is now disabled when a group is selected.

Browse Source
This commit is contained in:
jamiesensei
2008-07-04 09:48:01 +00:00
parent 022ebfc304
commit dcb16152f3
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/quiz/report/overview/overviewsettings_form.php
+4 -2
View File
@@ -9,8 +9,10 @@ class mod_quiz_report_overview_settings extends moodleform {
$mform->addElement('header', 'preferencespage', get_string('preferencespage', 'quiz_overview'));
$options = array();
$options[QUIZ_REPORT_ATTEMPTS_ALL] = get_string('optallattempts','quiz_overview');
if ($COURSE->id != SITEID) {
if (!$this->_customdata['currentgroup']){
$options[QUIZ_REPORT_ATTEMPTS_ALL] = get_string('optallattempts','quiz_overview');
}
if ($this->_customdata['currentgroup'] || $COURSE->id != SITEID) {
$options[QUIZ_REPORT_ATTEMPTS_ALL_STUDENTS] = get_string('optallstudents','quiz_overview', $COURSE->students);
$options[QUIZ_REPORT_ATTEMPTS_STUDENTS_WITH] =
get_string('optattemptsonly','quiz_overview', $COURSE->students);
mod/quiz/report/overview/report.php
+9 -3
View File
@@ -57,9 +57,12 @@ class quiz_report extends quiz_default_report {
$pageoptions['q'] = $quiz->id;
$pageoptions['mode'] = 'overview';
/// find out current groups mode
$currentgroup = groups_get_activity_group($cm, true);
$reporturl = new moodle_url($CFG->wwwroot.'/mod/quiz/report.php', $pageoptions);
$qmsubselect = quiz_report_qm_filter_select($quiz);
$mform = new mod_quiz_report_overview_settings($reporturl, compact('qmsubselect', 'quiz'));
$mform = new mod_quiz_report_overview_settings($reporturl, compact('qmsubselect', 'quiz', 'currentgroup'));
if ($fromform = $mform->get_data()){
$attemptsmode = $fromform->attemptsmode;
if ($qmsubselect){
@@ -80,6 +83,11 @@ class quiz_report extends quiz_default_report {
$detailedmarks = get_user_preferences('quiz_report_overview_detailedmarks', 1);
$pagesize = get_user_preferences('quiz_report_pagesize', 0);
}
if ($attemptsmode == QUIZ_REPORT_ATTEMPTS_ALL && $currentgroup){
$attemptsmode = QUIZ_REPORT_ATTEMPTS_STUDENTS_WITH;
}
if (!$reviewoptions->scores) {
$detailedmarks = 0;
}
@@ -97,8 +105,6 @@ class quiz_report extends quiz_default_report {
$displayoptions['qmfilter'] = $qmfilter;
$reporturlwithdisplayoptions = new moodle_url($CFG->wwwroot.'/mod/quiz/report.php', $pageoptions + $displayoptions);
/// find out current groups mode
$currentgroup = groups_get_activity_group($cm, true);
if ($groupmode = groups_get_activity_groupmode($cm)) { // Groups are being used
if (!$download) {