MDL-20636 Fix two HTML validation issues.

This commit is contained in:
Tim Hunt
2011-03-31 15:24:37 +01:00
parent 48d9c17db3
commit dbf76faf52
2 changed files with 3 additions and 2 deletions
+1 -1
View File
@@ -218,7 +218,7 @@ class core_question_renderer extends plugin_renderer_base {
$flagcontent = '<input type="hidden" name="' . $id . '" value="0" />' .
'<input type="checkbox" id="' . $id . 'checkbox" name="' . $id . '" value="1" ' . $checked . ' />' .
'<input type="hidden" value="' . s($postdata) . '" class="questionflagpostdata" />' .
'<label id="' . $id . 'label" for="' . $id . '">' . $this->get_flag_html(
'<label id="' . $id . 'label" for="' . $id . 'checkbox">' . $this->get_flag_html(
$qa->is_flagged(), $id . 'img') . '</label>' . "\n";
break;
default:
+2 -1
View File
@@ -214,7 +214,7 @@ class qtype_essay_format_editor_renderer extends plugin_renderer_base {
$this->class_name() . ' qtype_essay_response'));
$output .= html_writer::tag('div', html_writer::tag('textarea', s($reponse),
array('id' => $id, 'name' => $inputname, 'rows' => $lines)));
array('id' => $id, 'name' => $inputname, 'rows' => $lines, 'cols' => 60)));
$output .= html_writer::start_tag('div');
if (count($formats == 1)) {
@@ -406,6 +406,7 @@ class qtype_essay_format_plain_renderer extends plugin_renderer_base {
protected function textarea($response, $lines, $attributes) {
$attributes['class'] = $this->class_name() . ' qtype_essay_response';
$attributes['rows'] = $lines;
$attributes['cols'] = 60;
return html_writer::tag('textarea', s($response), $attributes);
}