MDL-52910 cbe: Fix competency picker dialogue scrolling issues.

The competency tree expands and collapses, which causes issues
for the dialogue which is supposed to be centered and non-scrollable.

We need to introduce a scrollable region in the dialogue and fix the height
- this may be slightly annoying for tablet users but is not the worst thing
in the world.

admin/tool/lp/amd/build/dialogue.min.js

@@ -1 +1 @@
-define(["core/yui"],function(a){var b=function(b,c,d,e,f){this.yuiDialogue=null;var g=this;"undefined"==typeof f&&(f=!1),a.use("moodle-core-notification","timers",function(){var h="480px";f&&(h="800px"),g.yuiDialogue=new M.core.dialogue({headerContent:b,bodyContent:c,draggable:!0,visible:!1,center:!0,modal:!0,width:h}),g.yuiDialogue.after("visibleChange",function(b){b.newVal?"undefined"!=typeof d&&a.soon(function(){d(g)}):"undefined"!=typeof e&&a.soon(function(){e(g)})}),g.yuiDialogue.show()})};return b.prototype.close=function(){this.yuiDialogue.hide(),this.yuiDialogue.destroy()},b.prototype.getContent=function(){return this.yuiDialogue.bodyNode.getDOMNode()},b});
+define(["core/yui"],function(a){var b=function(b,c,d,e,f){this.yuiDialogue=null;var g=this;"undefined"==typeof f&&(f=!1),a.use("moodle-core-notification","timers",function(){var h="480px";f&&(h="800px"),g.yuiDialogue=new M.core.dialogue({headerContent:b,bodyContent:c,draggable:!0,visible:!1,center:!0,modal:!0,width:h}),g.yuiDialogue.after("visibleChange",function(b){b.newVal?"undefined"!=typeof d&&a.soon(function(){d(g),g.yuiDialogue.centerDialogue()}):"undefined"!=typeof e&&a.soon(function(){e(g)})}),g.yuiDialogue.show()})};return b.prototype.close=function(){this.yuiDialogue.hide(),this.yuiDialogue.destroy()},b.prototype.getContent=function(){return this.yuiDialogue.bodyNode.getDOMNode()},b});

admin/tool/lp/amd/src/dialogue.js

@@ -66,6 +66,7 @@ define(['core/yui'], function(Y) {
                     if ((typeof afterShow !== 'undefined')) {
                         Y.soon(function() {
                             afterShow(parent);
+                            parent.yuiDialogue.centerDialogue();
                         });
                     }
                 } else {

admin/tool/lp/styles.css

@@ -55,6 +55,11 @@
     text-align: center;
 }
 
+.path-admin-tool-lp [data-region="competencylinktree"]>ul {
+    overflow-y: auto;
+    height: 400px;
+}
+
 .dir-rtl.path-admin-tool-lp [data-region="filtercompetencies"] input {
     margin-right: 10px;
 }