Fixed behaviour of groups.php in the case of an empty group, see bug 2346

This commit is contained in:
gustav_delius
2005-02-13 19:38:10 +00:00
parent ce3c1c2bbd
commit db837a6645
2 changed files with 19 additions and 12 deletions
+18 -12
View File
@@ -35,20 +35,26 @@
$currentgroup = false;
}
if ($currentgroup) {
$students = get_group_students($currentgroup, "u.lastname ASC");
} else {
$students = get_course_students($course->id, "u.lastname ASC");
}
/// Get a list of all students
if (!$students) {
print_header("$course->shortname: $strgrades", "$course->fullname",
"<a href=\"$CFG->wwwroot/course/view.php?id=$course->id\">$course->shortname</a>
if ($currentgroup) {
if (!$students = get_group_students($currentgroup, "u.lastname ASC")) {
print_header("$course->shortname: $strgrades", "$course->fullname",
"<A HREF=\"$CFG->wwwroot/course/view.php?id=$course->id\">$course->shortname</A>
-> $strgrades");
print_heading(get_string("nostudentsyet"));
print_footer($course);
exit;
setup_and_print_groups($course, $groupmode, "grades.php?id=$course->id");
notice(get_string("nostudentsingroup"), "$CFG->wwwroot/course/view.php?id=$course->id");
print_footer();
exit;
}
} else {
if (!$students = get_course_students($course->id, "u.lastname ASC")) {
print_header("$course->shortname: $strgrades", "$course->fullname",
"<A HREF=\"$CFG->wwwroot/course/view.php?id=$course->id\">$course->shortname</A>
-> $strgrades");
notice(get_string("nostudentsyet"), "$CFG->wwwroot/course/view.php?id=$course->id");
print_footer();
exit;
}
}
foreach ($students as $student) {
+1
View File
@@ -763,6 +763,7 @@ $string['normal'] = 'Normal';
$string['normalfilter'] = 'Normal search';
$string['nostudentsfound'] = 'No $a found';
$string['nostudentsyet'] = 'No students enrolled in this course yet';
$string['nostudentsingroup'] = 'There are no students in this group yet';
$string['nosuchemail'] = 'No such email address';
$string['notavailable'] = 'Not available';
$string['noteachersyet'] = 'No teachers in this course yet';