L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-80947 communication_customlink: Check before customlink update

Browse Source
This commit is contained in:
Stevani Andolo
2024-07-08 07:19:30 +08:00
parent 7d7a871edd
commit db0d4ab677
3 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
communication/provider/customlink/classes/communication_feature.php
+6 -2
View File
@@ -113,13 +113,17 @@ class communication_feature implements
}
public function save_form_data(\stdClass $instance): void {
if (empty($instance->customlinkurl)) {
return;
}
global $DB;
$commid = $this->communication->get_id();
$cachekey = "link_url_{$commid}";
$newrecord = new \stdClass();
$newrecord->url = $instance->customlinkurl ?? null;
$newrecord->url = $instance->customlinkurl;
$existingrecord = $DB->get_record(
self::CUSTOMLINK_TABLE,
@@ -131,7 +135,7 @@ class communication_feature implements
// Create the record if it does not exist.
$newrecord->commid = $commid;
$DB->insert_record(self::CUSTOMLINK_TABLE, $newrecord);
} else if ($newrecord->url !== $existingrecord->url) {
} else if ($instance->customlinkurl !== $existingrecord->url) {
// Update record if the URL has changed.
$newrecord->id = $existingrecord->id;
$DB->update_record(self::CUSTOMLINK_TABLE, $newrecord);
communication/provider/customlink/tests/communication_feature_test.php
+16
View File
@@ -88,6 +88,22 @@ class communication_feature_test extends \advanced_testcase {
$communicationprocessor->get_form_provider()->save_form_data($formdatainstance);
$fetchedurl = $communicationprocessor->get_room_provider()->get_chat_room_url();
$this->assertEquals($customlinkurl, $fetchedurl);
// Test with empty customlinkurl.
$customlinkurlempty = '';
$formdatainstance = (object) ['customlinkurl' => $customlinkurlempty];
$communicationprocessor->get_form_provider()->save_form_data($formdatainstance);
$fetchedurl = $communicationprocessor->get_room_provider()->get_chat_room_url();
// It should not update the url to an empty one.
$this->assertEquals($customlinkurl, $fetchedurl);
// Test with null customlinkurl.
$customlinkurlempty = null;
$formdatainstance = (object) ['customlinkurl' => $customlinkurlempty];
$communicationprocessor->get_form_provider()->save_form_data($formdatainstance);
$fetchedurl = $communicationprocessor->get_room_provider()->get_chat_room_url();
// It should not update the url to a null one.
$this->assertEquals($customlinkurl, $fetchedurl);
}
/**
communication/tests/api_test.php
+2
View File
@@ -476,6 +476,8 @@ class api_test extends \advanced_testcase {
// Now delete all the ad-hoc tasks.
$DB->delete_records('task_adhoc');
$course->customlinkurl = $course->customlinkurl ?? 'https://moodle.org';
// Now change the provider to another one.
$communication->configure_room_and_membership_by_provider(
provider: 'communication_customlink',